From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 070B940F1E for ; Sat, 14 May 2022 00:42:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C6ECB68B3D6; Sat, 14 May 2022 03:42:27 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2073.outbound.protection.outlook.com [40.92.40.73]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A293B68B378 for ; Sat, 14 May 2022 03:42:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ltel0ypYfa5X95U3RlWVPd8/sPFhgoMmKSho2j3nyWqJfabjJPNksd2uyuDhPbBb69WA7Ae+LG3l2RWoKQinsLG0lWb9t3SZOiEqLijhoufftd7Sytwy7WqvbNjFTLfM6mJ/UtAlzg8MV9dVo/Vxbh2lY2dWNszzcwaZ8AdX30jz0XqwoeE56Ezp2dcd73ylhA+J8O1v5Gokv6qM9tT4QwFQg09S7QGNoaMfOmwiXso1LeWJ5cKD8lTK/SmvTFvnxjhsgGL5R5FAbn9BvjEuMVBzmScePaN0WZBhChqOtG6JMM4SteR+oGU1oJ8wrPXrCeG6g4+WuaxJL1dhQ8FfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A2gXlqOZos26vdvgBZY7SKCg4mnj7WktqscQfUnKB8Q=; b=Dww6iaHXvfmTqfb384bxrwqyxTTGfs1M+Zq1SdHfOFit/VDs29UNPUtqqizyz5h68tM8fBBpHL008qMGXp0MlLn3DyyBisuzhQ1tRatUINEwQK7liJMFXpM1SH2MyQnbg12h74n2iGdQUx/QV2rqCQNxcscbRcDmja688NWIZUFw7qYFwLvyjDxU88eRzefnviN3GyqxE+vf1fNZ/GNGtxTorvNG4svyxtgb/5OL7I559zIoiiPLqTCeulQ6krJz8gOWnMqc7WTqH2AJXPgxHuFMj5q8pnOGEnw5tIDsLvOM59LC05hNw4gorMT+JQ6hZm3IY0sTk47Bkdx61IrJ5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2gXlqOZos26vdvgBZY7SKCg4mnj7WktqscQfUnKB8Q=; b=YeS3+zEZUro9fYbmIyhCWrIacmA9To2ZeQi6XBa/9brlWygceauBhIsXKC2FCjb1wQ541T+LhGp89JpS03uYOI9lJojdknpV6OKukFwy+u9HFtnIyYpkU0A7SwCBAvF2FVVnCOoQIQGOVNYbII+o1jN37OUZPLcpn7E59loX44gXLhIiFqja5OfdzdD9g/eztlcNZttVSqjJ2Lk2Shfojr+o98BHtvnOqW+md+B6SEsazJnQjFuUSCOjKg/OkX4v13z9yqSTaDWrleJSk7dAtVGPmp3fvsJQ1WuhpDvq3daEfghXz+jVzGvh4FzLUoCqUpgv9+KpaGnnFzb6f6B2Ng== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0266.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Sat, 14 May 2022 00:42:18 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Sat, 14 May 2022 00:42:18 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Thread-Index: AQHYV9QNP/PRify4SkipW5U65/+zkqz/hzrQgADP4ACAAAFRMIAADCEAgAACGVCABt4dAIABGaBQgAhtCoCAABn5QIABMduAgACxSQCAAPjgAIAAApjggAT0jICAAAyyUIAAtVQAgAQiaGA= Date: Sat, 14 May 2022 00:42:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [urVtvQmionYGbb3HOCV0ByccsHfv4ObB] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3f8464b8-5631-43f8-6138-08da35429966 x-ms-traffictypediagnostic: CH0P223MB0266:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K8gPDNE9TfEsucaguQ61aWnCH0M3FvvvOaC5f2UVxPwhoBN8ctcho1oNquRBKHA+4Yb9K1MIIPQFMS8vcWTNigjnGdq+rCxLUbYHnJwJpQ02jN7FvQPsBA2Fz2SH0XvCeOqk39aUtJpqmxPFMxqzEg8Cba4M2AQv962ItlUgSo2GV6M4dl+gky6XIlZZXNJGaEJ3JLtqnQmo8zVmIHHb2CEREODp2gqBIITKw9qfQk96PYMWo/j56bkAOdlFKlP8JYpkd5RJESe2LGr9p/J7KILz5FVwHXubS/rUEe3FcCIY6qFYgkDliWgIPEbPEx1ldzvouXh8yF/RCpZq1FaFnlH3LcWbgMYZnHd7tqVdZNcAYF35i7K/tD+HAoKkh7g8EOP+tqcBMZCSK2KR5u3HrgPP6q4C2sn4KN/zf1jAzY01yQyvD5qM94S5un4znNdBSiyRW1Xe2d1Z4UhVd4pz2RzYbnF880zP4BajXkbIF7/khMoLsXqzqP1vozRX6hENRDJrguZUD3n/83y4Uz3fS+G4NfPY5apCrfE9fzw+1db4FqhzVgsy5zWlBDgqNDBa6BYeIwyoi5mw97HA+mlqfw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dWhhZHlHaEpzNXIvVWh5TmgySHN1VUVIanBiSVY1VWtGZlh5dGMrNUswZlFK?= =?utf-8?B?RFJFdHM1VzBrcmhzblQwSGcyVVVldzI5a2lvdnRJT1M3NjdrcE81c2xMandW?= =?utf-8?B?clQ3UjNuTE92T2h2ZGVNK1NzNEFwdy9KQkR2QVIrQ3E3bFA1Y3ptY28yY0pE?= =?utf-8?B?Ykcxd1JlUUVJa0NDQ2tTSlZrT1pkVk4zUklTaW51d2pRQmRFcUdmWW5HOUZj?= =?utf-8?B?akFWZXExdWJ0K2hzYnNZUVlTWXAwMUhHRzBPbllxU2lKdTZ3Sk52YXlrME9J?= =?utf-8?B?UHRsMExnNmU5V0NqUFM3alJmN2ZKZDFJendHSzhsWVllMkhQaVVNdFRIMUtq?= =?utf-8?B?UWtBZ0lReFZGb1Y5Q0lobmVLRTFTMmd3MGZVYmNNdlliaDA2RUcraERDT09i?= =?utf-8?B?MXhXU1U0dkEzYmtVenhmalozaExnTlp4TkplQlZ3RnJkVFkrUmZDTXE5WnBt?= =?utf-8?B?Yi9GdlVsb1FSY05ZWUVIeG5IQUlWZWFhSmN5TWZEc0RrOWpTcE1MWGxIbSsv?= =?utf-8?B?cWt1S3RENmhUZ2pLMDRRdUFPQ294K3c4K2NvOVhuV3A3VXZyYTRoUzF4Y1My?= =?utf-8?B?eGZ1eDlSbUxZOXZmbUtzQWFOVG0zTjFwNFgxdENkT29xZno1S2NERVUrdzJn?= =?utf-8?B?QitmV1ZrczdhcDZvQU52WEw0WUJ3bDVSRysrT3IyWXlNY0krSENGVkx5TFd2?= =?utf-8?B?a21Fd0ZYdzcybC9wcit2VUJEWGQ1ZUlZRElTeEF0QkVLRHFOVG1EeDNwQkxs?= =?utf-8?B?djUzS0Z3Q1BsQ3pZN29vdzFOSzdmcHBKNnpNWDA4NTZaN3ZrVDRHUEIySmY3?= =?utf-8?B?eWZOUmJ4TkFVWERDbmtDZDMzUUN4SjlBM0lSMkRHajdEejJMMWJJci9MY2lk?= =?utf-8?B?R2hvcSt6bTRtRXFNM1BCUDJydTUxalNLRVhsV3Q0WnVacURoSG53aFZ4ZlRs?= =?utf-8?B?VTlQYldWeTk1MGdlWmU0aTJSSGk5dHMxS1JhN1hEYkZRN2YyUm1ha0pPVVh0?= =?utf-8?B?bUZiOU5MVHZqbVlNa3BxRVVrQzhyTGxrSGRnVzNUOTF6YUJ4VU1RMjgwaTFD?= =?utf-8?B?WHVqbkJRa2kxdmRlU0dLQzU2L05WbDNRNnRkb0pXN0hXaDVaTytENStEZGFC?= =?utf-8?B?R1pIQXp5UXFxVUFwU0tDdDlQL01mMlcxQVhYNUJDa0dNb0tqRU02eFZ2NFBt?= =?utf-8?B?QVlZRUZKTnRoVVlzMEVueldndkx0SGdrcW1XRHdGMkU3eVpvNElRVERTdlI5?= =?utf-8?B?eFFlRkFlZDNzUURNalo5L1hZSklVOVpFR3BoZDlFTGJVNUdoWHIrYW0yemcz?= =?utf-8?B?eTJyc0dSVGFpQ1EvTDEwVnhlTlhKOUxQTXV5MWw5aDdDdVZDb0RjNWlmNUx4?= =?utf-8?B?YnVPMkUyNFo1T2sxZ002eHYramFlazNGK2JlQnZqYWlJd01Wc0lDSzBKMWh5?= =?utf-8?B?N3pncTRUUEw1aWhQRURhZVlEZW82OUdSbk5lR1FqRXlpSUpuRlB1MmVIcExr?= =?utf-8?B?MWJVVWJadDAzdzFOK2p5TlZxbVI0V2xLd0dUMUZBbGs1VExWdnk0OEFMcXNn?= =?utf-8?B?Q2o3STMwS2xlMkV3eWY4Y0h3L2xCSVpXWTQxbXRoMkFUdTZ1Ylhyd1ZkNTZa?= =?utf-8?B?QnVGTGxIK1c5MHFIY3VGZzlOZlhIVVcrdE00cStyNzhZWjV0NjN6YlNVSHJL?= =?utf-8?B?MGxnSFR0Y0podkNJUVhULzVWTDh2NFk0NEpGVFVIWkEwOWl0UG94UVBubVgw?= =?utf-8?B?SGdub2d5UDc5R2grN1BFczZpWml5QmwzdnhheGtlRWJWVzJsWFZGSUs4WVMy?= =?utf-8?B?T3c1aU84Zk5XN0NoTEtkWmpScUNyc2xQWUNiRzh4QWdIZ0hQWk44TnJObFRZ?= =?utf-8?B?M04rVEt5TlhaOU1KbTN0eC9jcjJsYXZUdzdjMHBDTm1SSXN0dnBSWC9GMHdT?= =?utf-8?Q?3czf1/oeBp4=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8464b8-5631-43f8-6138-08da35429966 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2022 00:42:18.3615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0266 Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of nil- > admirari@mailo.com > Sent: Wednesday, May 11, 2022 10:57 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and > utf8toansi > > > I think that can be changed easily. > > How about writing the necessary patches yourself? I did and submitted today. > > The prefixing can be implemented as a function and then be used > > in file_open.c. > > Other file system related functions like mkdir, rename, rmdir, etc. > > are already intercepted in os_support.h, and the prefixing can be > > applied there. > > I haven't found path concat in these headers. What I did find, > however, > is the use of snprintf with forward slash separators right inside the > #ifdef _WIN32: > > #if defined(_WIN32) || defined (__ANDROID__) || defined(__DJGPP__) > if (fd < 0) { > snprintf(*filename, len, "./%sXXXXXX", prefix); > fd = mkstemp(*filename); > } > #endif All these paths end up either in win32_open (in file_open.c) or in one of the functions mapped inside os_support.h where they are now (with my submitted patchset) handled by the get_extended_win32_path() function, which handles all cases (e.g. forward slashes, relative paths, prefixed, non-prefixed, UNC, drive letters, long, short, etc.) in the same way as .NET does. > > I have not fully analyzed the situation, > > but surely there are just a small number of places that need to > > be changed and not 587. > > 587 was obtained with fgrep snprintf **/*.c | wc -l (became 588 after > a recent pull). > At least two of these uses of snprintf correspond to path > concatenation, > and have been already presented here. Not all of them do, but I have > no interest > in examining the other 586 cases. But if you think that it's easy, > well go ahead. I did that now, and you can see that it's as easy as I said. IMO, submitting "competing" patches is not a nice behavior in general, I only did that because you asked me to. Hence, I didn't include replacements for those of your commits that I think are still valid; they should be merged as well, even though they are just covering niche cases and are not that much relevant to "long path support" in general, which is from my understanding primarily about being able to access input and output files on long paths rather than running ffmpeg.exe (et al.) residing at a long path location. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".