From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9CB004DF16 for ; Sat, 26 Apr 2025 16:29:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFF0C68A210; Sat, 26 Apr 2025 19:29:08 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2022.outbound.protection.outlook.com [40.92.40.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E122687C8E for ; Sat, 26 Apr 2025 19:29:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EftHy5+pDLjr/DrxJ/Mgz5e7ylxDg/lnJ7xwJDNJ53KI/HcWuFyoFInUXkgHojFiUaPYAVnghewq4b2Da2lnnex0Xkesxh6uhJHFWCuqzsB/RyfZfsMa+NM/oqUn6Ij3/vSJbND6CDKSfschAZ0fP4kg+c+Lxn5/3yg577EOzrXW+o/nT0dEHE0zfainCsk+A8yF1M8rt5vXUKpXli1E+4s6IdtJsl17YsixlyyrL5yseCw4hiayoeZL+HNk2ijszsxC7CBbhxoaZnIl+uEmninKeKwUNeWbuVq+q+s7gFI84XFsvNJpoxZPY1AW7oLwyEJS+NLSGzF5jCUx5pvttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlQbz57DjP7ff+pJv2+/Im4BD3jgcpdm+Z3AdHKvax4=; b=DTFADi+0abdn+wciXKTqKUs8GOhIRtxbdV1hbZb2Njs5uZNmlc5PsysYlnGHVEZq6Cpy82jThLQGaIa1D6UOYtbHSViZ0bsjleGJKAxPNekZTZk3F1DmroSzKAMmSLiY4R+pOJ6s71Ddh7fI6zlb/5YL0wJhKBvdy9f0zsYq1sgrnGYeOcvSZPI9V1NaWQdzqBxZZEDJ3fojrIyQYtpODJV6LgshaXfvurXDgdSSLFPKoW3qjPwr4074KQ8YTdAUQw2/CyN+Yf0Kl32FNi7mEu65Fetuq3bx+bjsYsC+2AngsDjEoPO8GSoV0lQPoulqDLr1oAtwdES+5hgpHruaIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UlQbz57DjP7ff+pJv2+/Im4BD3jgcpdm+Z3AdHKvax4=; b=VrkxdphR4nQLVgGN4CJ9tbmhXLZFWMr3tDeNcX6USkM43qFZORYoU3Cd9VmsMeaJeO73cvLfju3uMuc0+4jpq05Qk4gW4uI0nXoEq3n+grFHoyReZjdgx6JK0yle3+KgBN5ABQBZx1m6tevZbZmkd+zp+a+xgY7LfQg9veCy1lXYhCUkSBH84+2qGe6t9uWA+sdbZiThnJNe+3kHORcxV3/c2wmg7g55I8e7UidERRENy/5I3/dMBSSHmoGpVanUtSBvBH1Ygo7+1h6PDEKnyPxYU1AHhhhqOcnicOAVRESL3BKya6q8cd/tC0smQLrM4SjG9DKJPCxifD1wHZLeDw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by LV3P223MB0916.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:1d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.36; Sat, 26 Apr 2025 16:28:56 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8678.028; Sat, 26 Apr 2025 16:28:56 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [TC] "Future Log Output Default" Thread-Index: AQHbtr1mk0XyPD/VKk+XwC5OKdTNBrO2FcNQ Date: Sat, 26 Apr 2025 16:28:56 +0000 Message-ID: References: <20250426151027.GF4991@pb2> In-Reply-To: <20250426151027.GF4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|LV3P223MB0916:EE_ x-ms-office365-filtering-correlation-id: 3c942e95-3391-42e9-19aa-08dd84df70f8 x-microsoft-antispam: BCL:0; ARA:14566002|7092599003|8022599003|8062599003|19110799003|15080799006|461199028|8060799006|6092099012|20055399003|440099028|3412199025|4302099013|26115399003|102099032|56899033|1602099012; x-microsoft-antispam-message-info: =?iso-8859-1?Q?zZUP9xJTx/v9GK0dQgmqdaXjO6duWiGQs1y8HgvsHiiXt1wgGiU0H9x7ot?= =?iso-8859-1?Q?1v3sm7GIlanw2NkEv742pA0EVHUuE+Aqn9kciyPfu/vWaH90gsScejeNuW?= =?iso-8859-1?Q?hXZ1/9pFaXCOV7HDyCd2DwGD8a2uf6LhPl59TxMOQh6bbFzt2Nio8Xmq63?= =?iso-8859-1?Q?IHY4xmwWOp/c9sDbZViD4lXO1xeRUSgnJgAmPoKCIINFlImFuVgZd/npdd?= =?iso-8859-1?Q?NJmgQRDNmbkGdsbtWYFPU5zdeZoW3QWtpaqkE+2PV1sJpZ3IUdBJi3qIlt?= =?iso-8859-1?Q?yaF7IyqriY5uWvCXeDzhqZVMKiTY+RPceUHcsiyGG3PyEaqzv/YYGH4/EP?= =?iso-8859-1?Q?Ok/WDLr79d7zbyuIG+LcJflUklSGjtWcaq/uEVLqLOOw4xVvI1tjJDIeTh?= =?iso-8859-1?Q?bo1AV1Ri7r9f1Mkpvzr8/jlOr1ivB6PkQOPZUWqabj7n6wR+BXuwT1oomg?= =?iso-8859-1?Q?lXkUCwrnz+mFUGXnm/qNTKYco1jjvEBtGDlBBYwd4Lr6uxH6MjkH3l/ceT?= =?iso-8859-1?Q?WiHeRSKv2AIfPn9m1fS6rLkmflG1xHGLNmK63MLBvSg7hBDmFDSWRXk6Nd?= =?iso-8859-1?Q?DQfeShPq9umdo80e7eYaNStYinQWol0QtcFBHn63nTmSLBOReCnrmna/G4?= =?iso-8859-1?Q?AgoROe0jB3IfgwSc6x25HRWYSjteRNVClHxjS6mQRhDVRAkHEvfd2+OUFc?= =?iso-8859-1?Q?/tyWYq2KcZ/+YS3e+j0zWATSvnvuIZ4i/k62J9MHbRra7TAru3w7olF20Q?= =?iso-8859-1?Q?ytfy/9XkebQTHTMueLdFYXJ9zSAOJwwwES0CpAaMRnJLtbsVOJFW6W/WlV?= =?iso-8859-1?Q?dS+m2DDmB/Q1gnudBno8MyQMFXzFB12QiyYnQ2Jq1DILEu0NQtwzbmeTmn?= =?iso-8859-1?Q?69vX+5tF6BYA4ifmE3ChKvouBUfancEHkvwikHZtG7771bXFqnhfc5P3Mj?= =?iso-8859-1?Q?qrgsK3RsNBki8YE94b1/ehW8K/WCURT6lCGh96zp1YlU0R2aws/snGmf2X?= =?iso-8859-1?Q?qwAVZswMUMkcZhQD75vtQfAWedQN8zAxTJlnLmQuMqFgQRIA+74WOp2faZ?= =?iso-8859-1?Q?ESmjspYrpqUrEbDxclDmn07GsFwuMHtGnTG5oxtVSXzof9JsrJKafCGOCN?= =?iso-8859-1?Q?qVN9e24NS6iJZHmxuSm15qFV8HZ0H4h00I/jdt08s3Ca/M6uicthz5LNOa?= =?iso-8859-1?Q?hjPVNFBNBU0nRAnZHxmLCXJ/UFAAvWBIzNx6L1qtsTIhRBXLJjX7oKm9sh?= =?iso-8859-1?Q?gtFjb50U0WUwtYivEUY4FKcePJ3aUhKVc2OloM3C5K1PiOZVSeXPQDch+7?= =?iso-8859-1?Q?f7/KWFArgUaX8sS8MriMJ4M5H4LPtHHIqR69Z2gLOjWOXpCpG31SuA92yI?= =?iso-8859-1?Q?DCEqWPVsmA?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rtboxyNOxtZTN8fg78rtVKZh0X8uLPBFtIGjELe4wgYvLzfJqsq7srZj7n?= =?iso-8859-1?Q?sKionIusjjP7nOIwYDg2X/MG52F0hQydi0qgz8uxwiLeVNoLakjfuLfWAV?= =?iso-8859-1?Q?OAqb8rrdoZKKZjt0V1WqpN0I3sMp6ZG3LM/GL3q6wTBsaQ7Vfa6pEymcCt?= =?iso-8859-1?Q?0SOaKqwWRwpQ7NNBCRTFv3o3b26Zh6NMPk537xhfAfEq2w0yraRBIZePKf?= =?iso-8859-1?Q?D5+6JKWGIwbNSAzGjOgcSqvp2om9AcJhClt6tNBr4idQ9pjPjDoPz7o1EY?= =?iso-8859-1?Q?iDh+bh2aq/ae314TM856PA4V/Q2KYKOXTlNEYabiqccASN/UzYPgg054XG?= =?iso-8859-1?Q?MgV2YvdaCpxepVEIec+NdJnf1AKsU9mZsh53qSdtVQM/B9bqXOI5MTDbZA?= =?iso-8859-1?Q?mfwWXWE5gjRvEx8WQvrjNwDWnIhrbWoMNa/RDVvG1JQ2ndK7BPfTtemCUM?= =?iso-8859-1?Q?eT6t9VuPF4R2B4RXQ79Wtoh9beBtJJhIsKUluYQhUo7RoEhoy2OE1qeGO5?= =?iso-8859-1?Q?NTUwY3qcX4oTzAJWeWvsNd5iYr5V9DhX8RsmslFBBmwVCg6GfZpd2JD9r0?= =?iso-8859-1?Q?WNhB3VK+Hrs+MSllcrTRLeBo9IAAawSP4K2+yo+qvuGYvSWBGM+Me7BaPW?= =?iso-8859-1?Q?vO0Tvl/migCkliF9h+TdkhSyoLnu73AbB4/vmOGFzIxT860TCYRN0JPH/K?= =?iso-8859-1?Q?wIWEm43nu7nLsdu4IcKkaPisdDtt+5JDeoHr8RYIvc5xYLvAWNZwgNzLg+?= =?iso-8859-1?Q?3wJ7x3gGKswt5nn7SrIvQyT4AQsNWbRQkx0u8YxJiQQL8nrWoBjfHuqrOr?= =?iso-8859-1?Q?NEwqfFAWaOlQBn/2qOKD2AyPxGIaGJOoVPJ6pGrTQZ38/QsWwBcOnoA5cz?= =?iso-8859-1?Q?6O9bREnEmfxZWP0C6Ug3PfyP8FpFmDmvXFFnsO1xO8lT0KXJvvZyqvU4nD?= =?iso-8859-1?Q?p8/4+RYv9XbyLqWokDQg+G4DEkdPyYovq55Eywf7ffiKTx3qYApBf8xoax?= =?iso-8859-1?Q?NlgUTPEik5TwNx/NT16d8xVqioDfKQhV4LWXBV1fqchYSzHGipnGSAkeRW?= =?iso-8859-1?Q?RUch1wzWLXXwLVOnIYCnptcHY0cR7CfXV7SqEuMXJBzvzSZY3J1uxkYEOE?= =?iso-8859-1?Q?brV0PaVL2eXwnvhzgzC5zC5socu0jKS9A5Ya++kTaKUm3PuUjVCNsk8ZNo?= =?iso-8859-1?Q?Gv1at9Evi03DpoJjqOu66p3TDFXyPtmVCbDzm/pSfOKLlUPrP5qoqu5iUS?= =?iso-8859-1?Q?sWMurTeZqpR+GKBKj05OUKNy8Rpa3cgcYeYGg+tU8=3D?= Content-Type: multipart/mixed; boundary="_002_DM8P223MB0365730ADE5D1A6AC620DD64BA872DM8P223MB0365NAMP_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c942e95-3391-42e9-19aa-08dd84df70f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2025 16:28:56.4338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3P223MB0916 Subject: Re: [FFmpeg-devel] [TC] "Future Log Output Default" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --_002_DM8P223MB0365730ADE5D1A6AC620DD64BA872DM8P223MB0365NAMP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Samstag, 26. April 2025 17:10 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: [FFmpeg-devel] [TC] "Future Log Output Default" >=20 > Hi all >=20 > This is just an announcement that the TC has been asked to look into > avutil/log: Add log flag to control printing of memory addresses > GitHub: https://github.com/ffstaging/FFmpeg/pull/59 > Patchwork: > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3D14094 > ... >=20 > and the disagreement between people about it. >=20 > So far, Niklas, Martin and myself have commented, there have been no > formal > decissions and no votes, we just since yesterday send some comments. >=20 > From these to me it seems the TC members who spoke so far seem to > agree > that the addresses in the log are "mostly noise". >=20 > I wonder a bit if the TC discussions should/could be more public but > thats > a subject for a different thread. Myself summarizing will surely miss > some > fine points but iam trying anyway. >=20 > Niklas also brought up that item_name() is used in filters to > disambiguate > instances and that we maybe could add a const char *name and have > fftools > genrate a unique ID for each >=20 > Either way none of this is a TC decission or binding its just a > partial > summary of the things that TC members said >=20 > thx >=20 > -- > Michael GnuPG fingerprint: Thanks Michael, hello everybody, I would like to note that my reason for handing this over to the TC was not= primarily about conflict resolution, it's rather that I feel that this dec= ision is at least one size too big for me standing right in the front line. Ideally,=A0I think, it would be great when it would be backed by a majority= , but I wouldn't know how to determine that other than a vote. The TC in tu= rn has already been elected for making those decisions and so that seems to= be the most natural way. I'm fine with any outcome, also open to do once a= nother variant of implementation if that would be desired, or just keep the= default to current behavior if that's the verdict. Thanks sw --_002_DM8P223MB0365730ADE5D1A6AC620DD64BA872DM8P223MB0365NAMP_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Sat, 26 Apr 2025 16:28:50 GMT"; modification-date="Sat, 26 Apr 2025 16:28:52 GMT" Received: from SJ5PPFF1542D51C.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a0f:fc02::641) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM with HTTPS; Sat, 26 Apr 2025 03:11:40 +0000 Received: from BN8PR15CA0001.namprd15.prod.outlook.com (2603:10b6:408:c0::14) by SJ5PPFF1542D51C.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a0f:fc02::641) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.30; Sat, 26 Apr 2025 03:11:39 +0000 Received: from LV3P220MB1729.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:c0:cafe::54) by BN8PR15CA0001.outlook.office365.com (2603:10b6:408:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.36 via Frontend Transport; Sat, 26 Apr 2025 03:11:38 +0000 Received: from BN9PR03CA0936.namprd03.prod.outlook.com (2603:10b6:408:108::11) by LV3P220MB1729.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:21c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.27; Sat, 26 Apr 2025 03:11:36 +0000 Received: from BL6PEPF0001AB54.namprd02.prod.outlook.com (2603:10b6:408:108:cafe::7c) by BN9PR03CA0936.outlook.office365.com (2603:10b6:408:108::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.23 via Frontend Transport; Sat, 26 Apr 2025 03:11:36 +0000 Received: from ffbox0-bg.mplayerhq.hu (79.124.17.100) by BL6PEPF0001AB54.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.12 via Frontend Transport; Sat, 26 Apr 2025 03:11:34 +0000 Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5ABB68AF2E; Sat, 26 Apr 2025 06:11:30 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 23F2468813C for ; Sat, 26 Apr 2025 06:11:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3E29043B17 for ; Sat, 26 Apr 2025 03:11:24 +0000 (UTC) From: Michael Niedermayer To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] tests: Add stream dump test API util, use it to dump stream data for chained ogg/{vorbis, opus, flac} streams. Thread-Topic: [FFmpeg-devel] [PATCH 1/2] tests: Add stream dump test API util, use it to dump stream data for chained ogg/{vorbis, opus, flac} streams. Thread-Index: AQHbs8+5iN61rxJw20qZVECA9L3s4rO1SieA Sender: ffmpeg-devel Date: Sat, 26 Apr 2025 03:11:23 +0000 Message-ID: <20250426031123.GC4991@pb2> References: <20250422214408.10102-1-romain.beauxis@gmail.com> <20250422214408.10102-2-romain.beauxis@gmail.com> List-Help: List-Subscribe: , List-Unsubscribe: , In-Reply-To: <20250422214408.10102-2-romain.beauxis@gmail.com> Reply-To: FFmpeg development discussions and patches Content-Language: en-US X-MS-Exchange-Organization-AuthSource: BL6PEPF0001AB54.namprd02.prod.outlook.com X-MS-Has-Attach: yes X-Auto-Response-Suppress: All X-MS-Exchange-Organization-Network-Message-Id: b5d25a84-6bce-4481-2aa1-08dd84700d84 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 received-spf: Pass (protection.outlook.com: domain of ffmpeg.org designates 79.124.17.100 as permitted sender) receiver=protection.outlook.com; client-ip=79.124.17.100; helo=ffbox0-bg.mplayerhq.hu; pr=C x-ms-exchange-organization-originalclientipaddress: 79.124.17.100 x-ms-exchange-organization-originalserveripaddress: 10.167.241.6 x-ms-publictraffictype: Email delivered-to: ffmpeg-devel@ffmpeg.org x-original-to: ffmpeg-devel@ffmpeg.org authentication-results: spf=pass (sender IP is 79.124.17.100) smtp.mailfrom=ffmpeg.org; dkim=fail (signature did not verify) header.d=niedermayer.cc;dmarc=none action=none header.from=niedermayer.cc; dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1745637084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VethuPGNpJXEEYWqV6qzdCztUZAGPg/zjBwLVKEMep0=; b=HyWWXMijjc9WcjCA0kg9BiAqKxEh1NbDTBkYzdFweSRe3itmfmLWHMpLtV30xOE2WYY4Sj JVl6hJdXDQixNRIfuRUS2ldtqnkpw1BlhSfWuZI3yseqAbPWtF2aCDdU/o4p+KHf7qFkxY U9DF2tHk51lZDDYId406NkYJvXxvQcwGRtayW+zB4T0dL57WjgZGWv8TBMl7zPsj6XJc+7 0Rn5P5/DM4wJoRbgUcASqz8QuEOprIVqacfFNnPAGR1BDCw9UwAhtbaspdAh0Te0cMRl+a ge0Uu04Vx12dqa9ldaR8ePGCnSPfTZB0ayKv4rAm59PVLZpAEfcnQiohXuIyhQ== x-ms-office365-filtering-correlation-id: b5d25a84-6bce-4481-2aa1-08dd84700d84 x-ms-traffictypediagnostic: BL6PEPF0001AB54:EE_|LV3P220MB1729:EE_|SJ5PPFF1542D51C:EE_|DM8P223MB0365:EE_ x-microsoft-antispam: BCL:4;ARA:1444111002|68400799013|21080799006|461199028|13100799027|6092099012|440099028|3412199025|26104999006|1380799030|1360799030|1370799030|56899033|2406899039|6106899015|2006899018; x-ms-exchange-crosstenant-authas: Anonymous x-ms-exchange-crosstenant-authsource: BL6PEPF0001AB54.namprd02.prod.outlook.com x-ms-exchange-crosstenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 x-ms-exchange-crosstenant-network-message-id: b5d25a84-6bce-4481-2aa1-08dd84700d84 x-ms-exchange-crosstenant-originalarrivaltime: 26 Apr 2025 03:11:34.9461 (UTC) x-ms-exchange-crosstenant-fromentityheader: Internet x-ms-exchange-crosstenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa x-ms-exchange-transport-crosstenantheadersstamped: LV3P220MB1729 X-Microsoft-Antispam-Mailbox-Delivery: rwl:1;ucf:1;jmr:0;ex:0;auth:1;dest:C;OFR:CustomRules;ENG:(5062000308)(920221119095)(90000117)(920221120095)(90011020)(91020020)(91040095)(9050020)(9070021)(9100341)(944500132)(2008001181)(4810010)(4910033)(9575002)(10195002)(9404095)(9310011)(9220031)(120001); X-Message-Delivery: Vj0xLjE7dXM9MDtsPTA7YT0wO0Q9MTtHRD0xO1NDTD0tMQ== X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?v6AWKaO91SnHii6K5urZAjm+RLRyi99UY3371SZA225BsOLQ2aTDJTQu0/ld?= =?us-ascii?Q?io9JjmEEkfo7zUlp7fBuSjVwbP0EPuB4bkHzp52y1To1t/L/e87erbwBMP+k?= =?us-ascii?Q?GfQWWNUV78BL3Jlli4Y8BeNXh0Mj2EUf1T62Ofjkfu6zH2kbTJT4c2a71Eso?= =?us-ascii?Q?jBs2sZV2xNx4TNOPH7//A94vJW54eRZ70hGt9tVLprwfOcszg2IUDWrhAiRQ?= =?us-ascii?Q?5XZuh0j0iSjr5qFn1Y+n/Cjc40JJn3H2yZlcgB08Z2VHc03R96dC383aBh9g?= =?us-ascii?Q?LtfhyjUnf5ODVDz25lC9AhAnT42ov75dwpNNmLQfkGXuoZxvmys8+973hTWN?= =?us-ascii?Q?AX5O0qJNaizySiL2TYjfAFGBFzQvaEaDddea/n/MT2/38VeXYceyQd/HMO1v?= =?us-ascii?Q?rEj+hAME3ALsJaApviY1bPFqRQHQ51Durqrah6mim52zcf3JW1+B5TtcQTrU?= =?us-ascii?Q?XZZQcD56rExM61Ov7BtgX3MdGvLDsVKTuY4HzC/WoDMjX6w+Kj8Stgi4kY7a?= =?us-ascii?Q?EcRnfEmIDS2lbLKCXwaTCk/bAPF5T2ktf22SB9VQnMqEchnBk9BC5JxqQsVg?= =?us-ascii?Q?qOAuyAwlHP7hH0dbjMVqeBUq5BKF8dLk2hqGweOxGLABG9Y3lBwGDXZw/P7y?= =?us-ascii?Q?2vYNeGL05QsNSacUfJOhNDsEtxa363jH6L7CLqgvagu4R8xDUlrwF+s0ktzU?= =?us-ascii?Q?ljdA6ARR815jKyQFpbjmhWoa4UwbUhWfxV5Yljwl/eyUGO/tP8WXPjVow3EI?= =?us-ascii?Q?RgTc4xhYINxrTumvEntnUOPVlE9DhClbUICyWpIgF5zlth0J10LzSKqpNdDU?= =?us-ascii?Q?ulyUkTJWbLCNHc1ypaN2X3MiklzhCnMW0zLQOjojPv3E6XI5yhzBXOK+bAmI?= =?us-ascii?Q?MctqvwixV1yOG9CFwrcR2eLA7stJrfX1tg1fiI9L0sUGqi7HHiT/G9id+aR/?= =?us-ascii?Q?3Rr/63Y5kDKbIa0c7cf6O5RIBovtQTbBiZ/IEI4B1oQ3LVsOTkJOgYy6u9by?= =?us-ascii?Q?SDOgewJup4LQvT+WfB/drqI0Vf5r8auAf2lsfzNJp5vhkTi1CK/gTXRyvath?= =?us-ascii?Q?7FGS4wx9pvoeV2vmqmcMqJHYwrdTBEZuUHtWjqsbHxSAvdjuu3+tBt2L92hL?= =?us-ascii?Q?eVriU16/6VBJ+Z98iaRF71ZPWOoatQh1uqijZeilDpsZkt8ADssPOBtmBVP/?= =?us-ascii?Q?8SHq0d14rTrmggbPowI3uSCnxzZLsOBl+92aLMoYNKk9gnzfcVAwjPcEDBPp?= =?us-ascii?Q?XdiVk/gsdX6E2Flo2DExKJ64S7287gxEsQlFqcB/KjiK4/QG4wrx5smO9Xgp?= =?us-ascii?Q?Gi9dGKAUmj99DPcGLPyvbN1zsAH6oGa8WQQv5Cc8QNtjPN72rax23c90dd7y?= =?us-ascii?Q?W/hAqWl7tU7bewf1Q3hf4wDS3lM+CTmzDEX2zufKUomssTP/TV/VU8rFJ9yn?= =?us-ascii?Q?9kCtoZXWTz75nOfbiWYMpwKzd1e9vj8p5a8ivUtGFM6D3jeXRKJi5kVIkweM?= =?us-ascii?Q?coYAYUpHdZA6TEv61vEZNmptY6be/8to8R8wHOnHfreccfNzG6DyGMt/3mlT?= =?us-ascii?Q?NU/A3zgNANQRotmphHRV9W/77RcGS1ovVcRdcJV1+UsoS3qunEMo7dv3VoLm?= =?us-ascii?Q?dybTh9JL965V3K1zckWlES3kqArzytnma3jRWYiKbTe/w1E1xQl7meQLtSQC?= =?us-ascii?Q?JYhqH7FmCUEqbz5MSZ17Y7RYCBseQvE9lIwdPQXNZ7d6G85a0nkHSb95Vc+r?= =?us-ascii?Q?JoNipogRmBswVuRRSo+P4c3Yg6/I4otvWwTLTABM+1cDe5Y90NqIGcqbLT8O?= =?us-ascii?Q?21VJdm5iHlnPFgx2iCfj1aLa4gi9wbu1/KTe7GFw2i3wFf0iQP4O4wHBhWVB?= =?us-ascii?Q?KIId5UjXpg2TLwm+oQQ6hHy3vBLfS71ZNB+iy8RZcE8nUcyJoiLYnkp/0Qmw?= =?us-ascii?Q?GEf2nn0sncSckCSJU8hRusc6EXV1W6DQCg1Hc9XKP6P+UJi22z+QyBdlSl2x?= =?us-ascii?Q?Jzn3TmWIQ2S3dj76ji6LKRfFzw=3D=3D?= Content-Type: multipart/mixed; boundary="_003_20250426031123GC4991pb2_" MIME-Version: 1.0 --_003_20250426031123GC4991pb2_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On Tue, Apr 22, 2025 at 04:44:07PM -0500, Romain Beauxis wrote: > --- > tests/Makefile | 4 + > tests/api/Makefile | 2 +- > tests/api/api-dump-stream-meta-test.c | 177 +++++++++++++++++++++ > tests/fate/ogg-flac.mak | 11 ++ > tests/fate/ogg-opus.mak | 11 ++ > tests/fate/ogg-vorbis.mak | 11 ++ > tests/ref/fate/ogg-flac-chained-meta.txt | 12 ++ > tests/ref/fate/ogg-opus-chained-meta.txt | 27 ++++ > tests/ref/fate/ogg-vorbis-chained-meta.txt | 17 ++ > 9 files changed, 271 insertions(+), 1 deletion(-) > create mode 100644 tests/api/api-dump-stream-meta-test.c > create mode 100644 tests/fate/ogg-flac.mak > create mode 100644 tests/fate/ogg-opus.mak > create mode 100644 tests/fate/ogg-vorbis.mak > create mode 100644 tests/ref/fate/ogg-flac-chained-meta.txt > create mode 100644 tests/ref/fate/ogg-opus-chained-meta.txt > create mode 100644 tests/ref/fate/ogg-vorbis-chained-meta.txt > > diff --git a/tests/Makefile b/tests/Makefile > index f9f5fc07f3..75b9bcc729 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -219,6 +219,9 @@ include $(SRC_PATH)/tests/fate/mpeg4.mak > include $(SRC_PATH)/tests/fate/mpegps.mak > include $(SRC_PATH)/tests/fate/mpegts.mak > include $(SRC_PATH)/tests/fate/mxf.mak > +include $(SRC_PATH)/tests/fate/ogg-vorbis.mak > +include $(SRC_PATH)/tests/fate/ogg-flac.mak > +include $(SRC_PATH)/tests/fate/ogg-opus.mak > include $(SRC_PATH)/tests/fate/oma.mak > include $(SRC_PATH)/tests/fate/opus.mak > include $(SRC_PATH)/tests/fate/pcm.mak > @@ -277,6 +280,7 @@ $(FATE_FFPROBE) $(FATE_FFMPEG_FFPROBE) $(FATE_SAMPLES= _FFPROBE) $(FATE_SAMPLES_FF > $(FATE_SAMPLES_FASTSTART): tools/qt-faststart$(EXESUF) > $(FATE_SAMPLES_DUMP_DATA) $(FATE_SAMPLES_DUMP_DATA-yes): tools/venc_data= _dump$(EXESUF) > $(FATE_SAMPLES_SCALE_SLICE): tools/scale_slice_test$(EXESUF) > +$(FATE_SAMPLES_DUMP_STREAM_META): tests/api/api-dump-stream-meta-test$(E= XESUF) > > ifdef SAMPLES > FATE +=3D $(FATE_EXTERN) > diff --git a/tests/api/Makefile b/tests/api/Makefile > index c96e636756..a2cb06a729 100644 > --- a/tests/api/Makefile > +++ b/tests/api/Makefile > @@ -1,7 +1,7 @@ > APITESTPROGS-$(call ENCDEC, FLAC, FLAC) +=3D api-flac > APITESTPROGS-$(call DEMDEC, H264, H264) +=3D api-h264 > APITESTPROGS-$(call DEMDEC, H264, H264) +=3D api-h264-slice > -APITESTPROGS-yes +=3D api-seek > +APITESTPROGS-yes +=3D api-seek api-dump-stream-meta > APITESTPROGS-$(call DEMDEC, H263, H263) +=3D api-band > APITESTPROGS-$(HAVE_THREADS) +=3D api-threadmessage > APITESTPROGS +=3D $(APITESTPROGS-yes) > diff --git a/tests/api/api-dump-stream-meta-test.c b/tests/api/api-dump-s= tream-meta-test.c > new file mode 100644 > index 0000000000..bbfbd1f30b > --- /dev/null > +++ b/tests/api/api-dump-stream-meta-test.c > @@ -0,0 +1,177 @@ > +/* > + * Copyright (c) 2025 Romain Beauxis > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a copy > + * of this software and associated documentation files (the "Software"),= to deal > + * in the Software without restriction, including without limitation the= rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or = sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be includ= ed in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHA= LL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR = OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISI= NG FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALING= S IN > + * THE SOFTWARE. > + */ > + > +/** > + * Dump stream metadata > + */ > + > +#include "libavcodec/avcodec.h" > +#include "libavformat/avformat.h" > +#include "libavutil/timestamp.h" > + > +static int dump_stream_meta(const char *input_filename) { > + const AVCodec *codec =3D NULL; > + AVPacket *pkt =3D NULL; > + AVFrame *fr =3D NULL; > + AVFormatContext *fmt_ctx =3D NULL; > + AVCodecContext *ctx =3D NULL; > + AVCodecParameters *origin_par =3D NULL; > + AVStream *st; > + int stream_idx =3D 0; > + int result; > + char *metadata; > + > + result =3D avformat_open_input(&fmt_ctx, input_filename, NULL, NULL)= ; > + if (result < 0) { > + av_log(NULL, AV_LOG_ERROR, "Can't open file\n"); > + return result; > + } > + > + result =3D avformat_find_stream_info(fmt_ctx, NULL); > + if (result < 0) { > + av_log(NULL, AV_LOG_ERROR, "Can't get stream info\n"); > + goto end; > + } > + > + if (fmt_ctx->nb_streams > 1) { > + av_log(NULL, AV_LOG_ERROR, "More than one stream found in input!= \n"); > + goto end; > + } > + > + origin_par =3D fmt_ctx->streams[stream_idx]->codecpar; > + st =3D fmt_ctx->streams[stream_idx]; > + > + result =3D av_dict_get_string(st->metadata, &metadata, '=3D', ':'); > + if (result < 0) > + goto end; > + > + printf("Stream ID: %d, codec name: %s, metadata: %s\n", stream_idx, > + avcodec_get_name(origin_par->codec_id), > + strlen(metadata) ? metadata : "N/A"); > + > + codec =3D avcodec_find_decoder(origin_par->codec_id); > + if (!codec) { > + av_log(NULL, AV_LOG_ERROR, "Can't find decoder\n"); > + result =3D AVERROR_DECODER_NOT_FOUND; > + goto end; > + } > + > + ctx =3D avcodec_alloc_context3(codec); > + if (!ctx) { > + av_log(NULL, AV_LOG_ERROR, "Can't allocate decoder context\n"); > + result =3D AVERROR(ENOMEM); > + goto end; > + } > + > + result =3D avcodec_parameters_to_context(ctx, origin_par); > + if (result) { > + av_log(NULL, AV_LOG_ERROR, "Can't copy decoder context\n"); > + goto end; > + } > + > + result =3D avcodec_open2(ctx, codec, NULL); > + if (result < 0) { > + av_log(ctx, AV_LOG_ERROR, "Can't open decoder\n"); > + goto end; > + } > + > + pkt =3D av_packet_alloc(); > + if (!pkt) { > + av_log(NULL, AV_LOG_ERROR, "Cannot allocate packet\n"); > + result =3D AVERROR(ENOMEM); > + goto end; > + } > + > + fr =3D av_frame_alloc(); > + if (!fr) { > + av_log(NULL, AV_LOG_ERROR, "Can't allocate frame\n"); > + result =3D AVERROR(ENOMEM); > + goto end; > + } > + > + for (;;) { > + result =3D av_read_frame(fmt_ctx, pkt); > + if (result) > + goto end; > + > + if (pkt->stream_index !=3D stream_idx) { > + av_packet_unref(pkt); > + continue; > + } > + > + printf("Stream ID: %d, packet PTS: %s, packet DTS: %s\n", > + pkt->stream_index, av_ts2str(pkt->pts), av_ts2str(pkt->dt= s)); > + > + if (st->event_flags & AVSTREAM_EVENT_FLAG_METADATA_UPDATED) { > + result =3D av_dict_get_string(st->metadata, &metadata, '=3D'= , ':'); > + if (result < 0) > + goto end; > + > + printf("Stream ID: %d, new metadata: %s\n", pkt->stream_inde= x, > + strlen(metadata) ? metadata : "N/A"); > + > + st->event_flags &=3D ~AVSTREAM_EVENT_FLAG_METADATA_UPDATED; > + } > + > + result =3D avcodec_send_packet(ctx, pkt); > + av_packet_unref(pkt); > + > + if (result < 0) > + goto end; > + > + result =3D avcodec_receive_frame(ctx, fr); > + if (result =3D=3D AVERROR_EOF) { > + result =3D 0; > + goto end; > + } > + > + if (result =3D=3D AVERROR(EAGAIN)) > + continue; This code is not what the API docs suggest. avcodec_receive_frame() should be called in a loop there is not a guranteed 1:1 relation between packets and frames Even if thats the case most of the time Or is this tool only supposed to work with some specific types of files ? (if so this should be documented) thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott --_003_20250426031123GC4991pb2_ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: signature.asc Content-Disposition: attachment; filename="signature.asc"; size=201; creation-date="Sat, 26 Apr 2025 03:11:40 GMT"; modification-date="Sat, 26 Apr 2025 16:28:51 GMT" Content-ID: <8EFDB33DB09B61499660AE8C5C7F76E3@NAMP223.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NCg0KaUYwRUFCRUtBQjBXSVFTZjhoS0xGSDcy Y3d1dDhUTmhIc2VIQkFzUHF3VUNhQXhPMXdBS0NSQmhIc2VIQkFzUA0KcXhMSkFKOS82S2s4UElV a0o2VnMxNGZXOGF6TnQxMXVSQUNlTkJhTTd2ejJDOUQ0dm9QZnhpWG9qdHVSUHRBPQ0KPWVmMFkN Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQ0K --_003_20250426031123GC4991pb2_ Content-Type: text/plain; name="ATT00001.txt" Content-Description: ATT00001.txt Content-Disposition: attachment; filename="ATT00001.txt"; size=258; creation-date="Sat, 26 Apr 2025 03:11:40 GMT"; modification-date="Sat, 26 Apr 2025 16:28:51 GMT" Content-ID: <97AA4E42C9582E48AF44C62A0199B203@NAMP223.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCmZmbXBlZy1k ZXZlbCBtYWlsaW5nIGxpc3QNCmZmbXBlZy1kZXZlbEBmZm1wZWcub3JnDQpodHRwczovL2ZmbXBl Zy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWctZGV2ZWwNCg0KVG8gdW5zdWJzY3JpYmUsIHZp c2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsDQpmZm1wZWctZGV2ZWwtcmVxdWVzdEBmZm1wZWcub3Jn IHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLg0K --_003_20250426031123GC4991pb2_-- --_002_DM8P223MB0365730ADE5D1A6AC620DD64BA872DM8P223MB0365NAMP_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --_002_DM8P223MB0365730ADE5D1A6AC620DD64BA872DM8P223MB0365NAMP_--