From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF97C42FDD for ; Tue, 17 May 2022 15:43:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7DE4768B3D5; Tue, 17 May 2022 18:43:29 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2014.outbound.protection.outlook.com [40.92.19.14]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F97068B314 for ; Tue, 17 May 2022 18:43:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NADztSLezIazI5cnVw8YE2W7Hj7OztbeTnUUFFsZi+FrvZMbcqouEi89ujTUQuJpWmr1c42Svp3F3vYECI417QXReQzogL6HRxUo1htK9ajFky0TMBATRSsoMQ4uE7WBON1IQ09XDKH5Q3xDkTeq5K6E/dJAyyVPLuh3ndsovl2SJWbnAfeSm85RV61f3hU9qP6W3J613oay7tPZJfjcVWXyVj81nEfRObyewkbUHe4H6jDTkD+qFti+Jrfy6kqTKaKXYaXWL9QXwqGbuLiHLmsa776ZRC7r1HpbIb0155GSkU161doIxlIYLQBi6g5r9bnz5OhX3MVJs6sxCiKZ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AThg7aAAONZoQKjg4hCtLd68ieQobo6aIBPItSQa+Os=; b=VuiLF1AfyEUkJblHmBo0XExf6NtAbuzs/+O61kXiLw/lumV+LxJTkrAb3ikgkDk2/OE6fS9do3H+/E6+7hx7aVxaDtHkuhUjztI7+SeuQw58395TUpBYcXo2oY2sLAJPtd4KpLlKhuZ2PczKJWXWQRvaHGlBUBbq0kUtXsjiDyBPR+e+Qho5zKk41Av3hc4ZB1NEUxGqWuWC9f+JC++qlvsNcXErhfEE3yyXxo0xizq5skmCIwQisgvJThDG8uYObluBlM2wEGvHiGTlHeAfJKxjpP1qH99Xbb5bt/fWTAOkEFBp5pQHkzT3uBC9JOnyH4jcqt3QaGkHqGA5xR5Ghg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AThg7aAAONZoQKjg4hCtLd68ieQobo6aIBPItSQa+Os=; b=LKiXRcQBCju3fW+qK9rtGadIlPeY+VXFQ8bH5bTO1/Uzz4e+0BFiPmiGqujfa7tQW6yJvuC1G09E7pDpVPZ7bM7tMRwK5U4FYRx+b29/tJExM/Pf2FXRn3qMpWP8s7fQiq8nU9mbK7vD6YB1/0ZoE8AXI4fUnp2Di7yDQvGntjE683ulcptH5fdledz/5lIuTunrA6WqZFCvoA9L0nKXM5Litao08qGYlmtBt+KJuTQrUvTupT78WguTyv4RZexosFJTJek4P2ziyWv7k7EH2WQEQ6+vnpPE3j6Vb1yHFxqkSzbUH9i/0D+hxeSjKPwHnK6wqQQMLqyjW6kD0StthQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CY5P223MB0468.NAMP223.PROD.OUTLOOK.COM (2603:10b6:930:27::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 15:43:19 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc%3]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:43:19 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2 1/2] avutil/wchar_filename, file_open: Support long file names on Windows Thread-Index: AQHYaPywrYyA1nT6+EGODV6JkiNpta0h8QeQgAE8egCAAAMJoIAABhkQ Date: Tue, 17 May 2022 15:43:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [eEsbJnHdP2HtMAeBBQf38uXfvboDwalM] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c0af344-8022-40a8-cfd0-08da381bf7b9 x-ms-traffictypediagnostic: CY5P223MB0468:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 26bai3oxQzKuJlkhZxVnohTTzjrZKCq+3qCvbVCIF6qsyuAiehyzyY+EeL6F7h3j3ngWz/FBBOA15kIcvX1Ls3+3Tads2AgoE69DIcLsGgG3OJosdZNbJAb5PXmYThqvwSqLHpFFu0jClryEksDDWHn92AuNzzl/d1XFQSpRFz0ZVh8ySFp1su7viaf7Cj6ArK7r8NVRBJe1uL6WDwuIxVWLN9wfoK2GJHMVXdvXYZalK/uoUaJT/9BOUuYGLX/G/c5nNEvFMea8m4SM4Zh2gp9yAqqx6NMrvuUBeh7wKct9EuQ7XSpy8rB1Umj7HnwBElAy23bcrJkr6rO1PGaNtx6xx1d2IZCmOPO8f20pSVLpYQ3ElqZaWM1kMo9hxADSS7FnhIhTGoUg+xXOvXuKQUr1x4Jh9quM4bNCIHr4qsPmR8Ph4htLirm5Qlb5y1U76k79H9/WlyVdFCzTMxGDdglx2g119CYhGaj4+ZEdf3wdhVKGxX18yncygqDEAptLKe3CiGpKqpmPp4Dx3Ji2+sYcW6pnh/ttVYP+Mm9wvc+LEn+FDt30VAR2hqJi0mCxgsEqUuVXFnhHrHrteJYsrbHGWXTWMlQ7GH2Yuw5ZkKg17DMhuk8BQCgQK2gQN61Z x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bk9Hb1czd01WSXZKbnBmejlvdUJxUlBEMGFBbzduK2xvVkVmRlA2Qkd5TGJN?= =?utf-8?B?Z2FRMUkycUd6TkJyclYwMkRlSE41SEo5dm82YllSRGNlQnhQdXE0MllhTjIz?= =?utf-8?B?K1hBMEhBS1hjdG9Wd1RrSzl4OWxPYVZCS2JIU3o1THFLM3E3eWhTRkNNSjlM?= =?utf-8?B?U1FsVWhIUXMvOVZ6L1pBVGFiRDFLZTlDSlp1REdjZFZxTmZ3S0M2ZmEyUEIw?= =?utf-8?B?TkhaT0t3MkdZcFRnaDFoZVpSUCtnV3lmM3RVQmVJN0tkcDQyYmxtTWFpZ0xS?= =?utf-8?B?N284d2xFLzVnVmlGS2hLYVlaSUhIVWd6TDQxSzZnczljU1VSOUpQQkk3Q1ZZ?= =?utf-8?B?eEg3NDdjM0R4WUxaQmdJMDZhQVB2dGt0K3NTaUQ5clRWTFlyRmRwSlRnZjZa?= =?utf-8?B?ZmRYZjZjK0ZWMDZURG5RZ2FFVlRIZ242UG9YQjYxM1RVU2xHaUtNdld5bDZB?= =?utf-8?B?MmhRVjdIZHpVT1l0WnpBYmZ0TGR2SjNmUWowVnRpeUtuVit1WG9jZDU5amxr?= =?utf-8?B?UklxLzhibURyZ2QrR3RrQXl4STEyVWZSbnlFbU81cHZXL2VMcERMUm9WTkhu?= =?utf-8?B?OUNublhWNWhucnlDY3M2T0hSSHlHcDBvWUVaQ2hOK3ZoeEtNUHZvN0hmejFs?= =?utf-8?B?SHBQRldkay9jakJqZmRaTTlvTU5Gd3d3TDFrdmNHYUtpcHdSWXlFSWpVS3Nu?= =?utf-8?B?Tnl6SHpnU1R0WUtGak5XdUR4WUI0dFg5Wk9wYU0zemRkbzRaZm51NjR3bjIw?= =?utf-8?B?cFZWd2Rid3pERnltN1dDd1dacEtrNXdHc0t0YUtFS2hCbEcrYWlPaGdMUXpk?= =?utf-8?B?WnFoMUdybmN6NWNyUkk4bi96M2s3U2hOVXM3ejZaWEsrWEJlVHRiSTNDRkZ2?= =?utf-8?B?c3drK1VKWlVnd3dBZzlxYjNWMGs4aTRTK3JUWisrenpHY0lMdExiMm0wM2hl?= =?utf-8?B?ZDc4MCtRYWF5UFY1UWV0d2EzVzFRQU10YTF5SWlrcWwzWE9pZEdZWWJOWVRj?= =?utf-8?B?bldYQ2VXWEZRajJjeldybi9YbmJ3Z2ZHdDQ4ekJqMEZqdi9uTHRLZjhSbkFP?= =?utf-8?B?eGdvU3U5ZS84UXpIY2s4Nk1aQm83MFpWdWNoM1BSTUxNV3FPdlZYVjNxK0dD?= =?utf-8?B?c3U4dUl6bEMvODFJdThmenlBeDBVaVZ0MGI0eWN3UWNtdDFXNm9KTUJNRmNl?= =?utf-8?B?WUNmRnRkZ1pmTU5wWHorcGtPMCtXNVJPMm1BZ1VJMVNYSDF3M2VnYmQzZitp?= =?utf-8?B?Uk0vYi85b0FZWG9zekJ3Tkg4Ujh3MHliR3E5L1I3c3BSekxjNzVSaXlpLzVB?= =?utf-8?B?a3NkL0c2dnRobmRLUExBVTE0Y0ZacDJXQmVNM09FL0MyTkxJdW9BWHdoUEFS?= =?utf-8?B?QmwzUGFUVTZBdGV6K3dZVEZsT3lLcGFEUGdDdlVWREx0MVVZWnFZb2RSTHNq?= =?utf-8?B?MG1XNXBKYk1vb0N2bUVUa3BGS3ZEMnFFWnlNcStTWHhBVjhVYndvWWhuWkFs?= =?utf-8?B?MzVycFJwVkhwYWZWZWEvSmNQcjhiSHRMZ2pQaTN6MUFDM0xMQ0FZQmdYeUJm?= =?utf-8?B?YmhISlA4SEdiSW9EWlVaK2Nmb1RmSmsyU1BvV1pXUFQxc3lkYk5HV3JSRnBv?= =?utf-8?B?bFVSSTdRYkhHNjlVL25ZZnUvcmY0OWY4MitPY2tFRzZEbWJDUkg3eEZwdm1j?= =?utf-8?B?cld1N1hPVkJTb0FmMXQ5bG8yc0pMeUpibFRjelpmZDExbTUvWWdmYXYvaGJD?= =?utf-8?B?dTU1TDZWa3JiMjBTTStCZ09lbjBnUlRKcVljb053M1kxMEE0RFBjVElsazJT?= =?utf-8?B?bXBLZ1dUaUlEYVNySStaMFlkaW9GMkIweGdWVDFwQk0raE12bWJhVWtKOERG?= =?utf-8?B?UC9sRUpMeWx5NDFIbkp3TFBCU1VHV3B6YTVpUFFUcGJ6UHZwSER5T2RTQ05Y?= =?utf-8?Q?pDEmYF6ZWII=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 9c0af344-8022-40a8-cfd0-08da381bf7b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 15:43:19.7456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5P223MB0468 Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/wchar_filename, file_open: Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Soft > Works > Sent: Tuesday, May 17, 2022 5:28 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/wchar_filename, > file_open: Support long file names on Windows > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > nil- > > admirari@mailo.com > > Sent: Tuesday, May 17, 2022 5:07 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/wchar_filename, > > file_open: Support long file names on Windows > > > > > stat wasn't already defined as win32_stat. > > > win32_stat was already defined but not mapped. That's what my > change > > > does. > > > > There are two defines in os_support.h: > > > > # ifdef stat > > # undef stat > > # endif > > # define stat _stati64 > > > > and > > > > DEF_FS_FUNCTION2(stat, _wstati64, _stati64, struct stat*) > > > > which defines win32_stat (not stat). This function takes struct > stat*, > > which due to previous define > > expands into struct _stati64*. > > > > _stati64 and _wstati64 both take struct _stati64*, which is named > > identically to the first function. > > struct _stati64 expands into different structs depending on the > value > > of _USE_32BIT_TIME_T, > > which your explicit structure definition does not capture, see: > > https://docs.microsoft.com/en-us/cpp/c-runtime- > library/reference/stat- > > functions?view=msvc-170. > > If someone defines_USE_32BIT_TIME_T, your code will fail to compile. > > Yes, that's true. But there are hundreds of other things someone could > define which makes compilation fail. > We don't need to accommodate for every single possibility, and it's > not > that _USE_32BIT_TIME_T would be required or the default for 32bit > compilation. > > > > C allows functions and structs to have identical names, preprocessor > > does not; > > therefore win32_stat must be used explicitly where stat is required > as > > in file.c:160 > > Except when you define a compatible struct with the same name as the > function - like I did. I don't want to say that I'd consider this to be a great solution. But the problem is that the function and struct names are identical and when we want to re-define/map the function, we also need to provide a struct of that name because the macro-replacement can't work selectively. Maybe there is some cool trick to handle this, yet I haven't had a better idea so far. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".