From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 215714F1F7 for ; Sat, 17 May 2025 19:08:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 98A7368D84E; Sat, 17 May 2025 22:08:18 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2078.outbound.protection.outlook.com [40.92.22.78]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D499668D7C9 for ; Sat, 17 May 2025 22:08:11 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bePfyg30pajcIiof76AuawIvBKeLikTmP8qifCNw4NEDkVwEm0tW/OCJUTKSU4S6VZzbKI7JdCYNzd57KybHx/cmw1y9MqTHHK/R9f4n3eUpx1SIXCnOI2e06673y5eFH28enm8nUe8GIUzbG+uu5uro4KBbces8yk4tdCYkgSbI/lHHkk39yD0zA06aelAcSYFnWd3+Qw/P/YFNwRUlMIAx5/q3OmBpqUl5P7wzEKWByaSchAsr5d2OGhXa1USwnkIwNYFSws4Bz9urvAbZQ0xNgnfbPG0CZXjkTo+/dHqhW5JOnHiYkRe8KcT42iTibWzYwgcALizsLFBzZiQE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/ldcJ7+6rQde8HwqV4AMDTr/Jhkc8kcRvJDG0eidY0=; b=oFAu7jyshBS7OKqHI3W0tPxaSgeq9pYzFufckGl7Xnnnf6yzmPRE2/x0+1LjA/yMYrZK59Jl2UujfUlt255aDdAeMl2VUdazSc5LFWvwqYRziP6MiCpYKfko3UCLQFrqbP/UJm/RTRFic3qmLZVMh0mJiknbSGHn+EEiY2xnZMn+TfblWm6d0WgpgBV14Ep+3cwg3I3vodE5Vm4Kqn1rnmNyhleLJmDLAdoPECwjgfTVr0VI9Y625+bQnk7l7s4YIgJvkuCOQM0HQjZCtkk4J4qusPVefSq7T6iovEgjiyqohTt0KHN8VIZ9fvHjaGBN8IL4lCS/yL8iacP4jbRHIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/ldcJ7+6rQde8HwqV4AMDTr/Jhkc8kcRvJDG0eidY0=; b=AMiFw4R4hIdZPsM6fVAsiQkIj/JvEwqoaTHeRNXZpHZFagqa3j+8iOHxTNM8XyxLzZpTBtXfRFwYH9XpsqkDQeyu/pz0r9LAmQMX4qLuSNDgb9rACKh0wmiDO8Vi/z0TQmnNjMi89HOiCvUWQPONEgaAVDseEZemgKf2WFJG0bN8j83LmtEgQGEgCcI4vQXDi3tzEsw0mbH3nUtAeaxc25nG64/vQVNyEx4W/uiQLYFFLn1NPmT3KNhA8dHfeNJxxT1G2iBtuts1weYbBFQWd9a8cOR716OdG6XTTXVkVmjyiMBeZSmMe4vth2SqcBOAJifYHsfpdAvWgFTmv84ZBg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by LV3P223MB1086.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:1e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.33; Sat, 17 May 2025 19:08:08 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8722.031; Sat, 17 May 2025 19:08:08 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print Thread-Index: AQHbxxzj6ox+QknH8EuRFL4mwSavlrPXGdXAgAAIPACAAAaXcA== Date: Sat, 17 May 2025 19:08:08 +0000 Message-ID: References: <20250517111422.3393457-1-sw@jkqxz.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|LV3P223MB1086:EE_ x-ms-office365-filtering-correlation-id: cac5af67-2388-4df2-dbc4-08dd95762917 x-ms-exchange-slblob-mailprops: obhAqMD0nT+76ZruCrigLPUIQMEMZUn+AmKVPivvH02D0TKleyH2f6mrBmaap7v1ghO7epx2h/H7e1b9qyMI6I63pDTfOeVwLOJQMbOiNFBCf/SGtzE1R6nNoG9zeO3o571QqFqHwZ8K7DTRSnVw2o4cf/yaUBsQNp7zctCeYIGvJS05BNiX3ERWTY7V7WxHZGYtLbFDPwAeSUTi/19xyFzb7YXiIPIWoWKrk0LUxsu0FH2CntP/xZV6ByQ9m0AdgNNIoI2n0znlIodS7U2K29mK/f3qlPREvvtDi1f1KYyVQT5U3bEvEt3lGIS4rQQJ2AddoWx8bhtevBOt/G/hg7m0Db+FH8Xo68tv1/MkCEg1qSeprOFD3zjvlUsshAknzf486nZbPufYMo9vKcck/sxxbiafiwTKYHiFzylP4tdk4kOHB3w2umHFAKo2C9BvH0/+B2vA/Gmu5Blewz0TaQyHoEbYhhMpJG4MKo4tQmqn2IFnAnbfHzx/dO/Zmun39nQxs/KB+kMO2soi9e1A2xTSW9YQJ+RptjZ0Zuop6Z6Y7aBu3xDv9fpPE05wzGXHx7o298kr/mFRVn9lfZyOyzUTFyblqGe1ZKdUNtU4fWpaACiBZtZmrbphEJsV5s+GRyREfzBPP8S+i2l6Pqv8VpLr4j9+oxh0udjzthcLKdqbe618qYXQY2sYbGT0xC+9LTwHIcVCILLSTUWStigJR4QzVIljdGaShd8toho/5JeRN4byn10TqCpi/FPEmqvVcCOoxa3ZA7bw4J9yGIeym/2bxxs7U9eQ8CsdSZkLFzrygKOt3yN4qr27LlrBAlzT x-microsoft-antispam: BCL:0; ARA:14566002|7092599006|15080799009|19110799006|8062599006|8060799009|461199028|3412199025|440099028|4302099013|10035399007|102099032|1602099012; x-microsoft-antispam-message-info: =?us-ascii?Q?gjI0s9z22xCukGT/E5vrIopwzaXlODmPXZX0kljxK9ZbS+smsBtk+cLgWKPe?= =?us-ascii?Q?d7bzol0R0/+nW/uAEE6X8EEyV25D5xKhUseANkCunsJwb6unAhYL5mG7jdA1?= =?us-ascii?Q?/ZvF79LCxLwlxUbxzuvjNzo+/MRmqJuwgn+OCeHlMXjEdulUqSnnJfOjCwoi?= =?us-ascii?Q?gm1lfFOThSoTthM9Tpwm73DUWhu81eVIWvgV4kdOp+mGtdDLtcihpB/lAC19?= =?us-ascii?Q?c0KVI/3tHIHvTgfuNqOa1u6ETeSxr483f78iOA4Q+L3dJxTVcA8UK12JiY8+?= =?us-ascii?Q?9BSM8aI/zMJn0VSQJsaTlgh+yWbdwicADeuJF8/IAvug9YNAuD0hZ+SxhSWc?= =?us-ascii?Q?NxwIuKgQVbI8c1PrYlP9hQEcv4bdbVi/K7+HNvOgNNFQZS6cpOHVEWif3w84?= =?us-ascii?Q?QgNexCiNKXOELd7Uxxzh78pSQNiJ//J4wy0EaTzAAL8hhUkVgk0Zsctn4J00?= =?us-ascii?Q?73EXvRDyykY+KgvbwQOJTT+4nJ8a5a0yRpFh8jNxfxtDrrIWs5aAObXzsxU2?= =?us-ascii?Q?rmTlmUA1nmBrlms5zt7jS13VdU7+rIf5Vg/NCSnHUIYwVGXme2OfkBkLvvsO?= =?us-ascii?Q?6TNew08tj69d5E2+7+e9GaVH3y1q/KPuyEg1Tn5c/UKbB08gagDmki8jcRB6?= =?us-ascii?Q?1AxqAX/j3m+oIKcB7wyHBWy33/8vyT79suopi12ebcr6qr9NJyxboNdzkRUD?= =?us-ascii?Q?LoK88Yi5yHaXfExdy0O9RUdcQLNRpwcMDtqfiKKLulsoMg7qneghhaq9nos+?= =?us-ascii?Q?zjNBpFUlZBKQMvjokCMgK1viNnlqKeT6I3dYUWqZDUM75S+hCPEvhOipvcCH?= =?us-ascii?Q?TCXjpRfXMWZbwNb6NPEe+/1UKr7lnvo5JIMltVly9Y3IUneUUjZSXfXM54eU?= =?us-ascii?Q?QZ6obRMNYiKwH0K6Eg1jAC9ysjhXEOkjPFS7CJGhd6DUBIqKdXTH7Lm2WaoP?= =?us-ascii?Q?QOrUdreKraR7CL6c5vUV2IYEL937BWv113MKs/iMkd+CxjIoMJThvkCF96MM?= =?us-ascii?Q?MqEkdFLJ3pljqRINQ8RTVXv08bm3IvIw1FQ1ubuXKSzLNCeM2oOMZjJFedi6?= =?us-ascii?Q?3oNP8mWJl2ENScKXIJ3n1UrOwD8D5IXvRoTiVIEdlt6oq9wRzs0DhRhcac6h?= =?us-ascii?Q?HHb+NvbkEyPe51/YTPH9EtkWnp88Y6izeSeAKFDuKcGKUZcdyV9MRvDFkZcD?= =?us-ascii?Q?n3l4UGme0G6n2+CnmPZQI0FqtHlXs8fOz/cLN1YMkLukLjqxFuTlNhXEwMc?= =?us-ascii?Q?=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?812B6FR2Zf5tz/8yS8yWsazBWK5BgQteurWvbizZcLag4dADDTQU31Hoszy6?= =?us-ascii?Q?zs1n+obe+8i6kLHCjopTqzOnckUY1p29KpArn2XdA4/Nqt/LZ7M3nCBUC8FY?= =?us-ascii?Q?sGQ1ftUWdiuj24bPBcDZ1qvi+Neu3MlO4FdbqptndtmcBHYiXjUWM1oS7Lnt?= =?us-ascii?Q?U9EGeHhayEYP/yVvCUPagCpcYTzw1Q0BWagBrQt5NrQplUYOTN9jzvN1nM80?= =?us-ascii?Q?4uxZ3EOr+mGFw409lGnqxJLrILgXFp/kY2UPEs85B7F52kZ9nB04ZOHKj260?= =?us-ascii?Q?L66DJJa79q3OiVrKOZ/0wCougy0No/+9yHtsy7kZIbZhqX4QW+BEFYLGhd1a?= =?us-ascii?Q?t3LxWBXhVaB/W753b6cmu7wdr6g1dMAcXTt4goKGu/T+ap/D6W2PNQ14EcJD?= =?us-ascii?Q?gy0vNSFeo7yhaVYokuC6eHoBwqf1RgrFpRtZt8JWBfh/JHy37TFPIODMXTOU?= =?us-ascii?Q?5rPAxrY71gwGrfTnoUi0AAL+tDP6KalmVw8dqxqU9rHVXDxiUm/iJ+sNI1Vw?= =?us-ascii?Q?ER8wLIHPFzx+S2923zFodGhjttc7NTD3XAr+KiVq7HZ6S4sTeSAxV+JhzIWq?= =?us-ascii?Q?Nd9zmIq7s3EQWO3OgfYunmXCHYc4RGHNMdw/EIFYeZpYthI/yYkJ2O7FSZ9D?= =?us-ascii?Q?A16EriXGuGprVWu3X0gXc3DSZcjsqvDciBZxLTBwhziiye6iomRLc0l4XAaM?= =?us-ascii?Q?AK/ylujvy0UXSFOPPE4kUKl6OELF7h9GaMUoMi1lvC716McJzHSEzO9j/AkJ?= =?us-ascii?Q?5VZe53lu+6Edr8MT/0/J1Gf1tN/39a/jOhk7D072Kd7OrdpJw9DDhQ8AJaea?= =?us-ascii?Q?ppD4ApRF6YgBDyiZK4SJ+fpUknMesx/TTOMVhAoNuL7eboQswk/H81uKoNqb?= =?us-ascii?Q?ZVw/btA0yB9h/+kILlVTOVZF+iC1lDUeeSbWEH/9Ik1IvyVcApDE5/Gh+AC3?= =?us-ascii?Q?lUwpp207py4RG0rw/h+I0zrqYdLL/gi2jD9PkJ7FZ+VYAs2ZMmkArc+8Kaks?= =?us-ascii?Q?aIoGAihqJ1A21JbjcRbU0wWahr1l7ffWQKlCZr9uNhk6DG0B5OgdHK+BVXHr?= =?us-ascii?Q?t56yTTzwXNttIRBQVbHn4GyzAEIuJXQTZo+4uQA7oCdpZVTdSUdSW37sCQaZ?= =?us-ascii?Q?qEsEnNjtWf8G5h5WgtRVCNe5fVvyAbPR0bAt3FfDpW6nkZeKjBqm9AnvcEg3?= =?us-ascii?Q?hGJs+/ukJhZp51WJ4ITJ6Et16L3J6lGcXTvCl9znuXTrNhzTB5CUdXh97qM?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: cac5af67-2388-4df2-dbc4-08dd95762917 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2025 19:08:08.4262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3P223MB1086 Subject: Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are no graphs to print X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Mark > Thompson > Sent: Samstag, 17. Mai 2025 20:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there > are no graphs to print > > On 17/05/2025 18:52, softworkz . wrote: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Mark > >> Thompson > >> Sent: Samstag, 17. Mai 2025 13:14 > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: [FFmpeg-devel] [PATCH 1/3] ffmpeg: Don't print graphs if there are > no > >> graphs to print > >> > >> Avoids writing an empty json blob in setup error cases. > >> --- > >> fftools/ffmpeg.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > >> index 964770df23..ad28cff78d 100644 > >> --- a/fftools/ffmpeg.c > >> +++ b/fftools/ffmpeg.c > >> @@ -309,7 +309,8 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, > NULL > >> }; > >> > >> static void ffmpeg_cleanup(int ret) > >> { > >> - if (print_graphs || print_graphs_file) > >> + if ((print_graphs || print_graphs_file) && > >> + (nb_filtergraphs > 0 || nb_output_files > 0)) > >> print_filtergraphs(filtergraphs, nb_filtergraphs, input_files, > >> nb_input_files, output_files, nb_output_files); > > > > The feature is not just about filter graphs, that's why it's been renamed > > as "Execution Graph Printing". It also works when no filter graphs are > > in play at all. > > Here's an example: > > > > https://softworkz.github.io/ffmpeg_output_apis/1_nofilters_3_in_1_out.html > > > > > > As for the nb_output_files check, I'm not sure - is it 0 or 1 in case of > > -f null output? > > 1, including when you stream copy to null and there aren't any real graphs. > At least one output is mandatory for a valid command line, so it should always > appear in non-error cases as far as I am aware. > > The aim is to avoid to the nonsense json blob when an early error happens - > example below. It does still get printed on later errors (such as a muxer > error), because the graph is created then and some operations will have > happened at that point. > > Thanks, > > - Mark Okay, thanks for the clarification, and yes - it's important to get the output even in cases of error, but I agree that it doesn't need to be generated as long as output files haven't been configured yet. If you could resubmit without the nb_filtergraphs check that would be fine! Thank you sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".