From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 017394EF7B for ; Fri, 13 Jun 2025 23:53:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E4E6A68CC3B; Sat, 14 Jun 2025 02:53:35 +0300 (EEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04olkn2044.outbound.protection.outlook.com [40.92.45.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4463F68C64E for ; Sat, 14 Jun 2025 02:53:29 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MUHQwvBaD2ylihfuG9fXWAlkZO3RilriBUNtZrapr7d9RmzXFMK/LErGYfQju3zS/HwRALche3fJCy7TouxKyyx6xtwdAnu44u1P+U8Tir040NfKaXEiFa8dDQAryru3euE1k5bK2QvBKdoM/cclpAZo5LU/zMIjAWK300lScDAvTbTxzQnreGDLJIhYvFHhxAmtM6r+/VYneB4UYGDQkTTWMmhLMJdEVehpvKc/UX8t1tSfl95P0m0GiU8eAwFlZpfO6WNUJwH6lDPqiogVmvmE6XRlhu8NfGzs/b/ljY4UI8hqxZNvFUGjMUgCBz/BvjksyarEap9gFD/JUNQC9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Haoo+4cj6CZ6JfDDnlLyjxPE1yrmDLrMgFmHVPwgjrY=; b=pshIokUBDita8aNiTn92HM0wNM6d5AEr3yNdAnMZJmGSCg+oQuy1B1iJJGCH6q0YQAD9ug+HR3M8TK6GWm8yMi9IZYOWOBDohaLwfpCE4wfU4JXgewBFQCZfM8pmWTjUVg637D9LVLrBJbYFtMaeYgYQfdIcdZ5lwwSGBN0uegQ5hxOJ6dENt98conDMPDvNPCL6N/l18SqictdF/yfKy8o47J0Zp4g8P3HZe/dvWiUpZjCIA4bqs8jmmyFgO09ye8r5c66t+eNN0yViibGX7VpPS4wcZ/2ph+pZt11cxjLGNqtEf8jGQV/EJbptbt4T+bRnlErn4F+8xK8/D/903w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Haoo+4cj6CZ6JfDDnlLyjxPE1yrmDLrMgFmHVPwgjrY=; b=TUVJdu1lKh99Arl86Vb6L9Z0CgIhA0w8wex0zrsEJslNOw2bZeJcDiyOJVhL+vIftIDKfOtWfTOERawKyg3Ff4QbNMtOKkqHlBks6Iq7VRLFxk70p97eDSBoMyJl6SbXSmLMkJKySX6X5aSF48e+CULaYty8vDQoLejeg50rJwPdXcoFuN6iUIzH4vWS5puI4aYLk6CG6RXJYqfBtTm+q35RYDuVH9LOlY9MREChAOvFyjauNVyqqKQMLLQPhLsDU8L3s3tt6OCa8eTjPtk1BfdwS8xDquuTCS4yRhsXHgUCTNwnqONQTn3P8hfbCw0l1EMyuCw2ll6u8GIotP3PkA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0188.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.26; Fri, 13 Jun 2025 23:53:20 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8835.023; Fri, 13 Jun 2025 23:53:20 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments Thread-Index: AQHb3Ceu6PdeWcbWBUWhml3irHQKQLQBj7KAgAAzk+A= Date: Fri, 13 Jun 2025 23:53:20 +0000 Message-ID: References: <6a76e43900f1ac469a138bc2f5163a46d4a1dfb5.1749794067.git.ffmpegagent@gmail.com> <93a5c9ec-aade-0c81-7177-d0e2ac17314c@passwd.hu> In-Reply-To: <93a5c9ec-aade-0c81-7177-d0e2ac17314c@passwd.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CH0P223MB0188:EE_ x-ms-office365-filtering-correlation-id: 25b219d7-8ea6-41a4-7447-08ddaad579bc x-ms-exchange-slblob-mailprops: Cq7lScuPrnorNxbFcnOr5XZ/wReADy9KrumIquuxEjI00ETi4PpVSqF1g0P4GdsTWkeJwBAAKCPdHD7P4kh7FEA8Q+9wvQY/7OdR2klJPPzfrd/ehDIeT0jEfG3TxPiCiPupr0fD70YF8SBszZ1XJAH4QNlOGx8ngkSyXOMAjdf1lR0s7nkcvd+VUarQzUX+fn9pcit6BGe5DD6rDI81XmX+wXE4NAWLFn8elbRYneYx2wmRYVZAeMD49cugp5RhnCLGoRzKK7L6FSQ12Lq9LRV6JijE/QK0H9kZU1N3hs6F1fC20yN/0k6Fx3PW6MR/+YFGJvoghmwl/gMFO9aJPVRXqzacrF82OmlHeKzDFlLasPdHSwz5oB+zKOROCcFjjHWo/V682McNdXpwWgbuv4pCYeqFyXTplbiVKFFMyQGxPjo89fEtuRyYUCBvXfO/TsXJUlCHDZc+iJIlHQTX7oZoaSm/pxBbU/610sfdqCLbzBbKeASM0XY3M/93Ee/FGY1nwVsA9CEmmM+vhLL/Ash5aM3hq65U7hiZkjv0BIu+JLZ1UD5n2QK3NEXOWBYFaBqxiDHy6gmBysWoKupksxegnEtD3I79ZXZW11IHlef7HqgFqjTTQnStFEBtrKMFMmYxaI8nWdbWWgim2xMje8WKQzKUttbJBfKYgqka5I9BtdQPEquUQ6/ZHgkoawkfW/i79wQzy6HOLcBUAkS1OQMNXIZD3NMnC9MAGHZRpenZPI76LCgokgTNL7DgwwOEV8m2S3neEtA= x-microsoft-antispam: BCL:0; ARA:14566002|19110799006|41001999006|461199028|15080799009|8062599006|8060799009|7092599006|3412199025|440099028|102099032|12091999003|40105399003; x-microsoft-antispam-message-info: =?us-ascii?Q?loD56+Jnz6uQrBTDrZkEmGJLklx9zjbwiXMzbrJpHz4+Czz7fJhsuOJ6jvnH?= =?us-ascii?Q?/UJILwiYHGYpAPkNv/z7Qd97CodnmxSnXpWbV6mnkjSPs/arZRhArnmAtKhv?= =?us-ascii?Q?XxnbQnGj4xxYbdfwlD8/KDdbeGCXAe8Mn0oHj8ZVGZ20xX4yNyfmSuU1zrx4?= =?us-ascii?Q?/y4MezR1AVdo+5a16lUFvMgXmApXCX9QcfceqMQz23wQMocB28PjMb/WUy7a?= =?us-ascii?Q?iZDSqkThRqM7+cezYH/j/JASuU+atWdTBmKFHe+D+h9xabt5gkzROxejZXnn?= =?us-ascii?Q?RSDQkJ477VPxOEgtw9U+ZtAD31RoFNdhJ05pO6T9pg5NjygO0EQ+bwXGRdaz?= =?us-ascii?Q?5+YN3uqhTQqsao4G64CaMtcsuAp7LOExsQaPl+p55n2C2TA4g3dAnVbWgPzF?= =?us-ascii?Q?eA4hMPRnzUKQlvpAiyl6fH00LMisWNHF9CdCxdJXIzlbmd8tLonvxjxRYPHj?= =?us-ascii?Q?UTbKG2P5cenYGWLmcvDLshmWwoFc+qDlhVxGFlTfhDD9sU6eGhWVkSpFnVKb?= =?us-ascii?Q?Jj1/rqzdRToIKXW9BhLOMfECegqvL4bqO6o17bzXSO+GOKeEGFP3qh7BfZdT?= =?us-ascii?Q?MfF790AY4Vu2y3XZWj2+UWBSnEIALZywvxZfYZj9l8VVlQdRrq1kB3NWYRVd?= =?us-ascii?Q?dHIH43eMSyT4ARMxV0RvN+4BuDS+32j+HjWtTgycCqvqlr1lKc9fn1VHk9EL?= =?us-ascii?Q?ShvdSFOFgc0UjwcWxEESMYajgae4ExlouqawtDjqhNNOb2Yh6oZPmrk1LF8L?= =?us-ascii?Q?Azgl2A36E6h4+oWZLWYBc2bV0lwE13U5oRL8OZTBoSCbD6z+I8r0CSry3+53?= =?us-ascii?Q?+dAjfxJ92EcT5AcP83jK+vlZ1BlGHYHZDgE31YSwJZ1DUJyK6Mo8UqStPoJ0?= =?us-ascii?Q?2rTi6zLuhNetFjGL6PayKiQCNbIrbnMr7g1HxSUGjVLqcdLTtuRO269g63v0?= =?us-ascii?Q?Y9xhn7pE6+yc1LrJCXHVKJ1/RQ+UhSN308C13JLvdLc9IPuDZ1yZnKPEnyI4?= =?us-ascii?Q?tkBbBXF8M/dWeniSToCsDkuIDXzM0j59fM3Dzoxw797nBakCj48iFniBXGzx?= =?us-ascii?Q?vy0mxWIWC9gNdh9gr1VYwfrJdJ43j2Sq/0uu2tOxYIm89VmlLOkFwSscJASb?= =?us-ascii?Q?0CLmGiq67I9PlWe+ADae+fKhNkRtVBT7Ez0fpnvHNb5DZfboja+rUGT+cXN1?= =?us-ascii?Q?OZr4cRkI1O2L5lyMDdzH4OM8Cz73sVz56MSTTg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a5zOxegppnI9okoOp9Lhl/phKsCjRKPXDJn4tbipxSzPqKM9daRDK0QOXqE8?= =?us-ascii?Q?gFPQW7V+Dey1CaUCIOynf7wLdIT3Y5NeA3TOVUohF2euqWbpujopSvKP413V?= =?us-ascii?Q?fLHJNSo32ZXcKz35WV0+g4ftsQ1cdfEo+Uh3TXNYAPFIGOOEupRTfOkbIOFD?= =?us-ascii?Q?SVgc2elf4FO5it8AVceDKAFNaev8cczVeDL1/AemJR9PQiwBbDJxXD8bRRKA?= =?us-ascii?Q?Hs+zTWxQzkbCU8ltI414v52hou4Trz0/5KAPcbwnkZCHQW/2SkWnLOTxY89e?= =?us-ascii?Q?YGwBr4knodK6t06WWYfZVH2zmNQbf+9N88l2KGGmtb8KQOXK7c7RPTFnEpqz?= =?us-ascii?Q?lnlxu6pKE0KIRqliDIPnW7h3mAqqsEnBMfn7lrrM4nP180QRE41MUn267bcp?= =?us-ascii?Q?bX8WO89rpLfxy46CZpUbOvK222OUd0dwITlH66TRZtANxtr+/l2RYmx15bqy?= =?us-ascii?Q?gLw8Ri+jOFQMHpSIr49WofFFvI3dF4fiBJ6u/MqqepfwNnpMinn/Q7lI8zP/?= =?us-ascii?Q?zGXUNTiMfUZpCTN5HnxwlVqBodmOW60VOQgHz1zBreniJpOBOl1uiRMOpm35?= =?us-ascii?Q?xJ/6WE0PBYW6QKTnIGeczgJNV7N20ynMiZoF7AkZIcGi+KzoqyIIfk4vQO6t?= =?us-ascii?Q?m9/DKLaP/sAIvpJ+Mvk/teQLT118+gS/jk3O+z0W9aZtU2GGjIqmxUBcEbrv?= =?us-ascii?Q?UyLQP2rnxfIrQRmzC4dfqMJIg5VzcO6a8e0kBFeH6j0jNyS8ShNP078HbA3N?= =?us-ascii?Q?sjaYk45qMerAsVW7fZdyo+eISw7GYhBRNYve2qwetNsZAbaUQFGUc9xD8zQJ?= =?us-ascii?Q?g3CdpgL+FxHTzVMrJ4Ws5eU/+0CL6s1xoOsbwKQ22oGotuKPmxZZubqbP2UP?= =?us-ascii?Q?1FvRYnGWcALWeSl26qf3Tqk1wo0e1lLi7aNcCtyGSEhsuK/yxY8pBRGgwIeX?= =?us-ascii?Q?pupmBXDmY3ouvIntraYd0twNT9E9OAYoSmHawblSK4TfYmMG+zf2T9/BHTSk?= =?us-ascii?Q?ROeUM+e7004YwWlWOci8pFdH6sX3AHp2NtYaHqtkjumUk8cXJI4ABFDIsbam?= =?us-ascii?Q?/7KD5p7CT77Zx2jJIBpSkh0J71ToFzIiOWuO2v0nn7aMiOzD2nS+YTfJG4eu?= =?us-ascii?Q?/mCQxkgVL7Ts+sgbLHUNuvlNe3hiNcRth/m81QAOexbSoQygVYjabb067918?= =?us-ascii?Q?UG8ziPJuRcadK3xjZX0bD6qB2v/ze9Id/rKSUiqaAMwGd2WkS2DRvH3MNL8?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 25b219d7-8ea6-41a4-7447-08ddaad579bc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2025 23:53:20.3257 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0188 Subject: Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 22:45 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log > more detailed information about written segments > > > > On Fri, 13 Jun 2025, softworkz wrote: > > > From: softworkz > > > > Also moves point of log writing to after rename of temp files > > and changes log level to INFO. The completion of a segment is > > important enough to justify logging at INFO level. > > > > Signed-off-by: softworkz > > --- > > libavformat/segment.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/segment.c b/libavformat/segment.c > > index 04e973a198..608cad0ba4 100644 > > --- a/libavformat/segment.c > > +++ b/libavformat/segment.c > > @@ -417,8 +417,6 @@ static int segment_end(AVFormatContext *s, > int write_trailer, int is_last) > > } > > } > > > > - av_log(s, AV_LOG_VERBOSE, "segment:'%s' count:%d ended\n", > > - seg->avf->url, seg->segment_count); > > seg->segment_count++; > > > > if (seg->increment_tc) { > > @@ -471,6 +469,12 @@ static int segment_end(AVFormatContext *s, > int write_trailer, int is_last) > > av_free(final_filename); > > } > > > > + av_log(s, AV_LOG_INFO, "SegmentComplete=%s:%d Index=%d > Start=%f End=%f Duration=%f offset_pts=%s start_pts=%s Frames=%d > filename=%s\n", > > + av_get_media_type_string(s->streams[seg- > >reference_stream_index]->codecpar->codec_type), > > + seg->reference_stream_index, seg->segment_idx, seg- > >cur_entry.start_time, seg->cur_entry.end_time, > > + seg->cur_entry.end_time - seg->cur_entry.start_time, > av_ts2str(seg->cur_entry.offset_pts), av_ts2str(seg- > >cur_entry.start_pts), > > + seg->segment_frame_count, seg->cur_entry.filename); > > No CamelCase please, follow snake_case as the other similar > messages. And > yes, VERBOSE is the proper loglevel for this. > > > + > > return ret; > > > > fail: > > @@ -994,6 +998,8 @@ calc_times: > > if (pkt->dts != AV_NOPTS_VALUE) > > pkt->dts += offset; > > > > + seg->cur_entry.offset_pts = av_rescale_q(offset, st- > >time_base, AV_TIME_BASE_Q); > > + > > This line does not belong to this patch, or the patch description > is > incomplete. The line does belong there. The field it sets (offset_pts) is used for logging only. (it had been unused for years and exactly the name that was needed, a really funny coincidence) But I'm withdrawing this one anyway. Thanks a lot, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".