From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D5C724D422 for ; Fri, 21 Feb 2025 13:49:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BEBB668C888; Fri, 21 Feb 2025 15:49:19 +0200 (EET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2053.outbound.protection.outlook.com [40.92.40.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B11868C576 for ; Fri, 21 Feb 2025 15:49:13 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=er7Vk1B7RGmqHKf7RnreKPo6Wov0wpLd6oiTpF7MUyoVybtwN59kflP3s6DAWEf5CHQQyVpQSi5rD41cNC2y3+EjG1McZoM8+PFQE1H41BjHa3J6VaR4rgrA7OZwpDRipg6SUJEEIIZnxQryDYetzo+MYb0vcwny0A5e3DOeq5nCDtXhjg2jfzDRh5e6r2Kw3wlpcqceWB4X64eNbEdNmhO6BO34HylcqgTqq3KoyD2WJoB6S3Qdf2Hi6A73TtKBpn3HD3yyx4FikssxVR1E69u3CG2vLtblRj0DrLOpkHwHx+I3i2H7GA6ER5c9tB/I8GRBh22sVyMqoDevGMB3Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IlWg+surTNav+Ztt879mDRi/tEd1JB0InyqovdAOHys=; b=T1dzFz2FKQZxEup5m7SpLxcYMlBJaMYJRtTY1EoupnhlNCmW/KgXw9ZmdvMT4AMcy+UkzAzsbGceFjEA2ShqaYcz90CQy8bWrQNGhj//uX7snrXHrXVEPOIjvy3OT0hOFglc3iyW6bI+loW8EzKEsT0bRx7DTAG+nWVhGYMsCQVg/4+JUJnm6xv64N29FLF55yBWFmumi0NL9IB68eYtFMSlpwzRQV8sQuzpAuh7pTWFnpaVO+KoYTMMDqMDyAkjHB6wZ0+35umKI+OzmkF5kYKB0UZVdZ4WDRUTYNpXr3393ZJOk9tvL1ai3l06A3Y3uqWgAAAzAM4QxN4OjyJR+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IlWg+surTNav+Ztt879mDRi/tEd1JB0InyqovdAOHys=; b=PCqHqS1zvNYMoEkAvdaBdCgZpxk82CVnniDyPinQlnXdV3RRNer4ZnjgmYZO1NFqYc0MMF9Wp5wPUuFt33YoAE55XvvNLsQ+88OY2mEBynfb1vaFRJAVb57v4MTWEVNgaprXCF41Gc+giYo8QTQbFU1UI0mJmYCkHQktQWHn30pqTHR0ZMHzD88My5Bbb61oDrad+mhs8xWHUfRgiC9/U7P8x7S1p8JYis+W4isxTIfUXXXwKWmnjolGLzz+D6pFjj8eZ44aYPWxWHDy5jFKx59iX6/ugPb9ATPtsuykFmMXqJSOVaGblIrbp2zONi/OGgxk8K0aqLQhmjHjws/OCQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0119.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:15e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.17; Fri, 21 Feb 2025 13:49:10 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8466.016; Fri, 21 Feb 2025 13:49:10 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add options for filtergraph printing Thread-Index: AQHbgrT8d1+trcFiaU+SbAzXkjfWmbNRvlaAgAACe9A= Date: Fri, 21 Feb 2025 13:49:10 +0000 Message-ID: References: <0750b971f9ae0fc38917e0a3b3ccb7ad2e8cd221.1739959172.git.ffmpegagent@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|BN0P223MB0119:EE_ x-ms-office365-filtering-correlation-id: 39805dfb-2b90-4a7c-32a7-08dd527e84d5 x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|7092599003|461199028|8062599003|8060799006|19110799003|102099032|3412199025|440099028; x-microsoft-antispam-message-info: =?us-ascii?Q?X7hxzOqbFXSZ3RAOwZJ8tq9nmdv1Feq6UYFAC4lQUWOFbyA4+Afeg6XSZ47Z?= =?us-ascii?Q?VQYEz/bUmqjGZ53GBD0ZnevEXP7YxMD8ZsqnUoBxELfcnzH0Z1oYRZMiwgEY?= =?us-ascii?Q?7U0P+haCbyzXxSGrIq38pqgcvR+JJ15if+SkhXoF5jxkC7CHcZAd06ZNrvU1?= =?us-ascii?Q?LdxGpo9JmsuXSwv1VJQdrTrQMDdbMUKM+o637Qx2mgCzI6No20EXGvT0u/B4?= =?us-ascii?Q?41BsCpKNcAqJByFScyHGDS8/lQibL9XRoBzY0yovwfnK+B8MTMaQM/ZjvFU5?= =?us-ascii?Q?krwcYqBCSEWHo0WZRX05NCRerR+XTHAyglRzcgv1LXv/ROlkReBzrMOZedLR?= =?us-ascii?Q?AHqrcvisM0CfSLmir/MEjwxz3oNWrWM+OZK8LfaFEh+UpSej/L5kWuI98pRY?= =?us-ascii?Q?Wszym0xieib38gX+KVzYG26Mz208MLcc7ajHZDhKZaUDaw+gN9sAh776BNLz?= =?us-ascii?Q?+AxenhdLDTMOl1k93wktGmbS92CYvdwyE/ugD14B9WX9dsTNxwNj+ebUiQe0?= =?us-ascii?Q?vkq7KMSojHWHAAIDxGkUZIQDpLwSCKoVSKuoebjKN/aO9AoNCSMvS9QG29st?= =?us-ascii?Q?7D4pRaa0D3Dkipbdbzh7CY8mhtZewWJ2xWOR5VpdQYHlxIeRy7Beg8EkSUr1?= =?us-ascii?Q?EyZhtPazPk95MbZdDgIopY0YE2NgpEA7gax9PJfCEsrWD9MatbMi1LeGFyk1?= =?us-ascii?Q?Mqk5/SNsjIlUNlUQsdXQGXVLzj/ufaL856F8NdQTShqXDISfbw85/p7sUSM1?= =?us-ascii?Q?iOllce5Ttvgh9fSp0g5pwaUTGClja3WFbvSn4jCnMNxN3g9FS9/fn4eiNcAJ?= =?us-ascii?Q?JFnKKUb9vbS/3V8DYYHo/kyJ61KaviWHbUGc1VBKFa/gvDExnglbuvf5g+mS?= =?us-ascii?Q?wHPoLawCXUIcQ8j0vOd474D3ntO8yPHxA1ZZvd0ZkLvYEfPEEVlhh8pTgQtX?= =?us-ascii?Q?aXBa5Opw7xE4AGUl26OtCKcx8LjdHu8QoBII7+FAlTKJTZQlz21KjPPU20om?= =?us-ascii?Q?FwIvzzz8rkK/uN07U9DRwmkH1VzM5W6lIR5JReBYSCkeLCL1qwzGnqszqs1e?= =?us-ascii?Q?cABw7bOc1J97WNqB+iHSsqbUvUtlaQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AtJlLwg2FMLZgSrLZCIjvR7USw7OV2z16AkCV9XZA00qn9VJyUznhvWSE112?= =?us-ascii?Q?QqgjHacF61d7oKFDyCJij982/3oy7vx/ag3fS0hlIjKnk3fBRDoo/nZhfGWO?= =?us-ascii?Q?b2PJ2QWcswyKG9kC9St1Q3wyuNt/0EdXh2GhMukb2imWn0r+SkNm7H/eByc9?= =?us-ascii?Q?4x68hvte7CS9p1wMMV7THtk9H7/6kWWxMv+VGjfWGaZ9+N2BtahiONnu+sOx?= =?us-ascii?Q?+fsFbN9tcamK0SyKCapv4FOPLsz4hDsbMkb+v2w9XTYProuXVrAMSwJmoynQ?= =?us-ascii?Q?pjyGVzjanGi9GhzqL6q8vgwLviTpskUghRCbeSg/A+cYHva8lfDro4RkXC+B?= =?us-ascii?Q?GXE9dLcKglFmAeOW0eyys7szTcVVELjHZnTOfL/hTzvC9KdQ0TQQBsoSd7Tp?= =?us-ascii?Q?KROkfevRAPzkgbgRUNaVRUJt8z/amarhCWq7hAqvvfNqBLnTMIxaDbmfl8iU?= =?us-ascii?Q?E50xE49FYRa5tMmQ8xeGlnl8GW9guADI5oVWZJsdqTIxAhKpiIKviYGsFY5/?= =?us-ascii?Q?EFl09jWUamdKZvO1t95Dk2IdE6vDlvKQIbj9IcsropZS/dTGxbbCfK91EDhs?= =?us-ascii?Q?ioXEFcQN4QmPCz7VF2tS31czhrus5Sj8sTVSv+3mNyeVtFaw9hVWwCX433iQ?= =?us-ascii?Q?wGARYxgRGJXyqW58q1VB2rqtdWc2itgXKEDmEkGxb4VKGemjqVqFugujrTy/?= =?us-ascii?Q?cs24QC8kvz3EKj6Rh463QVb4FGVzxW6BTxKbL0OQom8RaVJS4JxGYRqahUL+?= =?us-ascii?Q?ed0JNW3f4qHwSjkmiVwHoxU7ZscMYekLxMLyav5P9oUeomHdNmLsT9Hl275t?= =?us-ascii?Q?yT/UR5yWI2P6fDjp39vEWOX0SzrchvOpW+M95ns24dynbLVpsZDuKuzy/wqE?= =?us-ascii?Q?KMn6ncbrDwcaaBE70sUV3UvZIcbEffAiAoiDhZSJHS445C4SU07dfIrzXU+H?= =?us-ascii?Q?JMd0n8Ts16JbHEeJleubfyqJY6UDxrv7Fo3ig8kRnM1PzWS/h60RYo9zDJSk?= =?us-ascii?Q?TjQYVV4PBxDjXdHQLNHK2R4fzYoODQ4JuhOyVqrk9W68tY5e3ru5HNhOTcSq?= =?us-ascii?Q?QR4vIxAGMetAiH7S4S3xf/9ul6Q6nYfRE9oYoU4ZlDeu6HvqAZv+rz/9uj94?= =?us-ascii?Q?tsAbQc2ZtquEjSf2QAz0G1acUY7t+qBXEqCnn64t+LjfL9i/DaYUibpfN6Qw?= =?us-ascii?Q?ZJFhinCwj6PQ/PE0VQkiymJOG4MCcwgW3JsPFOh6wnCmvJmneE2kCe0DawE?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 39805dfb-2b90-4a7c-32a7-08dd527e84d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2025 13:49:10.3909 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0119 Subject: Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add options for filtergraph printing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Freitag, 21. Februar 2025 14:10 > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add > options for filtergraph printing > > softworkz (HE12025-02-19): > > From: softworkz > > > > The key benefits are: > > > > - Different to other graph printing methods, this is outputting: > > - all graphs with runtime state > > (including auto-inserted filters) > > - each graph with its inputs and outputs > > - all filters with their in- and output pads > > - all connections between all input- and output pads > > - for each connection: > > - the runtime-negotiated format and media type > > - the hw context > > - if video hw context, both: hw pixfmt + sw pixfmt > > - Output can either be printed to stdout or written to specified file > > - Output is machine-readable > > - Use the same output implementation as ffprobe, supporting multiple > > formats > > > > Note: This commit includes only the default and JSON writers. > > This patch contains a lot of code copy-pasted from ffprobe. Moreover, it > is copy-pasted from 2018 ffprobe, with seven years of bugfixes omitted. Hello Nicolas, Yes, this is all true, but of course I did a diff to current ffprobe code and the number of bugfixes is exactly zero. Probably it's not seven but 4 years, as I've likely done the same when I had submitted it initially, in 2021. > When the same code is needed in multiple parts of the project, it needs > to be moved into a library with a proper API. Strictly speaking, it's not a duplication because one part lives only In ffprobe and the other only in ffmpeg. Also, the submitted code prints to a buffer and the ffprobe code prints directly to stdout or a file. Nonetheless, I agree of course that it would be great to unify it. When I had submitted this patchset in 2021, you had said the same thing, that you want to work on it, but now it's 4 years later and it hasn't happened. I understand that you would like to get in your new strings API into the code base and my only reservation was that I find it a little bit too clever/tricky which requires thinking around three corners each time when trying to follow what's happening. Probably also, your earlier string API (AVBPrint) is too good already to consider it urgent for replacement. Overall, I'm not against it, though. But this can't be a blocker. I can stub out the writers to a separate and shared code file if this is OK for you. I don't want to get in your way of things you have already started, but it wouldn't be much more than a move, not the kind of rewrite you are aiming for. I think you'll agree that this patchset cannot wait for something which might or might not happen in the future. Thank you sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".