Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Freitag, 2. Mai 2025 02:12
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution
> graph printing
> 
> On Tue, Apr 29, 2025 at 08:33:50PM +0000, softworkz . wrote:
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> > > Niedermayer
> > > Sent: Dienstag, 29. April 2025 21:35
> > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add
> execution
> > > graph printing
> > >
> > > Hi softworkz
> > >
> > > On Tue, Apr 29, 2025 at 01:00:03AM +0000, softworkz wrote:
> > > > From: softworkz <softworkz@hotmail.com>
> > > >
> > > > The key benefits are:
> > > >
> > > > - Different to other graph printing methods, this is outputting:
> > > >   - all graphs with runtime state
> > > >     (including auto-inserted filters)
> > > >   - each graph with its inputs and outputs
> > > >   - all filters with their in- and output pads
> > > >   - all connections between all input- and output pads
> > > >   - for each connection:
> > > >     - the runtime-negotiated format and media type
> > > >     - the hw context
> > > >     - if video hw context, both: hw pixfmt + sw pixfmt
> > > > - Output can either be printed to stdout or written to specified file
> > > > - Output is machine-readable
> > > > - Use the same output implementation as ffprobe, supporting multiple
> > > >   formats
> > >
> > > fails on arm cross compile (no zlib maybe)
> > >
> > > /usr/lib/gcc-cross/arm-linux-gnueabi/7/../../../../arm-linux-
> gnueabi/bin/ld:
> > > fftools/resources/resman.o: in function `decompress_gzip':
> > > ffmpeg/arm/src/fftools/resources/resman.c:82: undefined reference to
> > > `inflateInit2_'
> > > /usr/lib/gcc-cross/arm-linux-gnueabi/7/../../../../arm-linux-
> gnueabi/bin/ld:
> > > ffmpeg/arm/src/fftools/resources/resman.c:94: undefined reference to
> `inflate'
> > > /usr/lib/gcc-cross/arm-linux-gnueabi/7/../../../../arm-linux-
> gnueabi/bin/ld:
> > > ffmpeg/arm/src/fftools/resources/resman.c:110: undefined reference to
> > > `inflateEnd'
> >
> >
> > Ouch! I thought that zlib could be taken for granted.
> >
> > What should I do? Guard this and everything else that is depending on it
> > by #if blocks?
> >
> > Thanks for any advice, I'm not sure how to approach this exactly...
> 
> #if or make the whole tool depend on zlib in configure
> 
> or write a basic zlib implementation ;)
> 
> thx
> 
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB


Hi,

I managed to get around making the whole feature conditional by having 
the absence of zlib affect only the compression of resources, otherwise
including them uncompressed - mostly the same way like ptx compression,
so you can also do:

./configure --disable-resource-compression

to disable it. 

Does this configure change require any other accompanying change in any
file (doc, versions, api)?


Probably the compression wasn't really worth the effort considering absolute
numbers, even though the relative savings are nice:

graph.css         7752
graph.html        2153

graph.css.min     6655
(css is always minified)

No Compression

graph.css.c      40026
graph.css.o       9344 (6688)
graph.html.c     13016
graph.html.o      4848 (2186)

With Compression

graph.css.c      10206
graph.css.o       4368 (1718)
graph.html.c      5725
graph.html.o      3632 (971)

Numbers in brackets: .rodata size from 'size -Ax -d *.o'


Thanks,
sw





_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".