From: Soft Works <softworkz@hotmail.com>
To: "ffmpegdev@gitmailbox.com" <ffmpegdev@gitmailbox.com>
Subject: RE: [PATCH 06/11] libavformat/asfdec: remove unused parameters
Date: Wed, 22 Dec 2021 18:16:29 +0000
Message-ID: <DM8P223MB036566422FB84E3883F323A3BA7D9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <9988ecc6d2a0c1be27ff4924fe72c3f81f9649a0.1640186030.git.ffmpegagent@gmail.com>
> -----Original Message-----
> From: ffmpegagent <ffmpegagent@gmail.com>
> Sent: Wednesday, December 22, 2021 4:14 PM
> To: ffmpegdev@gitmailbox.com
> Cc: softworkz <softworkz@hotmail.com>; softworkz <softworkz@hotmail.com>
> Subject: [PATCH 06/11] libavformat/asfdec: remove unused parameters
>
> From: softworkz <softworkz@hotmail.com>
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> libavformat/asfdec_f.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
> index 4c898ab3f2..e87c78cd6c 100644
> --- a/libavformat/asfdec_f.c
> +++ b/libavformat/asfdec_f.c
> @@ -299,7 +299,7 @@ finish:
> avio_seek(s->pb, off + len, SEEK_SET);
> }
>
> -static int asf_read_file_properties(AVFormatContext *s, int64_t size)
> +static int asf_read_file_properties(AVFormatContext *s)
> {
> ASFContext *asf = s->priv_data;
> AVIOContext *pb = s->pb;
> @@ -494,7 +494,7 @@ static int asf_read_stream_properties(AVFormatContext *s,
> int64_t size)
> return 0;
> }
>
> -static int asf_read_ext_stream_properties(AVFormatContext *s, int64_t size)
> +static int asf_read_ext_stream_properties(AVFormatContext *s)
> {
> ASFContext *asf = s->priv_data;
> AVIOContext *pb = s->pb;
> @@ -554,7 +554,7 @@ static int asf_read_ext_stream_properties(AVFormatContext
> *s, int64_t size)
> return 0;
> }
>
> -static int asf_read_content_desc(AVFormatContext *s, int64_t size)
> +static int asf_read_content_desc(AVFormatContext *s)
> {
> AVIOContext *pb = s->pb;
> uint32_t len1, len2, len3, len4, len5;
> @@ -573,7 +573,7 @@ static int asf_read_content_desc(AVFormatContext *s,
> int64_t size)
> return 0;
> }
>
> -static int asf_read_ext_content_desc(AVFormatContext *s, int64_t size)
> +static int asf_read_ext_content_desc(AVFormatContext *s)
> {
> AVIOContext *pb = s->pb;
> ASFContext *asf = s->priv_data;
> @@ -619,7 +619,7 @@ static int asf_read_ext_content_desc(AVFormatContext *s,
> int64_t size)
> return 0;
> }
>
> -static int asf_read_language_list(AVFormatContext *s, int64_t size)
> +static int asf_read_language_list(AVFormatContext *s)
> {
> AVIOContext *pb = s->pb;
> ASFContext *asf = s->priv_data;
> @@ -639,7 +639,7 @@ static int asf_read_language_list(AVFormatContext *s,
> int64_t size)
> return 0;
> }
>
> -static int asf_read_metadata(AVFormatContext *s, int64_t size)
> +static int asf_read_metadata(AVFormatContext *s)
> {
> AVIOContext *pb = s->pb;
> ASFContext *asf = s->priv_data;
> @@ -693,7 +693,7 @@ static int asf_read_metadata(AVFormatContext *s, int64_t
> size)
> return 0;
> }
>
> -static int asf_read_marker(AVFormatContext *s, int64_t size)
> +static int asf_read_marker(AVFormatContext *s)
> {
> AVIOContext *pb = s->pb;
> ASFContext *asf = s->priv_data;
> @@ -772,21 +772,21 @@ static int asf_read_header(AVFormatContext *s)
> if (gsize < 24)
> return AVERROR_INVALIDDATA;
> if (!ff_guidcmp(&g, &ff_asf_file_header)) {
> - ret = asf_read_file_properties(s, gsize);
> + ret = asf_read_file_properties(s);
> } else if (!ff_guidcmp(&g, &ff_asf_stream_header)) {
> ret = asf_read_stream_properties(s, gsize);
> } else if (!ff_guidcmp(&g, &ff_asf_comment_header)) {
> - asf_read_content_desc(s, gsize);
> + asf_read_content_desc(s);
This is a test comment.
> } else if (!ff_guidcmp(&g, &ff_asf_language_guid)) {
> - asf_read_language_list(s, gsize);
> + asf_read_language_list(s);
> } else if (!ff_guidcmp(&g, &ff_asf_extended_content_header)) {
> - asf_read_ext_content_desc(s, gsize);
> + asf_read_ext_content_desc(s);
> } else if (!ff_guidcmp(&g, &ff_asf_metadata_header)) {
> - asf_read_metadata(s, gsize);
> + asf_read_metadata(s);
> } else if (!ff_guidcmp(&g, &ff_asf_metadata_library_header)) {
> - asf_read_metadata(s, gsize);
> + asf_read_metadata(s);
> } else if (!ff_guidcmp(&g, &ff_asf_ext_stream_header)) {
> - asf_read_ext_stream_properties(s, gsize);
> + asf_read_ext_stream_properties(s);
>
> // there could be an optional stream properties object to follow
> // if so the next iteration will pick it up
> @@ -796,7 +796,7 @@ static int asf_read_header(AVFormatContext *s)
> avio_skip(pb, 6);
> continue;
> } else if (!ff_guidcmp(&g, &ff_asf_marker_header)) {
> - asf_read_marker(s, gsize);
> + asf_read_marker(s);
> } else if (avio_feof(pb)) {
> return AVERROR_EOF;
> } else {
> --
> gitgitgadget
next prev parent reply other threads:[~2021-12-22 18:16 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 15:13 [PATCH 00/11] libavformat/asf: fix handling of byte array length values ffmpegagent
2021-12-22 15:13 ` [PATCH 01/11] " ffmpegagent
2021-12-22 15:13 ` [PATCH 02/11] libavformat/asfdec: fix get_value return type and add checks for ffmpegagent
2021-12-22 15:13 ` [PATCH 03/11] libavformat/asfdec: fix type of value_len ffmpegagent
2021-12-22 15:13 ` [PATCH 04/11] libavformat/asfdec: fixing get_tag ffmpegagent
2021-12-22 15:13 ` [PATCH 05/11] libavformat/asfdec: implement parsing of GUID values ffmpegagent
2021-12-22 15:13 ` [PATCH 06/11] libavformat/asfdec: remove unused parameters ffmpegagent
2021-12-22 18:16 ` Soft Works [this message]
2021-12-22 15:13 ` [PATCH 07/11] libavformat/asfdec: fix macro definition and use ffmpegagent
2021-12-22 16:23 ` Soft Works
2021-12-22 15:13 ` [PATCH 08/11] libavformat/asfdec: remove variable redefinition in inner scope ffmpegagent
2021-12-22 15:13 ` [PATCH 09/11] libavformat/asfdec: ensure variables are initialized ffmpegagent
2021-12-22 15:13 ` [PATCH 10/11] libavformat/asfdec: fix parameter type in asf_read_stream_propertie() ffmpegagent
2021-12-22 15:13 ` [PATCH 11/11] libavformat/asfdec: fix variable types and add checks for unsupported values ffmpegagent
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 00/11] libavformat/asf: fix handling of byte array length values ffmpegagent
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 01/11] " softworkz
2022-05-07 18:48 ` Michael Niedermayer
2022-05-08 2:27 ` Soft Works
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 02/11] libavformat/asfdec: fix get_value return type and add checks for softworkz
2022-05-07 18:57 ` Michael Niedermayer
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 03/11] libavformat/asfdec: fix type of value_len softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 04/11] libavformat/asfdec: fixing get_tag softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 05/11] libavformat/asfdec: implement parsing of GUID values softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 06/11] libavformat/asfdec: remove unused parameters softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 07/11] libavformat/asfdec: fix macro definition and use softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 08/11] libavformat/asfdec: remove variable redefinition in inner scope softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 09/11] libavformat/asfdec: ensure variables are initialized softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 10/11] libavformat/asfdec: fix parameter type in asf_read_stream_propertie() softworkz
2022-05-07 9:36 ` [FFmpeg-devel] [PATCH v2 11/11] libavformat/asfdec: fix variable types and add checks for unsupported values softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 00/11] libavformat/asf: fix handling of byte array length values ffmpegagent
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 01/11] " softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 02/11] libavformat/asfdec: fix get_value return type and add checks for softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 03/11] libavformat/asfdec: fix type of value_len softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 04/11] libavformat/asfdec: fixing get_tag softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 05/11] libavformat/asfdec: implement parsing of GUID values softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 06/11] libavformat/asfdec: remove unused parameters softworkz
2022-05-08 18:50 ` Michael Niedermayer
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 07/11] libavformat/asfdec: fix macro definition and use softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 08/11] libavformat/asfdec: remove variable redefinition in inner scope softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 09/11] libavformat/asfdec: ensure variables are initialized softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 10/11] libavformat/asfdec: fix parameter type in asf_read_stream_propertie() softworkz
2022-05-08 3:01 ` [FFmpeg-devel] [PATCH v3 11/11] libavformat/asfdec: fix variable types and add checks for unsupported values softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 00/10] libavformat/asf: fix handling of byte array length values ffmpegagent
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 01/10] " softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 02/10] libavformat/asfdec: fix get_value return type and add checks for softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 03/10] libavformat/asfdec: fix type of value_len softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 04/10] libavformat/asfdec: fixing get_tag softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 05/10] libavformat/asfdec: implement parsing of GUID values softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 06/10] libavformat/asfdec: fix macro definition and use softworkz
2022-05-15 18:12 ` Andreas Rheinhardt
2022-05-15 22:51 ` Soft Works
2022-05-16 8:48 ` Andreas Rheinhardt
2022-05-16 22:03 ` Soft Works
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 07/10] libavformat/asfdec: remove variable redefinition in inner scope softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 08/10] libavformat/asfdec: ensure variables are initialized softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 09/10] libavformat/asfdec: fix parameter type in asf_read_stream_propertie() softworkz
2022-05-14 20:55 ` [FFmpeg-devel] [PATCH v4 10/10] libavformat/asfdec: fix variable types and add checks for unsupported values softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 00/10] libavformat/asf: fix handling of byte array length values ffmpegagent
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 01/10] " softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 02/10] libavformat/asfdec: fix get_value return type and add checks for softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 03/10] libavformat/asfdec: fix type of value_len softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 04/10] libavformat/asfdec: fixing get_tag softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 05/10] libavformat/asfdec: implement parsing of GUID values softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 06/10] libavformat/asfdec: avoid clang warnings softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 07/10] libavformat/asfdec: remove variable redefinition in inner scope softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 08/10] libavformat/asfdec: ensure variables are initialized softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 09/10] libavformat/asfdec: fix parameter type in asf_read_stream_propertie() softworkz
2022-05-21 5:21 ` [FFmpeg-devel] [PATCH v5 10/10] libavformat/asfdec: fix variable types and add checks for unsupported values softworkz
-- strict thread matches above, loose matches on Subject: below --
2021-12-22 14:32 [PATCH 00/11] libavformat/asfdec: Fix " ffmpegagent
2021-12-22 14:33 ` [PATCH 06/11] libavformat/asfdec: remove unused parameters ffmpegagent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB036566422FB84E3883F323A3BA7D9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz@hotmail.com \
--cc=ffmpegdev@gitmailbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git