Re: [FFmpeg-devel] Graphprint Patches Reminder #2

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ramiro Polla
> Sent: Dienstag, 27. Mai 2025 03:48
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Graphprint Patches Reminder #2
> 
> Hi,
> 
> On Mon, May 26, 2025 at 9:19 AM softworkz .
> <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> > if there are no objections, I would apply the patches below tomorrow
> evening.
> > Please let me know when you need more time or you have any concerns.
> >
> > Note: The last one has been updated (v4) to always keep .ptx files (as
> requested
> > by Timo Rothenpieler).
> >
> > Thanks
> > sw
> 
> > [2/3] ffbuild: correctly silence and tag new css/html steps
> > [1/5] fftools/makefile: Remove resources from ffprobe
> > [3/5] fftools/ffmpeg: Free print_graph option variables
> > [4/5] fftools/graphprint: Fix memory leaks
> > [5/5] fftools/tf_mermaid: Add missing uninit and fix leaks
> 
> The patches above should be ok to apply.
> 
> I just sent a new patchset to fix things a bit differently from the
> patches below. Could you please test them?
> 
> > [3/3] fftools/resources: add missing extensions to .gitignore
> > [2/5] fftools/resources: Use .SECONDARY in Makefile comment
> > [v4]  ffbuild/commonmak: Fix rebuild check with implicit rule chains
> 
> There are a few more issues from the graphprint code:
> - most (if not all) commented out code (such as code with ////, or
> other parts with simpler // comments) can be removed.

Some are for reconsideration after the initial check-in. There's also
something prepared for when subtitle filtering is introduced.
Some are obsolete, yes. I'll clean that up in a while.


> - graph.css and graph.html are inconsistently indented

graph.html: yes, it saved a lot of file size. Weirdly, the blanks
            didn't get compressed as well as I had expected, so I've
            un-indented most of the tags.
graph.css:  no, that's a common way of indenting css rules.

> - in init_graphprint(), there is a repeated
> strcmp(text_formatter->name, "mermaidhtml").

It favors readability over a mem comparison over 11 bytes.
But yes, maybe there's a better way - will check.

Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".