From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id F1DB14E809
for <ffmpegdev@gitmailbox.com>; Wed, 7 May 2025 23:59:53 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 429E468C037;
Thu, 8 May 2025 02:59:51 +0300 (EEST)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12olkn2076.outbound.protection.outlook.com [40.92.23.76])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E528668BE03
for <ffmpeg-devel@ffmpeg.org>; Thu, 8 May 2025 02:59:43 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=OjeyE8MZCtebBADUa9zqm8+YTHCAgqQ18QbMsNcB3mAaqljTkU3L5AVzJSZWUSD0WIxkU7A5wZjo9tVZ17UlXiMk9iROknc7td2tpS6wsuYO2qdjdT3aEGETYWG3oAyycGU/CJ+5cfF73RkwrXQmN7zFpErcManuUCeAZcScgfk6eoMmeYqi7nnR3hwdFm7xqeKlgUZc1oJ4kmLn+JrF16Gf2d35y3rbRULS0vJ8H0+8Ptn5GHVKHzD39iNtm++dqwd1MmC0LNAGdEiTXb80vxxfkMcUaCZ3fqSMLQAavYj3y2RN5BtItEv/Ti2X5VBHNEnPhrjGxCe4qXZGUVmt3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=0AEp7G4lWz04BO1IBIIDU9MfYI/BOXKOGp4Or1m8RVk=;
b=Mnal0dd5joINxRMQjCpMM5TrqtmfPHm7UlBEcAeZ5gD6cR4bj+RIQc0R2Xgb0hq1kMB0zk7ZjtrkDRpFAZZD82e/LQJLTzI46WSGY6MWFoWkFOgEjigMZ08Yrp88vxKQL0Emy40YK4KnNkn3Vy0+/FERIxRvpKEOY16/ip5Sqm788iGcl6aLsIOaIxiAssYoPwiLUG+44KB9OUABkI+wbHU5ANEI64O4v3VCIM5TdsE/eYTfjJNmE54sJQepDhBDexMpL655+PnXmcyMJ6WprKpqfb9dVngZAhVMK2NfkyNYbUdmYrkuaIzQTQ53hco4yhM1aYkh5AnzUtPQHFD4Fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=0AEp7G4lWz04BO1IBIIDU9MfYI/BOXKOGp4Or1m8RVk=;
b=qryB37DBbCzd3JxNw3X1YFxZIa+jNEdJRS+QLOmZuELAi9jHGwaUwfH7kIfw0otPxHQPaetctPfAqgWjpadOpnQv0WLI0zceK7RMchhZhYqC8a/OjLkoMmdEmReyJwqYjiaU6nv8sdojPxKcOSDC8OXkXwHloEhGJ021PSPmyGnnw0MXTiu5oIepIEIP0i5UBd/vBxaoaHpVsgbLklIe+VI/k6S8VNap7sIv3fxqzsxnkRe9z+pH/dTjUyhui7RUO39SYwYRP0u82MfhETQDu7KkANcRHRtxLs1cpEXGOZipzRkFbQX2BCOaFdyrUTKuVbRYj9p3Sl1XQJ0mhLDZcg==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
SJ0P223MB0565.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:485::14) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8678.37; Wed, 7 May 2025 23:59:40 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8699.019; Wed, 7 May 2025
23:59:40 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: Stefano Sabatini <stefasab@gmail.com>, FFmpeg development discussions and
patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting
and whitespace changes
Thread-Index: AQHbvKBNbOPm2aaw8UO2iXQAV14HLbPH2tIAgAABD0A=
Date: Wed, 7 May 2025 23:59:39 +0000
Message-ID: <DM8P223MB03655C5E0B0F7EED85D2CADEBA88A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.v9.ffstaging.FFmpeg.1746260565.ffmpegagent@gmail.com>
<pull.66.v10.ffstaging.FFmpeg.1746327446.ffmpegagent@gmail.com>
<7e8fddd1b83a4ab9c1330612020f82af9377b6c5.1746327446.git.ffmpegagent@gmail.com>
<aBvweAMgcV4iz0g5@mariano>
In-Reply-To: <aBvweAMgcV4iz0g5@mariano>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0565:EE_
x-ms-office365-filtering-correlation-id: 9ca198a1-83e8-45aa-c91e-08dd8dc33abe
x-ms-exchange-slblob-mailprops: obhAqMD0nT+76ZruCrigLPUIQMEMZUn+QhgPA3y5qpgGv7luVt6ZQLfFyJ1WLlo1cxeCtN1TL+hA5f6N8ahypySvgOXa12DPHRr1i6UtTMhcyCLFmHb5lp6wDyIeKduobK+fUgwTk1+Hgo6SHcFyqJP+m3Z9qFpaVteezMaFZ+Ywo8AhSSeULoxfjEXGeWwcW3BaCLarh+N6XauG2zFti1FpPGjhpkwRFPKjTZT5vq/m1lf3e1H1oQ8VfIi+Dy4R0SM+84Z5rLvGbrf3r2Ht3u5f826+8ehJyGYoPzyNTfnwy7Do+pz26pPrkUT3/sLVskY3597Gdxvh5N2uU7GPrVevkBgJPQ92O18dx/yRGKNwZn2ZsL6SPQil1I8BALtqtDUdRg7yO8xgQ99m4H9KmX77yT3ebVOKePBgBmLfac6ff4JHzEeb94QP8M0TGLBnHCLwdalhso+dfTWGyh8IUtkzE1MmCb0sqvo/u8P83LfE2PFQAQHOq4g2wMdEMjMWXOCwMOKmaMQIaxDhKpVypaF5PCjJq5lqtNJXcTH6gT2wyqDpKZ2EQ89N+HksTAMkukcRQZKo9cSWmh6hT+oF1ineqpCEdFylf2BUzyiAcodNveKjQ4KWMzfJFAZBf8cleWQ8bYmaCR2OhGdJQEqDs/6biFminecAkqg7wK7RmOMj/Jlb0e5nDv3JOlmkFu/qoEaONlKB6w+jcvN7wfO/YPqe4VttD+qHmetFZi5AacmVA/lMJXG9jAysOOCkdglbydajEbqDrbLKJoO3eF9JvnuWmlnHD29S9PHZLK9DPL/D3S47PhEgGKFgFUeH8pDX
x-microsoft-antispam: BCL:0;
ARA:14566002|41001999006|461199028|19110799006|7092599006|8060799009|8062599006|12121999007|15080799009|440099028|3412199025|102099032|10035399007;
x-microsoft-antispam-message-info: =?us-ascii?Q?QCZVuORiWSz/XRvPZKjMyZrX4v1lfiZVeBkaAmHL0JsuZNVvjS/st3JIPaiU?=
=?us-ascii?Q?CnSf+7zwKM2yUE2wpMLo4xM0LGKsVR7OXEZfoNsxzoA6GiMXctI4ji+r3qP3?=
=?us-ascii?Q?F5kuAk36ic8z8shh9KLAf7E3nq7puIMYSsMI/vODAYvvLVUWjFys4j0QsMjI?=
=?us-ascii?Q?8WHsvCLgjYGalX65RGm6U6/kH/Y3x849hYm2yEv8BhVEK4dn6GFF8kCP/kxa?=
=?us-ascii?Q?ypmnjfFuX9M4Ljo2R97wV+vWDK4fM5m6gZx3lujBohva0u4VHnU7ENtAAZqf?=
=?us-ascii?Q?D5hDZOe/UajqaNH7RMNqsBJbJ6sti5NFf4oEdnQ7gAohLnejUh+V8Ed3F/2P?=
=?us-ascii?Q?kmrii3or/cdq24sK32e9zbRXPT+4jpoRBZbM3dJLJKigsLJpdfKyGLbHqfTB?=
=?us-ascii?Q?Lb7GVRppyIvdjH1ckYZpsl5WnMAdrsSBNiS9L0RfaD7hfQh8skMbRF8WL6Pt?=
=?us-ascii?Q?JC7PenOscib469P5n41jOsoWRknjcDAecaFd0QCoo0PuF1hS9+bc9Gnm3ObX?=
=?us-ascii?Q?YnKkKcQV/WsuiufwIT6v59svIsVf4IWmEItwzQSVM1/DsUpYFhaYA3SZdr/R?=
=?us-ascii?Q?vBg4wFNaAajqO4ta9yuW1nxwFeb868YMpajjFRqm2CxGC5Q2vobg+Qb0v2Lp?=
=?us-ascii?Q?r+dUVk2dMGdb86icIavkDIKliMFat/n27aOxy4oNXuEKi5+h9VGUuC0Mi0lZ?=
=?us-ascii?Q?GvwkmUaGYFvSjfXCzPppsm0D5ZTOAWkD6Ht7Xvlu+G8Vyodrx/LMMgjw/060?=
=?us-ascii?Q?MyQCytS4KdJ9NsG9t5F+ezl/hRheh/bpdawMMGOLGVFeOsRp7Z6F8hjOWYS4?=
=?us-ascii?Q?E1a/UyXLlitInlW0+j30+zs/AlJAn3MDATGp7D1ll/qnsfZwzg/xWxde2DCm?=
=?us-ascii?Q?Mg9uLzhuiVw/T+XFTzuuonAPI+spvUYOLA2t6dL0fxtjcNXz0aPWN7vK4ih1?=
=?us-ascii?Q?JIAvXhEfjYqR4O9Y2S21QO72hSTManyLk72MyapWSippU6j13+/z58h/ET9+?=
=?us-ascii?Q?YTcBoE7H70j1NdxK3l0gJ9SDeAJCb072oQTWoVhXQER99YAGkk9ox0wYS8oJ?=
=?us-ascii?Q?xx3lvPQq/zYHR8R3kz+eBM0f/ieAmRc8KVZZjNR01bdpZR7IcglZ6EgkslDe?=
=?us-ascii?Q?5kj1gEabIW5+n6UkNxm2Cw7zzLYgUO266d+BjFzk4KMiPCLEBic5CtK6ygUx?=
=?us-ascii?Q?y4sK2HKaYy4MhEriCMOwd5jljPUO50pwOT798y6fBXTjD302Pvg2NdjvdNA?=
=?us-ascii?Q?=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HmIkvMRH4Z5YVBpC2IAjY8HpGpDkyWHEgyGZpkmX/XCr9eLF8ph+DRoiPEl9?=
=?us-ascii?Q?O4CPfxc8XF6edj3UlQeFxMBQ7Y7XEAUJEEzK2/2+zPlCBA7lghyrmkLuZl4/?=
=?us-ascii?Q?G4A8SXHipAg2A6NleLG9N+qVMJaKvVWZ5hWNH8UCyaNHUszg/YiL4/KxTDRO?=
=?us-ascii?Q?u/kYVCKRyLjYBlIa+3NsbR4zkPDj1ersxSkW6+xf//V+yLVumjwcd52vwmfc?=
=?us-ascii?Q?mlXY12GbhoncA8SPdp97oltnRO0zZ5qN3nesWYQCG9HHCCTvL8bseQgWkddt?=
=?us-ascii?Q?Ee5msPxZHltlz4Mbjbj+mj/jEU4jEIPADhaWiusZJ8z/MANBbYAs83o6pj6J?=
=?us-ascii?Q?5FRsdGez4flM2O+0mpySTPS6p5xpviMpGS83XnKVt+qjXmcgwIeRuko+M2xp?=
=?us-ascii?Q?9okHDhf06kojmA0wkpFH0ZuvlEOuqi8bkv5ZDSlXTWhigxvS1agi791ze0AR?=
=?us-ascii?Q?WG37/nvWG7Swj+yNIUu9vAyZQH++uoBP6w4vXiDVq/YBUPGNrPywP9O9t1zE?=
=?us-ascii?Q?+KJX3OAh7D3+OiqvGlcjb3OnOXtE5/rjAy33ToS2bHiG4gd+KcwNihUKXXvH?=
=?us-ascii?Q?FQqHMF3VwKN67GuGZrNwWuitbCxWbAw6MJRcZ/8ddu1+YIqH7T2yLxvygb4u?=
=?us-ascii?Q?K37Op9HMQpshWXU4PrzgzGiJ4IKKzAUO8T6Cccy8bHrVimp5xDeMQXqATtJL?=
=?us-ascii?Q?OWGzQQ1BB7so0SQCmjOlIQoPvMlHzktdSVsh9oubWxCk80JW9aYMpRgM3L6A?=
=?us-ascii?Q?9Fq1H9PTkfuiLhH+FD0KnJSwcadCFNbzFXroRb8nKo2GljaE+HxAPuorWiYV?=
=?us-ascii?Q?/t/OziQzehMXL3wji0mqN8dZBvddU7TuBNVVkaNHCtXv1q6Xu2iklh03z/9L?=
=?us-ascii?Q?HH5lp+vW6EC0A2SH5GE3VrJ5OIKDb5F2suc+SiLnk2gKzpqdw6/R0HFkwFU8?=
=?us-ascii?Q?Hd9VjMnj/SnVbFXdUsJguoFNbIyl+fUODnE8kHKZVPe3MCCjKtfPS5uDsPbT?=
=?us-ascii?Q?hRAZKU76/5peYJNq9YuV45JPWQbNiskoWR6WN1an4qVLwqvKiJrls4GOHdqG?=
=?us-ascii?Q?ZD/eRJy9rY6tSbSgGMeUhckUd7vS3dvIIPcfDv2vf1CpPOhRDKWN1DS+ijqO?=
=?us-ascii?Q?tLRSZuT0kMBFzPujcUgCbEc/UxowCJSffRLqk+ltB/WvrEufLGSiFCKjQTEe?=
=?us-ascii?Q?Yx0TEDN/b+JO9gnTFw+EA1oaGCRjuF0aHITa7Lt38Lyar0NeUE2n+xpBWs0?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca198a1-83e8-45aa-c91e-08dd8dc33abe
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2025 23:59:40.0002 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0565
Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting
and whitespace changes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03655C5E0B0F7EED85D2CADEBA88A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: Stefano Sabatini <stefasab@gmail.com>
> Sent: Donnerstag, 8. Mai 2025 01:45
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: softworkz <softworkz@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting
> and whitespace changes
>
> On date Sunday 2025-05-04 02:57:12 +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Reviewed-by: Stefano Sabatini <stefasab@gmail.com>
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > fftools/textformat/avtextformat.c | 92 +++++++++++++++---------------
> > fftools/textformat/avtextformat.h | 20 +++----
> > fftools/textformat/avtextwriters.h | 11 ++--
> > fftools/textformat/tf_compact.c | 91 ++++++++++++++++-------------
> > fftools/textformat/tf_default.c | 20 +++----
> > fftools/textformat/tf_flat.c | 26 +++++----
> > fftools/textformat/tf_ini.c | 36 ++++++------
> > fftools/textformat/tf_json.c | 10 ++--
> > fftools/textformat/tf_xml.c | 30 +++++-----
> > 9 files changed, 177 insertions(+), 159 deletions(-)
> >
> [...]
> > - if (show_data_hash) {
> > + if (show_data_hash)
> > if ((ret = av_hash_alloc(&tctx->hash, show_data_hash)) < 0) {
> > if (ret == AVERROR(EINVAL)) {
> > const char *n;
> > @@ -211,7 +211,6 @@ int avtext_context_open(AVTextFormatContext **ptctx,
> const AVTextFormatter *form
> > }
> > return ret;
> > }
> > - }
>
> For the record, I'm a bit against these kind of changes since they do
> not really add to readability and might led to logical issues in case
> an instruction is added to the else block and the parentheses are
> discarded - but not so strongly opposed to block the patch though.
>
> [...]
> > -void avtext_print_section_header(AVTextFormatContext *tctx,
> > - const void *data,
> > - int section_id)
> > +void avtext_print_section_header(AVTextFormatContext *tctx, const void
> *data, int section_id)
> > {
> > tctx->level++;
> > av_assert0(tctx->level < SECTION_MAX_NB_LEVELS);
> > @@ -272,8 +269,9 @@ void avtext_print_section_header(AVTextFormatContext
> *tctx,
>
> > void avtext_print_section_footer(AVTextFormatContext *tctx)
> > {
> > int section_id = tctx->section[tctx->level]->id;
> > - int parent_section_id = tctx->level ?
> > - tctx->section[tctx->level-1]->id : SECTION_ID_NONE;
> > + int parent_section_id = tctx->level
> > + ? tctx->section[tctx->level - 1]->id
> > + : SECTION_ID_NONE;
>
> nit: I prefer the original form (it now looks less readable).
>
> [...]
> > if (section->flags & AV_TEXTFORMAT_SECTION_FLAG_HAS_TYPE) {
> > // add /TYPE to prefix
> > @@ -185,30 +189,33 @@ static void
> compact_print_section_header(AVTextFormatContext *wctx, const void *
> > char c =
> > (*p >= '0' && *p <= '9') ||
> > (*p >= 'a' && *p <= 'z') ||
> > - (*p >= 'A' && *p <= 'Z') ? av_tolower(*p) : '_';
> > + (*p >= 'A' && *p <= 'Z')
> > + ? (char)(char)av_tolower(*p)
> > + : '_';
>
> Ditto.
>
> [...]
>
> Should be good otherwise.
Hi Stefano,
In message "[PATCH] [RFC] global/clang-format: Add .clang-format configuration for consistent formatting" I'm trying to work out a common format that matches the existing code formatting rules.
The patches above are formatted accordingly.
Regarding the first above, FFmpeg rules say:
Don't wrap single-line blocks in braces. Use braces only if there is an accompanying else statement.
(https://ffmpeg.org/developer.html#Code-formatting-conventions)
Now, I'm not sure whether this exactly means "single line" - clang-format only supports "single statement/block", so if it means "single line", it might be difficult to replicate.
Seems, we don't have any rule for ternary operator placement, afaik, the most common rule is to place them at the beginning of lines, but I surely can revert it.
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".