From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 690E5428F0 for ; Sat, 7 May 2022 02:57:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 257D268B373; Sat, 7 May 2022 05:57:36 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2098.outbound.protection.outlook.com [40.92.42.98]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3524F68B1E2 for ; Sat, 7 May 2022 05:57:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOGTKrLOkzo40t5FSLpu/A1tL5fogzzdgEGuQUnNn0yuKdupfHC5vqN0UPHcqBwacUFfVc0cSO/f396+OoY70VuRkovHNe7YWmyu2NqjD3z0Kj73DB6foOnMqvGeRcmBXDm6JfxNRJuvElzJvFCb765/RgDzWssUfHRKss1e/7iZdRpyX74MsnLqFmpSEhgR8xHenkgl0VLJTPa1OiMaLmTpG+HxIssn9VaIffzlU758ucwqQY4HFPqdbDbDgAi5oYRzBSL4XWL9TeS8eumI0Xvz8au786qOt0dhmEUyBpbOixB77H4tkzynyywxId6WxU93W4mL4+ZGKmydi6RedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g7KATOQtuP5aq6E2/MZmGDrzLQ3ypPTbEHKubXUQh7Y=; b=Yw7k2dmerHY0cWSMRQQDIkvsV7zg84ON4VM04XUjEl8NleI9Kk1GbnGltC8/3f5Lv1W3EumUwRC5CfUOFZtcJaq/hX+QPwogU+v7XHzg2fXQdbqQ7WH1Od6G4GEf3nfsiotpEpCs7LLPtQEzZlekLl7J6JSEoZO2xX7c60QTszkAuUzuVXKRi6CCbYbWsBbzaCwbD5iI4VBLylJmNFK7y2RBsoHLDDnlis+DKJEJV+wHwk77FT7fQS3dLU0/dt51VFTTA0R4EBDjO1k13lo0xZw1m3+g/o7u9Qu1wObetSOg6ANqMvw5NfweWnaqRCsRp7Oxrut9tDbc8qjtMh0qxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g7KATOQtuP5aq6E2/MZmGDrzLQ3ypPTbEHKubXUQh7Y=; b=QFpx+z5sMdldcj0qINjD8/vY+8/ee9nCJocNqBHcwOzX2J24Au37SpAniDGQRkmGTDMfN6auxeFdjkFkbaXPFU8UXy8y0cpmc+MQT++8Fczv0Tj7fjN2MIXhT5UNAF1w5ZGJ7lxp8VrRIhf+LU9ItU83TA0IYQ1fYPabMkdoMBdIV+gPO7z5FXgPU6CA91QGFnx4OMUB+G7C/7+yY0VJxoIqUjQxo/ULngmVOrg71ArBloId2bL1/zV/XNM9YZoubqmkupM2RtwYhX3ZWTugHRrafmU/UnwbY374RZzXkwMcp4RjUoweq7kmqHbgr1eBG9MTtwAuX23pzM3vJrDJ+w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0123.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:f2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sat, 7 May 2022 02:57:27 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5227.020; Sat, 7 May 2022 02:57:26 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Thread-Index: AQHYV9QNP/PRify4SkipW5U65/+zkqz/hzrQgADP4ACAAAFRMIAADCEAgAACGVCABt4dAIABGaBQgAhtCoCAABn5QIABMduAgACxSQA= Date: Sat, 7 May 2022 02:57:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [9hrgmAykAAjj2n9mX8FkMLNR350bkBaC] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2d03cc12-5447-46a7-36fd-08da2fd55191 x-ms-traffictypediagnostic: CH0P223MB0123:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KSM+XLxrs0CAJdQ64Vdbh8psZ7frQ0si38gSf39TGGC8bwW3KNEMO1C5mz+MF5ZgB3rpMTcTGxOWOovPvKvlaOnU8x8meti2ge3YF2cD9cYvE6uktvrauSfY3sZI9/j/R8lOjYOZSltdN99l4tfq0IFG4pgTMU20i0mmC/URKVPyE9MRQ+IZ+K26e7JgRjsj08+wtUlmWUw3z1hvOVYo7gtV/xXzKi5IBNcUwMCGOcir1Zm+ie6qp+K0elBugYkeOe9NPZwOdvexqIi6l7y23v4/3DE0nlaPESIjoGJ/kygfEoVPzoOGvkQIqwvZ8LlMhzB30jLrG3NCS/M+n986BXoIjZ4ehWCLPLFI8iC4e+Jth0uhKPf0p82XiOaIEmC1zNF9ITGAS1DzyGQO8c8ovPrKES0PQ/4nNqJUE22KRvWweoJFNDm37xnqHXUOr5WupSy3Z7KdrDgMJOM1EV24WEo4xqayCB4fbPEAtuT1hfBDpwpzDGGyi0RivQwNp6PfT6+vP99QH85gqXMdelmL1aco8buMkVAgrHI6TuSj0u1lhybHJboRXLuRqlE+tPy3jhlxXv7ZK7TprTEP8asWz0CITOPtoL8TFmnaH6Yyr/a8YzBye8UpL9pBPJ435ff5QsqhK9Qr6jdET5VlFumrYKdbZOA9IraQDcfmcvNzr1Y= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cFdKVzIwNk1hTjhxUFUxckFaczVuYStLcHdDVS8zd0NsdktFdHVpdFpXV3Fq?= =?utf-8?B?a3JzWnNnSEJkS25FcFpGR0lFdGhsQ2wwUlo4NlJaWlJyd2lQUk5zVVNnYW5X?= =?utf-8?B?akFqYkR0Q3NxWDJ4ekhneHVidzN3aW5RdWozbHhTOG96UEJ2NGhIMDA1VEo2?= =?utf-8?B?bXVFb29mUVp5MEM5YjRMenZSTHpCdG5IR3dNM21ua1pJWjFVVjlQWWFySFlp?= =?utf-8?B?MDkrSVNnWGRGend4UGNNUllMV0VsWjErR3o4cVBJL1N6aDdSL29zMGZ1QitN?= =?utf-8?B?VThnNEU2NHpsMlljNTA4VzY1UjM5MndNSzQxWlJBNTRYcjlldkVUVFdobUVO?= =?utf-8?B?cnNjVWVrT09KTnl5clhzVFpjcU9qd0V4N0hUMUI4VzVxeGhTL0lMWEo5VUJH?= =?utf-8?B?cDVIYVhvRzJCNDJlc0dMVUhZNmVkN3doTENjVHdqTXV0cXhHUGMrRnB4aWta?= =?utf-8?B?Q25aamlHQVVLY3pQZlZhQjdub3AyT1JFQmx0KzBaYmJMN3puMExNakNJT1M4?= =?utf-8?B?NitsZHV6b3JKMFhwV3dzejU5VFJ3UFA5MENoRjFsQlpoUWEvOGl6OTc5dldk?= =?utf-8?B?Q2EzYXNuUFNhQnhSeVhVakNrR0diY1V4cE1DM09iM1ZwejJQUkdMLzFBOVpD?= =?utf-8?B?OFM2ZkxEVE5DbFg2VTg3K3g5QUxBb2dldzFXSU0wSW52M01IaHhmNUF1bmFp?= =?utf-8?B?Uy9jaXMyNDFVLzlNWHROUnY5dER6a0ZoVlgwK2k4SjdNWDJUMy9DV3JQVnJB?= =?utf-8?B?d0FhZVBIVlJmQnU5L1A3a000WXBPMnIydEpOMCtWNUJHQlhjaU80bGJ4ZG5Q?= =?utf-8?B?eTVKZmNxWDVpWUVaUlNqdUdrZmx4RjBxYS9Wa2psSjlBUTlaczNRUWhLUTc4?= =?utf-8?B?M2N1aU5tbWQvQUc1R1BNQUhrVUNreTF1anc4N05CRzA4TXkvNUFjdkhTZ0t0?= =?utf-8?B?RFIyK3YzdmR6ZzJTeWtnNUVkMU1PTy81cG4zUW1jWVZWRlFqYVF3RHR0VWkx?= =?utf-8?B?ZzRnNGhJakgvbzJwSTRidG9nQjlmWXB0cFhQUEJ3aWhtZzF6NDBxKzBOWkFO?= =?utf-8?B?ajJzNElnak1tTVhHeFBvKzc5OTBSYmZ3N2ZvQjYyQmV6MzdWclNkNmhvckk0?= =?utf-8?B?NXRCaXlRRytzMnY4THc3aDJuZ1lMZEg0QjJMeUV1UUNhZjl4bTQrQlJBRVFz?= =?utf-8?B?UTk3cEVydklOcDdMTkI1dWhRQzgwZjk0SE9VOGJtMGRCbmtic3BaQXZmQnBp?= =?utf-8?B?Nlgyb3dzUDZSaHIvdDhtU25JR09SZC90ZzZGNkg2eERsZHpHTktta2lxbk1T?= =?utf-8?B?bGI4dTZ4SlN5VkdXSHhCOUxrd0k3MzVEMGZjVkRuWUs0c0dFL3dFeFpJTWN3?= =?utf-8?B?SGFWUVpIRGU4VUtwUi85Ulp3eDFoSE92ZHJXbkZBbkc2M2N6cDFxT0J2WnM5?= =?utf-8?B?Q01ic2hrb3h3VG9Vd1JtdVZBQlVNR2pOeU0zSFpScEpnSUs5ek9rY3djNFh6?= =?utf-8?B?aG8zVkVkZGdvODBWL3hIMHhQVlk0bjUrbFUyd2k3U2VDeC8rYXVpT1dLV3Rw?= =?utf-8?B?UlozalVHWnZyMTBla0xtV3RXTDNSS2FOSzE5cXFYay9PemE0STZ1aVpkVTdW?= =?utf-8?B?RnpMT1VWVEg1RE5RSkVvNVdUNGVvS1pJNDUxbms4Uk9QTWtjTnAyRFY3WDVh?= =?utf-8?B?SVNoOER1TTR1ZzFyZTRoQmFmbUc0VHlSTWd2SEJoam1DVVBKYWdCSDh2WTF3?= =?utf-8?B?ZEJpMm9rU1BzRzg3VVJycHIyNGxpbGZYTVE4SXhVL0EyU1RUbFd5bEdCdWR2?= =?utf-8?B?TjZEUi9WNWlPSEtxUmRDbnlRWTNFb09iSGVJLzYrKzFnNHpIN25vZlVvSnJZ?= =?utf-8?B?Yis4Zy9UeVJNR2ZIV05oREk1L2k3bG1mcVNxbEg5bnVFcXMzRk84a3FQSHpL?= =?utf-8?Q?ddk+igZUE54=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2d03cc12-5447-46a7-36fd-08da2fd55191 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 02:57:26.9200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0123 Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of nil- > admirari@mailo.com > Sent: Friday, May 6, 2022 6:08 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and > utf8toansi > > > > As a matter of fact, you are. Your alternative method implies > > > ploughing > > > through hundreds of C files normalising path handling across the > > > entire application, > > > Almost everybody here knows that this isn't true. > > I do not. During the review of just this particular patchset it was > found that FFmpeg > sometimes uses av_fopen_utf8 and sometimes just plain fopen. Plain > fopens > were already replaced with av_fopen_utf8 and then reverted back. > because suddenly it turned out that av_fopen_utf8 is problematic: > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295488.html. Read again. As each lib gets its own copy of file_open.c there's no problem using av_fopen_utf8. The concern in that message was about it being a public API that could be used by external callers. > At least in one place backward slashes are being replaced with forward > slashes, > which is not compatible with \\?\. That's the pending issue with your 4/6 which is probably ok otherwise. > > Why should that be bad news for me? > > Those are three very specific cases and we had already covered this. > > Because none of this is covered. They are covered by my patches, > and you're against merging them. 5/6 + 6/6 are the manifest changes 4/6 see above (forward slash replacement problem) 3/6 is pointless without 5/6 2/6 is pointless without 6/6 1/6 remaining bits can be inlined in 4/6 Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".