From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Nuo Mi <nuomi2021@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] build: fix windows build issue introduced by 45bea45
Date: Thu, 15 May 2025 20:31:36 +0000
Message-ID: <DM8P223MB036556DD0A39F0155F6640CDBA90A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250515124603.42691-1-nuomi2021@gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Nuo Mi
> Sent: Donnerstag, 15. Mai 2025 14:46
> To: ffmpeg-devel@ffmpeg.org
> Cc: Nuo Mi <nuomi2021@gmail.com>
> Subject: [FFmpeg-devel] [PATCH] build: fix windows build issue introduced by
> 45bea45
>
> We defined CR to 2 in libavcodec/vvc/dec.h, but the CR used by
> _IMAGE_ARM64_RUNTIME_FUNCTION_ENTRY winnt.h
> reorder the header will avoid the issue.
> ---
> tests/checkasm/vvc_sao.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/vvc_sao.c b/tests/checkasm/vvc_sao.c
> index 9e6507b2c3..4ad40684fa 100644
> --- a/tests/checkasm/vvc_sao.c
> +++ b/tests/checkasm/vvc_sao.c
> @@ -20,14 +20,13 @@
>
> #include <string.h>
>
> +#include "checkasm.h"
> #include "libavutil/intreadwrite.h"
> #include "libavutil/mem_internal.h"
>
> #include "libavcodec/vvc/dsp.h"
> #include "libavcodec/vvc/ctu.h"
>
> -#include "checkasm.h"
> -
> static const uint32_t pixel_mask[3] = { 0xffffffff, 0x03ff03ff, 0x0fff0fff };
> static const uint32_t sao_size[] = {8, 16, 32, 48, 64, 80, 96, 112, 128};
>
> --
LGTM - at least as an immediate fix for the builds (Zhao's suggestion can
still be considered afterwards, I think)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-15 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:46 Nuo Mi
2025-05-15 17:42 ` Zhao Zhili
2025-05-15 20:31 ` softworkz . [this message]
2025-05-16 12:53 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB036556DD0A39F0155F6640CDBA90A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=nuomi2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git