From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3F954222F for ; Sat, 30 Apr 2022 16:51:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B59E868B270; Sat, 30 Apr 2022 19:51:23 +0300 (EEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2103.outbound.protection.outlook.com [40.92.18.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 166ED68A83B for ; Sat, 30 Apr 2022 19:51:17 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CUp0xWvB30e/M+oGKV5+4oQq0aZiYShVrmUNlSS77PEBNlk1bOWgwWNHXMhStxbvDZFqvvDt27VsXZjh9XHbVZWo0WQJ5ujfR6xRhnYGUnP+ufLiDAqY9FGKfEWEczDlq91TBuPKNVVUPphgxCKnF6Y2vhAC1BPaft7oPqWoXfD7FyKP2AcPOFPHEPR5xzCYanGn4BTKDXSwkWiz9D/54iL0qhYgi1cw99Ms9AR6DcNq5pyknSsBVzl4m0/GMSUm1UuZIV59W828nfyy4YQbsKdNU/naTyiDAh8U3i7HuWXkEXQbiyDHTLPsWpLUO0Alz/HlftLp2nYuLP5aJsS28g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcWxneB2VjISUs5T208OJjlIEuiGVb5slVwBx0eFGTE=; b=RkUoL0My7YqyZZ26nLhGNF6DWJ7oISIL+cHLuN0uB3DZWKPAKT9GoFNf2OTYnoONJuvBpr0ZTTrGdOOYmcAKmkZFO1ygnQn4SgYRJ7B083gaeGhEKZe+9ykIGYYEykc2g7lVI8WbckXwN0oO6LyL+AwzULt7isfdCNlojtQGEekdQ9dH4IStsuLa5k8ALCuuoAk2NCmeQMb3SWyBDedifxhwJlRcXllkli1mXU5YZZd0DSlYIKXyDh3hGs9b/wDROizm/a30+sAWuwKpwsO9kvwhuY05otEDTEW1UIDoVCv05iWttox81qglbCb4dMo5A2wzKEyADvpDFA7MsFLnvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcWxneB2VjISUs5T208OJjlIEuiGVb5slVwBx0eFGTE=; b=SUMM5EI9PU88zppIi3PaYALVA3LBtqaKpx0opAAYQ3W2l3J8WiL2lDM+RJlQxih/4AOsqW/re4+MXpxRcf/rRhl3lk7eUwVp0mjdRmDcE5x6vLaWvpctZH3qz0efUB7P0PnO8IsyyBbgwKXYrj/gudmDOiA/mrLWYW8GMH5VrQuIREDsAPVmDi+dP6ETJOXTjIiwiZ7ljLtNclnh8zE9zgGjZxvVccS/xUyHjz7Y7VKXtl5uHpKSXOBTXVN8EQ0/3xp7NCZZstLlZH/dLj5TCf/W+yL/jGke7d+cwmbRtEpGRcM8bfdkCVUngsfVH1GC/s195MGdCmS5lsshS0fmUg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0060.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sat, 30 Apr 2022 16:51:13 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5206.013; Sat, 30 Apr 2022 16:51:13 +0000 From: Soft Works To: FFmpeg development discussions and patches , "anton@khirnov.net" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSCOoldZr8XAI0qbTqYdIv60xqzhXE0AgAEI6YCAJpQPsA== Date: Sat, 30 Apr 2022 16:51:13 +0000 Message-ID: References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [L8NZsYAP4B7s6fpUfxlWCE0a9vz84rif] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dfe84894-254b-45c2-1c6e-08da2ac9a2b2 x-ms-traffictypediagnostic: CH0P223MB0060:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ddajL+YPe1uYD0Awyw6d2OzeRmVeQLSABx6NofFlbxWqocxANf7LfV2JQ+asCSJ/Jc0Wmyqozu7F/Ks6K6DCYbSzX9KtlZ0DqL8aatbfCM746n1LVfQgsH8ok4vIlAP80AhFCXpjkPDeJqH/tTvF1fhmoo88aLce7w1r/Drhv/MAlj40WvxoZomGBBBQEIHF9f26gukIoDFXIDtcks2dO096Q3wLwEDY1ALGhhY/JNdjx1WDUedzgJuxKUvd5tVQjFlE699nNKlJqmn3LQJw8/YuCEahQAQJAj4GP26oVaQc+K19lg+iqm04Jyr3Zk2HenFzvR4xgeFxKdE0ZifRGWYkuqt2KLyhMnSzVprAr6e9cu6lYL15VrNeGmWQnWWoVf/yUd5IhHF/TRBGj8CQ7bCf6nVcHvTbw6eQbuKC9Sl+rLJQNzYMtzIkpZyK9NIKKKBiImD4ok3/Tq9VphtCetO6mTM5eLwFRz4KIqyV+zDu0aWB4VAyPA8r3DD8U7Vaa8d02Ctvn0/HLzPECuW0sZX5vhicBaY0RD300cOkVLlIoM7r1KMVeztRZtLUpYR9X+7ELpce+vCQFhzoGjZet5QjUkV3fAV8WCgLj98Bse2E1Ss8CqcpcC2tDfi/NG1 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MlpCSVJDc2VRcWwrTmJLcGZjTnN2TlFyQlpEK1VYektwZURrUytDbGpZdzhP?= =?utf-8?B?R3hzdmRuQVV5UUxiWVNmVXN6ZGdheVBGU2YwYXJWb1krekVPZXl2Qnk3UWY1?= =?utf-8?B?OE1XTERSL2RhSTBCV1AwUUdxWVhidFBkM2RTSW9OT3kvem1zdU0wK2NraHpC?= =?utf-8?B?WG1JTzFrU3R4WGZ5TWRDbkk0bVovOWp6SGNoU3ExYTVCdHF0STR6MDRFaG9I?= =?utf-8?B?V1FKbHBtVXF6STgxQVNnazFPMlRhWjVEanF4T2k0UkpIZDZhLzBicHJyWVdU?= =?utf-8?B?OWt4Yk1qYlhZOFBOZmxvZ1JrWXZGVE1STjBSNFExZHRzcDBkR3FQdjI4U0I1?= =?utf-8?B?YkpzRjZYNGpFcjRmVU41bXZRQmpLVS9RZnI1b3hqS1pnMVg2ZkVWdkNtUUNW?= =?utf-8?B?UUVIQ0YxQ0ZtRGJEU1R6QVB6cFF3YnMrR1VjbHh2eHRSRTZlSktIUTYyL3ZI?= =?utf-8?B?ZGZhYVk5WVEzSU81bnNsUEFna3I1S2VnQmdyNVNuTlBlVm5tZ3Rsd1dkU0xL?= =?utf-8?B?NlJWUGpPRVhtbWRURUhtUXZuRys0cjhNNGhXSUFzV1FXUVZpZ3pydmtZR3Ns?= =?utf-8?B?aGZDb0JjbzMrdGVsekM2emxJOFIyZWxaZFYrVXBDUnp6SDVoUjNiTk9pWHhF?= =?utf-8?B?QURwQWhsNEY0ajhocVhIM1dHLzJydTlZUVhsU2w0UXR4Y1ZXUSs4aTRNdlRW?= =?utf-8?B?LzYxVWtEb2h4SmlFcVZubVV6SEFNMU0rd1daUGlEdHRkM2tYSHdvV0R6Y1Nu?= =?utf-8?B?RzN2NjBXTHF5aFFINmsrR0JzVnZjWlVCa0U1dGZNeWZLaGEyRXZTY0VpMEJh?= =?utf-8?B?ZHRFb3VIM3p0bUJnSVBhb2hTTjNWSVB2S0NaVTJyaGlmSkJGZ2ZiMzRuaUxN?= =?utf-8?B?dnd0QU0zdFBnbWtmWEFhb2xvN1J4b0dvS1IrZXZWQm80T0tjNDEwRkU3eHpt?= =?utf-8?B?alFRcWtwU01KekQ4cUlBdjAxMm9RZ2IyUjlDMk1NOVpIUEZweko1RmVZYzBV?= =?utf-8?B?L2YvRUttQXIxVGNDRVdzWVkxR3lDUFFHanJORlN6eWF1blVmMnRJei9mTEZE?= =?utf-8?B?TnRybUQwZVROZVFiUnVUTmVCMDNKYWVKeXZLaVpGMFNqMXFaWGE5TnE0bUQv?= =?utf-8?B?NkpTU1dnNFBBcWMrYmJxWXN2SC9BTkppZnJxVXV1REc5TE9TZFBpSXFqL2FD?= =?utf-8?B?NnU4a3lRT2NTaHVZMUE3c0dDZjVLVXlBcEZXbURCT2dOTEMwaE1NeFp5d0tW?= =?utf-8?B?Nmx6K1g0SFZBMHF1YTl0YkFmZ1RhVmZGT1hHSWpCWnFaVUpTcWIwZnhlL1pi?= =?utf-8?B?WTd5c0dQUHE0L1JvdXhZVG5aQ1IzSi9CWmlSOXdSMmk3NVE5WG1Ncm9pNi8x?= =?utf-8?B?UlRnck01cS8zanpzbGFpZGhqcHluaVJjai9vVUJWaFZBK0tZbjJJUGhURHpn?= =?utf-8?B?TkNKRGFaN1Urdi9aNGw5RzMrSThZRURMQkplV0dIMk5oOW03K1kwRTFkTU10?= =?utf-8?B?cE0yaU9UejdaeFFZOVhyMGFFQnd2aG8weGRmUDF0MU5MRGluYmJ0ZEovdEhw?= =?utf-8?B?SnVwUnp1ekF1aVJWNDgrRXpyMFVpeCtpT0NneUZrZ2xGZXJtVEg5UVNkZlll?= =?utf-8?B?bERUaDF0aEx2SWdYV1l2SXY3R1RjalFrUWVQYWFYeGVOaFZPWGtVbC9teXMx?= =?utf-8?B?ZCtmWkNxNkVhZENpZ1ZQWGl5bjFMS0lFTU55dnZFWC9FZGJSTzIvdlkrbUxh?= =?utf-8?B?U0dDaDlLcEhlZHd6c2lkV0JSbU5iMkNDSTRsWGFpcHFRRmpIeU11Zi8yMmNo?= =?utf-8?B?dTVaeXl4Vkx1Wk8vQ093OHVTN0I1eWFMZENZWlZzZ2xZTzhNMksvKy9XaURU?= =?utf-8?B?SGNFUGhuZFVNUGswcE1MTDZMempkSks5SFA4WEsveFE2WXFKMk5pVDJyY1Ax?= =?utf-8?Q?8gjo1t2qLuI=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: dfe84894-254b-45c2-1c6e-08da2ac9a2b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2022 16:51:13.2408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0060 Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Wednesday, April 6, 2022 5:38 AM > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > code when MFX_VERSION < 2.0 > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > From: Haihao Xiang > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in > > > preparation for oneVPL support > > > > > > [1]: > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > l_media_sdk.html#msdk-full-name-feature-removals > > > [2]: https://github.com/oneapi-src/oneVPL > > > --- > > > libavcodec/qsv.c | 5 +++++ > > > libavfilter/qsvvpp.c | 6 ++++++ > > > libavfilter/qsvvpp.h | 2 ++ > > > 3 files changed, 13 insertions(+) > > > > Why not just remove this completely? > > None of our QSV code does anything with audio. > > It was removed in an older version, however someone objected the > removal of > this. See > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > 4-2-haihao.xiang@intel.com/ I think this was a misunderstanding. I see not objection. One was just asking "why" and the other one had missed the point that audio has never been functional. I agree with Anton that the audio stuff should be removed completely - ideally even beforehand in a separate patch. softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".