From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0C19E4F065 for ; Fri, 16 May 2025 08:26:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 088EB68C8C4; Fri, 16 May 2025 11:26:02 +0300 (EEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2051.outbound.protection.outlook.com [40.92.18.51]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E0F0C68C884 for ; Fri, 16 May 2025 11:25:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HGqwxUHn5YAxhq/N3WR9HeWtjur5jMfQ9vxC2Urz47ApcZE4kw+MLdaU+35b10XN64J6nXsBdbJ2BsXfWzxBlKm1RhjYwBYC8jCQyItWLYzET8w5Q328Ut4TpfiGtAHqAHWcJ/H45Jzuc0flBZZfkH4mmlI7lRnwIzx1DJIicmXwVMY7UJrnkbhIy8ReCFSnV33fEH5m1hmUXBlcuAZSOIK5NrVES++UyTCRnY2zOxsF+JW6Qv3oEo9AM8Kne/HAsHFfH1R46eEqOB/8eknE14aMz0Jfv3oAJVMm6I1Y2NyAm4R4n0Wgozk+DiNcv3fgVm/yG3CJcGylO2vW6MMvhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8JGFy9+c6FHgBPyOC1VXIY2VqKN4biFR/BhhKqHMGNk=; b=Y92sJa3h3KqmMzUQT/REwKDaorJ8p75F9RZN+wOBh6tFYOqYHUNg8324o5Q/lslpQ5qLvfmBzto2HABD278D5ge0mWvAUpglUt9QjeeRKmtt0ArDL4FiQoCFdoPnDsMQFUCiP37TPbxn10Dh8Q7vjaFIi9B4UF08r3XcYVwB7xG01Y/Aijln47WzkNybypdDuiEhkdjHrL8hXAey3VxhcDit72UYILb3hWt7tKTEATGmk9W1sm+sljNJZ9bvrQyq4QJw8x8cKQdG7t1w4nO7f+uaadgVB2R9PVvHSUizXVN7irAyDN+xQ18mwleEpsi3ZAHtPaDxjLQzeJIhyI5CVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JGFy9+c6FHgBPyOC1VXIY2VqKN4biFR/BhhKqHMGNk=; b=Frq2eI/Yn98zHKbhP30V9q6cSEWE0I0GYdPQQKBc5rvEPi/g1ryj7zfPmyYOHgU7QOZjvlFomoJ18vGXTOaxBHiKc/6frUOQtZEknbnKsvgABFt75G+AA6+p4QADmGTS1YC3MBV2ACxOsnKxqkyXdzHh2f7WGyUK3Bmf9edwVxs7Zrg7YHKNh9QfZ9x5fn8ne9423I3WBW8dBn9q01wxrl1FUSsz/70L7hm5p1N/P3kx+4nztidxMJf8GjCmUTvlofuCPz8QjidMx45BbOOAV8/yXzJHy3zRhZ5rSxQOpAacFbEgmCXJeecvkcZUsHThgaGo81DOGabpOQCoI0oGUQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB1037.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:2fa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.32; Fri, 16 May 2025 08:25:51 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8722.031; Fri, 16 May 2025 08:25:51 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! Thread-Index: AQHbxirm507au67TyEiB1J2yca4eyLPU4cSQgAAIYICAAABpkA== Date: Fri, 16 May 2025 08:25:50 +0000 Message-ID: References: <20250515211148.6C91C4128B8@natalya.videolan.org> <3df3113a-203a-11de-6bdb-6a3ed7771c94@martin.st> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB1037:EE_ x-ms-office365-filtering-correlation-id: d39f0f24-873b-4e68-5d89-08dd94534491 x-ms-exchange-slblob-mailprops: cn60g5V53KPw5WU8gd1IqJnxdTHKCVAzlG9Wvmyp7de4aehVXMo8FLMx/ztSb6BAfwMfvl0kiS1lT+r2VxHEAaAMLgYayOmsGdoxYxG4mHuNQ+r+zBhapWlZKyXisHS2rdS5teyu7xg1Od6BFMxJEiSZHH+jDYP6oAf3PfOKVVA3kQ6bIv2SRqEtURF8YobyQwH9utbhZK6kdV+1Qw5uLADKn6f+m1ytrz7naEWHegbRj1B5aNcMfDQqcifqurrr7biEOxBMCy7ToI9d+knUrMGmbRt2qQNFtCjRMCEToXiPJUaFikcuXIrrQbcnKX2DpGiJ4/SR3/wpFv3P8RUvUkYRnAu2dMF7A1fv++0PK6E2EofVxzYWtdALpV9nDvQ7xReqbvWnFWrYs03h1K9w/1LNufZUFq8Lfg3aDNeUxSfQuUIz7tB8Y3zxlRRBe8mUbbEaTy15rPHp4GF8RPDZCyJw+0E92vCihZchgpW3S7VyiA2G2WUK+Ih80YojOGfaOlpCnpXXzH9/8S6sSRcFvhCnlarN0D79TaMmmgb5Ei8RXQ3X6tkAZQWSv4H5FNdtx8+h2+IsPQzxSo14fJgHCxUTPx2nZN9oSKi66kRG+FVdTqClbJDhx8CocYvjsvttI8CNX5jjzwlkIC5ZmkdYHbz05UYFSHCcyMLGMdNHrKO5NZAQBslRI6O2zatHNW0LezflFcI2qzVb7t+lzwZvx0goZBbxb2cJNcz5gjcD8ExdhOCOL5r/k88sBIxDhyOrHnHKm3V4R28sURbjSoBb0fytkLbyuEgLKYGOx91pCDcI4i/Uk9pLFjJ2RIw+rmMxsjBTOGKQSjE+6KfCgYSuleV6E7RAnKX1/VIEWqo2WS47awdMyvD2uQ== x-microsoft-antispam: BCL:0; ARA:14566002|7092599006|19110799006|461199028|8062599006|8060799009|15080799009|440099028|3412199025|102099032|10035399007; x-microsoft-antispam-message-info: =?iso-8859-1?Q?/9sQmZ6dm68N9XNTLdJgqXQJA2rrGoo4hLD2JikO2nIUhoYd1G9HEsZTXy?= =?iso-8859-1?Q?Pp1xk1I2kUlKh+N8F3A2de+vA+vFSyefBEaZLyBeAefhRPV0eFKjrH/EsM?= =?iso-8859-1?Q?hDp72ecsMv9dHZGM0DYwe9bCN6G4ZvOVuj46f+N/66rygdLimgyAPURJ4o?= =?iso-8859-1?Q?h9f0df5XdHS7/L0wB/AvbxpuQPIR8iK9EHcJ8astnDxxgi30e6kqPaQ6S7?= =?iso-8859-1?Q?iXoOcYkaN6GgfQ8a1JD+n4JSqgTLxGWkgblJnOll/bJs+o7LZgRvF7libG?= =?iso-8859-1?Q?gmkcXJ9s3jNb3rUKRUz95mPyFuujZKcbRNMVwhPXY6grHP4tCXDfEj+WHk?= =?iso-8859-1?Q?sYb2HJ/ojIJYZmke6CE0WubpTWhhlw/oh+6oDMRpMFjP9ODEOdGdUVulHQ?= =?iso-8859-1?Q?3ZjOEq0Cl187HJIQPkr6kVDJnK44gBOJ+v2/nDQMix/0pFw/0vhGQSi6EO?= =?iso-8859-1?Q?RadmVfHA8IYgIBXNNSVy/LxinOi0fOYQ1/C4wKsyZ6j8BED4qZGX0oj8tJ?= =?iso-8859-1?Q?E0rCyoeYBnsTE5e7UF9aL4LxAmH8Lw03k07CAQYABfzGNFhKvseTvvgDTx?= =?iso-8859-1?Q?7Shqq8C02dgJPh16QaxL/njz4ZzgVpJVusGIkX48KFJsuhOty3RJo1/6ia?= =?iso-8859-1?Q?pzTFqxVWBm441QRfeMe9IxL0glnLO+VAzZcrBLU8UipOnGqWtKbtKOKi+s?= =?iso-8859-1?Q?GaMZnfI8FjBKCy3RTvjrVbUrxutqG+MU7xitfOUiZX3yfvD/nIAsGW4EDa?= =?iso-8859-1?Q?uQVzuaiRml4oHXI0BdA8pRpQoRuRnbOAbVlDD9+O7H+H2+L7MzpdGMrRNL?= =?iso-8859-1?Q?77WMEuYEOIy0+GyFFVRS7cW4eO1ymVDHtsysK5QuxBBAdO45uWnrN5quWa?= =?iso-8859-1?Q?+vETHdw63/RMkK9jFzv+31vJak0llsPBZDtn94ALmS3t/ADDARqLRu+/ra?= =?iso-8859-1?Q?j42458OE5b+YSPYoF6ejiq9zatbS3MYNnt8xzfH7G6APG/zbD6ovQPhvW3?= =?iso-8859-1?Q?/fKahKJTQGj39YN4gUSI1nl8GB4qY7Sn21mzXTEDIeFQM50vyrt115hxfA?= =?iso-8859-1?Q?Srp6S+eBTeXmfdpiPRlqQhZRW3AA47glVptIGCyTF/SHeaaGjHmzxg00nz?= =?iso-8859-1?Q?JkRhqWPm7JCHuWtffnDSIqtQNwz0BhcVXbynUeuFI2m6lvdeUmuNcVPks6?= =?iso-8859-1?Q?Piri01diQCBIvAzW552H9DAy7R3rislAdwk=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?WHWabtdfU3KpOE36B5xDcqAZ7gcW1M19nKO/wbRHDeAtRXQ6sP/pbKjg6c?= =?iso-8859-1?Q?Bdi28L53Vl+XXF1FZ54MQ5aDblyeuUU37aubj2RnGxylOTqT36Dk5HCRO/?= =?iso-8859-1?Q?C0RcWm8c6zl2rJKszYM161c1ckVFYd6WlmvRDTMgaXk6udYmekXaVsNaUr?= =?iso-8859-1?Q?5SnGghfOkVaiv7DgB+8oZ4rYDnHNul4kOaCNeMd8lXs3pD9/xACJanRrUp?= =?iso-8859-1?Q?cZUQRdPbyO6PUMpWUP6y9SMKBRIAen6xKXr8u1pCfT1K6pZia9OryMtGfI?= =?iso-8859-1?Q?ocWRa2cZvl/2Q3KNiBDECyUwI12lRHZow/hZCC4v6llj3ubUunpl50+NAm?= =?iso-8859-1?Q?QRjRskn6Vi3WJ+q6/BznhK2AfnAcP7ZhNKN/VMbqQFllzl0hUdBlqgfOAi?= =?iso-8859-1?Q?P2bLLbTdm36OBXhbQ4g0jwie41fA69UBs10GwJI5xqayZtsjQGBJvBoeDE?= =?iso-8859-1?Q?gO14ze4xF6Nnf1Bkl/se47Y6gz8RHFvyl8qG0rpLjkf9isEh4NfryHQhjC?= =?iso-8859-1?Q?hbcVmh6qf2GrM/FE5DaAJBd69FPiUNvA70JRMqsykvvkm7hzElNht+1p+0?= =?iso-8859-1?Q?mC9qTK2EobDLIqVQ4bNxkZpx13JQrDgccExO2pUXBfgXAlqzMkLLup8t3o?= =?iso-8859-1?Q?BhT6xWZld0pqpqi21o0rgH+AErm/ZqCH/yTCz7rrDODzIMtbQBAdF3a5F/?= =?iso-8859-1?Q?PJtcrrvJWPqy/IyI2MvW1ZmfO6cPWR2kVCaldFcg8+JrxDZiVDYvEbdN4f?= =?iso-8859-1?Q?QpwcbPzHSmc262qedBDlsAtIprd2f9rLc+7zu+CshFrMo1RO/KaQHAXJjE?= =?iso-8859-1?Q?fSzJl1YAbRwyjHHb5k4w7zMcYwbAzL+rA0J0eRz4KrLLVZLy4pMj27aCCZ?= =?iso-8859-1?Q?ZHzol8f9aEn1FiPBNten7rTvmOSsFR3XNyj9/9cELMKWNk7lO2gv6UchpK?= =?iso-8859-1?Q?LKI2IPN1qSqGka1lnZTp3dlOD9GiB9H89OdMQ3EVFpk9JairxiYUJKlnw1?= =?iso-8859-1?Q?JB+DuubK9w38ROiZ+fNYACt/LQjPHJ2tvyIZkEN0C55csXHm0OJ4ClufQG?= =?iso-8859-1?Q?2uj7Ts7VK5EyGRDILKwCs5xPscNNkGK5YBOZ0xNLU2pJ3jNP4flq5EQDB+?= =?iso-8859-1?Q?/vxGlXhSYr5sPjHmbT4MinGs6zuwy/FUFjVyth+x74Z4GD0+j+pqI0Dlbt?= =?iso-8859-1?Q?/+rLz+uOEgew5DX+8pf2f7KzcaI/f8hqrtFtpsOq1FjRLsP7XSdIbGSJou?= =?iso-8859-1?Q?6HHCYrDiLUtPSgdptzeh3hzzI5imVmgKgs7aWXpP8=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d39f0f24-873b-4e68-5d89-08dd94534491 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2025 08:25:50.9495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB1037 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Martin > Storsj=F6 > Sent: Freitag, 16. Mai 2025 10:19 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make= it a > Killer-Feature! > = > On Fri, 16 May 2025, softworkz . wrote: > = > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Mart= in > >> Storsj=F6 > >> Sent: Freitag, 16. Mai 2025 08:22 > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, m= ake > it a > >> Killer-Feature! > >> > >> On Thu, 15 May 2025, softworkz wrote: > >> > >>> ffmpeg | branch: master | softworkz | Thu May= 15 > >> 23:10:02 2025 +0200| [1f2b8d7238eff4ab8a4d8d6177e250b8180d51f4] | > committer: > >> softworkz > >>> > >>> fftools/graphprint: Now, make it a Killer-Feature! > >>> > >>> remember this: -sg <=3D means Show Graph > >>> > >>> Signed-off-by: softworkz > >>> > >>>> > >> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D1f2b8d7238e= ff4ab8a4d > >> 8d6177e250b8180d51f4 > >>> --- > >> > >> This broke compilation in a number of configurations: > >> > >> Windows UWP/Phone: > >> https://fate.ffmpeg.org/report.cgi?slot=3Darm-msvc2022- > >> winphone&time=3D20250516053009 > >> > >> filelauncher.o : error LNK2019: unresolved external symbol ShellExecut= eA > >> referenced in function ff_open_html_in_browser > >> ffmpeg_g.exe : fatal error LNK1120: 1 unresolved externals > >> > >> iOS: > >> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- > >> ios18&time=3D20250516011754 > >> > >> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: > >> not available on iOS > >> 61 | if (system(cmd) !=3D 0) > >> | ^ > >> > /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/iPhoneOS.plat= form/ > >> Developer/SDKs/iPhoneOS.sdk/usr/include/_stdlib.h:184:6: > >> note: 'system' has been explicitly marked unavailable here > >> 184 | int system(const char *) __DARWIN_ALIAS_C(system); > >> | ^ > >> 1 error generated. > >> > >> tvOS: > >> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- > >> tvos18&time=3D20250516014542 > >> > >> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: > >> not available on tvOS > >> 61 | if (system(cmd) !=3D 0) > >> | ^ > >> > /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/AppleTVOS.pla= tform > >> /Developer/SDKs/AppleTVOS.sdk/usr/include/_stdlib.h:184:6: > >> note: 'system' has been explicitly marked unavailable here > >> 184 | int system(const char *) __DARWIN_ALIAS_C(system); > >> | ^ > >> 1 error generated. > >> > >> // Martin > >> > > > > Hi Martin, > > > > do you think this is a reasonable condition for Apple in configure? > > > > enable browser_launch > > if test -n "$sysroot"; then > > case "$sysroot" in > > */iPhone*.sdk|\ > > */AppleTV*.sdk|\ > > */WatchOS*.sdk|\ > > */BridgeOS*.sdk) > > disable browser_launch > > ;; > > esac > > fi > = > This is not how we normally do it. String matching trying to detect things > is generally brittle. If the problem is that we can't compile a call to > system(), the configure check should try to compile a call to system(), > and if that doesn't succeed, avoid compiling the code that does that. That > also works for e.g. ShellExecuteA. I'm preparing a patch that aims to limit this to Windows, Linux and Mac (regardless of API availability) and I'm not sure how to determine whether = mac or the others above in configure. Is there a better way? > That said, I also agree with everybody else that I'd rather not have > ffmpeg do this at all. This is meant as a quick fix to unbreak the builds, for the final feature = behavior, I'm open to discussion as mentioned. Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".