From: Soft Works <softworkz@hotmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings
Date: Fri, 21 Jan 2022 01:46:49 +0000
Message-ID: <DM8P223MB03655270AF5C9D95DD779433BA5B9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <72c13fff-d78d-b195-96b4-5162b0235a74@gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer
> Sent: Friday, January 21, 2022 2:45 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings
>
>
>
> On 1/20/2022 10:41 PM, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > libavutil/tests/md5: Avoid warnings
> >
> > Those are always showing up on Patchwork when FATE tests are failing,
> > covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-
> 20/softworkz/submit_md5-v2
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> > Range-diff vs v1:
> >
> > 1: 3910d81fa1 ! 1: 4723054463 libavutil/tests/md5: Avoid warnings
> > @@ libavutil/tests/md5.c: int main(void)
> > {
> > uint8_t md5val[16];
> > int i;
> > -+
> > -+#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> > - volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > +- volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > - // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> > -+#else
> > -+ uint8_t in[1000];
> > ++
> > ++#if 1 || defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> > ++ volatile // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > +#endif
> > ++ uint8_t in[1000];
> >
> > for (i = 0; i < 1000; i++)
> > in[i] = i * i;
> >
> >
> > libavutil/tests/md5.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..cca63d6507 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,11 @@ int main(void)
> > {
> > uint8_t md5val[16];
> > int i;
> > - volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > - // FIXME remove volatile once it has been fixed and all fate clients
> are updated
> > +
> > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__
> < 4
>
> 1?
I'm an idiot...
Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-21 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 1:17 [FFmpeg-devel] [PATCH] " softworkz
2022-01-21 1:41 ` [FFmpeg-devel] [PATCH v2] " softworkz
2022-01-21 1:44 ` James Almer
2022-01-21 1:46 ` Soft Works [this message]
2022-01-21 1:48 ` [FFmpeg-devel] [PATCH v3] " softworkz
2022-05-28 15:07 ` [FFmpeg-devel] [PATCH v4] libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings softworkz
2022-06-08 20:26 ` Marton Balint
2022-01-22 23:23 ` [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid warnings Carl Eugen Hoyos
2022-02-03 21:48 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB03655270AF5C9D95DD779433BA5B9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz@hotmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git