From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Kieran Kunhya <kieran618@googlemail.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with increasing buffer size
Date: Sat, 31 May 2025 02:45:54 +0000
Message-ID: <DM8P223MB03655196A211D554EA7B0BFDBA60A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CABGuwEn7CbueFp6pbcELV1GcdnsZuHU1RLJ09mvcWgVe0RNUcQ@mail.gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Kieran
> Kunhya via ffmpeg-devel
> Sent: Samstag, 31. Mai 2025 04:39
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: Kieran Kunhya <kieran618@googlemail.com>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with
> increasing buffer size
>
> >
> > }
> > +
> > + if (strm.avail_out == 0) {
> > + chunk *= 8;
> >
>
>
> *8 seems high
This would use 512kB when 64kB doesn't suffice. We're far away
from 64kB, so it's just hypothetical.
But granted - this happens usually just once during runtime for
a resource and memory is more valuable than the inflate CPU cost,
so I'm inclined to agree.
2* or 4* ?
Regards,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-31 2:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 1:50 [FFmpeg-devel] [PATCH 0/2] fftools/resman: remove redundant includes, use inflate loop ffmpegagent
2025-05-31 1:50 ` [FFmpeg-devel] [PATCH 1/2] fftools/resman: remove unused includes, fix declaration softworkz
2025-05-31 1:50 ` [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with increasing buffer size softworkz
2025-05-31 2:38 ` Kieran Kunhya via ffmpeg-devel
2025-05-31 2:45 ` softworkz . [this message]
2025-05-31 3:57 ` softworkz .
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 0/2] fftools/resman: remove redundant includes, use inflate loop ffmpegagent
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused includes, fix declaration softworkz
2025-06-02 1:28 ` Michael Niedermayer
2025-06-02 1:42 ` softworkz .
2025-06-02 3:28 ` softworkz .
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 2/2] fftools/resman: uncompress to actual-size memory buffers softworkz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB03655196A211D554EA7B0BFDBA60A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=kieran618@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git