From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 23A934C307 for ; Sun, 22 Jun 2025 22:14:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6A66A68E6FE; Mon, 23 Jun 2025 01:14:22 +0300 (EEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2021.outbound.protection.outlook.com [40.92.41.21]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5388568E663 for ; Mon, 23 Jun 2025 01:14:15 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KerK0MVztKXt/U6nXmXWE0n3Z7X3npukYKukqY7RGLIV1TOBrZQRSFpjEqOSRnPrZvnlhef2pyQeXQWeCdA/n591GkLCm9mZX7bDOg0xmxlSuKnjDOKzD1HLgz6biGgTe2fOdhCgsR5w0lOK/GD+FfPp5BozD0i4ywYP/vXx5BA/3tt03Pxb6MPPCdKp5ud5515lxgGWJLLG1FsA50NS3B4/+2T9boaHSqmFbPh6evznBpa5ibBKIY/EhUeyP0/7GKu9zEA6qV/PFlwl1lJu1bTVd+2RCPqh+9ZJRw6evdw3kFx0vpWqzbuHNrJ2NMV3lYN0Arr/qBNTDnTXYyOg/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2poQhv3sd6xek2s8iS5yPsRBymxjF62BvoncbMPaMZA=; b=y/lgQtogUBzqRDG7p7dI+BvVMSb6iupyEpG10m7c18J64eWvBx3ppwa753Bn9NTanSi8hqz7DNWVmoh5MrTne9LS/a11MlN8Pb6m5DTsLW7YKCwIi+i9KwPKCBKGccN4jodMGEWGNkP0ZI0EwxY/UjNLrdENo/TasoQFOVKdd/V9b8DRBNKmK3mgkyXq0I9ghWfJxWMqEDxOBkxZqcwDriSoGgX28JNVbCR18AX99ndEb32Ix1rVQy9/mA1Q+9l+Q+/XhGMGpw1bEN0Mq9zkRJPFUY1mX1wx2aCcSkCCYD/rpTGxAeLCjMNK/mYaNW0okdnZ6L6i8dHc8pQKvYAsOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2poQhv3sd6xek2s8iS5yPsRBymxjF62BvoncbMPaMZA=; b=bQzrN8+Y4VLqDaoh0wYj5HEIYtjqQSh5c53KldgYG5GmWZ4KeZgIz/PkyXjT/Xjo5Aoo/kKlKT/yC6duwQxSw3R2539x7i7jRbJeVXOnUmz6AOJ4CIxjscznxvkgCqhzl30CMY8M8YPbq0dqnqeQvx1oiICErLIzmbhY1QP3kHhN3s/n8qMSDXZ4TBoOXNpFi7GonC0gO4FrdzlAraoO8qPmeD6nP0E8xgOhMYxxrc5tlIAgBd2DVBjBoh7wSRmE82xYnAWW7c3DTVvymn4PD2Ieg47bUphg36aglLhChuK8gdhTphrdgCCjjRwO0r6WQbKoRhAtNM1FJ6miMR+3rg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by LV3P223MB1144.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:1db::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Sun, 22 Jun 2025 22:14:12 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8857.026; Sun, 22 Jun 2025 22:14:12 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers Thread-Index: AQHb4dPI0GddWTAmKUOxlxoceF8yf7QL6ZuAgAPX09A= Date: Sun, 22 Jun 2025 22:14:12 +0000 Message-ID: References: <20250620110853.1448602-1-nicolas.gaullier@cji.paris> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|LV3P223MB1144:EE_ x-ms-office365-filtering-correlation-id: c315870e-9255-400c-b272-08ddb1da1e2e x-microsoft-antispam: BCL:0; ARA:14566002|461199028|19110799006|8062599006|15080799009|8060799009|7092599006|40105399003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?ERRTWoOR6D9hHT1Jw+wDk3nPnPDSotWugD1XLjBjIYce3vAS99HQOhZ/JZ1/?= =?us-ascii?Q?QI7CGI2hQv3kzJTeEKn+zoJT6e5ZYViTbrf/jc8OPBwz1av4lzwdsyL4WOLI?= =?us-ascii?Q?MuMX12Vl1BxuLzV7D7MnYF9/zuD0Z8M0KnHsNT8Tl1Mlm/PelsuHrv5L2uhC?= =?us-ascii?Q?cQer4YP7Rdw/Sb46bP9c7Gjtv5V5RE9MATobpwdJWyomHD7/ulorEI7FDXnp?= =?us-ascii?Q?mFGD0HOpSFMBzKWXmKzTNekYVW2RL1jCHeKRUyAwVfDnqfp2jgkJyaN0+nW0?= =?us-ascii?Q?N41m9KH6W8s/7WRWhrr+rgx7kxpVqbQviiTJUO94Y+PbE498Sy80WujEA/JY?= =?us-ascii?Q?ylHS/97Vb2EE55mYys8Q7o1v+FzoEbmZu2c2ZcN1zbCbUn4RtXIqvZRzkN+y?= =?us-ascii?Q?/e5Ue332l4Wzo8rGhuBaxNK9YERxGWiVET8BC/9UQ3gg416P4lYuDmynfAvb?= =?us-ascii?Q?WBAN/rtcCV/vL8zs1AJ86GOCyMO5qb9VZDZX2D1FPVd5LGnoBtifS2CRJab5?= =?us-ascii?Q?N04IGwAtOPTYdm7vARyNahTty9gXF2HqdJ/RQSO7dwt2krKAGFI8/JDFV1A9?= =?us-ascii?Q?Xs+fuJsnNdDtFUkcGgWd9SPnqrFEi8PzgmrqrCgeDLtTfgxmPB511+IPipPk?= =?us-ascii?Q?zcJBPdjPhmJg5b5bJuvbh+4oWGhK9R98wZPrjfJL9p5mdBgEUbRvl26soJu3?= =?us-ascii?Q?T0H04+IyaPBu0v1VmM/VcZrUcnVhh3HOu0wi1fDjD5sEXdQ4iswLfC2KuzOM?= =?us-ascii?Q?34rmcnMsGANXxx6Kcj5KW491kloIjTPel76/E58HANNQIMzA87tgl6JMbfuR?= =?us-ascii?Q?3x5UXrpu/Qf4joEvudOwDZLnyk0yHDpp7tgRC6gXBKDhWHYaJOtahiHnBP4h?= =?us-ascii?Q?5yj2DeO+rffTdRhXTENr3Lmji1fOfkAzaZmKgjXgGvbKAgaFTtq9gk/WI53p?= =?us-ascii?Q?8zCCzJfo84Rx3j67CJ9PfP7ItXD7OcyyKBoLwSh0IeAKQ9szxrL4XdagOWHz?= =?us-ascii?Q?uTKI8lJrsAV44LiMdZcOhtgluwJDQ+j8GQc3oqjsZUVGLNX9F0JaSXTE/Phi?= =?us-ascii?Q?EUVJkbNQnsKgdjUeC26Ca8bMHeOxj6YtoR9mnWDt9O0hg/+D3aVqP4g0O999?= =?us-ascii?Q?fnHW3sYtBdfg7Vfw+XfbP/7sSIgsw1qmYw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WBCveCe+26uIlb6518AGL70U5Kq9Gbmpq3a4cJiFsWlFQTzvMbb8nL9BlZun?= =?us-ascii?Q?bGpj8j2sUkHVs8oR9/tMQn2AW60CjjiNp10qNtVqiQtZ/CrIb2AfC9NxNOHO?= =?us-ascii?Q?pg763iapmO7+hIIQjalvo3hH+ItXh1PHCvS6QWrOQhjmIbdRNdFBOiVlm9FW?= =?us-ascii?Q?pUY2KQUwYYiEMDzdnV+5cwmkLUBsLqrJ73xAt7Pdh/hMG+D2XUfsBN/RPgSM?= =?us-ascii?Q?nwnt1Rau5YCemP8nqrIol+or/h2cYkQVne4zbUYrXjYclqTXPZ+DyNUno/AA?= =?us-ascii?Q?0pSgZMSxn4pSJ6kZkN8tWVNhfeazjP3kt3cxsu4sk63SGoScyiUhFZQlHron?= =?us-ascii?Q?xAEUFqxjDlBg1BMxc6XX4etMWcTzqjlA0eoJKBI3TwObLb4AWD+yGuUtRnNf?= =?us-ascii?Q?qw7bStvCd/WXMSANxp1Yo+nSI7M52YPq8B/HYG6spdQANK0cnYnkMFpImT+5?= =?us-ascii?Q?EAj6Ivop0VxPmYL6+4uZ41/bgl+lb7VrP3JTEfrPQDu6y84Se23wpC1XPYaf?= =?us-ascii?Q?7HVEfXcXuuyupyByPRAcasNbbQG1uYmoi3bfZQYYcgYAq1D0/zLWhZ+iBBB/?= =?us-ascii?Q?fgAjqURvajfFkiGzM8IoX2MO640iirY4e4Ni5I6riZkZsHNS114/5qx2XbM3?= =?us-ascii?Q?04v1QLigXU7u9EYtUR0VqTNZTi3cD7JW3o1aYzwUh1xlNN0RFYaNO8QhKrsK?= =?us-ascii?Q?4VO0bRBGi7qEIMyQ8iOhox8O4qt8znUkKh/BJRFLckegXcQrNpYoAlemc9xy?= =?us-ascii?Q?4e1L4hqLsQwRGyIXCOULxdCKeiFzYhNa4z/iti0yLjE3wjRkGjhxV5mWtO2Y?= =?us-ascii?Q?EgqmycLsMc39LnsLXZxNG98NcAqzEA9FBJcQpF5qQpaLmH+JF2P9+Evi4iF7?= =?us-ascii?Q?LBhcHFBZhRrxsa/s5Sb6cdggwi2FS0yqdakxMfNqjkkiECuX6mVVtYa6nVmj?= =?us-ascii?Q?Tqhd/ipIpdTps5ZyG0Ij1WD7wj9+Wt580L1gWkAbWLFsTbpbERz4jXNaW3fa?= =?us-ascii?Q?yB2ARSKeZsecUFAGUJHB/KaB5v2mQRzltJBM2//T8kbnl9BMkzrZNN1eTAzn?= =?us-ascii?Q?WVVAiWQMqzC0MKmppDX1gPted/KR0lNzvOmrAmEnk5+Lyor/Mytc/PsvKm//?= =?us-ascii?Q?BxUjFX5NX45IJgD8irH2jB2AaKVrANfpwHSIT/ZUqLUgNAsv9UZAwfAYDf0d?= =?us-ascii?Q?89aS16pK9JLQVNpkOblxsMFLEh6iWZnFixrkDjbpBTy2qAlM8hb7Ep6Wb4E?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c315870e-9255-400c-b272-08ddb1da1e2e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2025 22:14:12.3783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3P223MB1144 Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nicolas Gaullier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Marvin > Scholz > Sent: Freitag, 20. Juni 2025 13:30 > To: FFmpeg development discussions and patches > Cc: Nicolas Gaullier > Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 > bit integers > > > > On 20 Jun 2025, at 13:07, Nicolas Gaullier wrote: > > > Regression in ffprobe since textformat introduction > > in d7a3f68feae0b1c3718f9d2671c6d41c60a40680. > > > > Fixes #11638 > > > > Signed-off-by: Nicolas Gaullier > > --- > > fftools/textformat/avtextformat.c | 2 +- > > fftools/textformat/avtextformat.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fftools/textformat/avtextformat.c > b/fftools/textformat/avtextformat.c > > index 14779e6f0c..14bad9022b 100644 > > --- a/fftools/textformat/avtextformat.c > > +++ b/fftools/textformat/avtextformat.c > > @@ -437,7 +437,7 @@ static char *value_string(const > AVTextFormatContext *tctx, char *buf, int buf_si > > } > > > > > > -void avtext_print_unit_int(AVTextFormatContext *tctx, const char > *key, int value, const char *unit) > > +void avtext_print_unit_int(AVTextFormatContext *tctx, const char > *key, int64_t value, const char *unit) > > { > > char val_str[128]; > > struct unit_value uv; > > diff --git a/fftools/textformat/avtextformat.h > b/fftools/textformat/avtextformat.h > > index cf23d93871..8316829af5 100644 > > --- a/fftools/textformat/avtextformat.h > > +++ b/fftools/textformat/avtextformat.h > > @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext > *tctx, const char *key, int64_t va > > > > int avtext_print_string(AVTextFormatContext *tctx, const char *key, > const char *val, int flags); > > > > -void avtext_print_unit_int(AVTextFormatContext *tctx, const char > *key, int value, const char *unit); > > +void avtext_print_unit_int(AVTextFormatContext *tctx, const char > *key, int64_t value, const char *unit); > > > > void avtext_print_rational(AVTextFormatContext *tctx, const char > *key, AVRational q, char sep); > > > > -- > > 2.47.2 > > > > Looks good. > > Would it be possible to add a test for this to make sure we catch such > a regression next time? > > (I can also give it a try if you don't want to) Hi Marvin and Nicolas, tests are always good. In this case though, I'm wondering whether it might be better to cleanup and straighten the APIs and implementations first. (look at the value_string() function to see what I mean). Best regards, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".