From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 285844D03D for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 23:01:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E14AB687DC8; Wed, 16 Apr 2025 02:01:23 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2103.outbound.protection.outlook.com [40.92.22.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C3404687CB5 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 02:01:17 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nS+f6rS9FL19bxroQAPSpTEeEggbJ/yzjBPH4PMPxnzvxI9nkyiPP65Dt5uLR5croMp9GySrXysZW4rn8lKlI0ZEdJG2OdrRpuf0J8XmwzSMe4a4UJgn7Zl0lZ3DSdLbkfd3oD8aONAnpIVU+jYjiJNUMDYqMhRuxJ2IdppSHcFQP9b76oAKlt3zSUIClcr65bws06RDZz6rCNTfJrz9Fr6nSvFcYHRMF7UXxcjDK3KMCCYazQP4/oePLthTYFrgrBBpP5QJBT13XdK5XDSTUZ1bl6L7q76VS8cp2XrVCfn0iCKXeCZR4yeUNmwTvaWJ1A1EZWlADxblmn5olvwQMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LXVHMMcsqQ/5y/CcROhUJ6EmFMTn9CxW3c1kDGb3ss=; b=C18v9rCBa0GfgEJ7bmwBAcBKThxqyxvL1VWYd+jP8mwxsGm8XJpLPtCVN1d0sKS/sX+7EFGNNIJs6zBwP/7Mx+vC7oLv/fnUfJbex2zzu6d2X1teNhpCPH7/ZCYGSJJWJHVsG7ceVuY8TNANfCowNLAg8jVGIOU6v88o1vpdyRMLPvzRfyiT/2y67rJl/9Wv2ditM3p2A4AZ+Olo9Q0zEYpaslx/oTdxu+DcsYl5v5puAnaL591XflnacEx1kM5Il+5Qw9qn8nZTGYPlVk2LSAS9w+DX8mgXUv9g72H7UoM1m6YachaK78jj8RlofZahPiHmbutmRCWq3s88Ma3Z1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LXVHMMcsqQ/5y/CcROhUJ6EmFMTn9CxW3c1kDGb3ss=; b=lAgaEAzLlxrajlbdGkqQZXOrkhW1JewAo87ppotPBrT/23k2Ac0n5sjE8xFXK1MSzA1k5a/gr6ezE+GRdhUBvQFegoDu1cW/EuI7yUr9H0WH8JcemlhdsT8QEC2lJcdjKE1PKO/7iRF9W8OkMsocfVOMtflWXQfVzE3V5avW/TS7i4+6h6B8R4Sk+uvxvHlst/OFPMu2PbIOGhTmOCmxa+1temirt3XILGJiK5NNvtyGEN00qfh/kbRSXoAOgWgcY9sK8F+l7MB2nL1tZfKTiM/uIXQgAyEXPEApWXItBRHzWwiATAat6FRb1cX9l3dM/HELPyh8H3zhnt1+ME6FlQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by IA4P223MB1835.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:562::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 15 Apr 2025 23:01:14 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Tue, 15 Apr 2025 23:01:14 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAAAZwAIABQhQAgAAFo+CAADvZgIAAAb7QgAABGqA= Date: Tue, 15 Apr 2025 23:01:14 +0000 Message-ID: <DM8P223MB03654DFB8790C225AC03A3F8BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB0365928500AB53069869DC99BAB32@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415185538.GR4991@pb2> <DM8P223MB0365E10D38EF9174A32557DFBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415225001.GW4991@pb2> <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> In-Reply-To: <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA4P223MB1835:EE_ x-ms-office365-filtering-correlation-id: 98037e8b-ac5f-4353-3f57-08dd7c716c54 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|8062599003|8060799006|19110799003|15080799006|7092599003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?C7PzapQK73pPCzUdvAAG1yUenaNM/2CMTU32/ruvs+d8XhR/otVBdEerOY8R?= =?us-ascii?Q?uHAmbIZsI1/8jdZMg0W1zUxn/vp1c5W2QQZjCN+Q2juenI2CRwB9ENUuQuxt?= =?us-ascii?Q?wb2jLvWd9dZySgzhsN2znvL2vSsI0SlzhgTpUjAviq86GWTilOHeqnhXO+1O?= =?us-ascii?Q?4CT6O6H2QzOh358FtR7V9+CBiathGtAwA5xVwuevXyaaj0tsoiptFtBQEDCc?= =?us-ascii?Q?aOAeJ1Iaq7OgR5ubNb8AG0nGzHTzIc8D60hyp1qAj8T+mHDYav9SCwq0qzWt?= =?us-ascii?Q?eXPkSY734xPx/oKSzNcdGwfvXV3Kekb3aAIqSkLfBUUm/NZrmmpGe1lNYew9?= =?us-ascii?Q?nZYGg0bOVhxekILNXzSSZodJj/YHYJoZItEVzd/zTPslZgMjfAD/gpb2yCj3?= =?us-ascii?Q?Y0AGQuT/lRXCmX4vU0xen5C8cK2ttPT4QNTzeqZFhOPWIc2EFCK4vkcKcGko?= =?us-ascii?Q?OnobsgWyXVWc4C0XZpSJj8BhBZdacdIgTfvmV5mV/xM7eg/1f8ySZcvZo5ba?= =?us-ascii?Q?PX+kqKHUTa3h9zk2Tq53MCuQm244NkpY7EnKD4dmD2UieBsj7nFRlrUzDpDm?= =?us-ascii?Q?Nc/P8uf5NsRXkqGT1NK5U2RwKzQq0kyErwRZMb6x30HaTnG0nBCJD5y5tj9p?= =?us-ascii?Q?LCBwKtNRs7XkSXqJ+n8lIHCYD5ja6rcr/uYFOBZCIhN6cLtz9QNAv6L3d80s?= =?us-ascii?Q?G/f+dMcuHAIqlFNN65IRzvJPWELdiVLjSCzCqwLjnaEUFipsX/0RTWFnD2W7?= =?us-ascii?Q?r2iHxbTZsyFK00FSAWxHAPVEeBjTtQTrOsx1NjHznyfmGeyBiy347h5XlXfd?= =?us-ascii?Q?YFCgRf06kdZ9jv3KcO/cEMzkrk2n3gxsy9mfAYqaE2z4Gl95GKO6QMStRDpW?= =?us-ascii?Q?rJ9ak0ZFV08DeP0yCTPimWbxpGWsLPog2C0napyuY+qZmLj7fmOosgTdgpMf?= =?us-ascii?Q?2ib/PSBmXRQJ0JZ4ML2SsVC69o5BfanF3jvMrhRBIuwrUZT25K4+porWnT9u?= =?us-ascii?Q?eLfk2E8Xei7oNieDb9hEy4RKtYHQAOSwTHCQIVngJpDkVv1nGiI3eeT2yhzG?= =?us-ascii?Q?XZaZyJtyghcFE6sj9gap/X7vqHyQW45SSSNqVp1Z+D91lBEVQyY=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DKMwwBm/yQRxLPrAQpg8DLlxSaos0Tede9OCT1YnRZYCHCLqcElIFWEBOFim?= =?us-ascii?Q?/q69zl3/+ePePP8q5KuQeAt/3RuM4ERN3cxLZN6O2xlV5wv4BOeTvdyUv9rI?= =?us-ascii?Q?iTuc98P+0e91tFi0HijmyxO5U3wD1Wr+C8SIik9+9VEKsbieoh5Y4LMfLd1B?= =?us-ascii?Q?b1Qx5OEC16126uj9W12lqc4kqwwGUJi8zgN2xocGK5sLfEqW9t+x6YCRcdHg?= =?us-ascii?Q?+Vt5KKDpFO24cgbkj1okzO4TS1aKPf1eHpMvU4aeKHeuZbn7CisOCIV6ln+5?= =?us-ascii?Q?MJBcbSz2VF2LBBN4ax0V4K/hBROmN4TPxmORo94qagLdI/7Ezvi8EFsLeCu4?= =?us-ascii?Q?h9/l+jI33IEuFkyBxxVxy67AV1fz3Oau/urZaYiC07mTu+BdPE8tzqgX3KVA?= =?us-ascii?Q?tDPQSuxi5SDkFgsJ+3hSgoLWfwpHHW6Cx329lonlnxrZlbvOwHCelBHpZ5+T?= =?us-ascii?Q?VNgqK8DQxtkEL1VGBxLVFeXQYri++UV+QjFpce+q/V02FxT3Ug55gQ27vAt5?= =?us-ascii?Q?ky6+RAhws15Q78ECuQle5tv+HOa8LGx1zniRIddBW9FpsWHNgzNCbXQSKOhi?= =?us-ascii?Q?jcOmIgA5XjuWF1sLaNU/vtvVPC7p0AcAYNb28osV8kPbyMq1GiQUNef2+FJE?= =?us-ascii?Q?GSmun+x8qSVJsjAA24YEX4kGNfIkl2bU0VdgnEfiM/vofYul9XIYuKifrHVe?= =?us-ascii?Q?ncWWiBMu4SWXVRBYRaqvquXqvl5w4/NgGiWh5KwCDKqhQ1mCyMb+S575hVRw?= =?us-ascii?Q?q9+J3S8LbSqLMGWKR7b0BZSY9FeUA5nyJ4Qq9xzHYMuvBKSTjDy0fE4OisuD?= =?us-ascii?Q?QujEaUcEwfvpB+HE2EXTiRN/QzasdST1U+5/3MbSJaHe+BzxPBB1lHe9IK32?= =?us-ascii?Q?xY6dPdpHQ8vC7uWe6c2ocpkADu3NYWh010Pn0KUs2XLCEWk3J4LNUvs0SAqe?= =?us-ascii?Q?y8wAAR4wnMRMHq6YQd68W7dnjsSlmAN/yzYIxvmKxU4LwFkOewQyKJ/VAQi1?= =?us-ascii?Q?TM1HRZMjm02+r2RC0TChy6+x/ZLydynXlhP7w9HPYIRqC/Yv7hB7TTI+vUFD?= =?us-ascii?Q?9Wjt3/pVlQieQwPTELUzN7P3SZEHJ0nmQFj2C6U6qqQgs1gEH8oeWABwEuwy?= =?us-ascii?Q?a9J0Disc0frNGUGYR9uxUxc+d50kC+obEaqdnsEfbT9RkWu2cuK8I+nkFcua?= =?us-ascii?Q?YTQk4KsHjNMFNkZYsOu9AZ+FvVEriR5w0P+JI4vLxEZv4svEZRXz8hQdaVo?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 98037e8b-ac5f-4353-3f57-08dd7c716c54 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2025 23:01:14.6707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4P223MB1835 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03654DFB8790C225AC03A3F8BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > softworkz . > Sent: Mittwoch, 16. April 2025 00:59 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > > Michael Niedermayer > > Sent: Mittwoch, 16. April 2025 00:50 > > To: FFmpeg development discussions and patches <ffmpeg- > > devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > > decode_str() did advance > > > > On Tue, Apr 15, 2025 at 07:59:00PM +0000, softworkz . wrote: > > [...] > > > > > - The representation of multi-values - both, internally and when > > > outputting as probe data - is a de-facto standard > > > > The external handling in formats is specified in the corresponing > > specifications. ";" is certainly not correct for formats which > > natively support multiple values per key. > > > > Internally, if you have a data structure that represents multiple > > authors, you certainly do not set it to one author and a string > > with a bunch of semicolons seperating multiple authors > > > > Title: "Smile ;)" > > Author "Smily Face ;)" > > > > is not 2 Titles and not 2 Authors and software that cannot handle > that > > should not be used as reference IMHO > > > > That said, anything that works is fine with me, > > > > But internally it will be better to use a representation that is > > universal, generic and simple, ";" may seem to be that but only > > as long as you do nothing with it and dont care about corner cases > > > > Ill leave this ";" question to everyone else, i have a backlog > > of quite a few things i need to work on > > This is not a great outcome, because "leaving everyone else" means > nothing will happen. > > At least revert the rcombs patch until there's a conclusion, because > it really makes things worse than better with regards to FFprobe > output. > This will cause deserialization errors for many people in the world > who are processing FFprobe data. > Besides, the patch had been submitted 3 years ago, there hasn't been any review and the merge was totally unexpected. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".