From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 87D7B4D87B for <ffmpegdev@gitmailbox.com>; Sun, 20 Apr 2025 21:23:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22D02687B45; Mon, 21 Apr 2025 00:23:20 +0300 (EEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2010.outbound.protection.outlook.com [40.92.21.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 048E1687B45 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 00:23:12 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OFcBDIBypXVyOc+VO4FX3F3Gti5XBQc348xGTJZtVcReO5jsFTy6mTzuYzXucp8HFUwtevRERhjTSfVb4WAifbzMjZlvqFqp+IjKrUpwdMAui1Vi+uo8F2wUf0AZyBw4T4m24lF2YxwX+F2ztOwIVZEG7t7CdSYgDoA0f2+FQPLm/JAjYD9On05eNcQPwB3ccKHoay7Prh83Z+T1v51Fg13VIfRVxO94wp70X7CbO4HiA2jMy1wc4SqJ4Z38rUXujkSatuboNh/sLSjNOgYO/oHgpow2jP1GSHnMjDOII/Sc2j61jSWeUuqno1cU83mRUZPOiwAWCJwuQkdnP2GBug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qq1+AXgyoAxqHoCm7g5VfWywfihOVxCYsXhVS+MI8Po=; b=CI3xPGZiY43U4ofudmhZcPMhvpqZb2s/MjcK6ejjQHOZjJejCVXh6vM1L+Yk2yZpxU1VgusZYhFgPuRPWp37sxo+QdS/kGLQ1bI4JfAeOQ6xCaqfhMoWMRUh39z3S0gN+dFAWtLGm+Lo4rAb1Sf2IsezkMOf58j4OnJnIsRQN5VNE5J7yQR8PDb/aGl5AzbLUgOuFkyBLPyJ4lqvtBonWh8LzRhk6l2XJut9y5hCm2p1zilv/c3dfCpHwH93uEoxvFNJ5xXg5B1YdllvHH1O99AcvtTg5vYFFXcYdnce/uzpYdBuc0Dr/zaTVSC9g4aNaGkELEWmTpss7ksdvOLjwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qq1+AXgyoAxqHoCm7g5VfWywfihOVxCYsXhVS+MI8Po=; b=GmjAABI69157+kfwUbfw8Q+dPZVi754+MOyu0RsVHj3CsG1T8IxvdsIwkkgxPSfy8VhL+6T0ETvrolQbeGj/vbAyKsGGqiA0XVOQzdA3lMpOafvO7m6PbIQ3DAOZu+vIZa2DewH3B0W++FuqEDtNvPRiTJMBxPRhezw7/rbgRFejaSDhLENmBXKiwvkQGSS5+PZAdM66KJ2R7i3Bb8JTmbdlNEankkVPYHTKneyt7gljoZjI9o7rOTNJQAHqQAUw1/mi2yhjfgEaaj5z6fmJ+g59kEZx11MyvW8CKShWMaLwR9XHlz9QgsCoEZrBUBTN31HYfEnn7L4s9H98jX0G7Q== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by PH7P223MB1016.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:300::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.31; Sun, 20 Apr 2025 21:23:09 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.033; Sun, 20 Apr 2025 21:23:09 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit Thread-Index: AQHbsXq6tt6/GXQsREG8BiQqC0qR1rOtCUQAgAABaPA= Date: Sun, 20 Apr 2025 21:23:08 +0000 Message-ID: <DM8P223MB03654BB0C9E7B3D167B2DFA4BAB92@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.69.ffstaging.FFmpeg.1745101853603.ffmpegagent@gmail.com> <cfb2d90e-b912-d2b6-d716-ebd2afa61bcb@passwd.hu> In-Reply-To: <cfb2d90e-b912-d2b6-d716-ebd2afa61bcb@passwd.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB1016:EE_ x-ms-office365-filtering-correlation-id: 0a7b549e-64e8-4cf1-81bd-08dd80518c3c x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8060799006|7092599003|461199028|15080799006|8062599003|102099032|3412199025|440099028; x-microsoft-antispam-message-info: =?us-ascii?Q?c/C0pxPkLzIKHZrD5kx637TtdlcgXcom7JcbNZo9wjxKpb8arHXNvM6oDBwi?= =?us-ascii?Q?pqSOZ0lBGd67r0ycELYHxvxapZKwyAr/f1mrnYKNWlNLzfu4YePp43R/rMhY?= =?us-ascii?Q?83kUOqFwr9QmceIIGgiii1hkuck7aQISqfa+K8e750gHZ8IXenyKits1XSBR?= =?us-ascii?Q?mcLfyERog/fNxPHrxcO4MnSxGJJdsqYjXHgSBRkgtoyenorvIKXh0OLtm38g?= =?us-ascii?Q?MWt08DwAKzo/Ab4gya02Rqmdkfo37F1qwYP/el5Gi65qyYCfwXgXB7atbUek?= =?us-ascii?Q?0b2qUiu9BsaWJrH1diO9n4NL4zxFRffPXldPAdR0Rt+k5izayL8QUKBL+iMG?= =?us-ascii?Q?E5ZU4phGAf8RVlGppSZxi+gJJ4q07M1drM5NWlnjGnnsNfjMbqsGU/mkyDfw?= =?us-ascii?Q?M6ZVTMbd24qsGLNvQwKg6JB45IRHgn3uLuoYbl1pxMhzRFuCIpx2I6EOmbx2?= =?us-ascii?Q?rUFcm1RAotyEYVG/8htT5l3b8IgcrXmYLOTN8iKeg5ALudAaVmr6UJ8wwm4f?= =?us-ascii?Q?bPbdBxG1s+AwvCU4INhqY7HizuHp32yodT7Cbf984jjf4xbIJdV4F/mj8Jsw?= =?us-ascii?Q?0mVma44e5V/MaGwNz8Ju+d2xYaet98mNGTkPvf58PWfJ7FmgH22P+rGrOAhl?= =?us-ascii?Q?ufStrHlMYWrkqliuucr78ngotx/vK/ZQrCM0YFRmBRiOTFEDutoaA1jfc7Hg?= =?us-ascii?Q?CrbIcbjd5vhselkMmEucx/lgPgi/vV5HHhGrBp3ASr//4rT5s8hfE5eWW019?= =?us-ascii?Q?8FlI2Wa/pgZuVIG6Bx3qlaBNuzl+zjCr7rwYY/s8EYyIOXTWyvwnmgnWxVI8?= =?us-ascii?Q?BW3zhjdeUKqtq0+Rz9tsH5cGp+1ubmo72na6jvT+1xgC2Y9jtDcIHOeEeo3G?= =?us-ascii?Q?PebGqGiqXTC41NrWcAdT3Z5dZ4HqdEwzFcUHMmtUFwTJ1A8cLliVoZgWApUV?= =?us-ascii?Q?sQEUCTdBaIoJA61o+EDT5b0IJQHjldlmfAKturrcdqfF7jLlJM/Fu6gaBIph?= =?us-ascii?Q?apTo2PUbn85SPGGzgnUSnGk2VZVUpuvSm45fZ+lRIcc5dIv+jxRRcck9UOKq?= =?us-ascii?Q?1CbYF9rTxPTCbNv/zfpwQAyHusaHbC35iR2UpgOmLxs3yrWPVoY=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GMfvxBfPXUCzMtvQglrzl0hnz7aClZGmiJGJf6YYXLsDKi2hQUbhv25w1v6r?= =?us-ascii?Q?eB+5wWRdkU6qecdAvE5DE3o+NLvsPzRhszwb5cIF6dzOdZRI5l31fBDIvjH/?= =?us-ascii?Q?oj1AsoXOyXerv71A5Rn9TfqVdDyiX/v/3U2NxbMd3ppt48viwirCFesjBV+I?= =?us-ascii?Q?8s/M3tarGlWXcCQbBTV6EXKGsA1FRZBBNelOgDkCDx+s2aQdahhGew4FOkdt?= =?us-ascii?Q?CnersFDaNVkriXmviryzqC5POtyZW1RmeFwow4gMnb+Ubcr7uxNF59EQIL8f?= =?us-ascii?Q?lz6yw+SvSdaa1vN4qYQ7e2bC9sVcW7Ea+jv1rYL5M0KZlvEyxTubD6RQVuSo?= =?us-ascii?Q?Dl3W0ISavaPQjZCarbz/athswbRziRjPaavJpD2A8ypZ2U+ZtpBT3wXC/fSR?= =?us-ascii?Q?QlBPqryzS/sZNpWFcBcapGWwsZQF6vlsutIvzPCR8zASdDcU609x9X6h25hp?= =?us-ascii?Q?uKbuM7qwRck6LQbQQKVru7hqxmV4uejcrc8hTxkXvw8Yzh5RMZUTPAs8hs1K?= =?us-ascii?Q?/7jwrm3Tpjil4z5mIA4NBzsHDSm0uZJ5gGH3LIEVSPhVow7TlZRlqgqitH78?= =?us-ascii?Q?tuaZoEULStkcCjW/+fHGORTDcf63k77GS3eYRjL3nr5AWT7jZOGPY8xSc+1w?= =?us-ascii?Q?0MKW2bPdpSD3Yvq9gQkxbaQRg5j6eMY/B9KsiAFZBg70bNjpBzWwuLBv8oAG?= =?us-ascii?Q?DE9ApcUV4R2ZT9LhzGCSjcZEEHUdsVa8A6qG1U/+B9nDFIIjoc6l/kEduNQ2?= =?us-ascii?Q?UTu/nZT+kX9vR0FOXmJJDaltRHF57dnGLMNFHAlz4/Coj9HhNryK2Q88QFr8?= =?us-ascii?Q?YstkJKFLChIzosofBaDgq8wTeyLkpUb6s//euhUOx8zL316Tf/T4UBI9oEvp?= =?us-ascii?Q?+cc6corhpmrIL337DjvVjj9DYapW/LxJD4IfjOyepNjJtq/LelHqGDuKPd0C?= =?us-ascii?Q?/9J2f9FCnJN2fUk6T5BnwqJwM5H44Bxkm2kTlInMbNsjKamfcvN9nN6iWyD0?= =?us-ascii?Q?p+T0FpJlAQolBR65PwPPewjGgD27pIk1IwXKvq8uZfPdICAdD3G3/ILxm776?= =?us-ascii?Q?sW4TcpdT3DrvJT6nPx/I0aJtkFclMaGkKYtthCp77ifibKsoiUo1ApbELhhK?= =?us-ascii?Q?Zzwrh4CNDMFzz3pTU80BjnDk8I1Cj01gjZPLVFvh0st5rewxtwNyAVURMIwb?= =?us-ascii?Q?kPxKYqHS4SMNs0Qc/8VKwwROJJ7HIthFTCDgORzxLlVmZ/dN8AOXgMm5V7A?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7b549e-64e8-4cf1-81bd-08dd80518c3c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2025 21:23:08.9375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB1016 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03654BB0C9E7B3D167B2DFA4BAB92@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Marton Balint > Sent: Sonntag, 20. April 2025 22:52 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit > > > > On Sat, 19 Apr 2025, softworkz wrote: > > > From: softworkz <softworkz@hotmail.com> > > > > When viewing logs, there are situations where it is not entirely > > clear whether ffmpeg CLI has exited gracefully. The two primary > cases > > are > > > > - A crash/segfault has occured > > Windows for example doesn't output any message to the calling shell > > - The process has been terminated (e.g. killed externally) > > Relying on logs alone and not checking the exit code is a bad > practice, so > I am not super convinced this feature is worth having. Hi Marton, two examples: - When a user sends you a lot, they don't know the exit code and it's tedious to explain how to acquire it - also given that it's a rather small number of cases where you'd be interested in it. That's why you practically don't do this. - From practical experience, even though we do check exit codes and record them in the application log, it's still at an inconvenient place. For example, when a user sends 5 ffmpeg logs and the application log, I'd need to look up the exit codes for each log file in the application log - which you rarely do practically for the same reason as in the previous point Over time, I have built some extensive tooling around FFmpeg log file analysis plus a range of FFmpeg changes to make it more efficient. I'm upstreaming a number of those changes that have proven to be valuable over time for the benefit of the community. If nobody finds it useful, it's fine - I don't need them to be in FFmpeg. > > Printing "EXIT" on exit provides a reliable indication that the > > process has exited normally. > > Something like this should not be visible on the default loglevel. So > the > loglevel should be reduced to verbose or debug. > > And if we print out something, then let's make it more useful and > readable, e.g.: > > av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d.\n", ret); I agree that this is even better. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".