Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marton Balint
> Sent: Sonntag, 20. April 2025 22:52
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit
> 
> 
> 
> On Sat, 19 Apr 2025, softworkz wrote:
> 
> > From: softworkz <softworkz@hotmail.com>
> >
> > When viewing logs, there are situations where it is not entirely
> > clear whether ffmpeg CLI has exited gracefully. The two primary
> cases
> > are
> >
> > - A crash/segfault has occured
> >  Windows for example doesn't output any message to the calling shell
> > - The process has been terminated (e.g. killed externally)
> 
> Relying on logs alone and not checking the exit code is a bad
> practice, so
> I am not super convinced this feature is worth having.

Hi Marton,

two examples:

- When a user sends you a lot, they don't know the exit code and 
  it's tedious to explain how to acquire it - also given that it's
  a rather small number of cases where you'd be interested in it.
  That's why you practically don't do this.

- From practical experience, even though we do check exit codes
  and record them in the application log, it's still at an 
  inconvenient place. For example, when a user sends 5 ffmpeg 
  logs and the application log, I'd need to look up the exit codes
  for each log file in the application log - which you rarely do
  practically for the same reason as in the previous point

Over time, I have built some extensive tooling around FFmpeg log
file analysis plus a range of FFmpeg changes to make it more 
efficient. I'm upstreaming a number of those changes that have 
proven to be valuable over time for the benefit of the 
community. If nobody finds it useful, it's fine - I don't need 
them to be in FFmpeg.


> > Printing "EXIT" on exit provides a reliable indication that the
> > process has exited normally.
> 
> Something like this should not be visible on the default loglevel. So
> the
> loglevel should be reduced to verbose or debug.
> 
> And if we print out something, then let's make it more useful and
> readable, e.g.:
> 
> av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d.\n", ret);

I agree that this is even better.

Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".