From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ABC72405BC for ; Sun, 26 Jun 2022 16:27:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9024E68B7A2; Sun, 26 Jun 2022 19:27:10 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2060.outbound.protection.outlook.com [40.92.19.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34F5968B787 for ; Sun, 26 Jun 2022 19:27:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReX7t25fqAzcjmN4h0S/le4LoEwOJQpM0hNe5Fr9/3+BdMcknAdnrYD6ar1cGtnj2pbFIQXqz5h+gAXxi7ZambobgYNR0xZh1PDxtuhI4zU+zDelfiYjyEi9s7zrwk01FLrAnZDvBysYZvjDT1UnxML+2mS/1MppyjmwPfR/Y0ECkpNgapkxsr/rVtKwnhskm9FYiHsipcrJvmeWebrgoWCBSmRWhvz60HiDWnyPccTTt+rVNDD/vW/Gdqv2LkATud9lsrWH45hGcYT2vuhyLEIPQC5p0kodfhwyHcMv8tDc2wTOEiUAZdIMDSeUdRjS9crLH4pYqMauiiI3fjMedw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GqsougZv66GfCXF1rPC26gSONIxHK8Jemu9ksezNnLY=; b=gQITsv6i3g2AD2K7BbkZo6NPuMFzTvzYmfjXeO6eZJjr2wkrZmDAihL9f9Jv8RG+9fc39Uw3jWzWAao6LixCV0/c9cqBasBTq5bqKpDdm6m9jy0fZU0aeF3ULAnV90Ix7gXBJmNrXndLaR5hy3UxL3Spwt/RMsmGM9aIexWfDLR3n7/LiYPBK6jCATfN7vQ2ORt+uUO+f/0JQSPDpr6DFW9/qEzF6NijL2rxuk1t9wbRq9HcbZEjWa5YORYX/LVJG+qSx8acYyMbth3rOUBEuwefZxDN7Yn7LrOW7YnwC574aTkzrWJPDVIAYSjspgSe9JOW72RQqXyZDve3woAJ/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GqsougZv66GfCXF1rPC26gSONIxHK8Jemu9ksezNnLY=; b=lc3fRXb1Qb1NyvN/ekfJRB/1oiudHR4Ax00yLfFIc+MDs1VgGdN8pcjUOHSycBO4RLXDCJsEuv1a/ih8iRbk/yuVQ+OhcFyWSfesjZs1JW567aWs8ynN5ssYgGwXlOscEhCrg/abW2nUId8GWGabWS5Uqc8uK3M2Zp8QqrMUxR1CJhtKQrKStUsqimWhHeawFJ3QVBscH4U7Dl3XrirUMiXdx3V8iCHe5YJeoiQUatckLva4NnCizBQk5Rw1xniQjuuSORtFFhduHjIpCVA+sOCW9Lgf4L9m0IG3tATM+CImMiFuiORoi92jSR1hAxi0zCqU/uyp1UBHgE5rR/TZuw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0281.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Sun, 26 Jun 2022 16:27:00 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231%2]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 16:27:00 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding Thread-Index: AQHYiHomQ19hwERBuUa+wwaKzgqqH61f/jYAgAACDQCAAAwPhoAACd+AgAHJrpA= Date: Sun, 26 Jun 2022 16:27:00 +0000 Message-ID: References: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> <20220625113452.GR396728@pb2> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [b1EiMNmz6B1MkbzF0StrnZ4g4NJIg31M] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff2edc27-eb90-417d-cdc8-08da5790b27c x-ms-traffictypediagnostic: CH0P223MB0281:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N4bFloDc8rlKl8q+osPNYn5lVZeGQDn6FTSrQ2mO0CwmIDMo/wXWiOTQCaEWQ9746j2Ted9QQm4xIfzgjNUc33mfBl9VUssTo+UZqj5djxnd+dGzaJz1nDBl0mZ4yY9QCo40I2kTesEP7NYyx18DBqzXjTIAnznVtnLY5j/oNBPZDCliOAOgyA/kjwUfZ07N4XZ0uz+ERL1netpE9cUKAYE2mc5lvRpxC+NZnKzLUcg6GHbC7UtH/LQXhXt0cgYIa7hI9164e6SQe/s3wRyUtR9k+1t+Jshqu//hrRxG1cV2MHjq0yllf9LdDGiGWD8BRVIcJcnqRg+Wa0+QC4/fwVdFZl10e908sOlEYvjX6heQggZlJvKrgZ3PRLypcexsurlfWa/3dD09zHYebeMtLoomEJHfLsqfLTtXFNK56h0p6UKIv/B74foXnq5kxgL3FiNsqpN3/YKnWLev21KshDVCTfsSB7L3FVZOeXbEO5/Y68f8p3QYUTkTjy6zL3rtkoOffhzA+el+YpDupE8PV4EP5CqiV4p1WxzH5KUg52q0NVZi7JEHw/k66TD88gaPpyuKpJzdzBhNmyqdHa3SMfu4XViXfLffluw0aIE3z0EES30ydJ/SopYLVW9JVvJa x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K3hZdkdKTnpwNktGa2hpcXdIcHF3WGMvenI3K09JSFBtc2JQQ09aUSt3bUg3?= =?utf-8?B?ZUdIQ0p6WHhKbGErSzJ1TWtuVERHS1NqY3ArbE4rVk8xcGcydG1XQlpid0lQ?= =?utf-8?B?WnlPNmRvMFU4Qi9NUmExaXVUOGJoU3BOeWlhL1hDRFkyNVFCZkpQSXQ4UzFR?= =?utf-8?B?MEo1Q0lROHJMZld1TFlKTXd5dGxvakVXOGRzdW9hYTczSGllbDZRbFBRcm9Q?= =?utf-8?B?a05pR3lhamRuazZlRWd5NWRyYmNhWTJwOTNTcDlDYml2TTcxYURMMzFGTWRn?= =?utf-8?B?UmhraXoyZWZpU1ZHb3dkM3hEd0R6VXdaNlRQdE1OSFp3WmtOdkYyVW5rTTJ5?= =?utf-8?B?VGJSOVpZWm1WZ2RvbWw2NG1EWFlJeUU1VE1ZbjhMMUx6K085MkdKK1lRVEhL?= =?utf-8?B?aWNEVWhhV1AzaU9PRFJid0ptK0Yrd3NjZG0xa05mZDMycVY5ZGVXNlRYbmlz?= =?utf-8?B?K21GdW52aEE1SG9OOXZxTFg4SXFLQ3c4RytvTlJ4akdYVnM0aGVYWm5TOExG?= =?utf-8?B?SjhaTGVLeGQza1pZK0llVVI0Y1dZYkpZV2d6eTBVT05iOHVOWk9QUDZZd0RT?= =?utf-8?B?M2VaWFNKZC9aZ2hyVG0yTnZDQ3hManUyclNLZS9xa20vN1FyUy9lQloxZFND?= =?utf-8?B?a2gvdm0vRmZVUzVpNS9YOHB4b0pHc2JadUthcXhUZXA3eTFaTVdFMGlIcHdR?= =?utf-8?B?WDVoM2ZMWHFzaEFrUGplUHl1VEJLZjVjSk5RZmVvTVgxQnZjUVhsTFRXcFpX?= =?utf-8?B?RmlBbnl0TWliUWgrSGpTbTJjVVZuK1Fka1ovd3FZOVFPVm9PNVJZL2EvUmZJ?= =?utf-8?B?cE1RT0VtRXFqeitvd3FmRmN5NnBUcldxVzZnaDFYRFJKbkpaR05WNmNyT0F6?= =?utf-8?B?cHpuS2E0ZzN3eVNPMHpxeUE2Ty9CNWh5QW85L1QvTTZHbFo3RXVEc1J5TXI0?= =?utf-8?B?eUx1aGkvSElBaC9YNk1jV3U4dk4zLzY2N1VpaWJmcDRPdDNoTG1COUwrTkJh?= =?utf-8?B?c0VlOVRBdU1PQVRrL3dhU3JJN3d1QTVoZ0EvbWQ4MVpzRzR3b2VHcEp1TmRP?= =?utf-8?B?QllNMGVSVFNpak9hcEViS2JCUU5CRE0wd2U4enduR3N2M2dsOUk5Q1hXckov?= =?utf-8?B?NDVsN2JVbThHbnBwdUxpN3BRUE5SYkQ3R3J4ZE9za0JUbEdxeUN0dzhiYkpr?= =?utf-8?B?aUx1L0JyeE54WG5aeUl0L0ZtY3psRUEzVGVYQVNIenBXUExOTmVUeUxlSzc4?= =?utf-8?B?ZkNrcFpxWEFOT0orb0NqYURma1FyeGx6MnFuV2NXZnhQa1Rpd09ESGdtQ2o2?= =?utf-8?B?YUdsRFVmbkRKblRHcFZzUjNHTjBmQ0lleUExY3htRHVCYThnd1ZTRTUwMWN1?= =?utf-8?B?VTVOY2tPdTRFNFN2eWpvY1FBZnZXbXFsaUxzcC9XSXk3NExOVXRUVk9kSmw0?= =?utf-8?B?dG5lZmNpdWo2RWdzbUZ4WTVkK0xjZWprL0pUem81ZTJCRkpIVCttQW1GVElt?= =?utf-8?B?Sm50bEU1QjdzZzg3UU1JaFZVTlBGTkpyMzJGbVhJRlRKMndackZOYU9hR0Fj?= =?utf-8?B?ODRvcHFtY1dNTXhBeVpxKzdybW1BV1NPRnYzUW1vK0ZKMGV6WVVFcTNmbmxP?= =?utf-8?B?aEFqR1BDZk5iTk9YVWdIRGF2UnVvcklsVzZianNNUXlLS3A1RTc0Y1NTb056?= =?utf-8?B?d0NDUGwyVXoyZjRqekEyTWJ3eE1mWE93Wjdrb1djcHBCQjNpWC94bjVnPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: ff2edc27-eb90-417d-cdc8-08da5790b27c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2022 16:27:00.7308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0281 Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, June 25, 2022 3:01 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: > Introduce subtitle filtering and new frame-based subtitle encoding > > Soft Works: > > > > > > ________________________________________ > > From: ffmpeg-devel on behalf of > Andreas Rheinhardt > > Sent: Saturday, June 25, 2022 1:42 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: > Introduce subtitle filtering and new frame-based subtitle encoding > > > > Michael Niedermayer: > >> On Sat, Jun 25, 2022 at 09:57:56AM +0000, softworkz wrote: > >>> From: softworkz > >>> > >>> This commit actually enables subtitle filtering in ffmpeg by > >>> sending and receiving subtitle frames to and from a filtergraph. > >>> > >>> The heartbeat functionality from the previous sub2video > implementation > >>> is removed and now provided by the 'subfeed' filter. > >>> The other part of sub2video functionality is retained by > >>> auto-insertion of the new graphicsub2video filter. > >>> > >>> Justification for changed test refs: > >>> > >>> - sub2video > >>> The previous results were incorrect. The command line for this > test > >>> specifies -r 5 (5 frames per second), which is now fulfilled by > the > >>> additional frames in the reference output. > >>> Example: The first subtitle time is 499000, the second is > 15355000, > >>> which means 0.5s and 15.35s with a difference of 14.85s. > >>> 15s * 5fps = 75 frames and that's now the exact number of video > >>> frames between these two subtitle events. > >>> > >>> - sub2video_basic > >>> The previous results had some incorrect output because multiple > >>> frames had the same dts > >>> The non-empty content frames are visually identical, the > different > >>> CRC is due to the different blending algorithm that is being > used. > >>> > >>> - sub2video_time_limited > >>> Subtitle frames are emitted to the filter graphs at a 5 fps > rate > >>> by default. The time limit for this test is 15s * 5fps = 75 > frames > >>> which matches the count in the new ref. > >>> > >>> - sub-dvb > >>> Running ffprobe -show_frames on the source file shows that > there > >>> are 7 subtitle frames with 0 rects in the source at the start > >>> and 2 at the end. This translates to the 14 and 4 additional > >>> entries in the new test results. > >>> > >>> - filter-overlay-dvdsub-2397 > >>> Overlay results have slightly different CRCs due to different > >>> blending implementation > >>> > >>> - sub-scc > >>> The first entry is no longer in the output because it is before > >>> the actual start time and the strim filter removes such entries > >>> now (like for video and audio) > >>> > >>> Signed-off-by: softworkz > >>> --- > >>> fftools/ffmpeg.c | 613 +++++----- > >>> fftools/ffmpeg.h | 17 +- > >>> fftools/ffmpeg_filter.c | 270 +++-- > >>> fftools/ffmpeg_hw.c | 2 +- > >>> fftools/ffmpeg_opt.c | 28 +- > >>> tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- > >>> tests/ref/fate/sub-dvb | 162 +-- > >>> tests/ref/fate/sub-scc | 1 - > >>> tests/ref/fate/sub2video | 1091 > +++++++++++++++++- > >>> tests/ref/fate/sub2video_basic | 1238 > +++++++++++++++++++-- > >>> tests/ref/fate/sub2video_time_limited | 78 +- > >>> 11 files changed, 3010 insertions(+), 672 deletions(-) > >> > >> seems to break fate > >> > >> Input #0, ass, from 'fate-suite//sub/1ededcbd7b.ass': > >> Duration: N/A, bitrate: N/A > >> Stream #0:0: Subtitle: ass > >> Codec AVOption threads (set the number of threads) specified for > input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for > any stream. The most likely reason is either wrong type (e.g. a video > option with no video streams) or that it is a private option of some > decoder which was not actually used for any stream. > >> Codec AVOption thread_type (select multithreading type) specified > for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used > for any stream. The most likely reason is either wrong type (e.g. a > video option with no video streams) or that it is a private option of > some decoder which was not actually used for any stream. > >> Stream mapping: > >> Stream #0:0 -> #0:0 (ass (ssa) -> ass (ssa)) > >> cur_dts is invalid st:0 (0) [init:0 i_done:0 finish:0] (this is > harmless if it occurs once at the start per stream) > >> subtitle input filter: decoding size 1280x720 > >> [out_0_0 @ 0x557cab64bbc0] Subtitle format change from 1 to 3 > >> Assertion c > 0 failed at libavutil/mathematics.c:61 > > > > That's an av_assert2-assert. softworkz probably didn't test these. > > > > > > Yup. To be honest, I wasn't even aware that I'm supposed to. It > seems patchwork doesn't do either? > > > > Do I need a different configure or make fate? > > > > The supported way to set it is to pass --assert-level=2 to configure. > (You can also modify config.h by adding "#define ASSERT_LEVEL 2"; if > you > have not used assert-level during configure, you should have no > ASSERT_LEVEL in config.h, but better check this.) Both ways working fine, thanks a lot for the explanation. @Michael - thanks for testing locally. I was able to identify the issue which came from adding the new strim filter. Update is on the way. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".