Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format

From: Soft Works <softworkz@hotmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format
Date: Sat, 26 Nov 2022 00:58:15 +0000
Message-ID: <DM8P223MB0365434073BA6ADD61869C69BA119@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <fd5d1e88-0ca8-19c3-cb75-748127111048@gmail.com>

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> James Almer
> Sent: Saturday, November 26, 2022 12:58 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support
> P010 format
> 
> On 11/25/2022 8:51 PM, Soft Works wrote:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> >> James Almer
> >> Sent: Saturday, November 26, 2022 12:35 AM
> >> To: ffmpeg-devel@ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't
> support
> >> P010 format
> >>
> >> On 11/25/2022 8:26 PM, Dong, Ruijing wrote:
> >>> [AMD Official Use Only - General]
> >>>
> >>> Will it make sense to accept P010 input, however encode to h264
> >> 8bit?
> >>
> >> If it works (the encoder accepts the 10 bit input even if it
> encodes
> >> it
> >> as 8bit), then i don't see why not. I assume it would also be
> faster
> >> than using swscale to convert said 10bit input to nv12 before
> passing
> >> that to the encoder.
> >>
> >> Removing support for a pixel format as input in an encoder needs a
> >> reason other than "It's rarely used", more so when it's a single
> >> line.
> >> It either needs to not work, or somehow get in the way of further
> >> improvements.
> >
> > Oh sorry, I noticed that there was a misunderstanding.
> >
> > When I said "It's rarely used", I didn't mean that as a
> justification
> > for the removal, it was meant as an explanation why none of the
> > hwaccels has implemented it.
> >
> > softworkz
> 
> Alright, then i'll repeat my question: Does it work?

No.

> If it does
> not,
> then that should have been mentioned in the patch as the reason why
> this
> is being done.

For me it was clear, albeit a bit short. Anyway, I'll let Haihao, respond.

Best,
softworkz 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".