From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 591E84D696
for <ffmpegdev@gitmailbox.com>; Fri, 18 Apr 2025 05:41:53 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A505687DB2;
Fri, 18 Apr 2025 08:41:46 +0300 (EEST)
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam04olkn2093.outbound.protection.outlook.com [40.92.46.93])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 417AA687BE4
for <ffmpeg-devel@ffmpeg.org>; Fri, 18 Apr 2025 08:41:39 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=OqtJ5zR27/OzKavcf01gWm3vB9L2NeDVmokf1TOfTi3ILRjPTiFh0rxNXKdIA9rWzuA+wp7PDWzJfmwJmJSdk2RhH6Li7l2ZKfn1zdn3R000NXGjNegx2S6WKWK5NIvIdBS8zOvEOM6obWMsGbAtvEmY+rU6F9gZ/7O3XEwe7ihiNahUaJJOaNTZCrbmjhxrg113SDBG9pA4spicyBW4e6Lth6Z9cc1uGSZ8J3oRhR9J85adnecQEN2mq5WbA6X6iZJlowu+ZwmfIEuZnFwmHUFRf8/3gonwMUGYay89vkFUchT2qec3G2m64vENgtooo9lVZnDyCO8KxPHQgY7Drw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=Y9gzbDjkvTZ+vgA4DYetbhrsKRRB+FA9CpdA0qe6J48=;
b=c1Am86fY09fGKD4vAz7tO1XajqCbshpnNEyQ2ZfFALASsQqSLQpH1Ax/Demo3SjenhLHJSSmD9mRlg+k2i+mhGF2pWsgLz4B6D/zAImj3DTB2WIyLLbXzD//vqtWFpkp9umUjoGggolktQQShVpTM47Dt/1tBp87ijn+NtYaa/JEUa3QV4AzfBlZlbT6dHpOLoFv/h0L8KCk5RE8LYwzFrGtu2LYa1SIDnBSXKw8RbtzgTriNeg6F6ni+EY0MCn7gO+qoszC9XuwKutxpDtQAfhs99nYCAHs+ehAxOixoIkQAiCv5hEI0QgD03o6KImfGiDc6DMfGj4L+ITATEzlOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=Y9gzbDjkvTZ+vgA4DYetbhrsKRRB+FA9CpdA0qe6J48=;
b=d2Xdj10YMMG+oEsURFn9A0+J2dsDfDp0Iw/fJmKOEYQNnbgqv7V+ubQ4PweqpSj4CDboTMLY2pZJsEbx9+YLaniVkkS7dtxZHN7PJaGUeogOItKFvum+6+6/PeSHQTtWmYPYk3JH0xIl8S3u3rLzs9vGU5PLXFnBWpqwqmBqOcZNQXjzn1TVYAYjw+dLXwORKXS44BoMFfD1VOQCzBTJiGIVbj/RsopA94i/z3Mt70qRmYhjIpAXZDTJppR6k7V5qRUTInowz334N+Z9BBShyOpDro7Aeyn4aDNSwnG8WU9vVhNbEnW1UKg+5SocAeaiboPo8UkfXdIqTqklfxzRmw==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
CH0P223MB0332.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e9::23) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8655.27; Fri, 18 Apr 2025 05:41:35 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.022; Fri, 18 Apr 2025
05:41:35 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat: Quality
improvements
Thread-Index: AQHbrrgW9R6AVB6Btked3yEOin54GrOmHO4AgAAHeCCAAsWk0A==
Date: Fri, 18 Apr 2025 05:41:35 +0000
Message-ID: <DM8P223MB0365411A0C1DB20B6561A636BABF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.ffstaging.FFmpeg.1744634826.ffmpegagent@gmail.com>
<pull.66.v2.ffstaging.FFmpeg.1744798340.ffmpegagent@gmail.com>
<6568269678c770544d58a9277feaf4953c352d9d.1744798340.git.ffmpegagent@gmail.com>
<GV1P250MB07371D91FE8825EFAB6DA6C08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
<CH0P223MB0363BF1B89B56D5E8AD9E695BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM>
In-Reply-To: <CH0P223MB0363BF1B89B56D5E8AD9E695BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CH0P223MB0332:EE_
x-ms-office365-filtering-correlation-id: 088d3d37-4630-4ff2-9f96-08dd7e3bae80
x-microsoft-antispam: BCL:0;
ARA:14566002|19110799003|15080799006|8060799006|7092599003|461199028|8062599003|1602099012|10035399004|4302099013|3412199025|440099028|102099032|41001999003;
x-microsoft-antispam-message-info: =?us-ascii?Q?WecrpQrIfy/p3+9sbTtaK1IB3vO8FpS24mS3VghzVZYD85iQKeeB5prDyT8D?=
=?us-ascii?Q?Zpv1NITsBbHxtkG1YR9elIiFWccsIc3cKKrY8MSsdgZJ1qm3GjOCfeFBd7vt?=
=?us-ascii?Q?EP5enNZa3O03rrm7AqDprtVK7jCLhS4cwuggjkkT+2Y0fxqa4VduN2GlrDr+?=
=?us-ascii?Q?m0uEWvifaQxIeeM9p9B2J2ieaj/huhmn89W39U0r05ePINCXbUNuk1n1brhR?=
=?us-ascii?Q?RavslJABdordY1WmUhUXEYLDaPBR9TdL+ZdyH0AxA8DRlHqp7NNKCwvX/SkR?=
=?us-ascii?Q?2RId9slWpbIA/IOt2l2Wbc3/B8h0GLkPRb0yx3gkAxOkMGo53VHyIsIqcpcH?=
=?us-ascii?Q?8Ln78GYGhTKSrSUBnNbttQGPeEoY5c02n9SC7VKFzfHn99Oh3Eb1VX6KnbM1?=
=?us-ascii?Q?c8DzZmMpCPlFYXJ+O9BIOgmQuBu7uM5g9UbPPCn8j2D/7trNeFho3qZHfFUw?=
=?us-ascii?Q?CK6HXlWemIKw9kBQhnriL1U0i0YnLGiMHrGlqX9MKK0KSsb+IdBOnjrmstmh?=
=?us-ascii?Q?9YeEVvIqZruzf8uHeHAMyNUcuu4Py5HLH3tX9+YH0HwvKVE/HTJ3KfnLsGb/?=
=?us-ascii?Q?fnP6u8RGwKkqWQGUe6eMgQVc3ffZwnrIHJA3qlNL0NoM3u/oEQlr6a2RLTWT?=
=?us-ascii?Q?EfcGxfWqrz8PxS9r4LNQ1BsNF9GVdcTlA0HrPMGVDZQGUlrPPsVILDJcPV6P?=
=?us-ascii?Q?HSa+ro7OwtCh0TO3OXgp0+AMcO9vsJrKs0kRlfZWTVOo72Pv5QkdY1EIcKdC?=
=?us-ascii?Q?4nLIjLKQ+YY1Bu9huQFkvhTCD1FY8+7LvLlLCZh32UMnlEUpuJaD2j8DRrS7?=
=?us-ascii?Q?zSuampGlab5nBoQ1WWSqx1wV3xuI5a7pEcS3ngh7j0TC4VgH7ltTAPdCaDXQ?=
=?us-ascii?Q?GTLQbEo+YIwzRS+lpsRVvENM4O+pRwn5llYxYcXxtCONVHrAa3kprqbS3Bj9?=
=?us-ascii?Q?drnApnTAHlVMeT+plv5aAHXba6lXu+s7m2HUYVIbyohZqHpO4eJgbaY6PtfD?=
=?us-ascii?Q?lFmsJgW5+12ha0OtQZQZZG72qx/YzLvQQ3BaIuzZ8Xra+/7nGy5DuBK1zYLu?=
=?us-ascii?Q?vyG29WufXdfjI+cktwSEumhkKXPhyxZZ8t3LxLBl7vuk9Mu1AD0s0iiClJzZ?=
=?us-ascii?Q?lIGTDwTaR6s1lTkUT/FIJ8kNYjdxcQEcNYVg8SFHw6wV6Oq9E4V5bGXI0fpn?=
=?us-ascii?Q?yUC14Pg5iGcQzEv/fCHv0u48AOL8AqJ3dtsYN//rZvukk39TiT92sX41vCZ0?=
=?us-ascii?Q?agkud+GwJps17USWDvA/?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pMwXiv8Op8rUjhexedIeqUeYJC6Ikx4XXieQ0LLDULqT6jZH83jKimPE+rzl?=
=?us-ascii?Q?M8Wps9+Ryy26mX2c+USNAn/St5GisfFUrgkAvfBYf8EkDwj5nYJ1hfpBUV8o?=
=?us-ascii?Q?OB8l11MhI5Ou+kHzvh3kkKXyKoydFYroOUYu0oieJK4NIbOlsjFq2LuG36CE?=
=?us-ascii?Q?Ws18xl1qSrDxyjIOiYIG19wd44awaFvjw0tYdoGdA2RPV3xyHs3ePnOguBkY?=
=?us-ascii?Q?nZ77+joEQSCt1ZdW3QIcmuFXpgVbJGqLZgEZwwg6ZdHWDX9T46NXV5Nfrs7I?=
=?us-ascii?Q?hAbvIJC+R0hk+bEcZRmcOKKh7xzPlVbxMRNqTqPHtF3N5Ko5BctyEAKeu+JB?=
=?us-ascii?Q?/XMnc5tX0oJK3uF0RmV8Nee+L0cQ1C+WEHb2FkPAyRfHFOBBUbfRuTi9ZO9v?=
=?us-ascii?Q?+DmYff7UihrBVCAsO9T5gRcG1PVOapAT75lp4DBkENV/hIzAZ+xHQwUzV+jE?=
=?us-ascii?Q?4/CmkMsqGwz2DawPXZi/A5VrEDj9Vu9WkCrBXfuUjbhkkyz1gJVs8tXeiXON?=
=?us-ascii?Q?PrrVX5vVXkq3Q4bEdTf4jdEdXYhwzzvqf958+afpkm/UPSS+6KssSvJ8Enft?=
=?us-ascii?Q?t7zHXYxOLl+yxR68kg3LHl7XZbtsf7UMSSzLy+Ipyf5ZGXusaJ6ghTIdxPpd?=
=?us-ascii?Q?v04rUxODR+yH2PFyyJvkPeOTGZjPLtlW+Kde+cmxoHEbODn9T7nq14rQBE3L?=
=?us-ascii?Q?U1Txez1ye4kwH0uSaT+ljGLhg44X2QVZk9PUBNRhYN7E/I+OemPh2iJnZjbe?=
=?us-ascii?Q?QNZjsbVJH9gKZipECI0ppTpwmB6Fq0jv8F+yibU1ylZvc5JSjhQ4pa0K5S8U?=
=?us-ascii?Q?PL0QIKqRV6z/dsTCp14ixhmfG8qIw1TtWZhVjvR4LVAvxC/yk1fMeXfgWJIU?=
=?us-ascii?Q?lL5IwCMIuBVDYDhmtY0WrGJb4+zQ/6L0KzXSiEh0ql6AkrG5Oj7ZRGV5TLtv?=
=?us-ascii?Q?Jcr2VnnOhRoHVbnNQjIZubJBwhb6MNwoFzSt0o/s9oxos3l8r8yjh5rd9ubY?=
=?us-ascii?Q?NLzK5ZpRRnN9EPKUfK9/cwPmvnc5duNt+aYIjjYcxWj9HQk35yknaJE31fyx?=
=?us-ascii?Q?9PPKvMy+RB2R6oEmgW/mQaqPI31YeRAKPtFXf46DOZlhm6TdXmM90cjZHUHD?=
=?us-ascii?Q?HpzJWcR1hSQjlZeAU/86c0RPMz+0KoziexMJkZG0b6rb8bS8HYbJEoBKps0+?=
=?us-ascii?Q?1fXK+OGf0wrExHOipH9eOqSrQn0TYVrm04srrEhR2Fb+GpBCVnBzxHJ+mj4?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 088d3d37-4630-4ff2-9f96-08dd7e3bae80
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2025 05:41:35.2166 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0332
Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat: Quality
improvements
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB0365411A0C1DB20B6561A636BABF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> softworkz .
> Sent: Mittwoch, 16. April 2025 13:33
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> Quality improvements
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Andreas Rheinhardt
> > Sent: Mittwoch, 16. April 2025 12:49
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> > Quality improvements
> >
> > softworkz:
> > > From: softworkz <softworkz@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz@hotmail.com>
> > > ---
> > > fftools/textformat/avtextformat.c | 111 +++++++++++++++++++------
> --
> > ---
> > > fftools/textformat/avtextformat.h | 6 +-
> > > fftools/textformat/tf_default.c | 8 ++-
> > > fftools/textformat/tf_ini.c | 2 +-
> > > fftools/textformat/tf_json.c | 8 ++-
> > > fftools/textformat/tf_xml.c | 3 -
> > > fftools/textformat/tw_avio.c | 9 ++-
> > > 7 files changed, 93 insertions(+), 54 deletions(-)
> > >
> > > diff --git a/fftools/textformat/avtextformat.c
> > b/fftools/textformat/avtextformat.c
> > > index 811b14b999..4c8def8e65 100644
> > > --- a/fftools/textformat/avtextformat.c
> > > +++ b/fftools/textformat/avtextformat.c
> > > @@ -93,9 +93,8 @@ static const AVClass textcontext_class = {
> > >
> > > static void bprint_bytes(AVBPrint *bp, const uint8_t *ubuf,
> size_t
> > ubuf_size)
> > > {
> > > - int i;
> > > av_bprintf(bp, "0X");
> > > - for (i = 0; i < ubuf_size; i++)
> > > + for (unsigned i = 0; i < ubuf_size; i++)
> > > av_bprintf(bp, "%02X", ubuf[i]);
> > > }
> > >
> > > @@ -141,7 +140,10 @@ int avtext_context_open(AVTextFormatContext
> > **ptctx,
> > > AVTextFormatContext *tctx;
> > > int i, ret = 0;
> > >
> > > - if (!(tctx = av_mallocz(sizeof(AVTextFormatContext)))) {
> > > + if (!ptctx || !formatter)
> > > + return AVERROR(EINVAL);
> > > +
> > > + if (!((tctx = av_mallocz(sizeof(AVTextFormatContext))))) {
> > > ret = AVERROR(ENOMEM);
> > > goto fail;
> > > }
> > > @@ -213,25 +215,26 @@ int avtext_context_open(AVTextFormatContext
> > **ptctx,
> > > av_log(NULL, AV_LOG_ERROR, " %s", n);
> > > av_log(NULL, AV_LOG_ERROR, "\n");
> > > }
> > > - return ret;
> > > + goto fail;
> > > }
> > >
> > > /* validate replace string */
> > > {
> > > - const uint8_t *p = tctx->string_validation_replacement;
> > > - const uint8_t *endp = p + strlen(p);
> > > + const uint8_t *p = (uint8_t *)tctx-
> > >string_validation_replacement;
> > > + const uint8_t *endp = p + strlen((const char *)p);
> >
> > We use -Wno-pointer-sign in order to avoid these ugly casts.
>
> Yep, I know. Since I'm not a C-for-life developer, I'm using and
> taking attention of warnings and hints like clang-tidy.
> When you have a file with dozens of warnings these things are not
> helpful, because you cannot go through all of them a hundred times.
> When disabling certain warnings altogether, nothing is won, because
> often there's one in ten cases where the it hints at a problem while
> all others are harmless.
> In order to get rid of a warning, you can either add ugly comments
> or - the designated way from the compiler side is to be explicit by
> e.g. making explicit casts. That's why you see them at some places.
> Doing so, improves quality when working - even for languages that
> I know in a similar way like you know C.
>
> If we could agree to remove these in a future commit, it would be
> great.
Hi Andreas,
as my comment above sounds like a typical never-gonna-happen story
I have prepared a commit for later removal of all redundant casts:
https://github.com/softworkz/FFmpeg/tree/submit_textformat_remove_casts
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".