From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CEEEC433B6 for ; Thu, 9 Jun 2022 19:19:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8C9068B7CB; Thu, 9 Jun 2022 22:19:28 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2067.outbound.protection.outlook.com [40.92.40.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC7A068B7C0 for ; Thu, 9 Jun 2022 22:19:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vn89wrEebPQRffKrXtb21SliDYgRo7JB1PLGlxfoBN0i2Wns0oaUgeRVGkU4xSqdvyG+o1X5mxPQvWy8b0uaVzkFObLjUkXi1kAGZ8D0pBNu3akr0UFWEYyT0Lj7VsegS5g+19iDwqUXmLJLTeMhYpkqnw6srCiLyJ/ZD12qWcfHhqGqpknoSqyJN3jXpwg8fnA1TpDfZa3m93xDoht8x41gNOx+xWQjES3WWp6zglaKBLc2zBQhwurEuASholAdvQ1h33vvakU1d4iGj2I83yT9QUh7RZQpP1zjsPtpNAQjxYRcEef7itqu2wjBQQG+j78NEIoPwfaZVtE7mIyIJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KkH23FwC6iE8qDGXCRa5KM20sSQm7MNK/tfCy0wUcbA=; b=HsBkSbJMbIHf/VuoKkqJaS2Kbm1aQdI2EFjTi6OM4uUd2zo3QVKI5nBhUX+AU6Qrhm8UQNRXbaJRilYl5LU2vezlaO298b4+ePWsUiGtbFXvtZh3M4thOjsLj/ImNVB+n9494UModdP4QhAcYRkvPTe43/4cpAMDAdCryxWTsimHT0I3OD6ksOa2efUz5zkJ32mj+IkqwDHgSA4hGOtGBl+sb759GRWbbTBsN9Tu0txeycYpLAJAxJmRHeTGECwyK+7gGCinJbM5ayjyKd6JZWnLyU7/mdfID6mJtM3moQqkdzO/4jn5Lssl5hx7ZYGtWoa8bFLJqogZYC+WAjn2FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KkH23FwC6iE8qDGXCRa5KM20sSQm7MNK/tfCy0wUcbA=; b=jkxs6fe+Vrf8yNVZNCEQ3Qty6SVRGR4OITVBAeRNaNwrhAYN8esm4j7sjmjF3S0rDaxeojTmmlgoMV0ZNZETnQSiSf8HhGwBnXM6QFhLS5s8F4/CtkOQOL5qthX/vMS0CrC45dYAkkKZ/o37BnZXzp0BiSGBDGY8rNqXcUk3VnCqmpuIzMsCA7VOVkOfR0QZrwbH2xy9Erhly0HskQwu8I/sc94c7hOFZ3Y730MZhbEW8p088UEZ5j9gib11K2/ycdT4kbwpkUwxXeIp2xpIwJcv2pOrcU+16bQxIpr8YZFhUnjM+/5vDpp+pJguaHAe6HcWCSwxNi9tzEApJ73+dg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0084.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Thu, 9 Jun 2022 19:19:20 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.019; Thu, 9 Jun 2022 19:19:20 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v6] libx264: Set min build version to 158 Thread-Index: AQHYcPwx51y6fdcHqEysYWR3Xx526K1GCOCAgAAksUCAAVJZAIAAAxCA Date: Thu, 9 Jun 2022 19:19:20 +0000 Message-ID: References: <137512e-90a-d163-d7a0-8d7e9309724@passwd.hu> <18b8e22c-1d10-879b-bee2-1b128f176f3d@passwd.hu> In-Reply-To: <18b8e22c-1d10-879b-bee2-1b128f176f3d@passwd.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [AmWtlWqd5z865uSwpnTv4TuLsJy75P3w] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 000ce8c8-0f92-4ab6-5192-08da4a4cf455 x-ms-traffictypediagnostic: BL3P223MB0084:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vBHw/NlX66TNOnYVY1qeRkwk4bqu9yiDVJxHS/kEMqT25dxtkM6LcGAdf82JLklW62SBtnZHUwM8Ix94e+jdRzml9f5FhV/6EzFOsu1XLe64GHwujgLzxdEEZNoGssyaSBSQZ8mgslDw/sBzd3L9WJlnDOkuIf5GMhinKE03HOoiQwPAiiYtVXTmj/EPPZhowgRCuwGI+wFhn5cqW2acnto4xnzp7Gm4C5JyRG9QTJjrWV3qmr+Zj1Q5CmdgJggklUo/zChLsLYjaCNYXqQZSUdRNEKT58+1sZ3rMWNVZYsNx5EZ2tZ8ALSZYySaCgGQTDCV5TACu0Se2tLvyWYfd+BPAHULwgyvclqyDerFgYLmy0CPPjRQMHHz8yidy3soqCzQvPiWDPLX/nOq6RiTlHOpBXen7uT+UdStkeRMll7wUSyJHtPl1CF6qLsermYlIA5Svp97R2+DMN4n+/oROFrh7ksjIh9ZP5kR9XBA/QS7OUL3doAkq0nUaYOTEmBRVXwcB38cJ8sVLLF/nLoYEV6hVVtLtvY1kKiNh+fJ99k0FppVaVem/s0TUpRK3ThYFJY51MHCY2ul/CTOz9NO5GJskU0TN/y6iQ+RKZSaQCTN2mo6PoJ8mBscQckcZwtW x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QzYxVVNEV0pLTDNJOWtXN01mQWc4Njdnbisza2xDcHh4YjJ2VytvQjlkWFd5?= =?utf-8?B?cWJmQ0V0UlVrU05ITkRsUXhVVCtUUTRJYzhXbVhTZmM0UDl1N2ZiV0w4OWVL?= =?utf-8?B?N2kvVm92cHlwdkFDVFNCbkhxTkNQYnBGdFFlUXJROFBBSUsrSWx0Mmtnbksv?= =?utf-8?B?VGVaMlpidkRwRXRjRFErck84Q3FIZ2lvd3pvOUNxOERLS050R3V1S1gwSWpz?= =?utf-8?B?WG8vZDI2UXdhQVE0MDI4K2hHRVRDQ0xkYk9sdnJaN2FVbElzU21rbGgyQU40?= =?utf-8?B?aTVNQXZKMmZPSm9iQnNhYTd3OGpkTmJMUVd3Nmg0S0Ryd09wbXBVS2Z2WndQ?= =?utf-8?B?RFBPM0RFdmgvNG1NWDl5RmZkMFFiYVhWT1N4MUZ0aXIyUG5KRFd2WlNrSEp5?= =?utf-8?B?Wm9RZGZUazd5clNBOGVwWW5uUmlJVzcrcUZOTGN2c3E3ajdscHlzY3VkckI0?= =?utf-8?B?eC9xZ1pCQXljNS90QWlQVkpDaFhuSU5TWEpramtBbDlBNjNRWUN5WVM1emJw?= =?utf-8?B?V3V3M3pzTk5ERnkyeEFEY0ZiOG5zbGUxNUpIRXhRTC82Um11NzZOK3lBV1VU?= =?utf-8?B?M3JuRVhlUXNhZmlLUW5tclNuYlZzclFhS0UwZG4wandpSGlDaVBEVTQ2K3dp?= =?utf-8?B?TWVEM1RucktyNmxXMDdmVUR2V3hWNWJ2eFRZMmJlR3ZNOFFUVGh5L05UZSt4?= =?utf-8?B?SERSckpLZU40ODVJMXFwbk1lTWZDS1NtOHFlOEJFRDN0WDc1TXVXbFRCbkp0?= =?utf-8?B?dG1mOTVMOFEzaHhmNnEwNVdLbkdaVGNmZWdsMFRiTjhFTmhjQ0NiUEhZbVBT?= =?utf-8?B?QVlKT2RPdklKenQvQWxySVFwTGQ4UWlXd1JmR0dTOTBLVDZGREZBYk53NUNO?= =?utf-8?B?M3ZSZGI0TDhXL0ZrZG15ak5ycXlxTlEyWU1CTCt3VVJhTHJOUHNBSjc2TWRy?= =?utf-8?B?NCtydkY2VEpWQjNhNzV3WXdXRHhGQzhueWpDa0ovR1RxendhS3N3Qm1BbFJF?= =?utf-8?B?dWUyaXNGRlZlTUdFL0d4MURrRzA4Z1VZcjhoU1pwQTl3Y0NUcGpjS011ZVg0?= =?utf-8?B?aEt0TFM4ekYvcnY2REVLa2lCWlpvVFJHTWJZZk92d2pOcHVqbC9XTW12UnhI?= =?utf-8?B?M1FhaXR5SzJWa3A2K2tkL0xnVXA0N0xLcnZMU2JhNTVSc0EyZ3FiOWNhTUZz?= =?utf-8?B?b3BKejZlZ05OVlJxVjNjSVd1RzVBcFdYQWxIREVaeGFrMmp5YXpkWXYzL1Rw?= =?utf-8?B?WTMyb2M1YjZ5ZW1hVVQ4TVBKZWRNTHFLOFdSZFVTMkRKUXY1eVF0QTV6L1h4?= =?utf-8?B?K0pDSlRaRDFSN0lhOFYzZ0h0enllWW5kVi9DaHEzMC9WZlNDWHdybThPTzJm?= =?utf-8?B?dUdxaEZyTWZQbDQ3Vk1HaC8xRDdEMXJVRmwwRGdEbUI3emJjUExVbWh1ZDVa?= =?utf-8?B?SXk1K3lza2tCUHZZcGYwdmV4amM2UzRZVHZyNk5rYlJNTXJ6Y2lFYUhpS3lp?= =?utf-8?B?UnVuKzVFUDVWV3hNU2hLUHUvNFk5L2l6cmtjblNIQzlaOS9yWFA4TVdEakls?= =?utf-8?B?RS9yK0VkZ2Z4U3c2c3hmQXBhb1hBL0ZFUEp3MlhFSElJSUhxZ3Qwd1hBTksx?= =?utf-8?B?QTEwQmZDVjJacXN2bnhVYXQ1WWFTbzNldDhtM05SQzVJUTNWbC9vZC8rMldy?= =?utf-8?B?aUxhRldLRXYxbjJ3c1YvaE00NWJ0N3gzUFQyVXRibjM5RkVUcmQzdmJYYzVl?= =?utf-8?B?RVNRWlhYQTE5dmM0aWVHeTZGYnRnb0E0NUdaWWVwWHptRDhablZwOVF0MW1m?= =?utf-8?B?SVM0NWlqS3JYZmhERXF2OVZ5U0hVeGhOcU1jUGdxQTFKejJXMWRtZ1ZHeXp6?= =?utf-8?B?VkxkYVNNZFNxVDZqVkxwZlRybzJISGllNW5GNW4wTFZFaC9sVmFrKzlKbFha?= =?utf-8?Q?h1dueWmS/y8=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 000ce8c8-0f92-4ab6-5192-08da4a4cf455 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2022 19:19:20.3236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0084 Subject: Re: [FFmpeg-devel] [PATCH v6] libx264: Set min build version to 158 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Marton > Balint > Sent: Thursday, June 9, 2022 8:44 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v6] libx264: Set min build version to 158 > > > > On Wed, 8 Jun 2022, Soft Works wrote: > > >>> - { require libx264 "stdint.h x264.h" > >> x264_encoder_encode "-lx264 $pthreads_extralibs $libm_extralibs" && > >>> - warn "using libx264 without pkg- > config"; > >> } } && > >> > >> x264 without pkg-config feature got removed. If this is intentonal, > >> then maybe you should mention this in the commit message? > > > > I cannot honestly say that I would be sure about this part. Matt had > > this removed in his original patch and objections were made about the > version > > requirement, but none about the removal of the "non-pkg-config" condition. > > > > Would there be any reasons to keep it? > > Probably not. Removing it is fine by me, but the removal should be > stated in the commit message. Yup. Done. > >>> - require_cpp_condition libx264 x264.h > >> "X264_BUILD >= 118" && > >>> - check_cpp_condition libx262 x264.h > >> "X264_MPEG2" > >> > >> Why is the x262 check got silently removed? This does not seem to belong > >> to this commit.` > > > > Matt had removed it and there was a comment about it saying that it > > would by dysfunctional for a long time already. > > > > By a funny coincidence, Gyan has submitted a patch for complete removal > > of this: > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220527082922.994-1- > ffmpeg@gyani.pro/ > > > > Whether it belongs into this patch or not could be seen from two sides: > > > > On one side, you could say that THIS patch is about updating and adapting > > the x264 conditions to the state of time, but you could also say that > > it must rather be in Gyan's patch (which it is anyway). > > > > Just let me know when you think I should change it. > > I'd rather keep the X262 cpp check for now. Ok agreed. The situation is not fully clear to me after re-reading Kieran's response to Gyan's patch. Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".