From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 688E34CF66 for <ffmpegdev@gitmailbox.com>; Tue, 15 Apr 2025 19:07:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B056F687D25; Tue, 15 Apr 2025 22:07:27 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2047.outbound.protection.outlook.com [40.92.23.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DB3E687A81 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Apr 2025 22:07:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xLrxRbYQi/qzO/nZUuorb6todOrqhLUCw5hm0+pMeysus53QXjX1w2I7JYWCXGQAiwRB0SSk0M/HAbTcnMlGa4eGO68XQME50xKxfTYvr5Z1J4hSFZs5ynei+9/eDd4OF9Bp09lbE9EqPLbUmMxh10qT2sIZeDosAQ6MZHTfT9myI/KZY98RC5nofFjlas+yVFKsuVAOheyP0frUCt2+tOeZSV3LKdGXPKx/6bgDIzGaffWCl6djFKGKWw6so0egmlajrR2AhO9ssFpdoLLMshmDVORHlx+Nn7rMwTX12lznfYTnTWvVKvdjSGQi7cFE+4oP3W/M/jx164bUKOZ0ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xshge+gVeG+BAipR3WzHLyBwwR1TJiAUxiLK37stC64=; b=WAtO7O4g1NzSx4EdrK6BzS5x5jL6wWpNlU6Fz2TpGYUXEMzJlz8besWsUwbmXTc3qgoXcY0VKwpCxtlsnKiDWX5lGNYhQkTKDaR4NW+o2JLh0oO+MBrbjtNBbvO5FzFl+86CCBcoIUpHpbW54DMKFRX5/Lh+qs3qQchsepDpLyGO+kQTOffTLbWoB9GkZlfzkegHok9gRFK/sA8vZbO3TPdwO3sONfe7qt/4Dw68l58rOTnZK2TsDrrbDffXUTuWdxg//0pD7/qut5tkK5SOMlQGZvoIGS1A0zE4kjOFeaqrGry4meBZhg2nLnSvNoAXi4vSb4m6FFvWi5oYv/ozNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xshge+gVeG+BAipR3WzHLyBwwR1TJiAUxiLK37stC64=; b=ITKrhU0Y2EKju2m5AaJXNy1pJ3fIn0nIK5iDWEGWFrPtn8DavBZ01XE54py5OV6zLTtqnQiUanNcI3mEA6gR7Pp07Qa82cH9Cl2R5bmoeAITlb9t+pFlaIwQFhEzylHzlRgkyEMAzxF0fdfXYaAv3yr9HERcXS/Lv4m3RkXmzoqds2GRcIxnLaS+tvWe7HfdXz/Lcp6xhAmVZ+mc3sE34QcwSUyebgRKg+xNIM5si2Q5G8uG4nTpjCZZ3PIGGWa48cmeN09VwuM0DuN6Gr+jGft+laktYiSClBn6r/TCHN5jLuqJxMgXPiMMi1CmAQV8j+h31U0U4Q+RigIpJfZwjA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0174.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.36; Tue, 15 Apr 2025 19:07:17 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Tue, 15 Apr 2025 19:07:17 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAACQ9oIABG+UAgAAK1tA= Date: Tue, 15 Apr 2025 19:07:17 +0000 Message-ID: <DM8P223MB03653A546409CCE341788B1FBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB03650AB4340A4553BAA76A1CBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415182538.GP4991@pb2> In-Reply-To: <20250415182538.GP4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DM8P223MB0174:EE_ x-ms-office365-filtering-correlation-id: 8c034d6d-f349-4579-bc7f-08dd7c50bd4a x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|8060799006|19110799003|15080799006|7092599003|461199028|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?axT4aEjKxlMCx/qSSWmyE9EiQv82+rE9y7gH8CfPNOR1Y7BUyheg6eFdWyok?= =?us-ascii?Q?tShCU7R4hKaAN+34Z4m1/vlpADv6cREDhu8aSXuFUNIp+vGBV05u8dsyelza?= =?us-ascii?Q?t4mGI/SwhbA/BsKDVd0vQ0W00gTfo/dME28rexJJ+p7Sy4QkRhQ5+Q2qYE8q?= =?us-ascii?Q?I3oky3lDGGbqOzCqxUcXL/9QDmKvMivWiEl3giqmObJspVvPaiaDwa7UA+Hy?= =?us-ascii?Q?dy0cZu42RM6lVj8mnakVwQvNZPec+EMJaQEonGYgShUsYJxDb+dBYiT0QLBG?= =?us-ascii?Q?B2ZwFr6UzvfTkplKgu8pc4wqWA+iHeHqmFYwl4Aq2pUy3L7HNwNb7bgfKxy7?= =?us-ascii?Q?pYHeyq8ZuyZvSvjr/zfyY78igxKZRcNw9FGCDBbxEUudAvzhuTDFGRhtwwD7?= =?us-ascii?Q?siK7wqXF+04fDzzQXBkskUB0n6xu4dJwX0ovh05D+XAZz22XX1QM1pz2Gc5r?= =?us-ascii?Q?AVrz5d5aJfEaRTO13hfXtTKLrW6KMHoOws82PN0/ePqEdugjdQB2HEyM6xjs?= =?us-ascii?Q?cVK0lZUswDM4fgoIHlKwvd4y1rwoIB9aqcVec7kiJYuigGocSTb0dP5b/TFk?= =?us-ascii?Q?IWrjuQPvDUrC6F+NUgVDhP371rjB8hzTw+SJFmOSxiZ9f7AO0skTXe0UYEN6?= =?us-ascii?Q?83py5ZXObCrasSp1+0b2d/LE9bEOlebfni9mMTb0S7z3qfBU4BSohtcoZEsW?= =?us-ascii?Q?q/JPp9S30fdTdbFcLysUbAAqwFAWw1RtSuqo+2k/Jj/ynuoAo6xsK+FkMovl?= =?us-ascii?Q?Flq5gArhwTsIxuTcGSUBtoVeHoymu1IwPogJXGTSarvCnAQgWixyru6vmt44?= =?us-ascii?Q?6Eo0RLomgMkstAKthu/+W7vmgM2WnDaYs2R8Mu7cDH5Lqd6aGIbE6pqcM8pu?= =?us-ascii?Q?XPE+uIdytO0G5DUz1ePxSvuEdo/nAlEIHEoxRBgcS/0HpzQsnJ+y+cWWCrJf?= =?us-ascii?Q?flD7h9E6o/C5Lh6Cr+3GPOZeZtSd1sYtLTRQkTeegiC6Mvk3hB68Sq5R+Wfn?= =?us-ascii?Q?pl2jncfEX2XBzc7JjMPIxSoKmxjr9hjhEVUCvZ390AOSBsRUJbFl4ffcH9T9?= =?us-ascii?Q?UHffuS+e9/gJuDfFW305iFEBTiWFwmvUnNjqu5C7VsihQYZ1OOU=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rhoc8kEu2hv0lBoMeDj9gVwVdXLhrKA1Zk9jfmzVm302+wkytsZiPqjMPgXe?= =?us-ascii?Q?3OguJfk2JvMow77o6Cpa9wzFx2t/T2vZn8TJj8pnnMnDfCi2hb6+F9BAXqJp?= =?us-ascii?Q?4XFqE6d9v+LA8BZxOcfG3MRI7PZ5io2t5A6SwkgHOPBFrIjJWoLs8jmDklap?= =?us-ascii?Q?PIjsG9v8C4Nu/mfYpHLHnhS3wDUGEeWa4SpOUkn0oJbpAA1yRf0BesXTLMiT?= =?us-ascii?Q?OLyHymtkeT8PpW7vGs0YaJDU9bIMeYeyX8pKc4XME18V8lIW8YNX8291ejBA?= =?us-ascii?Q?o2FvIbmgZHP9rvZcgitCmHyLiu39nMJshdv0Yf0wHPap/y52lXCtvABtMFOM?= =?us-ascii?Q?SDEbPPKT56t+c+WbKDtY7YekMtEs/+06d+yyONiq1VtPNvkaZdNaEgkII9YO?= =?us-ascii?Q?oqoPz6/qG8BcLJ7UXEctByTujeeV6TTP+rkA61U7dnUDpBLTI0AfGlHtdI8O?= =?us-ascii?Q?7Ec2jiTKIAanV1Gy/LPlUoby+RJTfv5KKZ3Bsey4QJfPntRfucDMppCEavWP?= =?us-ascii?Q?UWC0u4zb5qrRvv9QHYlbG45ZAaxHOvX0F8I923VsJsUdojYKJGwqPs5yV80M?= =?us-ascii?Q?5vcfo8CKz/xEBAmHiFPONaLZUhfj0sQhsxwg7keXXYLk9zohzWiykjuH0pXB?= =?us-ascii?Q?7bkd30+XcJ4cLm81rTk4TwesUqYl41tDgiyeapgwhUwuIdWcbG/XHJlLNgFK?= =?us-ascii?Q?o9dsawKohk8iTwojEw58SRtSL7ZrxxQxMYQk1Kkhx2QrysWw4F0r0FaSzaap?= =?us-ascii?Q?9NfQrbzumEU5UBv8TnYuJFWoBKYYsDwsr6hSwSpeye2ndckBUS0qBi5YYONA?= =?us-ascii?Q?2ZRack7V1l8ifzmanIA4s57W9tk2iy5z8X7Brs3wWSj7kl2fE7RIicumPycW?= =?us-ascii?Q?2lIKTYRlv8DdY94xZi7cUECYWa42NZ7Gp4VkiiscBVXQwKxOQtE8y72FuB20?= =?us-ascii?Q?F0WRbberiATAKHyNRl+kS//Cbaank3SMNDk4DAVJAB0kmmp6dK/hN+R3PelS?= =?us-ascii?Q?rQdb3DVmVVF54J82Fe8kDtc0KJUPLEufawFtSs/LJVtfH9QpnjWuavpmj6Uy?= =?us-ascii?Q?f8ELI51QDcNd6d8qpcPUBhX+L/yTDqQvBZtWp6SeN9SBGWjwIljFWLAqpaqo?= =?us-ascii?Q?wVS3OPdiOLUWJ8gYxf8B2ELLIXk73XGJAD80+7ZlaYtei8Apcsen4B9kDplG?= =?us-ascii?Q?ivMzRdP3XCq2SKPV94tiIoEM+AE5TH6kpkrFZXxegGXrOA4ikcEVapaa8zg?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8c034d6d-f349-4579-bc7f-08dd7c50bd4a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2025 19:07:17.1378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0174 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03653A546409CCE341788B1FBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 20:26 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > Hi > > On Tue, Apr 15, 2025 at 01:37:56AM +0000, softworkz . wrote: > [...] > > > > do you have a test file perhaps? > > > > > > Will email you one, but the loop with a function that doesnt > advance > > > is an issue even if the specific file doesnt trigger it in a > different > > > implementation > > > > > > Thanks a lot for the test file. I was able to reproduce the eternal > loop > > that you were intending to fix, but I noticed that after removing > the > > patches from rcombs, that endless loop doesn't happen in the first > place. > > the patch was intended to fix that regression yes. But your patch > contains > a very similarly looking loop to what caused that. Which is what i > meant, > that because it looks similar it should be checked for that Of course, I've checked that and - albeit similar - it does not expose this eternal-looping problem. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".