Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
To: Marth64 <marth64@proxyid.net>
Cc: Kieran Kunhya <kieran618@googlemail.com>,
	FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)
Date: Thu, 30 Jan 2025 05:54:09 +0000
Message-ID: <DM8P223MB03653A0EBD1C0079309DAEDEBAE92@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAAhd_PVQ6-TcZ+P_Y0L2CBG273Gcakm23Amq9aNhfROT18+0+g@mail.gmail.com>

> -----Original Message-----
> From: Marth64 <marth64@proxyid.net>
> Sent: Thursday, January 30, 2025 6:46 AM
> To: Soft Works <softworkz@hotmail.com>
> Cc: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>; Kieran Kunhya <kieran618@googlemail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection
> and ffprobe fields (cover letter)
> 
> That said, the concept of exposing the properties was rejected. I
> understand why since they are internal.
> So the conversation would have to be re-opened, or maybe an
> alternative solution devised.

I found something! It won't require an API change at all.

In AVCodecParameters there's an array member coded_side_data of type AVPacketSideData which is defined like this:

typedef struct AVPacketSideData {
    uint8_t *data;
    size_t   size;
    enum AVPacketSideDataType type;
} AVPacketSideData;

and the enum AVPacketSideDataType has this member: AV_PKT_DATA_A53_CC

So, this would allow to add a packet to the codec parameters with AV_PKT_DATA_A53_CC side data - as an indication for the existence of CC data. Without any API change...

What do you think about this?

sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".