From: Soft Works <softworkz@hotmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Date: Sat, 7 May 2022 17:59:54 +0000 Message-ID: <DM8P223MB0365397A6528D041C7F0754ABAC49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw) In-Reply-To: <ea-mime-6276ad5c-5e4-387a869@www-7.mailo.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of nil- > admirari@mailo.com > Sent: Saturday, May 7, 2022 7:33 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] > libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and > utf8toansi > > You have completely ignored my question, haven't you? Here it is > again: > > >> Is there a Path struct, analogous to LLVM class, that all of FFmpeg > is using? > >> Or FFmpeg isn't using any special structs and paths are > indistinguishable > >> from ordinary strings? Paths are strings. > > Read again. As each lib gets its own copy of file_open.c there's > > no problem using av_fopen_utf8. The concern in that message was > > about it being a public API that could be used by external callers. > > av_fopen_utf8 wasn't mentioned because it has a particular problem. > It was mentioned to say that > >> FFmpeg sometimes uses av_fopen_utf8 and sometimes just plain fopen > i.e. there is no standardised path handling. > > > That's the pending issue with your 4/6 which is probably ok > otherwise. > > It's not an issue with my patch. It's something that was already > there, > and is retained not to break something. It needs to be found out why it was added to decide in which way it can be adjusted. > > 2/6 is pointless without 6/6 > > Wrong. 6/6 enables process-wide UTF-8. utf8toansi allocates buffers of > necessary size > instead of using MAX_PATH. utf8toansi doesn't care whether ansi is > UTF-8 or a legacy encoding. I am sorry about that one. I was under the impression that it would make sense only when forcing UTF8 code page for the whole application via manifest. I have no objections about it then, of course. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-07 18:00 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-24 12:08 nil-admirari 2022-04-24 22:04 ` Soft Works 2022-04-25 9:03 ` nil-admirari 2022-04-25 9:31 ` Soft Works 2022-04-25 9:51 ` nil-admirari 2022-04-25 11:12 ` Soft Works 2022-04-25 12:51 ` Hendrik Leppkes 2022-04-25 13:02 ` Martin Storsjö 2022-04-25 13:36 ` Soft Works 2022-04-29 19:08 ` nil-admirari 2022-04-25 13:17 ` Soft Works 2022-04-29 18:59 ` nil-admirari 2022-04-29 18:52 ` nil-admirari 2022-04-30 12:34 ` Soft Works 2022-05-05 20:20 ` nil-admirari 2022-05-05 22:38 ` Soft Works 2022-05-06 16:07 ` nil-admirari 2022-05-07 2:57 ` Soft Works 2022-05-07 17:33 ` nil-admirari 2022-05-07 17:59 ` Soft Works [this message] 2022-05-10 21:22 ` nil-admirari 2022-05-10 22:59 ` Soft Works 2022-05-10 23:32 ` Soft Works 2022-05-11 7:46 ` Tobias Rapp 2022-05-11 7:57 ` Soft Works 2022-05-11 8:08 ` Hendrik Leppkes 2022-05-11 9:03 ` nil-admirari 2022-05-11 13:32 ` Tobias Rapp 2022-05-11 20:50 ` Soft Works 2022-05-11 8:57 ` nil-admirari 2022-05-14 0:42 ` Soft Works 2022-05-15 19:53 ` nil-admirari 2022-05-15 20:34 ` Soft Works 2022-05-16 8:49 ` nil-admirari 2022-05-08 19:48 ` Martin Storsjö 2022-04-25 20:51 ` Stephen Hutchinson 2022-04-29 19:25 ` nil-admirari -- strict thread matches above, loose matches on Subject: below -- 2022-04-23 20:56 Nil Admirari 2022-04-24 3:39 ` Soft Works 2022-05-07 17:57 ` Soft Works
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM8P223MB0365397A6528D041C7F0754ABAC49@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \ --to=softworkz@hotmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git