From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A295040C36 for ; Wed, 8 Jun 2022 03:45:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B0BB68B356; Wed, 8 Jun 2022 06:45:48 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2069.outbound.protection.outlook.com [40.92.22.69]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6549C68A6B5 for ; Wed, 8 Jun 2022 06:45:41 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JudRmp8IxS4dnV+UU1vpitLjdLBMIxoHFBJc/gYufNh9o4uJZCTXHMjjiur8goWv3saTgd/4IDzmAwwj7amAUIYP6l7RRB34rdeH0XjBBAbkcxA3qTHH26MKyiz8IPIBQZseMjt5kGlo91r7hqg9wbTfAnT+c8/RJoe0UJZhhmlXOTx/OFDJzVGvaZae7p/ea3G7i5iyOVjK/07AA8OE1r8Z7SGiZKFLYfUSshNG2qdVzVsW0jOCLd33xAddsquvu7CXOESe3WPv278XtcJf+jGz/jJ0pGDWU40VS1FH+ND5JEPVYBlh/WzsmiBSvDwdgeqL0QE53fETFQkkr9aoBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yjlr0K/SswyIAv+cb8Z5MaDU+Xg1iokN598nORj13Jw=; b=oPAioIP1lv4GPblRO4RL9GQMl0/G1BTKqrH/xwya4WXHbUCndwbNjSaUxoukPF5ZoDmtBL8b6Ezv1FcX7baLQdLqqIxnU+CgoE+x80yngifpMwG5zv+McrBUBA7riW0fjzY/S1qaJy57Bo9eAtUGTNm0szhPqciWPji8qLk8Bun483uSIX8+yj58f2iiL+gCaWkF2zZ2kZMBa8vCgppJa3+iG7FtoWwhuWN0wE2+mK+51LW3gyDbgXo1imCt/NKc/3XhsVnuykpHnkq4yNudRjwuzaVDViug9QZoMvyzCxHJB32fip2AVyiP6DKrB352giE7V5urdgsXRgoe3LOwYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yjlr0K/SswyIAv+cb8Z5MaDU+Xg1iokN598nORj13Jw=; b=KHtqIFj2frBVce0nRIj3jVBu1rQlSTP07zvyh66wWQS502sC+kvFAc6XM/0+YBXOjjcRRZVJTRT9KirYYzaF9OUfI6GKWSXRHO4w8QI3gIGs9hVSWAJHWCA79U25GQFiRy9R4+wUPOUVzO4pqeKrt4mVG6lGQrngA5kJBgoUQv5IyM6Awj2vNHexsGBBY6FvTFhB+dg3C5rJw0JZ/3QQmK9XtXcs35EP1wxVnWk/Q2rMtfKqzmmH01VUbKCmfnGHbVCmgt4AkZlzNrVJChFFjVyHlo4SWQ/Yllsua61NCCserE/Hiuv20dT7Q9V/Hpu6rtam2u0mkZbCpYDZVh3Zdw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0235.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 8 Jun 2022 03:45:38 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 03:45:38 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT Thread-Index: AQHYemX/APXFdmsBaU2+kzHdFR1g661E0DBggAAI09A= Date: Wed, 8 Jun 2022 03:45:38 +0000 Message-ID: References: <20220607115839.18515-1-anton@khirnov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [/izKSJYv/cLDKaAztApLaS/mVXvj5PWU] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9f042fb-3565-45cf-ce43-08da49015a2b x-ms-traffictypediagnostic: CH0P223MB0235:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aj/+7NZXnIpMbvBvwk5TcGljTmqs9vHU/8X/b7kLyBKZhYmjIJA+C/UxXy1V6cuEV453bFSAT5NOlR5YIEGgKeaLPZwqN1wBuVTghXpGX9SqbOJFXj+fncx1PrsLXkfgnBcQU0JdQtBhWOCzAnoDCUmHK9eMY75YPCHyNREgozoWcgoYXfcyXYBIid0X/A5xLMoacG8Gelp5iociTlCakk4rOJPICPZLSirwFZGHcchk7sjBXZoAH+1Agfq8WHs5ktXfGxTHszMgF2gv9UvuE5KsgxSMAPeB8xPDqGisdFw5usuiT5TbewT1Hv2g2xDkKD2+gBrW+rrVmA/dD7ZHr2vtJyjO8mi8gOzy5FkYqAdDI8VKtNBnTl5FtI2ias+hKLK/X64UQuHHAJM3acXnGZe91N6z23hPQFxwREXayyzKg3V9TkDSPtNySZWWdjkbPS5Jc9MRzADqYyMbW/T8kCiqQts3vlJTAudPVsQzubis7OIgLpVh+3MRGO5CFYrXNXRT7TvVMvOik7JnfhStaMXRPhLgdpTjiaeXgWkygzDi+Ha7YGMI1C12yf3cAR/lIdQz5asaEgX7AOIGQWubog== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UW11VDZxZVVwMVBUR2lPa0JzRFkyZE9yMEZIUUFLbkhERkJ1NkwrTUNlTWxu?= =?utf-8?B?bVE3ZU9MVXpheFRCMHF1WVlsWllQNkhDRzNoaE1qTHM4RUVwOTNpQmJrSUYw?= =?utf-8?B?MHIzMXJyNjBHaG1EVlkwR21tRGFUa3hGOEhkWEQrSmVGVkdnUmxPeHVpWm4x?= =?utf-8?B?b1FDdnl1QytlczU2ZjZncTlhUUswQ3liWS8vUVJOQlcwQTI2cEwxSU5Kbnov?= =?utf-8?B?NUxvWWczMkpSTWF0VHRlNTVnMjloK2dydEVzUUw2dDV0cHFlWisxbmhPLy9Q?= =?utf-8?B?eStZU1o1SlJPZHZreG5ocnZXQzBQdlBPRkNRckVmRnZTS3k2NUJncS93Qkhv?= =?utf-8?B?bVNKVUJSMUtvdllROUJXVStBK3JGdmx0OFlDOFVSVTRvVHg4anArTytjcjdG?= =?utf-8?B?WUhLRlh6OTJZMHNBUWl4Mmw3NWZWaGgwaVVHOFpiZ0o1ZXFSUFY2T21NRCtS?= =?utf-8?B?Q0hUUFBQKzloWDM1aks5RXU3TFVWQzl1cXBCY21uSXJYcVEvbHk2bFY3blN0?= =?utf-8?B?blNMZ3p1eVJWNFpHSmJoQlV6RVJDdTl4Ym12d2JUOTVuZXloUnpVNjJyQ2ow?= =?utf-8?B?R1gvWWVFQlRidGY1ZEF1NUc2Z1NNV3RFcXVmUzZrdkErWE9Zc2d2NnB5QlVk?= =?utf-8?B?aEJJU25GQXIvMnRrcjlVcFFkbEdESjRwbDJ3MU9LMVRwZnZBNVU3WUdPWjNT?= =?utf-8?B?VkkvTjNmd0svTmZTZlRLV3VlMWFxTkJkSlNGUFhRTlZjamwvaVBjeWZvRUtm?= =?utf-8?B?NjBQUjU5YnJTZVdFcmZlcHJ2WElqWFovMWJBRXlQZ1dnSUZRRFdzUGZMZUpU?= =?utf-8?B?MzZBaFIwZ01JV1hUUUkzRWJDYnpoUENQM3ZPTjBSUjU3bjlKY0pmN1F0YnpH?= =?utf-8?B?ekw5K2dkdFJXUWxhNnBuNnFoMFZYekdrNnNHMTNRZzQ2cWo2NDRyOHVsN0wv?= =?utf-8?B?RHJDdHNHUkM3T1p1NVV1dXJkQlU1alo1T1NJM1JpSXhwV2VGSE1xeGhIMjFS?= =?utf-8?B?UlM3MkE2d3VzNjMrWjdkaVlabDlUekFiM0xWOEVYeW9MenNWVXRrd0hXcWVQ?= =?utf-8?B?M2Q4STc3dzFiejVmMlA4MGkzeDBiTkZ1U3lNRXlFU0wzOHlxQmVzemtXQWpZ?= =?utf-8?B?dVhESlpybzYycllFUFpOMVRFdytxeUxCTm5DNjNPWjNsekpEUnFUZEZuanZK?= =?utf-8?B?NkRXaDgvV0NPME9Hem4rNkx0em9wK3QxOExtd3hWMzBGbkVvZVprK3NjK1ZC?= =?utf-8?B?KzRydVdyajUycVNjaHV4UkttcVJyWk94WWpuTGVhN1FSSEtvYisyRHlYNWk0?= =?utf-8?B?MzJHRGNHYWNQMzVTOFZaSFRVelhCY0kxMnVucFZrYnVVaGN0TWpVOEhWY0FV?= =?utf-8?B?MXRLNFNLdDFJYjRpK1hNS2VEaThESjBPdkNEVHhFUGlsWjgvcEtuNFNFWEZJ?= =?utf-8?B?ZlJKMmhtRWpad2Z2TEhpWktsbjBGeUcwVndzWW9tVFBKSUZHeU12cm56VmJl?= =?utf-8?B?b3NkWmUrcnlWLzMzbU1PdkEzNkppZmZzVjRNbFpUNWUrSWxqZEhxSlRBbEFF?= =?utf-8?B?Mm15ZytrbDhaWG1WalM2MVIxNjdLLzhJRzlzVFFRbzJPVHd0Z0F2dXdoODd5?= =?utf-8?B?dG04YlJHakpMNEpIWTl4SlExUHRQRzVDYXE0Z3VwaFNING9CVXY2a2lQc1JE?= =?utf-8?B?V095NTRRNWEzNWkwRGNvbEtJWnY1UFFoV0IvR0VpSnZOdVd0NUZYdHR5VEtD?= =?utf-8?B?RXNlZ2VrTEViajF1STRWZmN1bU1pNTh4aVdSTHJrZVMxSHdaMEpWWmxoZktn?= =?utf-8?B?T09QdDlBM29IRllGblhER2VoMXBESE9tODJJRzlKOVhYMWlNNDhac2UwbTBl?= =?utf-8?B?VEFjVTVPWExCclU2NXlZYkltY2Z0WXc3UnlrV0xHUUE0Qy9FRitnb1VKczE0?= =?utf-8?Q?C149Y+ZOMOk=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a9f042fb-3565-45cf-ce43-08da49015a2b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 03:45:38.2650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0235 Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Wednesday, June 8, 2022 5:19 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain > attachments to AV_CODEC_ID_TEXT > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Tuesday, June 7, 2022 1:59 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain > > attachments to AV_CODEC_ID_TEXT > > > > There is no reason to think that an attachment will contain text > > subtitles. In addition attachments are exported in extradata, so the > > AV_CODEC_ID_TEXT decoder would not do anything useful with it anyway. > > --- > > libavformat/matroskadec.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > > index de73f97aca..cd30b5f7a4 100644 > > --- a/libavformat/matroskadec.c > > +++ b/libavformat/matroskadec.c > > @@ -806,7 +806,6 @@ static const CodecMime mkv_image_mime_tags[] = { > > }; > > > > static const CodecMime mkv_mime_tags[] = { > > - {"text/plain" , AV_CODEC_ID_TEXT}, > > {"application/x-truetype-font", AV_CODEC_ID_TTF}, > > {"application/x-font" , AV_CODEC_ID_TTF}, > > {"application/vnd.ms-opentype", AV_CODEC_ID_OTF}, > > -- > > > Thank you for trying to find a solution for the ffprobe error. > > With this patch, text attachments are no longer shown as "text" > but as "none" and ffprobe outputs a warning: > > Stream #0:9: Attachment: none > Metadata: > filename : ..... > mimetype : text/plain > Unsupported codec with id 0 for input stream 9 > > > Regards, > sw > > _______________________________________________ You might allow me the question whether we can be sure that this is the only case which is subject to the regression? Besides from what I reported above (and you might probably come up with a new codec ID for discriminating text subs vs. text attachments), this surely fixes the specific case I reported, but I wonder whether other cases could exist? (it's meant to be a normal question - I just don't know) Here's another thought that might be worth consideration: What turned this from a minor into a major issue (from my pov), is that it is causing ffprobe to fail and exit with error and incomplete output. What I'm wondering about in this context, is whether it even has to be like that? I mean, an unknown codec doesn't cause ffprobe to error-exit, does it need to do so when avcodec_open2() returns error? I would find that behavior ok and consistent when the same would happen when running ffmpeg (ffprobe fails <=> ffmpeg fails). But ffmpeg doesn't fail (unless you use the stream), so does ffprobe even need to fail in these cases? Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".