From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0DAFF4C72E for <ffmpegdev@gitmailbox.com>; Wed, 9 Apr 2025 07:51:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9866E689887; Wed, 9 Apr 2025 10:51:01 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2109.outbound.protection.outlook.com [40.92.23.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E9818687D7C for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 10:50:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cPwuaQjXtv2rQxMjR3/Ets/0dI5SPBpxWqWZvH/9QSNwJXLpIH45BK3OWacpTUoE4b8DozCFSdPnKipTHBqVa8j0kNIH3kBAuKdmmTjU6peFju3J7Iq92P9MTbhFytt/ar+l29FrpKXpm4uKkcGFbVeLmpL15AvQD3n2Ess3P0MARWbFMOT2lEt5DYuJmu8uiA3pJPRj0nwzqH0JOr7pl+O90rewcJpKdkiguJIk80b149o6dK1sFYd7u4Cq+qdVAXBXvfDZJpIwLoqeF74PhoClZLXdFQDUiEV7SIzdKx5LphEj3IfajxCR5ixva9NxMs5thumk+M//Oj7FJLgLDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9uPWDFPlu6VGzUIyhTazuNNyHgu2WFkA99b0wuwXULM=; b=pPNhAswoGgXOkJ2B4vzsLwwf8/IHNlz99qmKty9lHnGNX4xJxlizAZpkx3n3tYwmGkYdp9KMjUg0diWPvu4hIArURt0nR6b4ZmlmFQxruHneo1iLKaV0vnDGlbVYzf3oiTzDFF7T1/m71Ftk1zNwjJZaYHz/0BFNth/iBn7MFNpDOqkihe51ka7X4RF2SaTwdtIjROyjuj5RRlZZM5L+bCC/kWBmbSdFnUQA/3KZJD6psnSzX2wq5WpKVi0K5VTKC+i4tGvmJN5W0C/YXDlUeXh1aIYaFkqFzPAZ0FQnN6z65bK2J/vFCvpCYD5wEc7R5a1iwob+LZvbtJ8sCQtZnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uPWDFPlu6VGzUIyhTazuNNyHgu2WFkA99b0wuwXULM=; b=SZpcvRnSCX8ManCl+LalLAZyjFH/du+lKbN0YraKA6+CX76bZzJiPF65XJZGuVXkFwXvOfu5I2fQmlFj7EcWuvjr5aN9k8DLo/PIrp/3O/bji1DYUy8HnyLqEtX4V7M9uwUkgjTdGDM665VT+oS71vokpykrOiAN5PWCv9J2Cojefis9LBiW+kktZd+ta/cuO3TbDuhAbdMfHl/DzEJbfTmNDrDSm6eDB5deWL/+0RU1rmfYKS3vpUvXq72CX1jKsymB8fivmmksUKW1oWk7MPDr/4eZP/gWmiKz79dJVquL9icBjpVNqAH7qfYDoJWgosbp3LzjP3QuubULQWzUnw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM3PPF1370451E1.NAMP223.PROD.OUTLOOK.COM (2603:10b6:f:fc00::b89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Wed, 9 Apr 2025 07:50:51 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8606.033; Wed, 9 Apr 2025 07:50:51 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH v7 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES Thread-Index: AQHbqRP3Hl8zXZNrakSwTK3ordZ2NrOa75KAgAACzmA= Date: Wed, 9 Apr 2025 07:50:51 +0000 Message-ID: <DM8P223MB036538197C52ADA9679F9895BAB42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.59.v6.ffstaging.FFmpeg.1741858241.ffmpegagent@gmail.com> <pull.59.v7.ffstaging.FFmpeg.1744178102.ffmpegagent@gmail.com> <6c2d6f1e97d4809275afc9c82486f7b9f9807156.1744178102.git.ffmpegagent@gmail.com> <GV1P250MB0737112FAE6531CCD0D282928FB42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> In-Reply-To: <GV1P250MB0737112FAE6531CCD0D282928FB42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DM3PPF1370451E1:EE_ x-ms-office365-filtering-correlation-id: fd2a5293-dc74-4e8a-e8db-08dd773b3fee x-microsoft-antispam: BCL:0; ARA:14566002|7092599003|8062599003|8060799006|15080799006|461199028|19110799003|440099028|3412199025|10035399004|13041999003|102099032|41001999003; x-microsoft-antispam-message-info: =?us-ascii?Q?QxHXdDqRwzzXnCiWeYBJQoF9Esw4roAPnX6WbIHFvHdWIkrap/GvMw5/0gIt?= =?us-ascii?Q?XHLAIQ5dOSQvr4V9fbtM8CPGt4VikCMsBfWjdP5O07L+pIfwuXx/uHJ2/76q?= =?us-ascii?Q?s0leEOsbj0cX3OwA8vkxTOpz9hJvv5ixtPYaHuMaFlzOwjgjEtD8ZlGmi+Ym?= =?us-ascii?Q?irGXBxN2fVAD1Nf0AlQQTWesXwq/1C4MBMXtYGbwsUpYb/GWhnFDuztM6l5C?= =?us-ascii?Q?hTr6AyBZSjmT5s1cI1aa8nDxxG0ukoKnwE5od+xMP2KaENn7X+MJBNQR9G4E?= =?us-ascii?Q?xR6d4Q2DwCH5dz8ii06SEJbEBi88SZcz/EbWKytsY+sVFSsFBJpWerYLh91w?= =?us-ascii?Q?fQOt77pwhuBOSNLeyLESqLtemn1rZUXBxen//jTSRocg0N5mNwN07d1bO/G0?= =?us-ascii?Q?RNgOOJaMmD+ojnmxzkYFoq0IQrO2DITzkEc91HDUxor7hCl4cn/tlh6+ZbmK?= =?us-ascii?Q?IwXXlmNQv1EL0jFlsy2y9DrH403By8VQ6rowMyffk3OS0+3H6QLHGWGqg5Dm?= =?us-ascii?Q?KJH+kBXYlt8UeR90ukRau1fMd3LS9VVdJQyxLbaNKX1+LNyZZX5pGRKVdSpG?= =?us-ascii?Q?TbqN/Um8pB2c0U+Eh0cuunjzeR4ZCDVFLahZSwMZzOdMlZ7gOzMeyY9Fu4n6?= =?us-ascii?Q?3hXJGwbt773G45DnUnujaJlGct80M8765Tl/aZrROOJqiBnwCwhvy/JvipKV?= =?us-ascii?Q?xuidMJBUbnb4U2HXXwDOruywXJRdOaQlcjEumkCOXc5+OMY/f7k10ng1tss+?= =?us-ascii?Q?xHVHHKKqgnYto3lgm7/HzmH7rMcf4T2u+TrGzje43ITvlAcMT4wHQ0IvsrwI?= =?us-ascii?Q?EL82PyB3ZqZuvyk1lRbyOyGxro/k0etzfjslrxxHuLawkUmUSVATFZNwixVz?= =?us-ascii?Q?JiHyKPbcoCynJak3MzQXSdYwDPCdfAdlIixAv1qjkAKiMue1Vgl263c56Ha0?= =?us-ascii?Q?uSKKd2yDswVR/BHW/eihZZauRROSdBpywH6forx1tq+ns6pm5UryuRNot6vm?= =?us-ascii?Q?//ZjVkaa2NHRsKYHfj7k5CdoGpp2x7GRyRaYBXzG2Ke5y1wKNZbBauMlFmk/?= =?us-ascii?Q?KEILBknmHSHmaUrY/SZXUA+P+0UQnJYNnHdlQEitY3az7dLzQyqpwn+X6/2D?= =?us-ascii?Q?xEf9BFRNEndV99E6r0I9YOuvphJbnmXTA4yf8PI0ITY15q2+vUjkfBD5Tppu?= =?us-ascii?Q?ufIT85b726I0S1rsMuLMgDpJkddZjNtSTQNWfe0jsq354pf4Emu0pFMRPPA?= =?us-ascii?Q?=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Jmr3f1Bl9fzvvZRoLHJv4zyvStzzT9cDUkQjyfOZB5PaBgb0ezj3XZUKLpQ?= =?us-ascii?Q?fhbXsh6sRXQzaGnE30rjPI4wDId/mZ+s6UNnO8OvRnkWcQoWH71mC0411CaX?= =?us-ascii?Q?WWuP0VxfTWc4vCTdAzg83kzkPQn7rofONIidXJmpjLh+g1zYHhbgVSpmYs41?= =?us-ascii?Q?2qSxU+jxfK+VhbndWotkWTukwfRkNOdf/Fjh4L93ZUq37XrtPJCYVTRY4e+h?= =?us-ascii?Q?olFjqeReGhRblMpYV0pH6LMdcCD1CnHPMWVwf85hOczZG13qcq/Enw7Yfcbp?= =?us-ascii?Q?3glRBOx4mY9/+rAYmJ1Zaxj3jhDuxT4cLOM1NOOjH/CkOSIUGGCStvEUX1lg?= =?us-ascii?Q?V/D4Nzjyc97J/fyACZFZN++QpGI2M/JOyzmxN0dMiXyJT3WybFVk1gogGVdi?= =?us-ascii?Q?JojZKfAdy1Yp8U+uXzDkcxbiz7Nwm2h0BOWZfj1sQteaFr3UYYbRQV1TvDtd?= =?us-ascii?Q?kkb+f4evM9AHrPJaFEcouOweTX3qhXONzZS0ZdbWpZNZLyYRcxNuVVs8F5Gi?= =?us-ascii?Q?mYJLm2+x7G4+AVxdefO3afyUb6dyrjxlOPyk+hsVATGrnZSGUwsjIwbOnwjM?= =?us-ascii?Q?9JwHAcZ6IXL14TRV6X5iUJM77OiOF8iHrdkT2TT360G9YV3UuwYoZ7F1dFab?= =?us-ascii?Q?d/Kb4vOMFQaiNapklRXGcnTwezDjV1mJ3Hot+ZONPZhGhuV/dR4pC7/3qwFp?= =?us-ascii?Q?sDitmHYABiBr4KkftNeBa1yLWRF+W570LHvWiHEieAY+HU4bRIJYYkWEPwAH?= =?us-ascii?Q?+uAtpQPkRIyMAVHZX4GFrswJNX0l11agV4a8VQyCAD8antp9wSwZtk4Zh2ds?= =?us-ascii?Q?y5ZUl7mRIq4IOV4OIEJoS6VSE9moR6V13XwxXhWby3DbqlOtjfX/Lv55Evj5?= =?us-ascii?Q?p4CkO+QuCbwN+J7NCBDjg8vVJtz0utAxwa9+kGvtvhk5ZcLnzMJaKSoqVtMI?= =?us-ascii?Q?ervZ8m+xMwnhggmWwMJO/TYRBJhgI17FZfOU1j7zVNX4vGQaxKTJnLZCar1+?= =?us-ascii?Q?QfPMwQukO2c+mhZEopFVGymxWshFa3BTqOGU6S9aLMCHhnMPhL3b88EeYNeY?= =?us-ascii?Q?6AQ7D9QPDswx9oB6OAKJqjsZQP65sIDBqARXsg1LJ6q0ibiPUm212MIdILc6?= =?us-ascii?Q?gR3Z6l9hNBD+BV7PLbD2GgPxo6GAExDN7n//C4RNoe01Oiig+AEUwi5w8pTW?= =?us-ascii?Q?TPqITYtQendZSZomfE/vpeni/9R8LYxkBHlnf0xyo1Ex6jK68+LH8jy5KMs?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fd2a5293-dc74-4e8a-e8db-08dd773b3fee X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2025 07:50:51.5673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF1370451E1 Subject: Re: [FFmpeg-devel] [PATCH v7 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB036538197C52ADA9679F9895BAB42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 9. April 2025 09:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v7 1/3] avutil/log: Add log flag > AV_LOG_PRINT_MEMADDRESSES > > softworkz: > > From: softworkz <softworkz@hotmail.com> > > > > which is controls prefix formatting. With this flag set, the prefix is > > printed including the memory address, otherwise it is omitted. > > In libavutil, the flag is set by default, retaining the previous > > behavior. fftools remove the flag as default. > > The implementation of this flag is counter to the usual one: It is > enabled by default, but every av_log_set_flags() that does not set > AV_LOG_PRINT_MEMADDRESSES implicitly disables printing memory addresses. Hi Andreas, thanks for looking at the patchset. The intention is that memadress printing is enabled by default for library use of avutil (so that there's no change in behavior) but not for fftools (following the suggestion from Marton). For fftools, the default is to _not_ print memory addresses _unless_ a user specifies something like: ./ffmpeg -v +memaddresses ..... > This means that it will affect users that do not opt into this. I don't > think this is intended Yes, it is. > or that the new system makes sense. Do you think it would make more sense to negate the flag semantic? > AV_LOG_PRINT_MEMADDRESS seems better given that every av_log() will > likely only print one memaddress. It can be more than a single address per log line since it also prints the parent's memory address in case it specifies parent_log_context_offset. see: https://github.com/ffstaging/FFmpeg/blob/02eda84bf2fcf0db7793872204b0f564a6557232/libavutil/log.c#L329-L337 Also, thanks a lot for the other hints! sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".