From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused includes, fix declaration
Date: Mon, 2 Jun 2025 01:42:42 +0000
Message-ID: <DM8P223MB036537EFAB86AA137E75F39FBA62A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250602012828.GB29660@pb2>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Montag, 2. Juni 2025 03:28
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused
> includes, fix declaration
>
> Hi softworkz
>
> On Sat, May 31, 2025 at 03:58:44AM +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > fftools/resources/resman.c | 7 +++----
> > fftools/resources/resman.h | 10 +---------
> > 2 files changed, 4 insertions(+), 13 deletions(-)
>
> seems to breaks build
>
> fftools/resources/resman.c:60:8: error: unknown type name ‘AVMutex’
> 60 | static AVMutex mutex = AV_MUTEX_INITIALIZER;
> | ^~~~~~~
> fftools/resources/resman.c:60:24: error: ‘AV_MUTEX_INITIALIZER’ undeclared
> here (not in a function)
> 60 | static AVMutex mutex = AV_MUTEX_INITIALIZER;
> | ^~~~~~~~~~~~~~~~~~~~
> fftools/resources/resman.c: In function ‘get_resman_context’:
> fftools/resources/resman.c:123:5: error: implicit declaration of function
> ‘ff_mutex_lock’ [-Werror=implicit-function-declaration]
> 123 | ff_mutex_lock(&mutex);
> | ^~~~~~~~~~~~~
> fftools/resources/resman.c:138:5: error: implicit declaration of function
> ‘ff_mutex_unlock’ [-Werror=implicit-function-declaration]
> 138 | ff_mutex_unlock(&mutex);
> | ^~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make: *** [ffbuild/common.mak:81: fftools/resources/resman.o] Error 1
> make: *** Waiting for unfinished jobs....
>
>
> [...]
> --
Thanks!
Seems it got broken due to changes in master. On submission,
all builds were successful:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/4d7af186ce9f8a8d3b12cdc2c979ea54320eed96.1748663925.git.ffmpegagent@gmail.com/
Will post an update.
Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-02 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 1:50 [FFmpeg-devel] [PATCH 0/2] fftools/resman: remove redundant includes, use inflate loop ffmpegagent
2025-05-31 1:50 ` [FFmpeg-devel] [PATCH 1/2] fftools/resman: remove unused includes, fix declaration softworkz
2025-05-31 1:50 ` [FFmpeg-devel] [PATCH 2/2] fftools/resman: use inflate loop with increasing buffer size softworkz
2025-05-31 2:38 ` Kieran Kunhya via ffmpeg-devel
2025-05-31 2:45 ` softworkz .
2025-05-31 3:57 ` softworkz .
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 0/2] fftools/resman: remove redundant includes, use inflate loop ffmpegagent
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 1/2] fftools/resman: remove unused includes, fix declaration softworkz
2025-06-02 1:28 ` Michael Niedermayer
2025-06-02 1:42 ` softworkz . [this message]
2025-06-02 3:28 ` softworkz .
2025-05-31 3:58 ` [FFmpeg-devel] [PATCH v2 2/2] fftools/resman: uncompress to actual-size memory buffers softworkz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB036537EFAB86AA137E75F39FBA62A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git