Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: Zhao Zhili <quinkblack@foxmail.com>,
	FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell
Date: Mon, 12 May 2025 17:04:01 +0000
Message-ID: <DM8P223MB0365362275164C0CD4DAFF5BBA97A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <tencent_4970FD2D419A29404B9AF69F42ABE44ED108@qq.com>



> -----Original Message-----
> From: Zhao Zhili <quinkblack@foxmail.com>
> Sent: Montag, 12. Mai 2025 18:53
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: softworkz <softworkz@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when
> running in MSYS2 shell
> 
> 
> 
> > On May 12, 2025, at 17:59, softworkz <ffmpegagent@gmail.com> wrote:
> >
> > From: softworkz <softworkz@hotmail.com>
> >
> > MSYS2 considers the colon (:) as path separator (=separating multiple
> > paths) and thinks it needs to convert it to a Windows
> > path separator (;).
> >
> > Setting the MSYS2_ARG_CONV_EXCL environment variable
> > keeps MSYS2 from doing this replacement.
> 
> Doesn’t work for me.
> 
> The test failed if when set
> 
> —samples=/home/quink/ffmpeg-fate-sample
> 
> but success when set
> 
> —samples=D:/bin/msys/home/quink/ffmpeg-fate-sample

Another case that this patch fixes is

—samples=../fate-suite

> Other test case don’t have this issue.

Because no other test uses the concat: protocol.

> With a single input,
> msys can convert the unix path to Windows path before pass
> to ffmpeg, but failed for concat.

The problem is the colon behind concat, which it considers to 
be a separator and hence changes it to a semicolon.
When the samples-path starts with a slash, it might behave 
differently again, no sure.

I'll add a note to the commit message, explaining which cases 
it fixes.

Thanks,
sw


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-05-12 17:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12  9:59 [FFmpeg-devel] [PATCH 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2 ffmpegagent
2025-05-12  9:59 ` [FFmpeg-devel] [PATCH 1/3] tests/fate: Fix subtitle fate tests on Windows softworkz
2025-05-12  9:59 ` [FFmpeg-devel] [PATCH 2/3] tests/source-check: Fix make inclusion-guard check EOL-agnostic softworkz
2025-05-12  9:59 ` [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell softworkz
2025-05-12 16:53   ` Zhao Zhili
2025-05-12 17:04     ` softworkz . [this message]
2025-05-12 17:24       ` Zhao Zhili
2025-05-12 17:52         ` softworkz .
2025-05-13 14:23 ` [FFmpeg-devel] [PATCH v2 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2 ffmpegagent
2025-05-13 14:23   ` [FFmpeg-devel] [PATCH v2 1/3] tests/fate: Fix subtitle fate tests on Windows softworkz
2025-05-13 14:23   ` [FFmpeg-devel] [PATCH v2 2/3] tests/source-check: Fix make inclusion-guard check EOL-agnostic softworkz
2025-05-22 10:41     ` Andreas Rheinhardt
2025-05-22 11:12       ` softworkz .
2025-05-22 11:20         ` softworkz .
2025-05-13 14:23   ` [FFmpeg-devel] [PATCH v2 3/3] tests/hevc: Fix concat input when running in MSYS2 shell softworkz
2025-05-22  2:55   ` [FFmpeg-devel] [PATCH v2 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2 softworkz .
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH " Kacper Michajlow
2025-06-16 23:05   ` softworkz .
2025-06-17  0:59     ` Kacper Michajlow
2025-06-17  1:46       ` softworkz .
2025-06-17 13:18         ` Kacper Michajlow
2025-06-17 13:49           ` softworkz .

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8P223MB0365362275164C0CD4DAFF5BBA97A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
    --to=softworkz-at-hotmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=quinkblack@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git