From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1743342B2C for ; Sun, 15 May 2022 20:32:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C049568B4E0; Sun, 15 May 2022 23:31:57 +0300 (EEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2040.outbound.protection.outlook.com [40.92.41.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC42568B331 for ; Sun, 15 May 2022 23:31:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jmF5cu7r9w/ijnlMDbPUbya2mCwNmk4AyeBwp7Rfp/5txG/X7Fvf9eOVMulZx16DHKmf+GYySdnJ++UUJ378ElUgRnjOme+79qy7UwUbdq1oE9ZHYKSpX2za0ZyfhHGFhZXRJCcU4rerU9yzPwN6jYeduzmww6S52bchMmbykSsKO8upC9wzf5I24llyixK0CI4EtHsECRW6lagctIZMrMeR90iY+sFFKBs9sdaYSywKYgq9pubhFf/D0BzrJoiEMl5cdUv1AeIHU3IS/Cpv7A7nZrJtLk8nkuAndan9CMbOdjUdXLy8nXhTvHCYOa/krK5l5EY2dIx/DCFjzY/iqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bt/Wfs2AOUAzTwsHUImUfqwYXoS2rsCPQd2IDTidDCk=; b=PUnymE2zbXcA9W0n3XEgDSbtMkzuDf0yMvUqHY6yw/ltWYjobO3Tb92XajdRfCrG+Y9aDtA0aAcOVbBU+oQZITEZr4Y5fW0EPjYyRNqm/kgdLSW5rAuEtJ73uizDtnPGoebiR9Twif5Mn5X/n7qDqePdgejQ1e15KTa6EdflQIWB0AbQ5/w184LHdK3DaXmAiGVl2SafNnhwXHjj2vjZA/ebnmTlBCs9b37cCFhb1nD4Of0aeIOOsiQjjqAPG4w60TJpauDmHj4f5UafgdgXHI/XbUHJojoqbwJ14+FWtwjiuTmqUnXxh5Uq6dVozXcw/XUVf9J2aBKoGbTeFTOw2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bt/Wfs2AOUAzTwsHUImUfqwYXoS2rsCPQd2IDTidDCk=; b=qyJVJ1mULP2wuNRYEJHMGX03IoGyhPQUSLMRPArOJD3XYJ2kqbYbMFtZMmnT7n4qNI9ccyP7LLduj//bE98IOEaigqfkJl6vZWLIHNlfa5NaY4+7xQwXTr8nxWg6JfdelVGCUZHC59OBTuH/iHxxRgIt3T6CFQr01a9MMxAge2bRkw2D9t7JxFeiMzYQcNbqGmfEUByw+J4ZS92/HpMFLxq5/qxGweOSGU9JpxlPWRxk0+xYDFSPqRD+vfL2U+pfjPlvXcUY9jRf6oLC0RkHIslSHEzfwlAnE8/U9VP8uKuHtGZIahJfX3J25Ve1LxY/Fbj/SDeK4K0sfkz2E22QZA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0215.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:15e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Sun, 15 May 2022 20:31:48 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc%3]) with mapi id 15.20.5250.018; Sun, 15 May 2022 20:31:48 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 0/2] Support long file names on Windows Thread-Index: AQHYZq9FcZRkimOO002XIt8dMDhw6K0gWL2AgAANtIA= Date: Sun, 15 May 2022 20:31:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [mXEeHe788imwz4C5m/kpYb4xbrnpT7kD] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 291e2796-9c31-4612-5135-08da36b1efbe x-ms-traffictypediagnostic: BN0P223MB0215:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4JfVPDkBHebABktzGtxqNq2jUixQLJr/emp49S3+0E0S8JU2B+eLjMHHph0j5dOh9ShbJ0JQXawFZH0IET+kd0IZxPAAjtR6jx7e38f0EKLI/6M1kiTUoAvX9YGK7V8aDQqUHUUgcvF9x0VCcR/oRycJYsSAEBJ/u687GKS7LsOTLAVSty75GQQ1MEs7fdihnOHtxwPrk4ZBpH2NEMm8n/8eGxtDv2zEkf1e53S+14QBt4HD5A2YRs2aU3ujIQL/Rueefr0VfEIr9ulJdVdsvPepS8mFgyfe3cL9AZ4Wwd3wQ8rrivkx0GiKEI8jxY3DRJ756sDMASiAzDGDjgADrdBGByxEseX+DsQzr/xD7z/YQ3JWlLyNMbx1GKrEH3ONecrDrqdd1yviLoo2SEPmoo7RHfPPhe0K10bPQ0sh4TWe9FY7lhcZYL7qy24lv8bhFhnzZ2qKewVY8z/pr9CYQg+0xkKXqkAWdxVOUt0QYNdRq8fsN18Ser4nJ0yBJEd1R+JVZvQjh+cftASr5Lj3WOg2ZpqyABxqsc/7UuSa5miaCxICLuVQMksbQbdfdXedZzQGHrCNakNmkFq1AV5gt7jTLrrg8cXIwsaqYZ2I6F8S5XnMiw2beoI6sG+1fQEJLQXICg+lM+uF4+NsujsAKseTuz9Io2eNVzYmdbRL3mc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YWxhQy9SZlRJVTljNjRaVkVpZnE1c1ZHY0dWODQ5c3BVUjI2MnFlNkwyQmJ1?= =?utf-8?B?TTRPTGhKdUU3cGRvdzhzQzJNbEhkZjgrd0l4bjV4ZzlvMDk1a0gzRU1MandH?= =?utf-8?B?YlNSajQyTUE5aVEwOG1YK3hhaUpDUnJGa0l5aGhFYkh2dnJWc2NZQ0tPZ29o?= =?utf-8?B?KzNhektLWDQxVFJhdXJwcG9kMU5MSjlJZ2RrbVp4c2FOWS96eHFENEVGeGt2?= =?utf-8?B?TDVzWlJtaGFVSW9hZTRkTGtwMmRPUHlIMnAwRGVNRXhxMHA1d3pLVjQ2Skd3?= =?utf-8?B?Ync2d250V3lsWnV6Nm9aWUErSkpmamtmZ1pEdi9TR1B3WXhMN21LaGZEY0ZD?= =?utf-8?B?WFpOcjJvNFlMTFNPdm1NRTNOQ1FrdUlpbkxTNkFLenBwVzg2OVFQRkJQSHBU?= =?utf-8?B?c0JLcG16V1hNTk1HaTFFYWkwRWdzMjMwQk8wRHg0aVhTR1FmOTZIN3RBSU12?= =?utf-8?B?U1ZVRzBEMzFUTlZrOXJ4M0U3RTh1bEZrRmd1bGxXcEtTbTFRSHhpbENyNkRX?= =?utf-8?B?Uy9lU21jcHNERkZVUWhFUkh6MEV6Y2RzcElqUUpCY1pNVGhHc3ZpU2NhVDFU?= =?utf-8?B?amJ1cnZxRGRlRmhZR0RrZ1RtTEhOYitBSzQ1VTRWclNLd1BQNTNsMFJ5eFdJ?= =?utf-8?B?dXJMdnRWMVJTVmowNE9KRTNBeDBlM1UrYVdldXRGbzZIQkltVW05aDN3YTZL?= =?utf-8?B?ZkN3WWxySytDMjdOM3JzemZ1Y3dRK3hPMDJFcDlKcXMrWmZlMnI5SkhnR0xY?= =?utf-8?B?WUtxOUI3aE9oV2VPRngyYjhDUXNLemhPZXd1QVVxQlljUG9yUnJ4dDVvQzZh?= =?utf-8?B?ZU9udG5QcXI3N3dteGE5dGpoa0lEVW1IKzBINkhNcGo4d0lxUkNWL1JKeWlM?= =?utf-8?B?T1lXeUxVZXpZQ05yd08xRHhtSS9ieFc0Zk9DR0l0YXg4cytrcnh2Wi9nbzVV?= =?utf-8?B?Z3ZKSUp6bmhaZU9aS0l6RnkraTArNHR5ZzZFaFl6c2FwdkdaODFMSFNIYlNE?= =?utf-8?B?WHR6VThIZ1FJS2d6S05mRklUOVZSeTNmZTVET0NUamd1UnNsWlgzS0oxdVFR?= =?utf-8?B?dHY1ZDRsQUNGVnExTnBKRlJqbWhYQmFDUTY3dXVVRndsTHJITHJualgvVC9v?= =?utf-8?B?TFgvMkc4RXlWc0Fhc3BFZXJrT1UrSkVCdmdvY0ZaVHhCQVYvVm5OWXRIUlcy?= =?utf-8?B?SExpWm9HdWdXSHA4cmgvZWllMHpwcy9CUDJLdlBHaFVKRnZTYitheDZQUzdF?= =?utf-8?B?R3dnOTYvS3FpUFQya0FWSnh1MWJIQTlIZkxVbGQrd3Vkblh5eWl5UlkwNFg3?= =?utf-8?B?bkp1b3ZiQWR5cnlHV095YlRDc2Y5TGprYUdjelBva0RuUmw1R3VQVlBQMHpi?= =?utf-8?B?QVVwdExENEsrbDd4N053RnRjOE8ydmdYQTh5QnFDUytOWDRYbEhRbFJzUUlT?= =?utf-8?B?UHZ1WVNFT0ZCTlFQTzNzR2dKMzJ3TUswRUYzbnpaVklVRW9BZWt5SkNvRU5i?= =?utf-8?B?SWQ4cUZsYjZ4NEhTME1vSXBYM2FsMGM5RS9mZ2RkSCs3dE5jdXkxTm5kbXVn?= =?utf-8?B?Y2NpYksrK2xNckpPQnhoTHNUM2VzY0FNQVB3dE5CaS9VN25GVEV3cXU3blR5?= =?utf-8?B?OC9Ja0NhVC9icWRQUkhWbjU5WlVxbE5sSWlsK1N5VWhLVTBXZXMxQ0I2QjZm?= =?utf-8?B?ektwbVE5c2RUaDNmK2JmenFIRzY3RXUyUVVXRlNmdjZEclRWWExkamVhVEZC?= =?utf-8?B?ZHZCWEZSNW9ObEd3SFY1L0VCakk2bFJ3Nm05WEZSeE11UFY1QTVkM1RZOE1t?= =?utf-8?B?bU1SRWk2RlVIcnNaeXNROTRNMlNjbFV6SjdNZk9BUkJyaTV6L2FoVEJBMmRx?= =?utf-8?B?L20vM0t2QnVJK1pCdUk2a1cvdmkxN3Vvd0lQbDRFODBTaWZoN0h4dG9JVnE0?= =?utf-8?Q?qx/FynXGUCI=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 291e2796-9c31-4612-5135-08da36b1efbe X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2022 20:31:48.5529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0215 Subject: Re: [FFmpeg-devel] [PATCH 0/2] Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of nil- > admirari@mailo.com > Sent: Sunday, May 15, 2022 9:36 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 0/2] Support long file names on > Windows > > > I have kept the individual functions separate on purpose, to make it > easy to > > compare with the .NET impl. (compilers should inlinie those anyway) > > Calling add_extended_prefix without pre-validation results in error, > since it does check for \\?\, \\.\, or \??\; only it's wrapper > get_extended_win32_path does. > And it's not private, it's in the header. > path_normalize is a do nothing function. > > Keeping the comments about where the code originated from may be > useful. > Copying the structure of .NET results in problems. I can squash them together if that would be a common desire. > These patches are very difficult to review. E.g. stat is not covered: > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296448.html. I'll look into stat in a moment. > > Parts of FFmpeg still use fopen instead of av_fopen_utf8. Some of > these uses are > in examples or tests or inside #ifdef DEBUG blocks. > Others aren't: dvdsubdec.c:620 uses fopen and it is not covered by > your > previous patchset https://ffmpeg.org/pipermail/ffmpeg-devel/2022- > May/296189.html. I have left those out by intention because they are pending removal and are only for debugging. Thanks again, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".