From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0CB0143499 for ; Mon, 13 Jun 2022 19:02:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 402DE68B515; Mon, 13 Jun 2022 22:02:12 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2108.outbound.protection.outlook.com [40.92.19.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 53B6B68A56F for ; Mon, 13 Jun 2022 22:02:05 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F32cqWa7coJ5T24RcEsebWU0bzU7bFSDj9m5pMtbb/Xj4pcckv9xmniM/ktovmuRVsi7O88xjj2vIq3Ap/nTft4cSRpheQui1W/pYVT4LyQcb/jZKOoaT3YeYejkrDt3tDgFY+E4KiB2zo+lCuI8raVnHZcwehRnrLzPAqT2JaGEIXYPOsaOI3f9cPM0bmXNI7jI2Vgx9gjjrmnoYwSi2PjHILJjCg5/JSwLJUg6LEWT82unn4J4uY3rFEIa7bZ1U02tjxIQ+uYUHvCIJz4nTD9wdeE+pAKoDTDeZz/NWAfNhTlzFzN3P0HqeWiJ/mmHkBKOI6wo6N0cPGUIetaTHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=loIN5YyFTMqzeHNRlKq1YtRUq1R7QsuEnW0QLtHZsJU=; b=nUB6JJXoQEmnuWRccE+lBWXH0Fcf6jaYfiui0VoDDWxwoenltDaK+/cO8OITFFpIMmVPjyKU5eKQ2o06akejgrTkFLj2MN5nfh1UemwperdKhBFXiei0pt4ADcUkMtQglkT7EhcdzmotqLJD5rJFIOXuyko1cSvlG6+jd/LKQWjGItV9xcpKyS8DEJOe25J8l5ctriCFePkMu9JY0w235AlOyBEb10NRWHIAJIq6ehOw36VLN+BRJtWHt1aRceZbtNzBqaeaHqGhJn1CDCdImuwUllLI5+erg0nc89GSCcUWnLkkBIdG9Nz4t93im/LoEedgMZZ2D6LGgmeRG6do1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=loIN5YyFTMqzeHNRlKq1YtRUq1R7QsuEnW0QLtHZsJU=; b=jcV173VC2gwQNHWYbwwuDCtboivMg615ThLrzpVtAvlyiODmeAlN8hmmMt5ytAu2LfcZBiOXpdpal9et/zeSnBFYQmnW2T+RP2bUevsPWPZlU1QOaIHEIRAYAC88ICgZO+juIKuF+njZL8RPWEuuhQPxg+vBtWgLBW5hKYvrWk2VboCpA/uAykyLvxInzSu1mLVLkmWUDEd+IVWcRBUfGltOcpxIUWtZqN/VPcRlNZSmPTv3Od7TOG+mZSVTU23ijII11nG0vbFEL6zVY2KaVLRAso5Spke+qiUV5dTKtQVsyM7M1LOi3w6w8K2shpxxjel139tLX9tqBoKdJxWUuQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ1P223MB0409.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:48c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.18; Mon, 13 Jun 2022 19:02:02 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%9]) with mapi id 15.20.5332.021; Mon, 13 Jun 2022 19:02:02 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Thread-Index: AQHYf0Jr6qpkXsE9T0+yfFq1DsaMA61NiPYAgAAHfACAACDlEA== Date: Mon, 13 Jun 2022 19:02:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [L6sMTAsZckHulujvhuNDtkf981kmWHgi] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af609eaa-b9f9-4b07-5e66-08da4d6f339b x-ms-traffictypediagnostic: SJ1P223MB0409:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9pT9XcDeRd+r2l2KB5dt6CNQYZwd0WKe/UoHtrhOMQVg2DLeT24bRP7YM16HvPEW0ByfvjZ2b7BjojXGsH8DkqlDcuec8sY0PwZksoYvOLyHNibOlHGXaIm+ontYgUq5l6arWmXJ+fhADoQT7YSW4SSgNen8mq8x1kQWsUj07BJX7DAAeAYms6zXBpuyo87Mz2QH1jz3RDMdLzo2EM5plRvpgw4e0emG2Rpp9OtHocb7DeYiKmSoPUcabLZlRG9mKfXc2mQovBUbwZSohbTi0MnZhFO7STYOfrz1xPyLPLUS7UxVR0sc8i+SC1kuOuUEyyg0gqw2IoQnLUnVn8UTrieiUeNg94tVvDcXC5GpcSJPgbXgFzASmUK+6Nta4HYWMK8rMou+DuEpY5VKndoODlKTFDFrZP9uv7pLrTOcAFkWOmamcKaWNlWdyPX5yfUvmOk9PBsfzDn52kC2mdPDsQYkM/93RlgsUM+5R00DkLkcZathVO9cxV3UNt0KVngftrW9/qfP7lpPOGeMyDj0zwde0kKp7KCoYq5oIIU7XwB3wOqwMgl6ERRFhYmChADogcTJnE7SLpiFqKnYX6FykdABlLDFqUeQkbvvyRCgdnGww3XidUDBp3T6Casb69g9/V0w0rXB4eIqQFmUvny49Uu0/77gsgE7igjG9A6ksCA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cFlTR1JMZFZMQzkzNTRZVWFLUDZuaEJ3SXhzajRJZy8wQ1lNNnlES0MvcTJZ?= =?utf-8?B?NFVqZEIxMVJvdGRnMFNOR0F4T3VNWGxoM1NMbW5Ic0p0eUZvT3BpclNPcnZR?= =?utf-8?B?cjNtb05panl2TXhQd3lqbG5YRWlKRjNkcHVHMEtEQ2lmeXJlNTgrRE5vNnZq?= =?utf-8?B?d3FZWll3aytNcklwWDhQaUVXcXhSc3Rnc2lyd1R0WWdiREJvVzhXdndkUTRL?= =?utf-8?B?SnI4cktaZk5aaU9WR1FneVBCZDMzazB4TEIwSjJKcmtDL0FBVDdnOHFKZDcx?= =?utf-8?B?ZXNYd0FoSEVaR0ZobmFoWk9ld2J3clNjSjgvMGhFdUt2Z3BlczB6bTYyR3Zr?= =?utf-8?B?bWljQlJxVUl0VlFnSkdFcXFSQXFtQjFZY1dkSzdSZXV0QjU2eWZ2TGEzVW9Y?= =?utf-8?B?WDFiMEo4bk9Wdlp3VVdVcWpsS0M5WEVVSmFQN3NYMGM4M1BYOFl4V3ozQnZ2?= =?utf-8?B?ciszMTNPK25HRjczOHdPRGVVdUx0RlRFZUsybE5BWFoyQ09USVAwbzVaUXJo?= =?utf-8?B?WGNlSHpzcjNBTjBaSTRsWXdpWXBVRW5OK3krOWFjc3hpcm0zTHdaazd2Nmpa?= =?utf-8?B?Wm9YM3NOZUhTMnA1bDlJclpSTHQ5anlmUlBGdGVQNzkzKzlYeWY3VlQ5TUJo?= =?utf-8?B?R1VyODlMeFdNRHFJU0FTcFY0SWhLcGd1cEM1Z0dMNW9QVHdhR0hPb21Yb2Ru?= =?utf-8?B?SmpNNE41eWo2blVwbGJMRno0bllMTGRITEtDU3B0L0FlU2wvbkJackZMQTNL?= =?utf-8?B?WDlzZFpTWmJwekZ6anNBSVRjcGFBNnluaTBQV21FUTRQZENoYm5FaW9qRlUx?= =?utf-8?B?ZTUxYUVtczF6QnNTZ2txMUliaklJQkp1ckNXS01XTlFYNWROUXlnSnlackFC?= =?utf-8?B?SnNGclV6NVZnU2x5by9yektPZ2w0SDkrb29seEFZTXpZeDFIamNLOURSdVVY?= =?utf-8?B?d2hKWTF5VXZocm16QjhieWNtRDU1S1BPT3pDb0VYQS9sL3hRVVRrZnpTOU43?= =?utf-8?B?Z2JxNVdsWE5jcDViY0FtNGxwNmx1cmdIN1d1akRDTnhMN2wrNGlXNG1sRzBO?= =?utf-8?B?aWhxWjkxUk5PeXhyaE9uT0cwZTRsREJMQXloS3FPaVZEM3VGSTNQRVd0bDlF?= =?utf-8?B?WE9oS0d4ZUk3bEdWRTJBYXBMUVRSeUtYZ3RsV1RRNVlINmt1dFpLaDhINS8z?= =?utf-8?B?OUhPWmZHOW9vdlBzVzh3UFB2bU9ESXdJOFdPUmVacis0QXBoK1BmR2tSZTAz?= =?utf-8?B?SlF6M1V5b1U5dDh5RGVPVjVWZlBlb2sxWTVDOUptbHFNbVNkYWNXOEtUcnli?= =?utf-8?B?cGxKcVlDVzZKVXl6QVY0M0M4bEtHQ00wMi9GMTMyaExReTRDcVc0aEdidHlq?= =?utf-8?B?RkROL3VkMzV3dWpHOXVoRWc4OTZWZkRqclA1VG8ybkd5MG1zckRuUEVYdFEv?= =?utf-8?B?VEJyWFVEUmZZNW1QYUJzSUdDTTh2NzhLUWJ1OHl4akErcGFWa05WNk5XVExD?= =?utf-8?B?R2NpUXMvRmRpY1lQM3NDMFk4d1FRMmNsZHFTUms5Wk8xUHBIUy83YktxT0VS?= =?utf-8?B?MDc0MWZ2a0dpaHJSbEVZSW4rTkdqaGZHaVVEMElDMVRmMWh4VU9OcWdFUjBI?= =?utf-8?B?VDdHVXF3MFVvQ3ppVDRJb3oyYzFrakFYMXRlN0VWai9TUUN5cnBxVEtYdVVy?= =?utf-8?B?elZKeThERXNNQTRGZmNabUhFSWFudjlib2FhTndHYjBqRE44TVBKQzZKZkN5?= =?utf-8?B?NFlod0d4ZHpIc0dKOXlBM2Y3MDZ2UnpjUGw1OWhNdWNNcDVSU05KVnlPVDJj?= =?utf-8?B?RmtiRnZQZWg1Qy9ER2NBejJnY1ZadGlCTDBtblZKYTcrdUlBRXBnV1dFdFFs?= =?utf-8?B?aUZ4QUlnVmQ4MlFpVlZ0UEZJRVUveGh2aXhhL2FFdUhaQ2x5ZWNDK29jc1lF?= =?utf-8?Q?GVTobmOkhhc=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: af609eaa-b9f9-4b07-5e66-08da4d6f339b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2022 19:02:02.8719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1P223MB0409 Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > nil-admirari@mailo.com > Sent: Monday, June 13, 2022 7:03 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove > MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW > > > Why do you use a 'do' loop? Can't you use the normal 2-step > > approach, i.e. call the winapi function with a NULL buffer, > > and then use the returned size to allocate the buffer. > > This way you always need a single allocation only. > > GetModuleFileNameW does not follow this convention: > https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf- > libloaderapi-getmodulefilenamew > > > If the length of the path exceeds the size that the nSize parameter > specifies, > > the function succeeds and the string is truncated to nSize > characters > > including the terminating null character. > > MS does the looping too in their WIL library: > https://github.com/microsoft/wil/blob/master/include/wil/win32_helper > s.h#L339-L341. Yes, you're right in this case; hadn't looked it up. Thanks for the pointers. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".