From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 80DC54C5B4 for ; Fri, 7 Feb 2025 14:20:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B0FA868BA9E; Fri, 7 Feb 2025 16:20:07 +0200 (EET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11olkn2047.outbound.protection.outlook.com [40.92.18.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49D5468AE9D for ; Fri, 7 Feb 2025 16:20:01 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jAguAfHQIDuXvtOkO7P1bhQ+Mk6woqOAxzR9FczOnJBLVsRaSZ44/8q6bk6jHq/u8w+Xb05WcwDH7g6u8BkvnxgiqyAO7Gc/sYguf49fYble9x2qCnLJsn/3O+2gSJzezFr24+IhHeCzOzhm1xC6HgvSKJtUzeaFJP6UNAFsb5etNb/Usf4TMOVkfdNcSoC7gc+2bBsLug4NZbLVKp9ky26U6lFZ48KdFy5ZhojzKf/k496+8QVzX4k5pJMlxH+yGlCSJKn8TOVJOtNOftHVTQeAY4d68/c2GFOJX6dEunF8+DlRLWYyg9DKEYAZMyfYqg9l9yrvQe7V9CTdqbRmNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoLwqVoxcxHJPL+J3j1jvOtODFwsrvbM6QlpmWsAKdo=; b=CmfyG330cVCGmpGAaTQosdC+VTcZTUOae2S/a5gijkZV2cebQKZBv+aJp8AjhkqOiK9AneH+ibIzwXZMKJ/rufPYurYRCkQocSiLxjtYJ8HULEj5XYsvNLlaxJGPxF3yfLSrexyTxBsegkW2veaqJDCIgTVIwz2WuWP+OjMoa/FuJgkpShZ/X7fPN6jWw5KIoTTLFHFJ0fzkjziTussKHXbK3YDDqMhbqcouglZY6zcZUaCokIPrudPgsgeL8Qt5EMEbUh+K7huJms0voW7R/CumBNo+9eEq4pW5CxVQaQucKkuicjVcTGTegUe8NnzbFJIP645IVb7ehHJWLmcJPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BoLwqVoxcxHJPL+J3j1jvOtODFwsrvbM6QlpmWsAKdo=; b=l8yUs858sB/xW1EfuvRz1CIwjKV81NifwbtIPE+DHddzGFEh6yG1QruVCEfbuWxMNemb8mgvVnS4koMpZ7IkG3fmB6OQWK7IHdygK0sLAjR7iBNC+V9sR8Xo1/qSyd0i2tC7pXuWK5H2o2f/yr521KAm0+SxSySXSK7HicZ+eWdTmW5I8df7phrqv28lE8tmrqpaddJ1LdE0Lu12+tdG1HWd3gAynDlLNfc2FjhYIFtUI/usB2coOEhTY9vfM2Q6st9pZfkvrpmDOHNPLk10mRkh9nkBGsyfpCM7hriQxC7T9zjGS7c6SGWJaQuUCLumnoz+cTlyrio0P8kzph95iw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ0P223MB0686.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:47c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Fri, 7 Feb 2025 14:19:57 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8422.011; Fri, 7 Feb 2025 14:19:57 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags Thread-Index: AQHbeTXwerC42Ouy1kiVtWD9N2hrjrM7p4EAgAAHkUCAACUIgIAAC+2g Date: Fri, 7 Feb 2025 14:19:57 +0000 Message-ID: References: <63ab3a941166604541ce91cc37137edef4cbac93.1738915048.git.ffmpegagent@gmail.com> <2bd0c238-546d-4cb2-8778-e9d6f658fa3a@noa-archive.com> <6d7c527b-b834-4c08-9d16-90e033f28f45@noa-archive.com> In-Reply-To: <6d7c527b-b834-4c08-9d16-90e033f28f45@noa-archive.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0686:EE_ x-ms-office365-filtering-correlation-id: 44720cfb-4d3b-4cad-4830-08dd4782800b x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|461199028|7092599003|19110799003|8060799006|15080799006|102099032|1602099012|4302099013|3412199025|440099028|10035399004; x-microsoft-antispam-message-info: =?utf-8?B?MXljVEdjbGFYUTJreFN0eUNJQzAyVmdFdEFxeU42UDFjdFF6UmZLcmVQcWxp?= =?utf-8?B?Um11V2xoU1I5NWs3bnF6d3Y4a2ttbFNKUUxqUnNYVmNBbUg3LzIycFQ4TnV2?= =?utf-8?B?SVE1c0JVY2psVVJkZEtEd2RMSlB6bklWRFlUUGJUK015ZC9kZDJJdzloOWNH?= =?utf-8?B?WUE5RVRHTEVZeWp5LzdsUVdLMVJkUmkxQUhBQXh2enVNMGZyaGpZTmJRMVZQ?= =?utf-8?B?WG1tK1k5TnpSd2FrT0xmeEYxZDU2dUhIdmVvWXFEaGc2cUMzam9wK29TZjR1?= =?utf-8?B?Mkl3YVg2c2FQNDE3aWNCRXdIdm9nMll0eHBPaTFTcW5UeUZDQVlqanBRc0FF?= =?utf-8?B?S0dkRmVBdXp6MjFuaEJpRlNyOXl2N3k0RGFpM0NOb1pqRTAzQ2RBNUI5U1BI?= =?utf-8?B?MnZtcTFjRW13MWRrMm1UVHJhaTlCWmEzZkNEbmthNTcxd0gyZ01BVzNyZHVz?= =?utf-8?B?cjcxWHVFVjIyZVV2RzhjazhYcThpV2xGK2RKQTFIRUNuWWFmaEFuZnBpeG5Q?= =?utf-8?B?N0hRUEI4aWJtZ01QSWppdVZEdVd0aVQycElhaGo5RmQzMDcycXhZWDhQdElk?= =?utf-8?B?TkxFaEVPMkVqcTkwRWJMeW1ENmlZVTlBVW5jUjVnd2F2Ymo4UURNRzd1WG9z?= =?utf-8?B?YmlMeFdDL3EwcHAxY2x0ZWUzajNiQlZiWjI5Rmdja1dKZ2lLOFZuNlJmd1Mr?= =?utf-8?B?dlVFbnl2V2ZhOFhiMGlMc2ZhaWpNRG5FOUFjQis2cjNKRGZWeERmeTQ1R2tS?= =?utf-8?B?dW9XSW40RklaeW1HSkp4QktKOW9ZK2JzWWxUcU5YM0ZLTVYvNWQ4aERqNVY5?= =?utf-8?B?ZFIrSys1WHRDZ0VpRThtdVFrOTA3ZUx0M3lkbDRJU0ZURUlGQ1lsVERxSHdv?= =?utf-8?B?dHZWdHl4YW5NSC91TWNNYUxIeU1KZEZPTC9nT21MNVY2UGJVS2FvcTBocGF6?= =?utf-8?B?cG95WTI3K0lFbncyVXNrOFZxWHg1cG5jSzJZQXB5eE9nbS9EdlRncUtIM1lF?= =?utf-8?B?OVM4OG9mbkZLUTAvUUVnNjF4NGJ5UTVvUCs4U1VuZ2FYVHBQNXhPOEhGSDlO?= =?utf-8?B?NS9DWU5tWlNCTWU3VXBSSnhjejJ0dGtXTlVJaWZFUnc2VmIrU3RlN3BSK3JW?= =?utf-8?B?QlVaVXozeVh2Rm1LTkRjU3VOR3BWMjBGc0hvcXEzeTdEVUUvK0NCTzdQckhI?= =?utf-8?B?WEV1cFNIeUF6d3I5ZFdGZkdoSGtVUC96QXRiT0p0NXN5bEo5TURtd2pJWWhY?= =?utf-8?B?R0w5TDFZZXRoNW9jYkozQStUZTB1aXN2OENTSk1XRHRoQ0NJdGVwd1lkVHl0?= =?utf-8?B?MXUxSWJ6dkE2R3VXRCtsVDVyUkUwSWw4Q240L0c4NFFReW9sdEJvbStvMlhT?= =?utf-8?B?VVBuakJSVWZ6b21nR0h3elZhSFVGZDRFNkFBdDRHNktlQ0xJNzkwSkhhSHBT?= =?utf-8?B?MStRSXQxMGluZzBvZkRKQkhpYUpPaTQ2ZlBsWXNPRnczbWRXNGNlSnN4bUw0?= =?utf-8?B?OE5qZHhhM3pIRjBXaGNiMUlZWjlXU3J1SDcwNm50QVRpUkNYQ2RlSmp2VWs5?= =?utf-8?Q?sUvihSDgUrN0MCHssxVR/ht1Xrwm8egimAN6CGPQamy4y0?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXFuN3VNOXRWYy9Jb2gzK3NOcEF4d2tVNGEzN3RSQmxPazQzaVRGOUcvcjNr?= =?utf-8?B?SWF6ZC9DM0tlV3cwVW5PNDE2YVo1a2ZCd3pXVE5ocGhpeVZkNFB4bFFsaEcx?= =?utf-8?B?S25tREJjeEJSaURpa242NHNmMGZNM1V5R3pVZTZwVEovRWNpb1paOFhabHpF?= =?utf-8?B?bTkwRUlCajZ4TDFtSU1iT24zbHVOR0ZEZ1pqMWQvcTJudEpwaFllR3MzMlRM?= =?utf-8?B?Z1BDRnNGQURmb05JOFR6YWFGZVFQS092Wnd6RXVGNHNkaUxlQjZ3amR4Zmg3?= =?utf-8?B?eERHaS85YWY0WEkyeE41MXI1aU14Yy9sQnpudUZnRENvYVJzWUNKNkduTWh6?= =?utf-8?B?VjZTK2VzUnRLVVhDOXVGV0JvTmVNcmdUekhoTHJpc201d1NxVzc4U1ZsNWF2?= =?utf-8?B?KzM5QVZaVGJ3dDRhTnJrSWZ4RXBLV1JyRlNiaU9hR2xEUEtUZVlWVkhqd0xt?= =?utf-8?B?RjZOYXJrcndSa25uUTdOekZ4Ykh0QytreU1GeFdpNE1ZZE5DSEl5T3V0cHhG?= =?utf-8?B?eVhhdmd0M3NkVlRFQmFoUUcwbFpyZXNvMUF5djh6RDJoaEhNY3p5d2RtYzFw?= =?utf-8?B?SStJQUt5SEVHZFFkQnd4L0hJZ3hESXd4WCtuVmlQenlMM2RCWk0zUlc3TzZG?= =?utf-8?B?aUQzekVob0xnMTVVcVB2bmF5NWlTdHEwN2VHYmcrdm1BRDNHOFJQcEVGbHJp?= =?utf-8?B?VEFyeklPSWhCLzZDRnNMSHBkaEhtbThBV2JvVlJSRER6VHBMZHlWR1p3cDda?= =?utf-8?B?MjNCbVFiTWsrN2w4Q1Y1OS9qLzhra0RmK3RSdnBuSzZFbWV4UTJpNDFvUEh2?= =?utf-8?B?SUdybkxyRDVtS3RraG91Z2M5SmRnLzAzbjJJa1FPdWtySEFEUE0wTkJhWEJ6?= =?utf-8?B?b2N6aTVFcHVSL3BFd3FpTzJaRnR3KzI3OHAyUjdzSVNRSEJZYWpJendFRnd0?= =?utf-8?B?K21ZQi9rblVWU0tkTnNNQXVFS3VIWmhnRS93NUhmRnBVSUsyeStKT2Z1NDVr?= =?utf-8?B?NFh3OHpRL0ZBOHRZNi9xd0l4UDVTZ05ubTE0RXpWQU1KUlM0eTdKdFEzai9Z?= =?utf-8?B?TDNwK1RCNFVrQlZVT2tiSEhEWHhUQVJwM2hsaVhSQWhmdHgzY1BJdVE1VVBE?= =?utf-8?B?dWtsVXZ2RmxCNGlNOXRaQlFDb2dSYlJTd2ttNnZ6RDRibGtwMUxCbEUvNnJ1?= =?utf-8?B?SHdPWVVVZHV3YkFna2ZoNC9KaDdGVzZCSGUyQWs0U1k5MmsvRWllamVrSm41?= =?utf-8?B?bDcvaHErQ3c2Z3ZPSzFoRWRFREhmRk9GVkxQMVo4RVQvcVhLYTJ0dXNXNVFL?= =?utf-8?B?eTZ2ZXVNeHNZZUZsRGpLVVd3RHBOTVJWdVgrOGkwb05ESXRiTTd4Y2U1NnZZ?= =?utf-8?B?Nk5za3ZMeVcyOXVQVlpQQkpES0F0bStneXFkTGNDQW9RdmdtRnF6UWE4ODY3?= =?utf-8?B?cENFbU5yRHJhS3lJMVFzVzh2bHpHMDlQbStoNGZYQ1l6ZUZFaUQ4MytOVXl4?= =?utf-8?B?aEhmOXowRldaZUhzYys1RndKTXB0cjQ2ZEdUOVJJMHpSS21IMmswOGJnWmxt?= =?utf-8?B?ZzNNUDZrSFE5c3h0WXZXOVl3czNrZjdwbmhZUFkvbFhRK0Nkc0paYVcwSCtL?= =?utf-8?Q?jtKRGT76XGlOsZ5zDU0hIfCwH7FdvAjJp2t8kOBCv1oE=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 44720cfb-4d3b-4cad-4830-08dd4782800b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2025 14:19:57.5662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0686 Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Friday, February 7, 2025 2:22 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > On 07/02/2025 12:27, Soft Works wrote: > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> Tobias Rapp > >> Sent: Friday, February 7, 2025 11:42 AM > >> To:ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > >> time and datetime log flags > >> > >> On 07/02/2025 08:57, softworkz wrote: > >> > >>> From: softworkz > >>> > >>> This commit adds two logging flags: 'time' and 'datetime'. > >>> > >>> Usage: > >>> > >>> ffmpeg -loglevel +time > >>> > >>> or > >>> > >>> ffmpeg -loglevel +datetime > >>> > >>> Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents > >>> timing to be printed when exiting. > >>> > >>> Signed-off-by: softworkz > >>> --- > >>> fftools/ffmpeg.c | 1 + > >>> fftools/opt_common.c | 12 ++++++++++++ > >>> 2 files changed, 13 insertions(+) > >>> > >>> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > >>> index dc321fb4a2..f4c717afaa 100644 > >>> --- a/fftools/ffmpeg.c > >>> +++ b/fftools/ffmpeg.c > >>> @@ -130,6 +130,7 @@ static void term_exit_sigsafe(void) > >>> > >>> void term_exit(void) > >>> { > >>> + av_log_set_flags(0); > >>> av_log(NULL, AV_LOG_QUIET, "%s", ""); > >>> term_exit_sigsafe(); > >>> } > >> If I understand the purpose of AV_LOG_QUIET correctly the correct > way > >> would be to skip writing time/datetime information in the log > writer > >> itself (part of patch #1 in this patch-set) if level is <= > >> AV_LOG_QUIET, > >> rather than clearing the flags here. > >> > >> Regards, > >> Tobias > > > > Hi Tobias, > > > > my understanding of AV_LOG_QUIET would be that when program code > logs a message with that level, it will be printed even when the user > has "-loglevel quiet". > > I would wonder why such log messages shouldn't be prefixed with the > time (normally). > > To me it appears that the special case is rather the log invocation > on exit which prints - well: nothing. > > > > I'd rather question why it is not printing the log level for quiet. > Is it really intended or was it only done to make it possible to > print this empty message on exit? > > > > Do I see it wrong? Then I'll change it of course. > > > > Thanks a lot for reviewing! > > > > sw > > The documentation for AV_LOG_QUIET in log.h says "Print no output" This is the user-facing definition. When a user configures quiet, it means that ffmpeg prints no output. But on the side of the code, specifying AV_LOG_QUIET doesn't mean "print no output" but the opposite ("print it, no matter what!"). > from grepping through code it seems the implementation matches that > definition. The purpose of av_log(NULL, AV_LOG_QUIET, "%s", "") is > described with the AV_LOG_SKIP_REPEATED flag, see > https://ffmpeg.org/doxygen/trunk/group__lavu__log.html#ga6cdf5cd331b1 > 7e80e8308124f05a6db8 Hm, not sure whether this has been the original purpose of AV_LOG_QUIET. And one could argue that consumers of avutil might use this log level for printing non-empty messages. That's what the snippet above would have preserved working. But the quirky part has already happened (not introducing av_log_flush() or something), so - as a whole - it can't be easily remedied anyway. > So I suggest to just add a "(level > AV_LOG_QUIET)" clause to the > added > lines in forma_line(), similar to how it is done with the loglevel > prefix in that function some lines below: > > if (*print_prefix && (level > AV_LOG_QUIET) && (flags & > (AV_LOG_PRINT_TIME | AV_LOG_PRINT_DATETIME))) > format_date_now(&part[4], flags & AV_LOG_PRINT_DATETIME); Fine. Done for the next version, thank you very much! sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".