From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 458454483B for ; Thu, 27 Oct 2022 19:05:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E40468BC3E; Thu, 27 Oct 2022 22:05:52 +0300 (EEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2010.outbound.protection.outlook.com [40.92.20.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4234B68B5E6 for ; Thu, 27 Oct 2022 22:05:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=er1TdrzSWQN0GX40gUuA40K8Y2rq3zB5O6FLff2r1hdyqi0Mt09mAF04olgV2fViJOcwhebboJkhpW0VYWUj7A2oAo0vSxqJzxmGs/aaBbSLJs3XuzT+nlBs/1a9luU9e9JlnwbG3BiiNU8ngl9+RdSq36Y6IhEqklj/jaYkue7mAwtD8Hy3tpz5p1vopDY/McPtpY64T+R9JAE2mxNBDT8kfzjnOP4ver2dNu0Cu/rLe/yCPJ0xbSDa0r5lGbIc9zOq8z2mL5YKTToUsmEIpfpQkSEdNfFhzCb82Ems8Zg1EDI7lexBhoynbPAK4mSz9Yficdmj2Vqb7A6Ezghg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCFpbzk+pzAF/F1qXt2TO4MHhNwfhFP/9Nztl6CCx0I=; b=YAEHV/TVOrGbhI30nEnkcpvuRbjYKzaJEP/hF9NMX6EFKzih+o6hQPgDGF/11K3Tr+vIOQZ+jwINCfgt0sY5HYTr88cF5GWFNYcGo63AMHEnexFsHZsPKjcfqRkW7bNMXcT6JXEcd9MOAPAjemg2edLcC1XTnZwxkkDaT0uSZPEZkSBuaaCofqbFJ48fxqjPVaO45SZPy+Vl7XOoRXRNWSKmAJczLPaDq2W4t6fq5tthxLVhf/29hxGxHnmd7KBC3ihOQiuiJyX+7hH2WPZSxU5rmzgdOxc0jdLc0dqUrBr70emwgxi3DZ2PNRjSAX+kiWHOXwYRjq0WMr+99LydHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCFpbzk+pzAF/F1qXt2TO4MHhNwfhFP/9Nztl6CCx0I=; b=IitHrSoZxx5j0ifNPItDvteZ32ZqxP7UX90JETYPvPDNLd+muP4Hg5Gqhjy4bohuZzZVJBVbXixmSPRyc0tkeFjmQ96J4McsvTKaLtykZdvNWA0t2FuFD1u2tNsM9Z+qeh3Q/DSqbc0ouypyd255TRSEwMnAs6G2b9vKH1JJ5N/ZzJZcK0i6t/olz3bTDydqHeOty8Q5QxKg54BbTABq4vPqrQeukgfEPlu/fNnfMTw4cUM4lxmWnFkExqILdlWgu2W3q903HSf0+xRW2+YFbesMpgzFrDohs1c6oRLU02usluO7O27wBP5qhLdsYhV7cvzoD0rvseb19N9DJ2egHA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ0P223MB0662.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:47b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 27 Oct 2022 19:05:41 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::4b66:8c2b:d786:9906]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::4b66:8c2b:d786:9906%5]) with mapi id 15.20.5769.014; Thu, 27 Oct 2022 19:05:40 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles: Migrate subtitle encoders to frame-based API Thread-Index: AQHY6FIpTTEY6hPHQk+7h/noOXKbxq4iiX6AgAASn6A= Date: Thu, 27 Oct 2022 19:05:40 +0000 Message-ID: References: <300c14faaa3e95ec6f2785a0099d815264ecc9a7.1666689226.git.ffmpegagent@gmail.com> <20221027175349.GI4048598@pb2> In-Reply-To: <20221027175349.GI4048598@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Z3uhZX5L4p95AOphkpf0VFS/TGMALhsR] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|SJ0P223MB0662:EE_ x-ms-office365-filtering-correlation-id: 0f958363-3920-4f2c-6dca-08dab84e3d76 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rA3yUj8SwedBsfJsMN8FF1e4JbHG0byRY0SXsi/FdNMHvxHbruRdJFClGzeelmcvp89UkA4LeWv1us22imk2GF99OO2n1+9fHk9BXCAaOFitYy3UHAg36ijv/tU6KBmvn0dQMXcWzxXPn638+jDkjVp9W0DttaxcOUGSpXS0H77rX87GJu1zjHFbwURXHj+JlQsyyV6/WcjaLUV+cXZsUgLdH0Fa/gzMnE0A5ALA0xVcXvVD7Rd8wN4NKm+aWy493hi19yw0ECLVumR4j1x+xMspxnNsl5qA7kmnA8qQ4Gn6YJnyXljnUkUKCur/+w/Sr3qSHH1fmMqJB9BFN9TkILOmpXmEsq+3Q1UL3DfHrsxwK6dPxuvokK+5VEG3FPiUvJGPo3acBkqJpalhSeIj6aVEnXJi//O28PDwdtgUzDJHeMZpqoxPNAOVUewONhHU5zoIo98uGXpTsUtxdINoEz2ZiCBya1bvZaNmvQgB8vGQG4lBc60DEZeS/dcWnF98yWK5MWlyxzWDmTR4Eapk8qCvOG16y2jopcSjpzwwthoSlgzJApFwR7oa+DSs+H3BWVBFQeEk/vetDPIjOjdNJ1CS6aH+v01c8atShxzz32ZZuU7CtiwDjAVCTW4Z1VLuEm4Udj46uuz5uC64z8whM2vrC0LFmZ0/lYkK3x7R6SZwdL2fzrF4Y/Vv5ZgP0sqo x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VHdSTXFIMGdJWlFCK3F5dFc5SU9TaGIva1BKK2UzWkNMZWdSeDE1bmpBWUhn?= =?utf-8?B?WVhRNkVaQ2VtTzFiU0toOFh1eFZ1cjdhUHNPS0RNYktMd2prdVRKM09aZGR5?= =?utf-8?B?L3pMQ0ZMdzNva3c4VGRmOWNiYmNZYmhNaUVrUmpZSXVWZUkwRUJqZDMrOVc3?= =?utf-8?B?akJVT2RlUnVMT0g2Njlld2g0V1RZN2o1OHgraGhYcHZVaE04SzFlV2dtUTJi?= =?utf-8?B?L09UdjJkci9YcDFWYXQ3eDBrNlptaWwyTDdSWll6UlJEajlxR3RYR2xOQWNQ?= =?utf-8?B?RjFHcFpJTnE3RFNOUlFBaXJRTGtXNFdBMWFtQ3VTczd1b09yaUJmT0l4N1JZ?= =?utf-8?B?UllUYTZuWE5ISE91b05nRElNOFJRblkydVQ5RUJNV2FYQlFIZkowakVrQm9B?= =?utf-8?B?akd2YmFUVjQ0UDdlWmhneUdDWEhGNjdQcHBodzQxYnVOSnVCWkViRjY0SDMx?= =?utf-8?B?dFdySVExL0VDUDRYYzQ0ajNLekNpWEFjRk1rOWx2QmNSbDRIQUtDSlY5TmhB?= =?utf-8?B?L1FyVklQSzIvVjNZV2hSZTYzVy9FRTBzaERYM0hVVk03UGFXQkpBaDNud1dn?= =?utf-8?B?SStBS05LaHZFc3B2TFRmMExLTEZBWWIvRFZvT0NDOEhmWEsrTXF6cXVKMjZJ?= =?utf-8?B?VEp5NGg4eDNSYkMyN3F5MUNZYXpBS3lvcGg1QnhnUUFuNlNnMzBwV1drckV0?= =?utf-8?B?U1ZLdjhkWWg5SU4wWUdBbFZiV2tDZFlNQktYVldPRlNTWU1LN090V1p6VGov?= =?utf-8?B?c1VlbWcvdUxIT09ZU1lDaVNuV2hXcmR6d3RuRHJqdE95YitSRXhYM3lDTDJP?= =?utf-8?B?eThEZWxrb0RVZW1nQTA2RjJ2Sm1jT2o4a1dEbHlwVXhQL1pHQ1FmTE9IaVAv?= =?utf-8?B?UUhtWVNVMGFrVTdTSVlRSUdacm45d0FaV0crUlNXQ0M0ZHdoQ29ReEZHZG0x?= =?utf-8?B?TFV1V21STnN4NUY2OVlYVU5QMTRlNjkvclBwVUtzSm5NMkF0WkdrSk4vS0ZY?= =?utf-8?B?akdKanFUSUgwYyt1YzlUdFhUSCsyQWNtelpvTDgvOGxySlpBSFNDaktTbzJY?= =?utf-8?B?TUhZUWs1Z2R5NDVCRDdkeUlkaHpXM3hZUkhtRTVVLzd5VFJEQWZLT1grM1R4?= =?utf-8?B?SmY0RnZsTnJiblpWKzFYMU1jSEJwaExaRHlKSVhGOFRZY2M1bHhDWHE5aU5N?= =?utf-8?B?RnF2dHBoWjQ2MEZxRjYvc1U0NEJVeHhEcXdvaDM2SHY3ZmZGa2RTSUdWbXpR?= =?utf-8?B?S1MvbVBvOEZBenV1M0J1a3AvR2ZIam5qeEt2dHZTRFFPSGRuNklQYWUzc0F0?= =?utf-8?B?ZEdsTlV0LzR0RThRc0F1L0trd3JhbU1weTdFRkZ3NkxKWEw0QmtOZVFxbEJp?= =?utf-8?B?TFlYbWl2MUZnS3VmNW8vTGQ3ZzZCQllYTTlkSjl1bVU5VWluUFFzQ0pwWVBQ?= =?utf-8?B?ekhyVDBvTzJoYy9LMHhPMUVLNFcrTVhpbGhVVFdMNjREUDN0RDVCV1IrZUMr?= =?utf-8?B?TlZyeGdjV0JVWWgzaTFxR2N4NHFwVmE5SEFXblVYWUJ2RWRFWDA2VWkvVlJ2?= =?utf-8?B?cUZlRlVrRlQ4MDhLYUtxSnRkdUR4WW9wY2VLZmxTWVNyaGRpelNpU3JYSEVH?= =?utf-8?B?bHcrZHF2SDNhc0JOcVU5M3gyMFQzelZBQVVreXpvYzl5dkNaYVpwZG5Zb3Az?= =?utf-8?B?TW1iMlhkcmxnU3JSajNNN3RpUmZlSmlIdXpHVm1MYy9pRDNtaCs3M1BnPT0=?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0f958363-3920-4f2c-6dca-08dab84e3d76 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 19:05:40.4321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0P223MB0662 Subject: Re: [FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles: Migrate subtitle encoders to frame-based API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Thursday, October 27, 2022 7:54 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles: > Migrate subtitle encoders to frame-based API > > On Tue, Oct 25, 2022 at 09:13:44AM +0000, softworkz wrote: > > From: softworkz > > > > and provide a compatibility shim for the legacy api > > > > Signed-off-by: softworkz > > --- > > libavcodec/assenc.c | 189 ++++++++++++++++++++++++++++++-- > ---- > > libavcodec/avcodec.h | 5 +- > > libavcodec/codec_internal.h | 12 --- > > libavcodec/dvbsubenc.c | 96 ++++++++++-------- > > libavcodec/dvdsubenc.c | 103 ++++++++++++-------- > > libavcodec/encode.c | 61 +++++++++++- > > libavcodec/movtextenc.c | 114 ++++++++++++++++------ > > libavcodec/srtenc.c | 108 ++++++++++++++------- > > libavcodec/tests/avcodec.c | 5 +- > > libavcodec/ttmlenc.c | 101 ++++++++++++++----- > > libavcodec/utils.c | 1 - > > libavcodec/webvttenc.c | 86 +++++++++++----- > > libavcodec/xsubenc.c | 88 ++++++++++------- > > 13 files changed, 689 insertions(+), 280 deletions(-) > > Causes this testcase to fail: > ./ffmpeg -i 'bgc.sub.dub.ogm' -vframes 3 -bitexact -y nosubs.webm > > https://samples.ffmpeg.org/ogg/ > > I did not investgate why or if this a bug or expected. Just reporting > a difference > ive seen Hi Michael, thanks a lot for testing my patchset! I have run the command with and without my patchset and I can confirm that the output is different. Though, from analyzing the output files, it appears that the output with my patchset applied seems "more correct" than the output that ffmpeg is currently creating. The details of the investigation can be found here: https://github.com/softworkz/SubtitleFilteringDemos/issues/2 Thanks again, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".