From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E5A504D921 for ; Thu, 3 Jul 2025 01:08:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D59B968E3ED; Thu, 3 Jul 2025 04:08:22 +0300 (EEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2041.outbound.protection.outlook.com [40.92.47.41]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 096A568E3EE for ; Thu, 3 Jul 2025 04:08:20 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BrtrXmN14glGDLVzA6KD9XaVrQEVXqUtYVIEwflVQiM+GhQnPOK1MfmVe8AYjCwlRD0NAHonB6XVA+ukc1W5e+F36JMDIpPbLYvHuSkDxuAA3ghi9aiMXbJ7bSF8vyoBHJS7hcRdTyeN+MzHNENpbe4FBpIL3wsns6TrmuVX0jI5QHYlykIQYjRvqeFlAfx8OcJY4Rno45rglwBbyO+5ZQbF4jT05xz7BiTKzUFpwabyO61sobZuTDdq/efYb0PaQlli+IURWM7h6iAP4BSp899J5ghG0fjEWsiTGM60O51RYNlVaU9n4ga6q2BmeCyA/1QUEdx168+BGXCZoyckHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gYSHJFKdj/DHVxtpfcqsWg0Nmn2i3vAeSsadgJDiSg=; b=QzFXitCN6WV7YYDapX5EOAMdZ9lUXaq61gdVuf83f5Hm6NCW+2/tv524a/9k2Tu8vgUOoZAqwt9PPPwCCpqeNugSpYFfOFRuoOS7EYeUOAiajx92U160ePhMGG/0mC3YCtRIKUzyGvfvY2lcAdBMmsPktI4mewaHp95OcdE56vTpQ1a87ydERCfNC5J4/DjMVpAqU5p1CGZqRMEZkV3i0Do9qFpXtrUAsvmhVNELimJeuJl4rqNKJzXBj28C7trAUatRoRV2Zr1eQL/N/oEeopmWJKu7KK660ZGuvMvFoBSDMOjNtM7bXgedRZ39lbXQoBPKTNKyJRAXFUXme6HoKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gYSHJFKdj/DHVxtpfcqsWg0Nmn2i3vAeSsadgJDiSg=; b=UdXHlhM6zVmlWrbtylwFPqPAufhcq5JjixTz2H7h2d/injcCNrsu6MCL6yvCKx6sB9Up2+jDiJaTwe8Tv1zQ/R7fZFGq3NLKtVVt63xAhr3sCXi+dxaagqqsLcAXraOUqdJ/h5Q1wVsm9BSIrM9NAqHci7KGfORx5oOmTHxu0QpjX6WovOKJlQsI8pZamOCq2pS2knzQQz4qUlNEW0iRpuVXkVCw3pZACLhlPHJRTxmew8chPYK2iMERcpGXToqc32lR+huyCpPl76rdICK7xDr3C7k7v0+OEviywnylrae/n5HAXFrSmkSanUm2fLFd/eyBZr33Jheb1dVyhdKK5Q== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0308.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:349::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.21; Thu, 3 Jul 2025 01:08:17 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%6]) with mapi id 15.20.8880.034; Thu, 3 Jul 2025 01:08:17 +0000 From: "softworkz ." To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable code in tf_mermaid Thread-Index: AQHb5uH3FkLkHHPgLEGnZX1FkxNP9bQfnjLA Date: Thu, 3 Jul 2025 01:08:17 +0000 Message-ID: References: <20250626213250.8313-1-epirat07@gmail.com> In-Reply-To: <20250626213250.8313-1-epirat07@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|BL3P223MB0308:EE_ x-ms-office365-filtering-correlation-id: cdff07d2-5fa3-4ef0-3d9a-08ddb9ce181a x-microsoft-antispam: BCL:0; ARA:14566002|15080799009|19110799006|7092599006|8060799009|8062599006|461199028|3412199025|440099028|40105399003|10035399007|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?7F0cpV5HGGcZgdDaZz4gatY7067OcVAdUKTDI/B4c/DdbiP/mNtCaI+Ea0kI?= =?us-ascii?Q?4LetffJe5BsTlqrkqNl88Q6cLdHFob/frerMpvUGy7UIx3Dsjzut8Kko52lP?= =?us-ascii?Q?Vo9ef+jYqzhTmB9/6CTXRQVAuzSRoNjFEPAwQUzd3vkPQy631zGWeOlakYP3?= =?us-ascii?Q?ejfgKrgoy5DcMRjGuiLcC1NopDir1YFtpVqTIpnGhBs9S6lHO9gkaC0kmrGk?= =?us-ascii?Q?Ezei69n6J7vnonmXq67nbZcTqzKjlOeC5KYV3R99XIyiNMmuQFvIpjrZhAam?= =?us-ascii?Q?wRBtj+yC4eaRHtB/jt4smvInl97uRCi057AlNGTL2+1qJYyO3SW3RLD7xWF6?= =?us-ascii?Q?VRSRPHNSC90FAaCUhWGRg4+9NuOtI1VwABDyxhJQVvGUv17R3n1YZfMRgwBt?= =?us-ascii?Q?Gz7c5cf1IOEDQ5064Hy+6gqnY+TpEjrrmw1QEVJelKEYrMZJ9NUPp4IsdxzH?= =?us-ascii?Q?AoBurRZQpmIsM1vynjAAaKb71aYQDuXDf3TMIlwB3k8T1SZteKzC8I4OAX/B?= =?us-ascii?Q?p0k2YUvqfD5PWlqPx1nrxVSMwWs5WdsigZ/C3+vQzcnJgYx5jn3NVh756CrC?= =?us-ascii?Q?qMSBrJ5o/LMi+ueK0zRKDxlMOWCGQJGGEVoCBefIJpgX+x3h5JD+yfo3MvZU?= =?us-ascii?Q?g9svd61ahjrwSiZI+WyOJ124AzPIrE+J12bbKJf5XlC/pIGVFJFbCOmV4bOm?= =?us-ascii?Q?VgVlj5vbO6pQBjgJwpB05fibEhVg4ArzjTXQ66/mQTkcOuEl1O+G65jqv5za?= =?us-ascii?Q?9WvUrMXcsbsIzgthRxs65TDG2miAUWhJosUPog4BrWfF5TJbHZHXKoHG1h/t?= =?us-ascii?Q?B3xXYu1SMJYdy/2KE/QAH6ZcilEf2rpVJlt5Cz3RfArzVeDjRB5uewxO0Q4+?= =?us-ascii?Q?QZvjKi3Po/NgV87RLXjrHFFFGy24ftJxIdvRaUZBst/qXYWbJBfBPNRF3ZIo?= =?us-ascii?Q?VIwAMHuCcaxZshMGKYrDfYQKf1iwSG8guBDhy+RCvESTzCA159CYi8QkCPr2?= =?us-ascii?Q?FO84eLVJsjDWkW7bZR7SI+AKLp6anY4ekVu57/COBMB6yRRqkDA52HBudA0W?= =?us-ascii?Q?bVubn1i3sQco/5rRwsp6NICtfB//nwMFzS1Avx74mjg04/nQv878S7aoBqLu?= =?us-ascii?Q?r5baES0JPQtnxeK6cIptjxF1xYfdu2YH8MB4HuuJg5SMoJyt4XCCsWw=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SL+PouPFGKcaTJC4XLX/Dh0pUSbGoV3r/8B5cm45Mg0agTIpHhFjhn+u2fGm?= =?us-ascii?Q?+gYa2Ph6r/yEPrQO0Vvu8o06JQfqxEIVVd02sVAXXKNJzkrpqBAUoUHkW9Wq?= =?us-ascii?Q?vs6s7ASQnAxVRlrofHC7w9mqmS8QPQB9Lzt2angK/8eCuPnOX2oOCGpFQLCz?= =?us-ascii?Q?XdOGWdZtq11v9G9TBXt9LBDdG0AOOPqxylReVJgk8tslwArdTQoHmS80FFZq?= =?us-ascii?Q?qKvGdhJkT3GG4GAGdyGujsC7hKrvkYBV5PqpLwZiXRd1cIezkk8j4QnIV5Hq?= =?us-ascii?Q?3TjpaKhYTJ/gBp/LLxQDUncJ5lKE07fU2UeJX+3wT8k0PL65P6GcsXk3XX6T?= =?us-ascii?Q?qS8rupARPeb3EyhSuC/OswnHbJrf0qOiWQtM1h/ij9zVD6A/KlJRZz8AaIJ4?= =?us-ascii?Q?cbZmfhsnBIdZpkv2JJZuzTUHVH3ST49GRIYOb+7WJQRcSie/MsfmpGoKvTiK?= =?us-ascii?Q?mQtPjZM1j1LbKFEB/a/n9RKUOmIrbhLZpMUBJK7owXEcSs72yAIfipNcqeh0?= =?us-ascii?Q?OVFIEG3mCCbX5A1lb8euQpPYrohy7I6XUT5zTm9J5+WMkkss2mSmRrRiH+Wc?= =?us-ascii?Q?nd9Vq4YvUwPOSYBjGCnjEH9LhyzcRbj8H57Hb6SAO107XMGETQ6dCinXE1GR?= =?us-ascii?Q?GkZyUWYxER0mvgKHGO0ki5if9JSJxIyP3YesAcEvR+MWRI/Zm2y5OTELnunt?= =?us-ascii?Q?woszr7u6+6GL7nhzybVY2Ths3xRstDN8zhK26LX52bAd2tTGMMj03ZQVou4X?= =?us-ascii?Q?/sd6idNd+Wvk5MB1Ydazj/nCOxrcTMzW+QnD0BXnCA9GATVTOMJ6S2hOswEO?= =?us-ascii?Q?+GuvZz1nNu7c01MndvHNc5/v8gNz4hcnYQhsqL6kQTwSLBM4+xjj6xLGgOjt?= =?us-ascii?Q?C1MwMccwETc6icH+dJdAXJGqYFtIT1XH3BI3FE2BBNEgkP9LYlxo1qIru6L6?= =?us-ascii?Q?VYqReyaBTq0E0XF+SpMwoCB+iHVdAD86vLpkpjJgAfM87qRg0EX92MuSkABj?= =?us-ascii?Q?XOcpn6p5wcZHxHpb0/bSbhQg8he5ZGb/+ndBzxQoZRMQPFPocO6lGzct0tE9?= =?us-ascii?Q?vBRAPo4o2SI5xt/evtvIqycE/DsYiN5FxvrGyJrRMC/XpK8WNxeBEQKmFj+e?= =?us-ascii?Q?taCGusiee1PNJaMGsk43xYtvRz0OgP+BP1ZE6tSFFUwBZhVYzjXRCEWTvAUL?= =?us-ascii?Q?cWhK3PA5O5/oYEeKHrmX51jGWoWT0GAHwILVI1SEh7CeoKA5H+lp+psjvT8?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-c7cf3.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: cdff07d2-5fa3-4ef0-3d9a-08ddb9ce181a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2025 01:08:17.5076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0308 Subject: Re: [FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable code in tf_mermaid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Marvin > Scholz > Sent: Donnerstag, 26. Juni 2025 23:33 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable > code in tf_mermaid > > Integer writing is impossible here as the first branch was dead code, > so remove it completely. > > Fix CID 1646948 > --- > fftools/textformat/tf_mermaid.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fftools/textformat/tf_mermaid.c > b/fftools/textformat/tf_mermaid.c > index 3d864c2e3e..6af58d58c2 100644 > --- a/fftools/textformat/tf_mermaid.c > +++ b/fftools/textformat/tf_mermaid.c > @@ -616,10 +616,7 @@ static void mermaid_print_value(AVTextFormatContext > *tfc, const char *key, > > MM_INDENT(); > > - if (is_int) > - writer_printf(tfc, " %s %"PRId64" %s\n", key, > num, col_type); > - else > - writer_printf(tfc, " %s %s %s\n", key, str, > col_type); > + writer_printf(tfc, " %s %s %s\n", key, str, > col_type); > } > break; > } > -- LGTM! Sorry for the late reply. Here's a reference to the reason why it's gotta be like this: https://mermaid.js.org/syntax/entityRelationshipDiagram.html#attributes > The type values must begin with an alphabetic character and may > contain digits, hyphens, underscores, parentheses and square brackets. > The name values follow a similar format For AVTextFormat with ER diagram output, "our key" is the entity attribute type, and "our value" is the attribute name - which cannot start with a numeric digit. That's why we can't print integers in the attributes table of an entity shape. Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".