Re: [FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable code in tf_mermaid

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Marvin
> Scholz
> Sent: Donnerstag, 26. Juni 2025 23:33
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH] fftools/textformat: remove unreachable
> code in tf_mermaid
> 
> Integer writing is impossible here as the first branch was dead code,
> so remove it completely.
> 
> Fix CID 1646948
> ---
>  fftools/textformat/tf_mermaid.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/fftools/textformat/tf_mermaid.c
> b/fftools/textformat/tf_mermaid.c
> index 3d864c2e3e..6af58d58c2 100644
> --- a/fftools/textformat/tf_mermaid.c
> +++ b/fftools/textformat/tf_mermaid.c
> @@ -616,10 +616,7 @@ static void mermaid_print_value(AVTextFormatContext
> *tfc, const char *key,
> 
>                  MM_INDENT();
> 
> -                if (is_int)
> -                    writer_printf(tfc, "    %s %"PRId64" %s\n", key,
> num, col_type);
> -                else
> -                    writer_printf(tfc, "    %s %s %s\n", key, str,
> col_type);
> +                writer_printf(tfc, "    %s %s %s\n", key, str,
> col_type);
>              }
>              break;
>          }
> --

LGTM! Sorry for the late reply.

Here's a reference to the reason why it's gotta be like this:

https://mermaid.js.org/syntax/entityRelationshipDiagram.html#attributes

> The type values must begin with an alphabetic character and may 
> contain digits, hyphens, underscores, parentheses and square brackets.
> The name values follow a similar format

For AVTextFormat with ER diagram output, "our key" is the entity attribute
type, and "our value" is the attribute name - which cannot start with a
numeric digit. That's why we can't print integers in the attributes table
of an entity shape.

Thanks,
sw




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".