From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7032B402E2 for ; Fri, 21 Jan 2022 05:11:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACDDD68B158; Fri, 21 Jan 2022 07:11:14 +0200 (EET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2046.outbound.protection.outlook.com [40.92.20.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 541EA68B158 for ; Fri, 21 Jan 2022 07:11:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fz0zG8l2VyA0Oq5+C7zLCXrDq1SFO55PcXsWuXIpnsfAAMi9ioVR0Uh8WZY5HWHVoISLcibrId4uh2Nt6peMf47zGAEzbIcTSlCHHZJDjeZct7SPfolCEatAXXob2Hlm3LyQBqcuHZiuMiwcQQbvRtp8PCfSzcGQgSXQEr9RRaAp6BVDqzy0y1JsJLNiytSB/Am6eSnvMi5u4KwufKsSqEByaMdEeVErKz6kOHHnoi2ud8e6Dic7teaAbAEQBTWMzkQgKmkmHVbQ+0FyOlXVQ567PzcPjyle2ZKx8oJsv0I0QdHpGSM7XZxTLPv6k8rKsnB1OvXOlNYzl2z/xdZK4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dT2WwDvRm4TNTO+hP2D1XXedM9eoxrRFXwnuBF4lCSg=; b=Q5hXiIt6YzWoc3l3yahcwm3e1qrFjO6i6BN2V0LsOKMKngwp6duT392ze33jPntQNm0AFobpRBkrh1Y2Xl0pH3TUJLfc6yUkJSrPZT0NrOvZuw2HGjThaqD582flDEJgtnIMqq3da1g5q9FuWHRriQ2sG0Ek3RLwlOuQp2VJhopLnGaOPgiI4z/i9Ye06NmBdIGWHONMHs5Y+wua3fwsr0hczyZ4wTh0cnc7qOiGhk04o5tWYX10Y6+TpVv7gjA/h3NuQgY6pQQZIrYk+vOSFCozPrUse42fAur0CZGUW8xVSsCzrMaJUV2x7v0u+62kzSan2gUl3aqcFdgNaOcpng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dT2WwDvRm4TNTO+hP2D1XXedM9eoxrRFXwnuBF4lCSg=; b=LEHi4IemZYBdKHWNCvygO24zOPKDs+VBo9DvvS05vl16qgKW1uUf1Pm5bLyGRER6KdfZ/UIR/nqmLehWYL7K4/vhKDAKgzxfJBd/SwjiksxT8bROicIP5BP0waDbxqpKsPkrATwJejXNRyidXjIF/9AJZVdQfGTxvF1TtL6N0Gf9HAjjcNUskXcoYaqXL0GH+Fy1DPTcG3VDHsesM66jLEupnrKda3Igud1ZNQRDxZelzpPyGY871Jn2zFgAUmODuZzdaXyVWmhXZKnzVROYFLdsPxNGmaIABLqVUqbjbZhT5nYJmvtmgdCo24+PyhXR0832kDwS+PPF7bL4QP5UVw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0381.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Fri, 21 Jan 2022 05:11:05 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%7]) with mapi id 15.20.4909.012; Fri, 21 Jan 2022 05:11:05 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Patchwork FATE Errors Thread-Index: AdgOQNFmFBJsNZyGRJ6OuUpdsVW+VwAAvO0AAAFcPsAAAUbugAAAsjEwAAVfjgAAABZmYAAF878AAABXs0AAAUHdIA== Date: Fri, 21 Jan 2022 05:11:05 +0000 Message-ID: References: <20220121042418.qahluvi7zjbbilkk@jackie> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [nMH0PHg7sggHdlD8VtgiVwSzYimGD87l] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c980f3a-a693-44ab-3920-08d9dc9c6d02 x-ms-traffictypediagnostic: DM8P223MB0381:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GOQ/ziZr9kiPumz5Yewyml0SWxcCNJUuXKi02YgDwffcEO2ryYf/CQbcLV6qgSCx/OAO3XGyA3fXOOGuQlqpRxX5PBi7NIQ4mzAVrmiSlkK8TXcJquZTiY8JTHsw4+57akXcPLUql374/Q7S1HlasS7FFiny2Xw+oyDwBZqHB4R3s1PoxWTXAdxlEyuVYXDfQ6I+cOxe8qL0SHVwYuo1atz2NzztVNlpeNoRG+RYqra1MnQDspoiygnQfW90gOo+W31TO6YJ+sOvFzW4e6f91BPzz/nJWHNlNk60dwEV3kesos5C5po0R8fwJBZ4Q5cESIfDP7f3StJZmVpjky/nPEu+8nHWSaxQa7WhWINuYah24j0EuGS4hyXsIn9KC9aK1e3JRfcXjMzdWh2x9uOh+BissIZkrKzQvHTn/gteuF3IY4h0aup1NnrAeTvxCR3zwGC8/nBRquH+BxEGIddYMYvR6mptTBDlrhmsWYXobouAQhHUp0Kh9XmpzjdlZQdg4xO6jviGdQZtBbnZzSej0b3sEnhUNWVmLYMNp2orp9Li6hFbUJ5Kh1kI8Uko9PBnHVjycpGy24QLMaUD7knELYP72Bf8KN53ONUPXugyBub+3Z/C8bP6YknDikbjStXhIxayoGy0+0UJZ0XSIseiIOrOfEcpHcpZATv+I8LG8pg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ajkwZE52UWFrTEVXcWlUR2YrS2FRZkZSWWwrN1ZRbnJXZmRKYTR2TG9IaTZa?= =?utf-8?B?clZrUldnNUNwZHFhMmdaaFV6QU9pSVlOY1poRDBDUHpXM0EyL2xPcWErODN6?= =?utf-8?B?ejhPK3NscmZib1A5V082TGpMdm5TejdDei9hc3JzZy81Wk9HdDVha2I0aHc3?= =?utf-8?B?OGdKUmM5cERBdGFVKzdUT1gzTFBRV3d1UWFVNHdMZUU3Y2k1b3crdlRSTkRp?= =?utf-8?B?OTBKaUUxUVd5NWxiM043UFhBb2g4OFUvQWp6MlRNSXFtQjQxajNtdEthT01O?= =?utf-8?B?dGF1dysrUUNrUVh4T2J0RDUvd0hCVWR2WmlQN0NEQUd6UVdWbWFNeldyTjNn?= =?utf-8?B?enZ1dGw2ZlVaejhUdDRsSnRYMjVXNGFidnBmdUJkOUQvSTJYU2JzeWtGWUQw?= =?utf-8?B?bkJhRWxnc2JXa29hb09zdWlSUVJFOHowblVUWmIvM1V2b0dJS25zaVhiMlNK?= =?utf-8?B?TFdhM0VPZCtGYmQyV2ZBcHpRS1pjenc0MlhPQ3czamYwdzNPRVhvK2tqbWMv?= =?utf-8?B?MDVaTkNteW5mUFZXL2t0bU1NdU1rTDFLSCsvV2paOTI1TW5pblV3WXhVcjdR?= =?utf-8?B?TkM2a2JsalR0MXh3OE1nVUZSREdON1JpUGxQRVFsbW5UUXU1UFY5cUllQ0JM?= =?utf-8?B?TWt2OGhMb0R5d0I5V2VTdU5QcmFoSWI5SXpuUkpKYXcrbDBrL090NEowWkJn?= =?utf-8?B?SmNFZjc0YnpsNEZobTIwT1oxdGo5ZkhCcGhGY1NDZ0hHeU9DV1BtWGRyL1Zp?= =?utf-8?B?enZRNmU4b1N5ZnFJTVo3b0pFR0hCN2dKaDN4SzVOTlFDMmpkaE93Z0RZMkdM?= =?utf-8?B?QUd5ZVV4QWNQdDdqSW0vcVRoWDVhaTJsNXBRamYyczJMUEMzVkRibTJoaXc1?= =?utf-8?B?dmwrQXlWeUdub2ZGWXhBU2lEOHl2RzNUZDh2STlBMjBGdll2VVJacGlaekxJ?= =?utf-8?B?NUtUMTBiQm1sRXdXS0ViWjZoUjRKSGhmNFU1akdnNWVyY0s2aGs0K1c1UUZi?= =?utf-8?B?Wi9ZbFZ4ZVUwZFNSV2ZWd1FzejhEdGc2SlhrV05iS2JyY2dodVgzaUVzMVNV?= =?utf-8?B?Q1BKY0NkbTluUTRST0J6by9zYk4zanJuSVVUTzB0Smg3Y0FnZjhtMXFPRVZ6?= =?utf-8?B?Mm1OcVo3b1FGemZldkFxejJrNUJwaEU1QzNDaEFVZTZNeXdIY09ZaTNQbVUx?= =?utf-8?B?eTVLMkZwUGZyaG1GZjhxd1p2M1dPV1NvRE81Rzd4TFJHWDMyc1kwaDMzMC9w?= =?utf-8?B?Rm9BQ2RsRU9tOThsN1lEbTNoaU5heGFud1JNaWFjM2NVNVlLQT09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 9c980f3a-a693-44ab-3920-08d9dc9c6d02 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 05:11:05.0882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0381 Subject: Re: [FFmpeg-devel] Patchwork FATE Errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Friday, January 21, 2022 5:52 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Andriy > > Gelman > > Sent: Friday, January 21, 2022 5:24 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > On Fri, 21. Jan 01:44, Soft Works wrote: > > > > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel On Behalf Of > Andreas > > > > Rheinhardt > > > > Sent: Friday, January 21, 2022 2:31 AM > > > > To: ffmpeg-devel@ffmpeg.org > > > > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > > > > > Soft Works: > > > > > > > > > > > > > > >> -----Original Message----- > > > > >> From: ffmpeg-devel On Behalf Of > > Andreas > > > > >> Rheinhardt > > > > >> Sent: Thursday, January 20, 2022 11:38 PM > > > > >> To: ffmpeg-devel@ffmpeg.org > > > > >> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > >> > > > > >> Soft Works: > > > > >>> > > > > >>> > > > > >>>> -----Original Message----- > > > > >>>> From: ffmpeg-devel On Behalf Of > > > > Andreas > > > > >>>> Rheinhardt > > > > >>>> Sent: Thursday, January 20, 2022 10:22 PM > > > > >>>> To: ffmpeg-devel@ffmpeg.org > > > > >>>> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > >>>> > > > > >>>> Soft Works: > > > > >>>>> > > > > >>>>> andriy/make_fate_ppc > > > > >>>>> > > > > >>>>> => Does it possibly need 'make fate-rsync'? > > > > >>>>> > > > > >>>> > > > > >>>> No. The test does not rely on need samples; > > > > >>> > > > > >>> It was just a very quick guess, because yesterday I rebased and > > > > >>> saw the test matroska-dovi-write-config7 failing which was fixed > > > > >>> after fate-rsync - that's why I though it might be the same reason > > > > >>> (with make -jX, it's probably not deterministic, which test will > > > > >>> fail first). > > > > >>> > > > > >>> > > > > >>>> and the other test that uses > > > > >>>> this sample works fine. Some time ago, someone else wrote FATE > tests > > for > > > > >>>> AVDOVIDecoderConfigurationRecord in Matroska > > > > >>>> > > > > > (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220101165153.440729- > > > > >> 6- > > > > >>>> tcChlisop0@gmail.com/). > > > > >>>> These were faulty and one of them relied on a sample that has > > apparently > > > > >>>> never been uploaded (but this test is actually redundant with the > > other > > > > >>>> test), so I investigated and saw that the test (presumably > > > > >>>> unintentially) reencoded audio, so I switched it to a pure copy > test > > and > > > > >>>> applied it, believing that codec-copy tests could not possibly for > > some > > > > >>>> arches. That was a mistake and I am deeply sorry for this mess. > > > > >>> > > > > >>> Nevermind - things happen.. > > > > >>> > > > > >>> > > > > >>> BTW, I was thinking about submitting a patch for > > libavutil/tests/md5.c > > > > >>> > > > > >>> something like: > > > > >>> > > > > >>> #ifdef __GNUC__ > > > > >>> #pragma GCC diagnostic ignored "-Wdiscarded-qualifiers" > > > > >>> #endif > > > > >>> > > > > >>> #ifdef __clang__ > > > > >>> #pragma clang diagnostic ignored "-Wdiscarded-qualifiers" > > > > >>> #endif > > > > >>> > > > > >>> Would that make sense? > > > > >>> Those warnings are appearing in every single fate error output on > > > > >> patchwork, > > > > >>> possibly covering up more relevant things. > > > > >>> > > > > >> > > > > >> Instead of pragmas one should limit the volatile to those compilers > > > > >> which miscompile the code without them. > > > > >> (IMO one does not need to find the exact set of compilers that > > > > >> miscompile this; all that matters is that recent versions don't give > > > > >> warnings and old versions don't miscompile. If some compilers of > > medium > > > > >> age still show this warning afterwards without needing the volatile, > > so > > > > >> be it.) > > > > > > > > > > You mean like this? > > > > > > > > > > #if defined(__clang__) && defined(__clang_major__) && __clang_major__ > < > > 4 > > > > > volatile uint8_t in[1000]; // volatile to workaround > > > > http://llvm.org/bugs/show_bug.cgi?id=20849 > > > > > #else > > > > > uint8_t in[1000]; > > > > > #endif > > > > > > > > > > > > > I would not use an else branch, but only put the volatile and the > > > > comment in the #if branch. > > > > > > > > > > > > > > It was fixed in 3.5.1, so "medium age" would be 3.5.1 to 4.0.0 > > > > > > > > > > > > > Fine by me if tested. > > > > > > > > I do not have a Clang setup locally, I'd assume at least one of the > > > Patchwork VMs uses Clang? > > > > They're all using gcc at the moment. > > I can try to add extra info about the runners and their status. Maybe to a > > grafana page. > > Maybe the effort would be better spent on improving the fate-error output. > Of course in most cases, one can reproduce locally, but not always. > > The md5 warnings are gone with my patch. > > Before: https://patchwork.ffmpeg.org/check/52439/ > After: https://patchwork.ffmpeg.org/check/52456/ > > What would be nice is when it would output all *.err (and maybe *.diff) > files from the fate run. > Just an idea, though.. I mean something like find -type f -name *.err -printf "\n>>>>>>>>> %p\n\n" -exec cat {} \; find -type f -name *.diff -printf "\n>>>>>>>>> %p\n\n" -exec cat {} \; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".