From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D690410AA for ; Mon, 13 Jun 2022 21:52:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D047268B58E; Tue, 14 Jun 2022 00:52:41 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2012.outbound.protection.outlook.com [40.92.19.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BFC168B02F for ; Tue, 14 Jun 2022 00:52:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVZSaSu56N7GKdjjatMPL2bTjdmNyELlK6J41cIGrV9NEkQzw1Woe2xkYYLEXJtersaJrkd9J/271ktEvY770/WdgS9WVu7CJo9a6ZGXbu3Ijj1roJkZ+TDjQ2rfI4ahdc/wntIN4fDlJ5tg1bJPmuPjwNfcX5VNpUnsLBokghfZzoJboVO3umwc7RxTK4/zsyj6HRw+WcYwl7qTwdMPG1AmW5wOh6/MvQPAtTbHG2XOpY+U4bfqDtWi1jZ5GUN8HceMpvg0fW4Bsz77eGRhot3ftB8Q2wcXXKUVtDGnI7dUmx1M01JybtxKxY72gj5zOSeial0qut1vc4fKSswpWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ehTvTKd35dxSM/2eGOgfFXEtRu1tvGiAYNibF9PQxxQ=; b=Byb9h+bepgw9QO764J8dFi/WfBy/kVM7KqMRJOrqgdbrWvsmS5V8PZc1/m9OCrIqPGDM96cnOufGhlq2dduQ3XclixLQEqQvKA9F8jrK1esua/yhZ6HcWH8h2SqBkdeLepEZKajj6HtbuXA5r31DDcH0i7+7ajBTvgL8JHdVyITHHe3a40Dckuj4k0efenjZpxlEEITRiOJr9Ho1sTFTwvoTUk8n5XBiMZBwkGtO+JnPco6jpjf2gsImzfl8fRfKRyWfC3oAIYuAvpMYZ3ML99YhDf/RiStL9tvb8gbCsgMoUXz795GduP74CoyeesX1eu1E+uk2nSaFkyFVTS2ETw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ehTvTKd35dxSM/2eGOgfFXEtRu1tvGiAYNibF9PQxxQ=; b=UZAjsR5/p7jhBiG4q6xTfvV+dxJbTQuCmIa6NpjsnJaa+abgDXwRXVphOplJr3kHjqDJAzaW7+tYp7F6qIcMIE5sgFeCe57XIrt1Tq/ITaJmh+M8z25NdCMlJ4ST0pwEgs1KAms8IhULarUrQS9W6sTLoC1S67YbB4yZLAHFBXgijeju441cK6s/yPESJ8wB/wvVAgzFvwQYFk/gKun4D6BsTtwQY8lJpA+xQH1+9/sX0u+BgKi2MCpUoouuEbkQR5+axwPRMHHctHszNK2vTFWe0e/kiBwMJQeJ6Jx0O5J0tFzHDZgXz0EyI/SjoQMJuGPdPKwDq2C95A0g0YZ8TA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0101.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:145::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15; Mon, 13 Jun 2022 21:52:31 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%9]) with mapi id 15.20.5332.021; Mon, 13 Jun 2022 21:52:31 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv() Thread-Index: AQHYf0J4/HS9JaG/JUO4k628ixaVQ61NkYpwgAA/LwCAAAu7IA== Date: Mon, 13 Jun 2022 21:52:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [rJYQjZUSytdQ2DtMl126sRiZb997pJHy] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0458ec05-0d58-486b-bcc6-08da4d870480 x-ms-traffictypediagnostic: BN0P223MB0101:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QYIg79tJWkIyI9I7feDlX6kvrepakBu49xHJm/5Y/M9yGV1H0KRheJjljsPoHF4f4hCLs1A50FfI0fn6AofAU383j8dDp8ko8op6QuEicOupD9hRhVCWsElvr+aFfQ6+TMXgA6FIbnhqddWjKWQgJUBjS3KizZQcjFDds6hY13XdYLw/gvJBuBkapoB5J25eu/fXngDcBUrx4N3e1LiN7xaTtdSoNCLpOM+H0O66JyRz1PVAZkWwPsgbs3otKULA5NEHh87gch/V2DoOhwv+Vp+q1V4aACideWo1LY5FYHunjVRUoKPwr1ZG2jaUlgBosYVFvaS9eFBP/gdYkRDmCoUUVJabAWzt62RkTdwabXI0kuWTqvNZHq9Osrutu/pah5kEwl/E7MchWtqzWMURko5U6JU+UwFdmaB5l5qxrujJsGobhkuACK9ZTMs6tF7hKqxhEege3viWvAkae//EuyWZEmXHqH2xRrDPlklUoCs/97pFIImXA5x1jAl7qjY9ww8RADBh7Mmi+m+oMtM9Gb9do4GTUAssWhbXhNigytBMTJfsbwVWHPTEoxcf/UdFiLve9pc/tz8G+UqpOONlHRXla+kuZkBPs5Jd7GXAZSmJk6gD/VsmiqbvBQZnUIYF x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WkxlbHZwQWZWc2F2SnMyYXY5TWhhN1R6NWgzaEpaaGxuTlc5Z1NDcThVbGRW?= =?utf-8?B?VTFqMmhPd09HQi85bTU5KzdtWEdsR09NcHd6aGpOQWplSGVzc25BejExMGNH?= =?utf-8?B?dEZXT1JuRTI4aTQ3V0F5dEpIMnNsQ3BLUXFhTGwyYkFZM0ExTFhKWGJwYTVE?= =?utf-8?B?VjVDcEF4WWNkQ0NKOVdnNTFacW1UNjBIbE9LRWRQZnJCY1k0QmhaSGYxRmEw?= =?utf-8?B?NXJKVUlia3FWTXlKWHBGb2IyK0NuaXptUE4yZkVMTmxxYXJ4bStOYTk0UnZs?= =?utf-8?B?Mng1bGk3T0JLaDJFZ3ZOaEVUQ0s4aGFhYWpPeVdqK2ZJZW4rRHpUOG80ZmRZ?= =?utf-8?B?bjhIQ3o4bk5WUUJJbCtrREVmeWE3U21zK3U1WTF5OFF3UFpRZjk2c1BKN3ZP?= =?utf-8?B?aExUUzQvQ1BtR3JkYnQzNGZkVmlDQ0gySXMyMmRiazhjVk1PY3JXQUVEZXB2?= =?utf-8?B?MnBGQ2tGeHVmMFNlN001dldTNzNOVFl1Z0NGY3NYZFlXNUtnSVRRYzBYRW5y?= =?utf-8?B?UGw0S2NGVk04NWI0RU1kNlVleTZ1M3VMOEFXMVl4ekxRb0tCcm5DU1loSUJU?= =?utf-8?B?T3Y3S1pvZVV5TUVTNXBleEg2Z1hiSENpSUI0MWtmUnhwTE9NSHFXSjlLR0Ni?= =?utf-8?B?bGhUYzVsdGpCaGpxNDU5MzJnYXFpNVhoeHZVMmRCUTRZUjVVcVRJV0w2YzVY?= =?utf-8?B?OFNKSk5qTzVuM25WZnNLVTFZR3R6clo5eGNWM1g3UFN5a1pJTzhabnVEMmUr?= =?utf-8?B?TXdxL1E0VDR1WlZRQWl6NzhGUjU3bmVkUEJwVjdIQ2FWZ2hjaUtlbG43NmUz?= =?utf-8?B?bXp6YVZXSnExaURsakpocm9GOTRZMTBNNWw1cHBWK3pTWTExZlZ0cUlGTWVm?= =?utf-8?B?VWhIMStPZnlzU01aTzQ4YWZndkZtajVJYmZjYUtkVG5kWE11amcvQjBQYTZN?= =?utf-8?B?aDRvVFpWZjJzS0tNb09CbmtuL3BPSEdkTlMzUm1tRDZQeEFiQlJ1QTZVYnZp?= =?utf-8?B?Y1c3TVZjSXptakNidnVsZldCWFJLRVg2WEZBSHhuZ0puZVFrTkdLWi9ILzhW?= =?utf-8?B?czhwL1k2eVQyUVdMMjA4NGF6blBuMjRFZTh2Z2NBOHVyYnJnM2xzU0FFd1Vs?= =?utf-8?B?bnVNUTRudFlRNkxhLzB3Qml6Rms3NmZFaUYzOGNiNEpuTFNMWnNPM0h1N0M5?= =?utf-8?B?NkluUk1VMzBBQjZ4WXZIMFR0YnhvL3RwS1VrbFhOUXNRUnNFTEdDYk1aYkpZ?= =?utf-8?B?TER2WlBBWkNGRjNza0JiZFZFeTR1NmpYSHJEaHhoaUFaeGNha3NCcENwTTBD?= =?utf-8?B?YXpFd2c3MzIzblVLa0sxeWhBK1F2cVRwZEtlY2V4M2Zod3U0SzlDc0ZUV2Nv?= =?utf-8?B?eGJwdFR3dEdGZlU0aVFyRjNmMWJCMHFnZ0p3RXN3VFhocWdDWUk5OFpXdFIx?= =?utf-8?B?d042aTBXaVFwVEZDellMNmRBY1FUMWxhN1dqblB4NTh3YWtiKzJtVHZ1YzZY?= =?utf-8?B?N3dyUXRuZDJvUG5WalZCZml0Q0EvVStZcUk1WVVxdlZwaHVuSGY5UVJ5aDVN?= =?utf-8?B?bVU5N3JWcFlsNGQ4WEFFUE9ocFRvSnNacGFycVN3MVNHaUx1c1RVNVdqRWtn?= =?utf-8?B?L3hOdDBtN3lIcy9BWEo5di9XMHJNRjRDb3NoUG1GOURzNTJQQzFxMW4yWDFp?= =?utf-8?B?eEN6aXUxY3MrQXFoUUpmUWZIV1hKQklCQlBtZFNnNU1uTEZsOEg2UXJZcHFy?= =?utf-8?B?MHpxMk51NFRoYUw3MlRxQjlMWUtDYnp4USs2bVBxU1FXck42QnV4Wk1nMUd2?= =?utf-8?B?RTlySEd2WGx4aDhUbXFacldLdzdvOUNYcGM3UXFCSGRkSldRNTdnSVFMUmhs?= =?utf-8?B?V3RZTms0TnZqdkxDVzRhYmdQWjJraGZydmZ6aGY1MERXRG03RlJNTU1iM1Q1?= =?utf-8?Q?o2B00L0sQlg=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0458ec05-0d58-486b-bcc6-08da4d870480 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2022 21:52:31.7347 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0101 Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > nil-admirari@mailo.com > Sent: Monday, June 13, 2022 10:53 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove > MAX_PATH limit and use UTF-8 version of getenv() > > > I like the version check. I don't know about all the derivatives > > of AviSynth, but I assume you have checked that it's valid for > > the common ones (or at least the original non-Plus variant)? > > Interface version was changed to 7 in 2020: > https://github.com/AviSynth/AviSynthPlus/commit/40900dc1c54c14ea9f188 > c7242b88d464d067a44 > three years after utf8 was implemented. If I'm not mistaken, there is > no way to check > for a particular revision. > > > Two ideas came to my mind how this could be done better. > > What's actually needed here is not a string conversion, we need > > a valid and usable filename, and the function could be more > > something like "get_ansi_filename()". > > > > The first thing that this function could do is to convert the > > the filename to ANSI and right back to UTF-8, then compare the > > UTF-8 result with the original UTF-8 string. When both are equal, > > we know that the conversion is safe, otherwise we know that it > > won't work. > > > > Then, we can use the win32 API GetShortFileName(). Which returns > > file and directory names in 8.3 notation which (IIRC) contains > > only letters which are valid in the ANSI code page. > > > > 8.3 file names do not always exist (depending on system config), > > but it's always worth trying. > > > > Should both of these procedures fail, we could at least output > > a useful message, explaining why it doesn't work. > > > > Let me know what you think. > > Too much work for something that was fixed on AviSynth+ side two > years ago. I wasn't sure how important AviSynth is for you. Until I had given the hint at the UTF8 option in AviSynth, it seemed to be a high priority to enable the use of long paths with AviSynth, and what I was thinking is that this might be of interest because paths with non-ANSI chars are a way more frequent case than long paths (on Windows). Anyway, as long as people are using a non-ancient version of AviSynthPlus, it's all covered by your patch, and I'm totally fine with this part! Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".