Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: move elapsed time counter to the end of the status line

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Marton
> Balint
> Sent: Freitag, 9. Mai 2025 14:06
> To: ffmpeg-devel@ffmpeg.org
> Cc: Marton Balint <cus@passwd.hu>
> Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg: move elapsed time counter to
> the end of the status line
> 
> Elapsed time is much less important than the actual progress, and I am
> guessing
> several ffmpeg CLI frontends use the existing status line for showing
> progress,
> so putting a new field in the beginning is less optimal anyway.

I agree that it might not be the most important part of the stats,
yet, from experience, it is quite often useful.

How about adding it to the end, then?

Thanks,
sw



> 
> Related to ticket #11582.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  fftools/ffmpeg.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 24d43e6197..2e575e7b10 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -580,15 +580,6 @@ static void print_report(int is_last_report, int64_t
> timer_start, int64_t cur_ti
>      av_bprint_init(&buf, 0, AV_BPRINT_SIZE_AUTOMATIC);
>      av_bprint_init(&buf_script, 0, AV_BPRINT_SIZE_AUTOMATIC);
> 
> -    secs = (int)t;
> -    ms = (int)((t - secs) * 1000);
> -    mins = secs / 60;
> -    secs %= 60;
> -    hours = mins / 60;
> -    mins %= 60;
> -
> -    av_bprintf(&buf, "elapsed=%"PRId64":%02d:%02d.%02d ", hours, mins, secs,
> ms / 10);
> -
>      for (OutputStream *ost = ost_iter(NULL); ost; ost = ost_iter(ost)) {
>          const float q = ost->enc ? atomic_load(&ost->quality) / (float)
> FF_QP2LAMBDA : -1;
> 
> @@ -679,6 +670,15 @@ static void print_report(int is_last_report, int64_t
> timer_start, int64_t cur_ti
>          av_bprintf(&buf_script, "speed=%4.3gx\n", speed);
>      }
> 
> +    secs = (int)t;
> +    ms = (int)((t - secs) * 1000);
> +    mins = secs / 60;
> +    secs %= 60;
> +    hours = mins / 60;
> +    mins %= 60;
> +
> +    av_bprintf(&buf, " elapsed=%"PRId64":%02d:%02d.%02d", hours, mins, secs,
> ms / 10);
> +
>      if (print_stats || is_last_report) {
>          const char end = is_last_report ? '\n' : '\r';
>          if (print_stats==1 && AV_LOG_INFO > av_log_get_level()) {
> --
> 2.43.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".