From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A0DBA4D0A6 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 01:01:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8A6D7687DC9; Wed, 16 Apr 2025 04:01:36 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2067.outbound.protection.outlook.com [40.92.40.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24910687DA8 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 04:01:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qsQFEsmG7QznZSRh/06egm39pK1x9pwoHpSfIeXbArQrq2+BjD0FdDrjGkIxJP9xNqWJ5s08ZCDvmVtyEUtqoYdHkYfMm+1117yGsgdmDit5uQNc1YvA3enWQAZ1xzRbAxWeUDqOSha+FSsieeGe9uryUCG1CWxaUDaydQ9Zi6W2N28DMwDHvsHv56YD3lFMZC4Zgout57Z0rIUvCTjbicRiYRimlI+lmu6MIYjBzA0K2D8ZBA1YODPCNYF3max14nsUjHaY7ULeYuseBfcz+lc76cKGeMXakthgXW3rMnYN65LIUnmdH8X6T/hzvXqYn1RLFDq2OJG09xplcJcfsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Too785X+1zRfJrXcrYG8lyQJfmMAZD9StaEfmTtJr8I=; b=i27HBMG4URzKnM5CYVoOwWxhLfGK+YMKfADaL9ENK+E9zMNaq6XZE2YZWhoMeV5xY7qCiMO1C/poheWTlIYiGewhHleql8Kkm1VB5bjRQG4lSPz5KCRzEwmxB2cYidKlIoYBFcWvf0Ujvgwz9Oaoj1lXP3+KurhYLGccLR8YpRxYGnM85uw50FNPfDpZUfENGiJ/B2ob1+KDMSu6RcMocdx5JYmQVuM5ISBgETgn33cXsgXxeCXFlCUP1msI5ZAkGGJSs2h02DQ3kMiZ9p/QXQsZTq5q7ZuPPA1wlNvY00GqO01q1npUou8/zkhMDTqNpTlOPfqc1qxdZjBlN4lqsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Too785X+1zRfJrXcrYG8lyQJfmMAZD9StaEfmTtJr8I=; b=q3TvUD0NYJA9vWfEYxcFlMD5dDFmCBgS1eM5qtpHDWcyiMbddofB0w9AGm1xzRBnrvkZIGQWKhjYDwCcQgvIjlRorhzbme6ziM3VJlUKEykHL2eTfQFIxt+eG2YJ7lVxjmUVLyzNqQEAwCFSNHbOLQmWG7Ue5hKCWi8bz0hAiI2ougaRFPkMeK6/mSEROstFQSbq3EMDH5vVdoJa5ytuLlYwOJYIZ55cMYI8Adq1fJ8YU4jIQ3PhJwNdKlYzBDdhaZO/Ao8RJjy5L0vd/cuZOMHnnHrJwYEasEGYxEdL/0634XA1NlrDSs5UA9aJ6ZF1KIK7eJTcOkEVDpX3p8XKEQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM3PPF0A0A6277F.NAMP223.PROD.OUTLOOK.COM (2603:10b6:f:fc00::b87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.27; Wed, 16 Apr 2025 01:01:27 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Wed, 16 Apr 2025 01:01:27 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAAAZwAIABQhQAgAAFo+CAADvZgIAAAb7QgAABGqCAAB+tAIAAAGQQ Date: Wed, 16 Apr 2025 01:01:26 +0000 Message-ID: <DM8P223MB03652539C31184C4E12B4141BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <20250411222719.2779176-1-michael@niedermayer.cc> <20250411222719.2779176-2-michael@niedermayer.cc> <DM8P223MB0365A90C10FBC9EF6512F9E1BAB12@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250414231950.GN4991@pb2> <DM8P223MB0365928500AB53069869DC99BAB32@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415185538.GR4991@pb2> <DM8P223MB0365E10D38EF9174A32557DFBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415225001.GW4991@pb2> <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <DM8P223MB03654DFB8790C225AC03A3F8BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250416005334.GD4991@pb2> In-Reply-To: <20250416005334.GD4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|DM3PPF0A0A6277F:EE_ x-ms-office365-filtering-correlation-id: 66990702-323d-436f-3f50-08dd7c82372d x-microsoft-antispam: BCL:0; ARA:14566002|461199028|8062599003|8060799006|19110799003|7092599003|15080799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?rPJr9JlIfJiSUVHVNUOsKE8ctrZMaoorv0y/y6Qg8DbZdRgYbWfbjvuJvGom?= =?us-ascii?Q?IjoknWlUTua0B7iON6WkD67LNtCPsF+6fXda2fv2vGoSnKt5tUOHAxarK66R?= =?us-ascii?Q?1wX+uDG99xwmOPZOgdYe4NpWmYoIqIxxvgqoRMnei74wB9mdSKSETvflJQBn?= =?us-ascii?Q?3XI/8fN0MRY3nwe9hPFBAtQd2yNwUo947Wd6o9eybG5radUvt1wS08ObFxJp?= =?us-ascii?Q?njn+vOcq4ISpjd5mvi0jpUWWMb7h1ax8Qtipzpx7LY+g6ETY2TADrlc0n7Ic?= =?us-ascii?Q?28tzTOsm5aWXg8Zncp4KvYQRyPCQqmPyBUOstFfaDP0c0ArDZsxnI3h14+md?= =?us-ascii?Q?N7sYeFQ8wzGFbd+UP9AMHWXtmudY7qTsK6CcSEKdp91N07Px/LvMwXl2kMNo?= =?us-ascii?Q?gbsCmMKR5lXdxiegZr78jQO3uKqB41XxUXE3hnEWM8EW9Ktx2+iLJ5BoFtbX?= =?us-ascii?Q?RWNROwJwOzn7y3cxBQfZH6QnTjtnlxRwySgfkmB7iP141ohiT5gYe54YBDO/?= =?us-ascii?Q?pIC9KeJlkr2//vHao5anaO/qn1yfgMeq8qqHH6v9uQ7Dt+6OPs/fczHARdOJ?= =?us-ascii?Q?YHinjFqMnzhIZROVXIgsLvoRiqz+zyXbANuMY8Dxmw7oSt7kTM9u7t5AOFH6?= =?us-ascii?Q?AGSmizsao11NBdcVXrYra04x9b3slEqXz/8qZ79At3TiCRWKJHTrnQablqXA?= =?us-ascii?Q?utdQ3Gb8msKiL4Fi6OsVE2+8Gny25Gei5h6ImfUmEAXiqibEDpRXyfZI4i0l?= =?us-ascii?Q?iJKC9tDc73S2ygsVbPJWl3w2btg4PdMRe0dbdWzLMttrBJPM36kpcsxlUKA3?= =?us-ascii?Q?o17bB//q6hMtotyTFxh9elTaLiwhL/ZciPwZgbOTyoO8shOwssds1TK5JNui?= =?us-ascii?Q?qrfw1GUoMZL99QYeR+DlI7BM663emk80vJK2/C2PjZFwXG7G57ZAyHnQC3ea?= =?us-ascii?Q?RQr1peuEbAi/iD0awjbyK9OhPZwecNJhqrUPPQC9V3OuD1VzD9TDpbWnAmOo?= =?us-ascii?Q?awk4tpv3h9dYXyNKZ/aJjIdf1ZgoyrNC6JIFZcyCtPLQwJ5+UgXrq1CPBDj1?= =?us-ascii?Q?ZowDafSxiXLSnbBTAP/FAb4EJXYYYU4x/5G7GBF1fvaLm1/bp48=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SBPu3u4x4IznldAxwo8EQbsCXp6Vk4uipNM0B/8QaSC4w3A4RCqZ/132V5qz?= =?us-ascii?Q?yFaZcOwnCMhVCIPQuxI8ioJYPpO5Y0w2MRs+db3UhhRjnRg6goG00mYR5pwK?= =?us-ascii?Q?xN6LSOdfYzWDZ8VB5t7SA9bvJxWG82Czy+e/SOiorrWLwlK/pbgpLs1hOcQO?= =?us-ascii?Q?48hEyQkbq+WhUPb4CVZLjOLgMkgekuQjTRCJKtokcDzZw8NZa6I2fU5n2pBS?= =?us-ascii?Q?kXjRgBrTP+a8/G9qSgXJsuY+ebcH/xSFMEwyPOoR4JRNxouLsG+pzvXCGI82?= =?us-ascii?Q?8MLji7g/joNhVLDRInW6cURZVKCbc4msaaMgLPsTPpskxXoyoiUnOuSvdQoX?= =?us-ascii?Q?EzSjgpfTCPRZVgIQTJg5ej3578C9sVwiRDKe8j9J1KAoj/I5EWQEXgWVbSms?= =?us-ascii?Q?s+flIf3vD/7I/SHlT+3sxBdNpQIbI+1H5P0qae6V/e/OE9fprPjc+grI9ANg?= =?us-ascii?Q?GbgUIfg0R166J/+mETGWD+VkcYKkYLeXZ2bjRr2euuUFAAKmq85ZT7AsJE4u?= =?us-ascii?Q?eMshZPP9IwBirBw6VlcOIuWsC4b6djq+K8w2+HvWt/2W/JCLo1esRyxbLfTI?= =?us-ascii?Q?/R/6caUFOTmfFd3TVPKONn5wMI1kun8MDJmq1SM/0RGOwQQasVHkQHagGKbz?= =?us-ascii?Q?bEw7SbKOqlKww53nPlpsg/7CRrwZ/EqQu3oyRta6hUfDHBQtXQFiUfX2sy56?= =?us-ascii?Q?XaDLd6kNWB0eJLSMtQpo6BV6HAP6gpOHhRR0AMcSvGjbKpMU0FqgXVzfKKlR?= =?us-ascii?Q?pVTlHoCn1UOCBHDPrbskbjLP34Lk8kv8QqiW9jgvPIknBTGihA5rIWka/BDO?= =?us-ascii?Q?kf2kxeTWOaS8shBVd79rlRXc492+aEDFZwiM4Ieqs7UHiLF8nC89cjOl7rfL?= =?us-ascii?Q?ydNdGo+d2A1bs4EH8A+d91h4EfiP6ZOWou1wHbZgqqGOJpdKhRxdb/mFW4gC?= =?us-ascii?Q?7opKB+cOuPILas28UHehSLwBsWvSPMQ6cWXE2d9ivBr4lf8o++vDQ4ZhQ13G?= =?us-ascii?Q?NVPjjpxKFIPIeq2nR3rxexa25ZtGApGiCw8Tc9D3vK6ZAFawrecahmu5ORJk?= =?us-ascii?Q?vRFhoS55hY6UO4WuxEiXbRkCntKlY1dPDzM/fH5ILWqxLea9S0tFTwIaipCs?= =?us-ascii?Q?jOR1YJgbjlK9yG1K+PMJnpJ3cGLeBic2+GTVESAg2MsVBB9Q/PEEjGEWOHhi?= =?us-ascii?Q?dG7adV23iulKMc6i6WJPX2X08kaYncWhLew+F3aTCSo/BxuTH8ykVvNBfD0?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 66990702-323d-436f-3f50-08dd7c82372d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 01:01:26.9290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF0A0A6277F Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03652539C31184C4E12B4141BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 02:54 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > On Tue, Apr 15, 2025 at 11:01:14PM +0000, softworkz . wrote: > [...] > > Besides, the patch had been submitted 3 years ago, there hasn't been > > any review and the merge was totally unexpected. > > no reply for 1 week means commit must be expected > > "Send a patch to ffmpeg-devel. If no one answers within a reasonable > time-frame (12h for build failures and security fixes, 3 days small > changes, > 1 week for big patches) then commit your patch if you think it is OK. > Also note, the maintainer can simply ask for more time to review! > " > > besides, i reviewed the patch before applying it > > and there was an open bug that alot of people wanted fixed. But not in a way that breaks their deserialization or parsing. Essentially, you've just exchanged this bug for another way more severe bug in the FFprobe output. Do you just want to await the reports and complaints coming in? No matter whether applying this patch was OK or not in the first place, knowing that it causes a serious regression doesn't appear to me like something that could just be ignored, or do you think otherwise? sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".