From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CAE64327F for ; Sat, 25 Jun 2022 12:31:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5FA1668B7CC; Sat, 25 Jun 2022 15:31:30 +0300 (EEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04olkn2067.outbound.protection.outlook.com [40.92.46.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 946D568B48C for ; Sat, 25 Jun 2022 15:31:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZkrFtVjB4/s0MbsI8k8ibWa5Ok1+bmG6NQXn6l3p/h4QijzThNSFwxP0f/e+6n3tKHpOdMr66r5iXzoIrzy147oz2ShCTicLqtArJJDNUh10eyyNL+rUjrilrerUunP2uRqu8ZYuLeL5tgQQjmexcaHmWRTByUcGBHaUv+F1g8UQO8T+8NFpzLUa+t83wbY+fJGtKXFJ/k2xdhAYYcYyYJ7yzoaTRTEF4Pngc5teauJFDPGj7w28K+fQzNEK4Z58miVHuHXiAFfRSAmIOzguxHihQVhEdUsHB6+TNaNd+lBnaAdCCE27Sdy8fw8x8VYeyTXKkIp98pfK74F2mK/2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A4NlF0nA5HhZH5FlveP6AbBnMO2+PqY1CliIaGmEc9k=; b=PVu615U5LLradSD67uCXwLxDk5PGvh+9R4wZhHY5sne2fiNaHkM40Tog1GlX4EK0HgAVNX1oVlRj1i5iDltyyTvgQjjlR0xTh4pYOYhAAap5Bah/Dd6u54PBzwawlwqYjeZ4ODNY+az50cy6KLTpoV7J2wrRCKTfWSUrt7ZyDfq4mUh72ZG4WqGnIN74JRH740uG6OBqpRDE0eqDp3a+HKfqEuPXeNfkt14jjtLskm8PxgVKymOXdtEVrHyq1d0po/yhcP5wv+gCNNrbplIRSPbSAScGNmm57ENqYRPjPR4WhZtJK9Qah0JYWiyjSu+BBrP+0k0j8QZw0X+pgUL7hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A4NlF0nA5HhZH5FlveP6AbBnMO2+PqY1CliIaGmEc9k=; b=kJZdrJlHYgBFXDBZ84jdD2j26hKAUl2JlseJ3i30ZGpuX7IKMQNkKPbE+FxrKT+M+zyWqigYKDZ8UMGK9UuDKs6iYhAQfErMm4BuDvfxT8IwVOPY65noGv4qFmhlTL/eUSAKy7VnO2zPqij8IoOYjt0PHIWKpowQ+owjqLriPz+oS3sQIHvbHPmnWWWkzewT9OAh22MUxCVfuLSutblFDX7KqwXyb8wUqVhWf7B4gzzMq03PjNPkIh58rt5nefMdsbqr3HI+qxHP+qVovG8sy7jfw3OnT1TS6D0BTSB7I3QCcdbdqoKow2E/dyMWaalLA+bBhvkEpObtAjWnrflPUQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM4P223MB0471.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Sat, 25 Jun 2022 12:31:19 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::d9e4:ced6:ab31:c231%2]) with mapi id 15.20.5373.018; Sat, 25 Jun 2022 12:31:15 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding Thread-Index: AQHYiHomQ19hwERBuUa+wwaKzgqqH61f/jYAgAACDQCAAAwPhg== Date: Sat, 25 Jun 2022 12:31:15 +0000 Message-ID: References: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> <20220625113452.GR396728@pb2> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [u7x8e+WC3osAg/krZhXCwwxFYnk2anaV] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbd225e8-88c6-433c-8bae-08da56a698b5 x-ms-traffictypediagnostic: DM4P223MB0471:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gm6LddWga60tktNv1UHyLIbgNJ6ru54pEHd94LbgRrdIG67vuTN7AGo9z338Ci4pn8/qj5LbmTKDANByBXifyhKLrv7XYlx+WA0E4jmKypeg5aiPWHeGR1PzHguLTDfJQ8zG1Q/Tcn0ZttMyu6J4bBOL6q3fJqs5ermen5n5UNzlyM4wkpESqzNFzUJ6r4JVt04h9jZ1UeCzXBmhkn5hoN3nYM8Wnu6i22ewlBS8oJ4SjvHmQ4u049tqLiXjhYG2idgd7eddTnUZseBGwwXraKIyLxhPy3Ev7Er4JP7laDIKJANPt5jy9H76SowhYP2mTdBw1xzHYqI1tQIq5CDE0rsibAf7GSke5YmEHgNlCmQh+ptzKC8Aq2NMvxR9VsYd56sUuZ+b608679e5Mx6kJ7FOpOIR60jo8iwZDf8FXvdxLMkUrUOCjB+R/TCwF3cEvwBb4SNULGH2QshvoSPkq1Ld+BPHE3vSaxELNOXP1vOjJ9BYkZ5+uxfwd2n9411yFwQoVjHEPagW6JCBMSUPkC7UBd8fNUQZ3mHr8lees9Vwiygeqk8TdxKVWg4hXnWjbyDBno2ZvyDg7bEzqYs7iFpSqYTMjyL5xy1cEfqvWnpWzv5YUESpFtafvNgq6ZF9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?UWd7Q6XJMqWz0sFl6Ne8h405WNBLHh2bN+YuA0G5vzz0uRiiFTUeLqCSW6?= =?iso-8859-1?Q?apvb281XUO1wgOwgp4pS/na1ax7lN56aamoszgMJSCwttcf1qSreKRUV4y?= =?iso-8859-1?Q?2QpQHBSMfrN3LLgCGXtqnafKoXwEgoScODFMgJwydt6ODDSkuYl5sDe8ju?= =?iso-8859-1?Q?yoECwo0esnvZwwpox63f2nuQcnaVI3rLYPUUm+4F/caWch7qFfaiZl8UzI?= =?iso-8859-1?Q?AnVVnb9ckSM7NZRh4O1Dpkfrk1UejOf9urr8ZDbtANg6aXc9/K2A2E+zDL?= =?iso-8859-1?Q?CYCpuiF0ZvzAZ6vAEtRqAU+5JDKJrgq3pY52MLTlu3P7jC8d3F+IGgOiUM?= =?iso-8859-1?Q?fbWSfoYZq0sB4Hw81XvPn0Unq3fdRlApWEuH/n6zUYEnlVANxhzuWpvhKz?= =?iso-8859-1?Q?6g8huSGWB1mP+suZ2dfQuFTNsJJ1V/NWBcirfXB1CdG36nu9ojrfnQ6E9T?= =?iso-8859-1?Q?Dt2JYbgUWTfc9LHbbY0CO77IUW+q9IWfPNeAT0GToOKwOQx68jz00duVen?= =?iso-8859-1?Q?OS6uw6wy2wgp7/GTmPzrD8pGHzOh50M0G68LsPm07LEypT+LrlyLrKLgE5?= =?iso-8859-1?Q?VUgNeWCLGmfogxmvF0Zvf/F7spvfMkhFVeDrDDWF5e0dr9zZsnMxcXQddA?= =?iso-8859-1?Q?P21qnRycG/9J1Sh+gjci/OxrJAx2yswZsI1FfSQBjKFz0xpy8p2zr1jH7J?= =?iso-8859-1?Q?ylKAYQml21osnLZQUF5nHINgSn/HYpC2PmChJFrEWz/TIaWjRkgFDM6teJ?= =?iso-8859-1?Q?+5r4rJ2pka+mrd9vS5hRgDuoltslGOe+YtxpPGo9oEp7nOz+3ooJI2pbhk?= =?iso-8859-1?Q?NDliRfcQythJqEAtl4UClsvgCBIOF++jJ4q70+1sz/FkpnyEU0SJyUHcY8?= =?iso-8859-1?Q?OYrtFDjO/VOXojSerAmiL+07nhqf4g0Fh4AMNf5jb/Yd2szgxzLGMX/5ud?= =?iso-8859-1?Q?jJm2kWhhRwNZVFG2IL5exymBBZAPxD1EfsYtnrTrGIXrg+dt5I3v1wO8ey?= =?iso-8859-1?Q?mRfDnrjtLe/IF1oIfHLlaVfy4K626HlU5FlGV0+nZ7g2lhWK1mneo0LzEj?= =?iso-8859-1?Q?AxzmVpPrl8kCfU22jvXYZEF3wEMSi61cTbWtQ8PRLenfnGqlYQEygXq9Rt?= =?iso-8859-1?Q?x1m1CQKPI91DcSJr73pWeuYYh1nNq/lCcNvznCpSHaRnfoVU4ZDnr53syz?= =?iso-8859-1?Q?trTTXmYBBY4b75jWk/hpN3/pnM+A25fOeMejwzgKqgjNI6sdslLWNEw4Wt?= =?iso-8859-1?Q?4ZuQVt7ZvSM8cM8QW9PInrz8vIlrCvI2sFH3VGG1zCobS/rQyBB2JaOPbi?= =?iso-8859-1?Q?bJIt?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fbd225e8-88c6-433c-8bae-08da56a698b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2022 12:31:15.2317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0471 Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ________________________________________ From: ffmpeg-devel on behalf of Andreas Rheinhardt Sent: Saturday, June 25, 2022 1:42 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding Michael Niedermayer: > On Sat, Jun 25, 2022 at 09:57:56AM +0000, softworkz wrote: >> From: softworkz >> >> This commit actually enables subtitle filtering in ffmpeg by >> sending and receiving subtitle frames to and from a filtergraph. >> >> The heartbeat functionality from the previous sub2video implementation >> is removed and now provided by the 'subfeed' filter. >> The other part of sub2video functionality is retained by >> auto-insertion of the new graphicsub2video filter. >> >> Justification for changed test refs: >> >> - sub2video >> The previous results were incorrect. The command line for this test >> specifies -r 5 (5 frames per second), which is now fulfilled by the >> additional frames in the reference output. >> Example: The first subtitle time is 499000, the second is 15355000, >> which means 0.5s and 15.35s with a difference of 14.85s. >> 15s * 5fps = 75 frames and that's now the exact number of video >> frames between these two subtitle events. >> >> - sub2video_basic >> The previous results had some incorrect output because multiple >> frames had the same dts >> The non-empty content frames are visually identical, the different >> CRC is due to the different blending algorithm that is being used. >> >> - sub2video_time_limited >> Subtitle frames are emitted to the filter graphs at a 5 fps rate >> by default. The time limit for this test is 15s * 5fps = 75 frames >> which matches the count in the new ref. >> >> - sub-dvb >> Running ffprobe -show_frames on the source file shows that there >> are 7 subtitle frames with 0 rects in the source at the start >> and 2 at the end. This translates to the 14 and 4 additional >> entries in the new test results. >> >> - filter-overlay-dvdsub-2397 >> Overlay results have slightly different CRCs due to different >> blending implementation >> >> - sub-scc >> The first entry is no longer in the output because it is before >> the actual start time and the strim filter removes such entries >> now (like for video and audio) >> >> Signed-off-by: softworkz >> --- >> fftools/ffmpeg.c | 613 +++++----- >> fftools/ffmpeg.h | 17 +- >> fftools/ffmpeg_filter.c | 270 +++-- >> fftools/ffmpeg_hw.c | 2 +- >> fftools/ffmpeg_opt.c | 28 +- >> tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- >> tests/ref/fate/sub-dvb | 162 +-- >> tests/ref/fate/sub-scc | 1 - >> tests/ref/fate/sub2video | 1091 +++++++++++++++++- >> tests/ref/fate/sub2video_basic | 1238 +++++++++++++++++++-- >> tests/ref/fate/sub2video_time_limited | 78 +- >> 11 files changed, 3010 insertions(+), 672 deletions(-) > > seems to break fate > > Input #0, ass, from 'fate-suite//sub/1ededcbd7b.ass': > Duration: N/A, bitrate: N/A > Stream #0:0: Subtitle: ass > Codec AVOption threads (set the number of threads) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > Codec AVOption thread_type (select multithreading type) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > Stream mapping: > Stream #0:0 -> #0:0 (ass (ssa) -> ass (ssa)) > cur_dts is invalid st:0 (0) [init:0 i_done:0 finish:0] (this is harmless if it occurs once at the start per stream) > subtitle input filter: decoding size 1280x720 > [out_0_0 @ 0x557cab64bbc0] Subtitle format change from 1 to 3 > Assertion c > 0 failed at libavutil/mathematics.c:61 That's an av_assert2-assert. softworkz probably didn't test these. Yup. To be honest, I wasn't even aware that I'm supposed to. It seems patchwork doesn't do either? Do I need a different configure or make fate? Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".