From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E49CB42AFD for ; Fri, 13 May 2022 09:32:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCEA068B476; Fri, 13 May 2022 12:32:11 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2075.outbound.protection.outlook.com [40.92.42.75]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C056C68AC9E for ; Fri, 13 May 2022 12:32:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XjObWP0nlEXTt7hCgBa2PK4edcPYuHsHxKKaIxuqXNNK/7UvxABViScsSJ0707AMJzOf2AbdsseRNQXEPeiAE2O924mi41KgLomkKOnqaLCDeeC0if3d686SySsrxOhbBb19GpfsxMbjyucoMv7ZwckX8WMsASkHNHqkqlp2yupVC1hOIoGGUkNesRM/HSBERxdRUiqrUZIm85aRFsS+oLHuC3zCkDs2vqr74xudPEi9MLKCdC+QpMR48/Tjv0L8tG3UjQPLcQTWpwtbizRZzPG4708lugqbwSsc3fT5b/qD9/1VvqVEajt3/pf4yJTGCwGMtXh2wB/D07ZoFYW1pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FK6KmJbjDGs+TJp2xEXY5s8iFFBgdLSFb4L3BoBChgk=; b=b4JPYoW41jIOW7VMYyD2Y7nbUXw44smMsNhcmnIe4gdRHCNMNtxGRfA67cSr0TaxrgphZFKPdEX/QQ+Lsg1SY76zcTN3aBUIF+euEcH7CdJl/4Wuuv4M2r+o7T0vDcCR66Aw9Yi0jLUxYfr5qrg4DdG8CcE/RQTmAXM4S6GJhJeWu15U2ETEM/mB4x14HqOCRqO4+iatC2M+6xxTfUAL1IOWEJ6R3nKnsL6Yw7RuXYxriQI25v7vNDnJPZxVsOoWZu0zRuptNwbPTbncBY07g7QVtdwVk5Jdn1NdXQ0nUbvob8YiOZOdMTWDs02VDnqDYHtGuOzxKRoD4IdwFEzfOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FK6KmJbjDGs+TJp2xEXY5s8iFFBgdLSFb4L3BoBChgk=; b=PcrheXdSrX3soRtYD0qZanqvB00PxiVgP/CGM/2azuRyIQW0YT8ApEdkp1IAxX91BEZu7leMiz7H5MmO10JEvw+HF3IP0Ee+0xGRiOohSHpdwH4hF9e87jnLQ3WAP12+652GX7LmlaGPwKNPSNir5h6Cp7WTKh5gfxeKJS0Nv6c/CINYftn4Oarccnfmz21/g36XCR0MBQO1vf9ot97OKyhCEqp0J83a5GoJCBjlNRZAN06zyzqUUhxO+c7JOH7WXXtZx5/RBhaM0y8otC7t1f5Cwd3HeQk98YAgDPRPTRkJhQD8mLNcLe2CHiNqNzW5PlqQ4OUqb7UHn/Ec0adhHA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by MN0P223MB0485.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:3c7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 09:32:01 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Fri, 13 May 2022 09:32:01 +0000 From: Soft Works To: Andreas Rheinhardt , FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header Thread-Index: AQHYXriq6NmNTzVVck+rOPFLZ4OqTq0cY0RQgAAl1oCAAANQYIAADP4AgAAAyAA= Date: Fri, 13 May 2022 09:32:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [qWQ1+lJLHIrEHqS6ZbO1NYdGOHw0EYGi] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29924cac-65c6-4a36-2025-08da34c36f12 x-ms-exchange-slblob-mailprops: sTyj/kSftosB9bRjlmNyMBZIG2LeY0LGvnCiLhjjEQR/P1HWfkr+14Ut29YzfeKN+RroSfyM5/8beHLETkpzrywkNgSDGDaF9YUgzwCH/PsZ430lz7nyZmSCTcDgzzGtqd/CL9HUZEuKSZZdV8LO0rlnQGH/7Xc74BSpE44ryjq5TFaBWcuMSk2mfuQRYIuD8qztcVyjq39VtQ/VPBIXEzcl1stK2VrK980xsmmDa4acMRXB8vlLWFaTT6lft+z/bo0L9sO3jM3+v33VuHPmcymhfjwUDqMNTtpmVRgIq8JadJOXpFItCRxEl6OHdRDN6scpzYCVHEceYz1tvvTMXFp0YcONhtweK1gN/LWRmgqOJaVEdnfOU2UFAu4L4sQglidF8o69z3+X0zFwxcLauQq2uJi0Ty4mRyWRcQqidE79LQ9M7CQmPvXel5RsZ6E8/FxzlQwG0yxOw3d+hryjzRLGcnDInMY/2CevMf44f9id2gBLyRq0qO7jERFEqB6MeT4HS5naFMqDd+pIQKuLRRB5vfJbhH1F95SjRXXjAQ+cxrxLdfVFmL5C1wPHKAmV/W+Qa7yLoEgj26kBvYNl4wXOlaKgc/vkkbpNQ+i3sJr0XmM9+w1jbVRO75G8+gChHiO2jghQSWDjN6fgL5Dc8Lx2bU4T42NCN0uvy4dvZhlKB5K95ZMyHivP0g0wCHWyPjfLpX1mNeRWt2N2JvHXo+tIYt2Xa6Oxvdns0x3csArXFKteNYQUh8UQ075OqmDaLn68ci0U46dgUfhHxYYgLyhaTBFqFZ0A3Fbl76iOPX0e2ZdCt9f0h0KI1JOi1odRlufQMATEU3uHMVbROO/bkg== x-ms-traffictypediagnostic: MN0P223MB0485:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BJFB+HBNtgIW78GvOOwYsVXDXr8rccGg91UiP7DEesm1hSUgbLsKO8iYBZSSFxSYzYS2sTNP4zYArd9pGF4Ceh8GlkazeL6BA/0z6bcXiJb0nm9jymQWX/Y8Kzon2l/co+8opigHbPCAuZZ7GfTtjcX2C47ED5ChpsqBiiz8wlPQ/2D5TsdutUL+386St2tFPp/Do32BdjBL5tRqmiBo6z/iK2kBOSFcm1psUIG7og6LdPzjoxi7s25FQcMHGn3O2oeCSwG+OK7kTke8QoFUcIJFshnQ9bNcpUEJ8ywyoX/c5huFAX5C0rhQhaS3sC60mhyjDMcKSKcWiHj5dyXlmkr7gq1TAJm4ghuaW+XAg0vN13fXq8BQvfkM1oNJSngz9xzTFWfxEzlNCB9hz6TxIJtcQ8oRbChzRLmN4FXVD0OEBcNu12VzcuanCvvcuc9Zqbvcbv70pGGxdQRXreE1ZJ+3QtWLAOXZDR0kJoh2lxxXVCWEvhS2y7uN/LJRFYFrQ5dfjX3+XXGagAJC87GSz2MyxpssiI7tGUHisRHV/EcIygZ2qItL5XeXg5/l71EZSHmpVOQ1NgfSr0JBKFbhExjkvsWMbS+1n5GUaS7EqPsrAAL5AGi+9O2J67cAmqa/SuZxgmOH5BYvmUaxorpAq3Owvq4CfEC8rrBMZrBMx9k= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVFHdzQ3VW5WZmVuRW5DTHRDMUdRczVjd2pqdzg2OVF4TldVMkRwVlBQdnIz?= =?utf-8?B?YjAwVmJya0l0bzN5bERJVU4xNGF4amxkQk4yZFVZYm1mTWN6bzNPUnpQeURD?= =?utf-8?B?L3hxUXFUT2pqRDgyd2JRUnNPTlVBRUtyZDV3d3JVbU40V0ovRWk3VW5sVkx1?= =?utf-8?B?bk1CV3NHdnNTZjJKSW00UVdlU1JvSW9hS2E2NGQyb29sVjZrajJpZ1kwaFRZ?= =?utf-8?B?MC9KaEVtckJOcENaZFk4QTFzanViTDhyYU05YStLUHV3SWxnOGxVQ1VMbEo5?= =?utf-8?B?VHk1aEFPL3pkWWNFY0RIcTZLSS9qWEV1R0RZVE0rQ2l2MGdoSy9nVXR6dGpY?= =?utf-8?B?bERKU29jYm9FQmZPdW9zU3hEZjBvdTRzTmJsbzBUdVZqbm5kckorUjZ6ajhr?= =?utf-8?B?ZktCdzB6Ymh3YjhJcE95TlRTVUVVMWcvVTFveE9Lenk4cjBCSlgxZ3RBQUU4?= =?utf-8?B?blhXSzZyTDc0VkJCdFlXU3RKMlJxbHZ3cXNiZFJLL2NnanBoa1FOQXN3TGg3?= =?utf-8?B?QW1Fdk15M2JHanowQ0JDcllRZWd1bzVhZm1ENHBHL2xhdkl3TnRLcFhGUGNv?= =?utf-8?B?dTBYbnNyMDNZcS85MG80UllwakZhN2Qwa2xxVDZvSkxlOVVrWXc1U1NMRWZS?= =?utf-8?B?aGFzT1Y4VGlmaWE3Tk5sNDdBWGxUajBYSnpWUXcwL3ZtaWF6dmd3Kzk1NEMz?= =?utf-8?B?NVVZME1vSUFYMnZKTkZOb0oxSEFJeUZuTEQ4R045QnVQaEtlSWhiVjFzNTZk?= =?utf-8?B?dnp3NjBVc3Evd25HQXQ5bk1QdWtxeW55SmhCY0tEdXpuU0J0blZUU2RMUERj?= =?utf-8?B?TlJUQnp5eEJkcStSUWpCK0syMGV6c0lDcG56MldaTnpqbkV2TzBpSGROV2VR?= =?utf-8?B?dFFHbk00Sm9LUzA5VDRUcTRjRnNFN29qKzFMTTMvK2VSMExHUVJQQTA3YTVM?= =?utf-8?B?aVdEY01EMTIrdFltdTBYamI1Yk8rVUN4QWNBMmRNNmJOUDVjQUFudFF3ckpW?= =?utf-8?B?dzg4K2M1K0V5enIyMFU3Y0JNSGsvczV0RTZpNm1VdXE5bmVlZ01wcUlFQ1I3?= =?utf-8?B?WXVzREp6S1NvenNqYVp4MENDbmdyMVhyZG9pd2s2RjlySEVaKy9GUnlSaHBo?= =?utf-8?B?dTNpcHVZcERmYXU5QmcvRFJPOGtRL0d0WWZib2R4L0FqdkM4SHJWOVBzV294?= =?utf-8?B?TGtlYWdHV0liS1k2SXJlUmpvUkJwVzZmL2Vjd2dLbXFUREVFcFVtaWcxNXdz?= =?utf-8?B?NVJpMEFadjdtbEtBcndzMTlzeDJVbnJqN2U3NGxHanJNZHhuM2pldHltOThD?= =?utf-8?B?d2tXTnFURSttRmtQSTZsaThhMHhQeVlvU2JVdStycmdxVkZyd2JaR1podGlI?= =?utf-8?B?eVpDYmxGZGJQc2RldG55TThSWHNqa01GeFliZEttQlFUZFpWcUxYa1prQmJS?= =?utf-8?B?b0NaWGNDSTZkVFlOTVZMZkMySEZISDFMQ25CSkowMnRZK0ZKeVFGK0JXYmJG?= =?utf-8?B?TDE0dzlOZlFKQlBMeWNjMHRmaVd3cjV3eWJleCsvVncxL09SdGNEUmNydDI4?= =?utf-8?B?SGVxRitNalVpZS9yd2RVd08wMUJaUnB6SDlBYzRNaUp3dnRDKzRqRC8vSzQy?= =?utf-8?B?U29lR2VpRVI4VTZMZU9JemIxbG1rK3IwMEVEZ21UTUIrSExRWmdTNlY5Wm5P?= =?utf-8?B?Z0VJM1pBdHlLSXIwNFk1RWxKWjZBMktLTjZSS3FHaXVSV0U2cVdRZ29aVkZ2?= =?utf-8?B?dDNaem1xZmJSYWxWcmNxVkZ4NFBPcTZYTWw3SGJRVEZ1OU5Kc0NMYzZ4aHJq?= =?utf-8?B?Mk1WUzFwQjVaTHlMeW9hRXpLelpTdnYrZVZlbkFaamQzQTIxM3hWMjFUUW52?= =?utf-8?B?WklWNWZ3OXQ3V0NDVDdLYklVeGt3dDdnQmZGN0k3R0RJVTM0ajZDcHNTLzJU?= =?utf-8?Q?FChESfokTBU=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 29924cac-65c6-4a36-2025-08da34c36f12 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 09:32:01.1654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0P223MB0485 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Andreas Rheinhardt > Sent: Friday, May 13, 2022 11:26 AM > To: Soft Works ; FFmpeg development discussions > and patches > Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > ff_nlmeans_init into a header > > Soft Works: > > > > > >> -----Original Message----- > >> From: Andreas Rheinhardt > >> Sent: Friday, May 13, 2022 10:27 AM > >> To: Soft Works ; FFmpeg development > discussions > >> and patches > >> Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >> ff_nlmeans_init into a header > >> > >> Soft Works: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel On Behalf Of > >>>> Andreas Rheinhardt > >>>> Sent: Tuesday, May 3, 2022 8:38 AM > >>>> To: ffmpeg-devel@ffmpeg.org > >>>> Cc: Andreas Rheinhardt > >>>> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >>>> ff_nlmeans_init into a header > >>>> > >>>> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > >>>> and also allows to inline ff_nlmeans_init() irrespectively of > >>>> interposing. > >>>> > >>>> Signed-off-by: Andreas Rheinhardt > > >>>> --- > >>> > >>> [..] > >>> > >>>> + > >>>> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > >>>> +{ > >>>> + dsp->compute_safe_ssd_integral_image = > >>>> compute_safe_ssd_integral_image_c; > >>>> + dsp->compute_weights_line = compute_weights_line_c; > >>>> + > >>>> + if (ARCH_AARCH64) > >>>> + ff_nlmeans_init_aarch64(dsp); > >>> > >>> Hi Andreas, > >>> > >>> the above breaks compilation for me: > >>> > >>> 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > >> unresolved external symbol ff_nlmeans_init_aarch64 referenced in > >> function ff_nlmeans_init > >>> > >>> The reason is that I'm (obviously) not compiling stuff from the > >>> libavfilter\aarch64 subfolder. > >>> > >>> It might need an #ifdef ? > >>> > >>> I haven't taken a deeper look at it, though. > >>> > >>> Thanks, > >>> softworkz > >>> > >>> > >> > >> That surprises me: The earlier code did exactly the same; in fact, > >> using > >> if (ARCH_*) is our typical check for arches in dsp-init code. > > > > I looked at this a bit further. It seems that the VS project > > generation tool that I'm using is creating dummy definitions > > for such cases. In the previous workspace it had generated > > > > void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} > > > > in a separate code file for being able to work with the ffmpeg > > code in VS without modifying any of the code. > > > > Now that you have moved that code to a header file, this logic > > doesn't work anymore. > > > > Why does your compiler not just eliminate dead code like all the > others? > Is this MSVC -O0 behaviour? > I just sent the patch > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296380.html, but > now > that I read this I have to agree with Hendrik: Why not update your > tool > instead? I'm using https://github.com/ShiftMediaProject/FFVS-Project-Generator for years and I'm sure he will adapt. When I had posted, the whole situation wasn't clear to me. Thanks a lot for the patch! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".