From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59A2042AAC for ; Fri, 13 May 2022 09:01:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 279C568B441; Fri, 13 May 2022 12:01:54 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2035.outbound.protection.outlook.com [40.92.42.35]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C52B568B2A0 for ; Fri, 13 May 2022 12:01:46 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zc0UxB3ajZdihVMVoRO36PHrVVkE3HlLmhVLy0hGMCAYC1EjFB+3/Wt64khne9qHII5CP5PIPQekw0zRPje1i73EMkiEmXiDYtAbNaSAmI7EnJW5PrSnFTv7iY2OlBiRBglUnCCJlq9/EmfgSN4KYe0Hu2fa31YK3S8OinXPg2YkO4ZdS1wTJDaM6r1Wr1tN99Ap/pWUQfeHffeBZzVKF/QDiG+EOWQ/JbknMz6v9sI9Pg4bWH+/BalY83jfz95jJjSyfBtEj16fIYyv80XVjrF85k5yHTxz9zdXOU/NTkOvdxPPJVZUZoEqQJy1zzr1aANWqKB+z13k3ns/bJhf5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tv/8raZoci3OQi/S7sRZdpoPQAXq8FQCUANEeGHuSes=; b=oDE5fSiVvQ6o+Zh+lERrGS3vTDPnSrvCflFAyHqigAKtjiuOPpPvkIAQDX7Xd7rC7M+4VY/uD3dx4UWYdg1X4SDPLpK4tS6vmu8eWedRmyNSk3wn65rROTDrVarfT3n10VZN4WWifZ6o84nf9WKOoXtx3vgXybM571arjlZbGbgjRJ3nOTSbgCpzADPyY/VFa3Dqcm87UMH+qIozSCn2wCqN+0oYc77SBo8mZBksqrIqxcWXXV9OuXTkEX3SQg7v5zZK5OF0kT31cCesE7sWlxpRnVdg6tb56ftHx7A/FejHndN54mW6rgaw6B0Z9OQg+CvxcgACfuMqEoM407cpcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tv/8raZoci3OQi/S7sRZdpoPQAXq8FQCUANEeGHuSes=; b=pVf0ciB8fWirEO1mJCY/Q7nw55zS2Q7UYPVhVhQCiSHp/hlByxe2TmLutrrp3y89TGQT2l46aXHSgm9mtGR8aZ9wCPLShBLToAfc41HQqVLUU14k4X55SNA+eBJSvGxrOL3fN8yrPoVeWDhHWqKSsfiTYhnB09jdOtiHzl855/o7hhEpc6P+zn1H+0zvmgJFmFR6+ctKWa9XWrQsIa4cwDz4ZV2WMi3dkj03LkZjkHS88xvQBuRfgKIx9ryFSuQ0lfoWyguU+jYu9zFBYdK44XQsmotnsaf/YnIzO7fJMEke9nr0GLjYfmy7mergfnk6fNb34OrgfFJAFfShBCs5gA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0186.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:f7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 09:01:43 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Fri, 13 May 2022 09:01:43 +0000 From: Soft Works To: Andreas Rheinhardt , FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header Thread-Index: AQHYXriq6NmNTzVVck+rOPFLZ4OqTq0cY0RQgAAl1oCAAANQYA== Date: Fri, 13 May 2022 09:01:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [iQtSy+6ahTDfAk5bs5bx/HalsOJqDK+M] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7660d007-9df1-4915-2884-08da34bf3384 x-ms-exchange-slblob-mailprops: +LiGfBxqLEvHkesRcKowAYSe9YT5HwiwOyagp8R8QQ1OUu69DlLCN7RZ+dw5yATb/COii4Hb2dKlXF4uSoLrHQdk3G2MnZ8UPVFNfwDuN5S4J5EAh2Dh3DMysLRJJhNjrZdOcFafTKDVkSpC4lbd1H4WNOa5Rc2VtjFxcw/05Js8IGOtyyKC8jBtpat0AluZ0ARV1mi1zagjj51WI93D4TrOiHT5zzYUNBdm9JL1jprTcgpfYNR13d0FjxXy1RafUfqKEQe79izvhdJi/2bAILC79W4EQP8NqHloeYy8BS3CP6HG+uW0BI7dNQdDXCy2adb7N4WXW5RJ068FxJolcDe0or3rPW2clschuO9RJQBcx8eay+02kAf1lwpPbeLQXBoL6MrAnQ5YbMVgc/mmHcrdFLCsLecDEdHlyNIrecCvYRkGbcvAn5m8xDeeOmsEJ9WEhTAmzHgwt+iOxxcz3mdJ3MFRHY3Hrnx5XRiUaHSDOx06AtvZuClwk+zAn6aEoxHVt02bM7S7T3UI2FsJjSLKDq6yaEJ8kMK15g1bZJgxnZv+SuyPPWMhCU/iAmOIZGI/atUlzT4oxJuSdbWaaigV/VUQBAbF54u9c4MGinYhZK0j1Tqi8KQ0bXOuivqXYQO3vnf6iIk6Q2QwDGZZkBj359bx6kJ21NWsRbTbvHTz7Kmby3MX2dkhs+DssnmF4TXccShXF+Pv2JP83pO8DzoAkOqsHKQNfZam/lcdSukaGeINxKvP/8u/Es3gfDAOdSByN68cmswbaTPOSmB7/hwYw3fY0Fis x-ms-traffictypediagnostic: CH0P223MB0186:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZuM1P9BZZtII5mSJJ97s+mckuG6sEekALSs5t6vjZT4M2GkKcHhGHYIKjslhWiKybDrBI1PerWH0sSOYN/BMjUnrO9vFSzTswTEu96WqNXs2E6iBZlO2YfOaXTuqz25w3g636Ikh5PVJ8PQ8nEMP3k8Gw/1wUFY6KgKMsojzXKlWB7qWN8cZcbTk2wsF/0MwxG+W0edbOa6veYbI23Up/4ugjt93vzcK/0OGLY/66Q6g9XE45N8ZCpOQOZiodts7X0cFDMD7oRfq75AMS9yUnkk8XQihYTQKH1nvyJtQ2B18Ilenl0S3ROq/Cn2Hn2Oxxh1gB76vSLahrp8LQmiKjGuXeCGGoC5v3sA9+wusYHA4SAvFFc8cv0SXwNCqRTekKGXrpm9/iR2xDgaJjlG67kHzYEK5YsQO6vF0tiUd7jPSmg3nqhuvBIh4omtBUILNAjRDmZWhXewTVzsv9bozYLjVoHyf8RVePpZw6D+ecwtadNppBL/nosMD52NK1vTY+6IXEEnWylcAbeuDm7BRmsRavUX8z0+KF3v28rYabxneawCb21y/jdv5SAnwGyQmGXBObPieydqJZEfPGtCVMQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUE3ckZMN1BodGFnbGhDMDcyK0ZXL0ZLYTdlL09QcFhGYitrOHd6L3pMY0lk?= =?utf-8?B?Rk1FeFZ4L1JrWWs0bXZ0TmEwS3MvSTZmbHdtNVRyU3FBYmlldjNvR2hhL0tU?= =?utf-8?B?anZwYXVZOXFjRVVIQUg0WkxFckY3eTQ0WUJoYW50VXRtdENRem5iT2tmMExa?= =?utf-8?B?RUxvbTRwVGxCYUIzZEk0QldBQ08xRUJ6UGZ5bjkwZXpTSkV3U1ZtZjR4TkNl?= =?utf-8?B?N0tsMnpaeDd6Wmp3cjZyYVFDRkdjQlQxNTBKQnFuQVBIb3MrektEdjVJRU1D?= =?utf-8?B?RFViTXRzd2wzZjJ5TGZobStGSnRsc2IzRlBPd0hVY010UDUzREdQcHhNTCtw?= =?utf-8?B?ZUNtbWFKOFR5Z0RIWTVaTUh0dG82Vk9ZcXgrVjdGQlBWOXFPOFkzWXFGanpU?= =?utf-8?B?WTRpSFExYlpxRG5UQ3dPWDhQU1Zxc0I3L0R6L1JveDQrYTAzMFFxcUJnZENl?= =?utf-8?B?YWluaFZjamtIR2RLRVNsM2llc0VUcGVZdmg3aTVmNksvcUM1eUJrYVdKeTZW?= =?utf-8?B?bmxkdldYMXlSYnhoL0dLZDZ1akdpVFM2NTMrNkUzOVZDYk9XREtkZ0sxTzI3?= =?utf-8?B?VEthRXRuMmt5bEtBMTNJbW1PYVhTOEdTOGFUTDVNN2VLa3dvZzU2SHovZjVi?= =?utf-8?B?MTk2OXZhSWxrUVIrTUJWdytObWRlbGVPM2ttSjZTMHk3NHBsNWNuQjNVV1Vp?= =?utf-8?B?QVM0Znlyd1BCcWlSUnhvODJzc0hHUzNQV2tmaDdjZm80LzMydVdJS293TjhQ?= =?utf-8?B?QThPblN2UElPUm91MWx6OEpmRE4wWmFjU0JaV0d6LzdTaDFwRzAyWnpBVWc3?= =?utf-8?B?VUp5YTJwNUFJMHdLUTErcENRRTZtVFBVaVhPaXRRZXdBZDZKM2Y1ZWR0eUNu?= =?utf-8?B?NVQ5SEdlWEw3TnRjQUxGOFFWUDFqc0h4RGpGdUY4U3JUdWErM0dlbHdwTEFO?= =?utf-8?B?cmNYMTRzNTJ1T29VMzMvK3Bjcmppa2NWNExBbEhsTUdnMVV1K0R3cmVVVERo?= =?utf-8?B?VTA4d2hOV000KytYV1F2U1ZzY2g4TzJEcTQ4VjhPemJRZG9ncWN3UDlRaXRV?= =?utf-8?B?UVNIL0NXelBnbHFJUVJ5Ri80bHBtY0Z4T1htdmJVOGhLeUlMSE5SYlZCMEgx?= =?utf-8?B?cDFwdk9xUWw3ZkdCczVqV1JZc1BOS1htNWhJMHVxNEQyVWhFUG51ZXNJR1RY?= =?utf-8?B?UTNCbWRQejl2WXh0WEtxME9mM0lNZ3JmNXhzTWE3aFhZRjRCS2dUWVJIQTNp?= =?utf-8?B?ayt0SEdTRm9sL2RhRnZrOHIreWd3TExNbzYzV2hlanJJeTI5T2ZYcDB1NkRh?= =?utf-8?B?bHo4YU13NUFhUzJ1L1VCNGhxTjEvcER3RWJibW9LdmhMU09xOVlQSUxzZThQ?= =?utf-8?B?WDZOMXcyYnA2TjNQOWxld1ZqZFJ1dXFQUGtqQnJhRms5VG5sV3hMQjhIVysz?= =?utf-8?B?ZkVFeXMrSkV2TzNhR0QxQS81NWdYVmEvOGxkMlhpeVpaZU9ob2xhQ0g1SjZS?= =?utf-8?B?T2JKNDd3ZEZzSW81cEdxeWh3NUtqek15Qm0wd0laWWVUWDF4U1ZLTXExd0RC?= =?utf-8?B?cGhjV2VWRnMyL3A5OGZVVVJFS0loYWFlNlRMcDhDNk9iZFhqREMySk8yVkJ5?= =?utf-8?B?b2ljTGpxMjd2dHJUb0dhenhFSERqZVhMZmxmd2ttRnhBQUtRZUJIaXZaRFdR?= =?utf-8?B?Sk9WV0pKbWZwNEZaL1lLRGFuY2VhNWl6YjBOYU9NMGJBSHJ2UGFIZ1ZiU2dr?= =?utf-8?B?OGlQNUJFWUpYNitTeGZDc3hSclhCZVN3Z2MwSUJndkt6WTRVMEx5Z29tdzVN?= =?utf-8?B?SWJUMnNHR2VFTWdWd1ljajNsM3hwMUxOV25UOUVvSEFSTEl4VHhzMWtnd1Zk?= =?utf-8?B?Z2FlVGlTU0ZvWFQyN05MQW95dXJFdU5qRVVBVHNPWnh4aUo0am96clYvMGJW?= =?utf-8?Q?rfsLEcXSE1E=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7660d007-9df1-4915-2884-08da34bf3384 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 09:01:43.3731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0186 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Andreas Rheinhardt > Sent: Friday, May 13, 2022 10:27 AM > To: Soft Works ; FFmpeg development discussions > and patches > Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > ff_nlmeans_init into a header > > Soft Works: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> Andreas Rheinhardt > >> Sent: Tuesday, May 3, 2022 8:38 AM > >> To: ffmpeg-devel@ffmpeg.org > >> Cc: Andreas Rheinhardt > >> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > >> ff_nlmeans_init into a header > >> > >> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > >> and also allows to inline ff_nlmeans_init() irrespectively of > >> interposing. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > > > > [..] > > > >> + > >> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > >> +{ > >> + dsp->compute_safe_ssd_integral_image = > >> compute_safe_ssd_integral_image_c; > >> + dsp->compute_weights_line = compute_weights_line_c; > >> + > >> + if (ARCH_AARCH64) > >> + ff_nlmeans_init_aarch64(dsp); > > > > Hi Andreas, > > > > the above breaks compilation for me: > > > > 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > unresolved external symbol ff_nlmeans_init_aarch64 referenced in > function ff_nlmeans_init > > > > The reason is that I'm (obviously) not compiling stuff from the > > libavfilter\aarch64 subfolder. > > > > It might need an #ifdef ? > > > > I haven't taken a deeper look at it, though. > > > > Thanks, > > softworkz > > > > > > That surprises me: The earlier code did exactly the same; in fact, > using > if (ARCH_*) is our typical check for arches in dsp-init code. I looked at this a bit further. It seems that the VS project generation tool that I'm using is creating dummy definitions for such cases. In the previous workspace it had generated void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} in a separate code file for being able to work with the ffmpeg code in VS without modifying any of the code. Now that you have moved that code to a header file, this logic doesn't work anymore. > Is this the only place where this happens? Yes. > Anyway, will send a patch with #if. Great, thanks! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".