From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC5A841A03 for ; Fri, 20 May 2022 09:36:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9241F68B47B; Fri, 20 May 2022 12:36:57 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2054.outbound.protection.outlook.com [40.92.40.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB5EA68B2C4 for ; Fri, 20 May 2022 12:36:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zq5MVlaYOavmjqhbNfRoHcRX59OF59QCQNLILEIZPBdYTLeajFMREjrmoIJjTqRiyk80xPeDrZZ2cYZzv4hzmcx8zxlaSEKK2TihUmovprAKoZ0HpxQekiC4JfCewuj110ln3mqewNRY/VKtqt0UBQCCOZ2ipGS5AfTBJf44KNNoeSeYpsOKQaC1nFd1ykykkRGtzl4WJNyXCM52WzhNrkJlGW4F+PUH89kK0/TCyIVpNx0eYWKipTfJha+4GQKJ1d//RJa6BRxjj8VhiD/8iKxJSRtZWT1bl5gWZ48w+6irPjONPxvzIdHTQcJFYMFAHO1ylfbXn2I2b6Xf4Ngyqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X75JghGL+oKb1k3JhBvtfGCMO8MYAdIZDrx9vRMnpoY=; b=c1Dd5gEf1jQuv4wUcai4mre1aOxiEoppWLNLvZrETfWssY/xFLaaQFBIEwZkvq5Xd/dne5IiF8sJ1H3ZZN2DQg+Y/wm/z23CubAUmi148IZ+nAvtYM/JQ+4aIqtSTUvvwwEMtkt9MzosA61XY4PCaHyRcpTWNXhYdH1n/IqxNZTdy5ZfLK6lif70NewwHEF1oRhhvB2y0Gcn9DABMtXsJx70TLsgG7uh+Tj7u5HugrkGdalSasGE1lyOBuSToRQWxdj3yFwPBir+QgMMvDeeQNWJTnvSqThPqsyHPuMl1/VE49AO9L7PgOX/a8IiORzsBf+EH1p4UH89sZm269DyKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X75JghGL+oKb1k3JhBvtfGCMO8MYAdIZDrx9vRMnpoY=; b=isQKwh/af1I4SyMMWb7Zn9Gaq10Tzg60+m730ehkILDJbNNCM2tjC6x17RDvwUlz04sN8LzXVUfYYKgDaDkiiXTMsjcW5ywNQICLQIaI7S/CnEJgST3B9G/V/wAEKoXqsrQyO5WCYPaECOwWPRImXAYS3Y+iCIaRBYCsgiNa1WRXuvUGOqsnfmYrMlXkPoCTSrZHC7oql762WMobUecM3zWuh3Ho1ccjr2+XKqbCEaFyZ6ZnnZnOXeaKzBj1Z7/nlJF546Zi96zaKyNyLD/143m7EtJ/yj4rnDEnftia2A5cL8Y4Br3zi23sptS30P8RsfAzhoBCHDsc4sU+Hkn5ag== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH0P223MB0059.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 09:36:49 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc%3]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:36:49 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static Thread-Index: AQHYa9MhZAmI4J2BGkWRTzy53N4oQq0ndWMAgAAATfA= Date: Fri, 20 May 2022 09:36:48 +0000 Message-ID: References: <5517ad31-a7ce-cd53-0eb3-7cc74b4cb056@gmail.com> In-Reply-To: <5517ad31-a7ce-cd53-0eb3-7cc74b4cb056@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Xn1h361AH6FHNPqTfiposGr2kvvoteBS] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c62f3cb-aedc-45f2-8ecb-08da3a444366 x-ms-traffictypediagnostic: CH0P223MB0059:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vhmAzo2cAT3rvW/rKD8zQOsXNKSHR9fD44p7RfL3QGghm6OhDkHGGtxDcQ9juyydlXSlG2IrrsWceEkZl6v43Txfn7fQ/JUxr3d5oy1hsoWb3j3HpnNsO+J3ohaz6XJzfSjj0WjDXsOxLIWULo0UHW2kcOr1mKYc/XWCUt8jszuH075TMbR3MVobFJoyXk/VmnpAs85v3JrhNixH5Dpye6MUDCV/8kLag4/rqu1GEro/At9tq5jtNICCfFO33fV7E6WFQM3oxRfoEHktw6ZQG6pGBT8nzQRF7fuDYhECIw8dkDFaFKyz1F9M7J+H42/ygTT+LBL9SSMTNPJApLvk54tLmO0X7UFUPHx0SRw/wA/tLQHVAmhiQFnOnV6eQ0a+YtXc9WDt7PFF+qrq32Q7pB7t4SLx2dILjLg7DPYdMMqcqQ/+9QuOsd2fcv92olnI6QwFRc2blCYmfoy1dkkIZeLzg4pi3KytZBKozsBCmkagidQWb2mzfPCnlrRHzoj6jy8rcjYKEZ+XdBeiDK+Fy5xjAQMW88Tl9R5qoZ5o6Co4uCMVAZkh706GwkhhdTUQYvPmTO9XLYOa6IkxrMocGA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RE5BUXdWL1Z3MkV4cmhuREJJSUk2VnFwaWVRWUdKd2JydVppNDNWTFhOTDFm?= =?utf-8?B?bzNZMnZyRVVIVXRtTGVPV3RpeXFCbmdNWUhUaEMvZUxxWjZNU2xJckl2ck5p?= =?utf-8?B?NVJXNXlnbndHU3ZqdHN1dmxSbjlxNkJJOFRJSjI0OW5IcWgzRXR6M3NVdW5j?= =?utf-8?B?WlRyLzNUeUNMS0ZJejJFQjgrdmpxN3FTRGlPd3BaT1plSjI1bUlBL0NSdWtZ?= =?utf-8?B?YjJ5cjQzS1JSVEk2VFBteXFVMTl6S1RUMlg3UHV1Z2oveERBSmFiS0NOTjdi?= =?utf-8?B?T09UL0VESG8wRlBJRTUvbVdWdi9RZDlnUXNQb1p4M1JmdTJxYmFZQmZUZm1x?= =?utf-8?B?R2JYSGkwVTBMMUdBR2lybDcrUjV2ZUlmaXZKcmdXVmhjYXZNM0ZvSFlsWTFF?= =?utf-8?B?cElqa2dUSWhwbEFpNWhUU1VWZnlFL2RJTS9tZFZsRUllTENQemZXaUpvSE92?= =?utf-8?B?MGRDd2N2WnZUREFJL01SNjZOQmtkMVlZVklhZ1ZjSmlRcHVFUXdteURkVTdl?= =?utf-8?B?K244ODIyUDByODIxZmZWWW01T2pvTXpPaHU0WkozaEhxMWIvbnRsNEdCVjVS?= =?utf-8?B?dlJDWnRkaXV1V1lYOFZ6VE1YamFyMC9uS25LSmYvck1nRlM0SElzbnhoRS8x?= =?utf-8?B?K0E5TEJhcnRkUkVtQWhvdFUzNEJFVkM1RnVSWjN0dEwzdnE2Z3JuT0dvV3E0?= =?utf-8?B?Njl0QXJtSWFQRUtPSlFPeG1lcUM0OWI3N2ZVdG14d0pkMTZ6Q2ExVzJBeGpo?= =?utf-8?B?MzNZZ3gybkthaCszeFI1b0xZaXVvQmZ1cTRWeGpXYnRGYUt1a1R3aGp4czN4?= =?utf-8?B?Z05LZ2F3Q2wrWThlR1Vhekp2a3VhNE8ydmNCaGsrR3JSTHUrZ0x1dVhxNFZo?= =?utf-8?B?UnBCT2VTTml0YTdYekUvNEpFcTYyc1V5TE1MU0Y1bWc1cGNCYnFETEtha3Zk?= =?utf-8?B?UStDRTlnZldRbE9WWnVnaTYrT3pRZXk1MGRDdGx2N0ZWSlUycjB6c21aQjcz?= =?utf-8?B?YkhxcUZBQmR6U3A3TjlZaS9QQ2VMRlduYStmTU44WVRHUEpEV3lqQ29oNy9Q?= =?utf-8?B?ZmkzeW1Xc3NJY3Zvb0F1LzFaU1czWU1hZU1jRHhLaCtSTGhJVU1zU2IvOGx3?= =?utf-8?B?RzliVk9GVytlTmZUcFl2M0FMdUY3TlBuaFdzVFNoUXpZYXdpdTZ4Sm5IallS?= =?utf-8?B?eEs1Z3V6UnY0RGZ3ZksydHUvb0EyU0lsMHZDc3Q2cWg3b3gzb0Q1RGQwTFJL?= =?utf-8?B?NjY3ejFCK3YyYVNCU1VvU1Jqc3pMOEIxdjRmeW9XcXZFelBoSzlCWnNyc0s5?= =?utf-8?B?bElDZE5ONHBTMW1UYW9yUmR2azVUb1VLa2x0T2NiYlZVWlF3T3B5M25XMzBF?= =?utf-8?B?aklxOTdQWjVtNjBiSHlKZktLWXU1RC9EaEg3Q2hhVW52dmt6ekpxV0FyZllv?= =?utf-8?B?NmZTc20xeGhZbnFMem9qUzVSdzV5VGdkbXJsMzN3L01WMkYzN3RRQjJaS3Vq?= =?utf-8?B?bEVFcFVkK1VnRWlvOWNsM3JHYWNkSVdkOW5OY2x1K2JxTkw5WW1maHJmenF1?= =?utf-8?B?RmhOV1BWd3UxZmxTVjNZTHFYd3pYTzUwcEs5SWlnckFiYWFkVHY3THRmN2lE?= =?utf-8?B?WWJNbjRVaGgwaTF4ZDVzOEhUUzRXblh3bGN5bm9iZ3l3Y0I5b2hpR0hZSHR4?= =?utf-8?B?UVczUmpoWHBvYXNUWHZnVzJLTlIrdVVvU2lCY0hKYmFGdFN5eEQwVVhVSEZ6?= =?utf-8?B?NWFlVU1lMWprUVkrT25RYmlqbXFOVTFTTmZtOUpYam83enJEdGQwamdINkxs?= =?utf-8?B?WE1rZk5lelI0ckJoTzRBd3NsYmJCczhwLzRxS1F2SWwzMU9ub2oxTkEzVU1P?= =?utf-8?B?QkxPMHU2bUdvbStwVUx6YmF3dEtMc3BwbU55OFNFS2hnS09VanF5OEdDbnpS?= =?utf-8?Q?cyrXHHJVzWw=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2c62f3cb-aedc-45f2-8ecb-08da3a444366 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 09:36:48.8703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0P223MB0059 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Derek Buitenhuis > Sent: Friday, May 20, 2022 10:50 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define > X264_API_IMPORTS when compiling static > > On 5/19/2022 11:52 PM, softworkz wrote: > > This commit adds a check for the definition of _LIB which indicates > > static linking. > > Googling also seems to indicate that this > definition is no longer available on newer MSVC versions. Probably we have read the same article on SO ;-) But it's not true. When creating a "Static Library" project in Visual Studio 2019, the _LIB macro is defined. When creating a dll project, then it is not defined (instead there is _USRDLL and _WINDLL) Though, building ffmpeg with the VS project system is not the officially supported way for compiling ffmpeg with MSVC, which is performing the build on MSYS2/MinGW from which it is calling the cl.exe and link.exe binaries directly. In that case, no _LIB macro is defined which means that this commit doesn't affect the official MSVC build method. > Doesn't this indicate that FFmpeg is being compiled statically, and not > necessarily that x264 is? Correct. Or to be precise, it indicates that libavcodec is compiled statically. But the thing is: 1. At this point we are in the world of the VS project system (Only) 2. When - in this case - you would want to link the ffmpeg libs statically but x264 as dll, then you'll need to configure this specifically for that. Part of this would be to define "X264_API_IMPORTS" - but in the project properties, not in this code file. In other words: this is a narrow-scoped fix that doesn't affect default ffmpeg build behavior with MSVC. The underlying issue most likely applies to the default MSVC build method as well, but that's out of my scope because I don't use it that way and I can't test that. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".