From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9AC5440F4F for ; Fri, 13 May 2022 09:03:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 52BAB68B45D; Fri, 13 May 2022 12:03:36 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2047.outbound.protection.outlook.com [40.92.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A456D68B2A0 for ; Fri, 13 May 2022 12:03:29 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAJk/WAJLwaczd7pxW7XN+/Tks8UBRmoTtuOJKAE1Dsj5yNWqX4lH4qvykwkOQB4QRXioQgvKxw5UJZQETnJw2sl8rbwvMgwx5DDfNDVxtLt/pqGXjfyPupsDWNBPI8Fc7sHMDKFc4NwgIyOIxRvUGcIWyX1Eh86Z2v0OYx5zZQD3sNoWnP6XGCpbjyZBxCf4CfLH8VsHjGdX+MB6uMnVf77Iy2KUFkQIfpX4LJoPW7d92sqGYOboDJGz2HlPdo7qB0NRyk9Ytdw12bnRUqUL65193KSuSXtGYIvzo7reYtJPzJOr+ogYQs3HH6441k52dV5OumUh+xy8f9MVVV7ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mgnCknRO2MwuTO3UdSyt6iBicZGFk4GRllnBOxTFApg=; b=DeEyFFHgBnpwnFzy6LbaZ42Z07tFekhbemuqdDhjY0cbB6nHEHXy1EELUCHht4loMg2ADJoqVgCATKZtfBEEx7lBA3IBerL3bBqs+BPAgbmtZXz4MKavwMfIA8gtx0mWaujZYp9EEwNl5CC/tZyImcwXAabU9/H70ZOZf1xk17AjX5O1j5Firpz663s2rjk4+6+F8enqEaQUBoj36LK+19RVkAba+xu4NzjGZTgye4AHZZ/aZhZaMxfYSqvp5PkQ/uNIesS0UyEkbdb9u3FudKC7fpIRwNkECIk8TG/S9aEu7UWyyXOdKW6u+bKft+eG/jPrb/5rkzwW4G2s19gZaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mgnCknRO2MwuTO3UdSyt6iBicZGFk4GRllnBOxTFApg=; b=ZrI7uTx2+JLF4El9irqqxWrq3HUqYCP91pYa8CHtKc/nDke5GwVT0V5ylnwnelItIHUDAACgnAuyUF+2a+jkklG8y+CtB0a2BXczNSnFa3X8wvQhCUrIChvTdNdumo+bcBsrckDRnewnK7P4JioR+FKwPyHFukP4M7Fny/bbZdfNn4LTWACZwax1X10gtqgsCqvD8f9PQtK/yqboAj8LlfgDuUmY4vUN6YPibwv1jCw44oGizBvEgjjiTTx/K4HL627uG5M2DExJgVlD8kK0rvINokbF84Wzs6S/3RjKHDFZR1Y2tfcHcYbxh5q6UblQh1DbEZa/U8IhUYM1GVDUxg== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by SJ1P223MB0411.NAMP223.PROD.OUTLOOK.COM (2603:10b6:a03:48a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Fri, 13 May 2022 09:03:27 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Fri, 13 May 2022 09:03:26 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header Thread-Index: AQHYXriq6NmNTzVVck+rOPFLZ4OqTq0cY0RQgAAl1oCAAAkmgIAAAIPA Date: Fri, 13 May 2022 09:03:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [SujqyiUR3aDHXIFKhvpCADRP5D9c/rKz] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a380322-e37f-46ae-28fe-08da34bf7137 x-ms-traffictypediagnostic: SJ1P223MB0411:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q4993OhsFXo0JEL09udPebRQbBmrF8IhwLD3bMXib+qHT/YAZvECV9BlxWG/nXk3YrXQQbZ5+NFcxFjgoxKC8hhn/Qu3CSUhesXr99Z7W/mv+5BlGTyOeOfrTSCLZCM7ILdhY138XONwkA6n5zyHKPKcR2mNewRRTVG31y6pwEdmBFOV68jxUalJA4QhFBxEi14tyw4qvX8xl+KPjqP88Q8EaDuDq0eEGzK0Hd1k0chWTnbDWx937KYeCF2qd3K2uJfsK5gur94BCvskOdVaZC+N34bK6KuZtmJ3WjdRO81ryqfkhMdNALh9cL3kDa439PPI9H/E9ZawGsEMHwxdsFtk2GtZUFU9lNjChF369fCbGx51hMjrAlc/Wx65gxdnZToJWJWcIEWU3/NuPBhAlFhdwV8ha4bH+DhcOMAaI3Hl59sLu9CI3vPubbOdWkeaHRhCKmz5G0UqvCI3wSU6UrK4OxdQq9mPKULvAH37wYF6Yt9lCKHmzKq81tYdNQ0LkuRiDEEXCSqho3wGle3s6ELNJWiSaIYENtSDK7vcrYVYX1wew16BHNnUMCcO6b+ta2EktxCrLs1Y/E7LsdbyAA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OUswbCtmdFVXMTZnVXBtSW40SVFJWVVrdWJhZG9XeGJld1pwYzJLZzNEWnhn?= =?utf-8?B?N3dwVlJELzVuSVV1eDNKR3B4OWw0VGJuMlpLWWdGZTRYbUdQaVd1YStPbC9O?= =?utf-8?B?RTV2ZjRLbWpQZ085MllIL0o1bVo4RkhVOEkzRDJYek1IeExUTEJmNmExQS9B?= =?utf-8?B?SnJqWG1RV1QySVdLMTQ5SWZIZjRyTG1lZ0pWTVIxZVpGSXZVRldjbDcyNUtM?= =?utf-8?B?UGZ4VEdPTTFpc2wwYVlHU29ub2VqZTlVQytvN2lXYU12dGJQVVYrdElRYUZK?= =?utf-8?B?ZmpHTFhWTVFBa3NJdXdkeFhtbG8vN2EvYlZhTUc0bGJyMFUxSGZkV3VscHV2?= =?utf-8?B?TEdGVmpRY3NFRkZKT0hxUlJhYmNHZWtRZEpCTjRnUmE1cjFSSDhBZTdDV092?= =?utf-8?B?cUw3RldKTTBtbXhkTEphMmhNb1pjak9wWm0vNmg5THFzREFiaXJ4T0dWZzRa?= =?utf-8?B?RWIxNDU4M2JDK1dlY1AvbUZGWS9la0tRRHZUbEExSjBVRTF0NjhzdWJFWTJX?= =?utf-8?B?SFYraFZUM292dmNLOE1oTEs3Mmk1K2ZsOEZWb1J2U2pjTE9HMzlKekVEdUF2?= =?utf-8?B?ZGhURFRSYnZOdzRwZStXK3pmNWRFMDdWeUg3cm90c2JaWHAxbkhCNWVXTHRs?= =?utf-8?B?K1haM3BPNHlqQlF2VytoRXQzd0xEc1Y0REdoSitxYWVhZkIvWFB4NzB4eDQw?= =?utf-8?B?bmk2QXhQaXFFajkxRmdGbENLNzVwZFh3a1NDOVE5ZDVKK3ZnVmo2U0FSMHVo?= =?utf-8?B?UkcxMk9VcTZWRmNXZkd3RVhSVk02L0M5UkQ5NzFuSUZYa2piUjRoUUdMQmcy?= =?utf-8?B?eFAxK1Y1bzBSSVZjTThFR2d4QmE0UDJUQ1VJbEQwdnVzMEN2bkgyaE5EL0Iv?= =?utf-8?B?eng1WGJEeFRZYmF3N2VYZTlXNzdJSFdzY2MwWTRMRFVncFlDb255LzFnUVJD?= =?utf-8?B?SUYzSHZqaGp4SVhoTnFKMXl4TDMwamhRVHdRMFZjdHVKejJaUnhkSVFpOTBV?= =?utf-8?B?VlBaYzM5aW9iVWR6NUhIb1pkK2ZtNG1zUjA3N25VYnZJZStKdkJJUWc5SFpB?= =?utf-8?B?NHNnVEx4Ni9uY094bitEMk1QRk9oZ2RMYmVpNDMxNzdzL0d3MlMwNGptV09i?= =?utf-8?B?cmhsTHRab1ZYaTQxM1laRXJpbk9JK2E1QUpqUFNvcEdlekJFckxlK3ZCSzVw?= =?utf-8?B?Qk9tWjFoejBMT0JkaGN6K0dtM2JXMFpKcVZOVnlDZStRbGlCT014bDJXMGNl?= =?utf-8?B?ZUdqSzBsVDc1dzZWSTRaMEZKM2lhS0phWExVSzRDcUtRMEszNWpLZURIOUFt?= =?utf-8?B?VDF1cjFERVFtTHg2NjJqZ01SY2tRWThYTmNRMC9YNGxqQThYa0YxZU5TUVNE?= =?utf-8?B?aTgxTjVwSy9XWEYzYTh1KzBkV2trMDBhZXVyOEJ0Q2ZVZXgwV1Y4NkFDRGtz?= =?utf-8?B?WUp4RHphVDd6TVB3bkkvRHlCdXVuVjByaU9yZ1oyTlJySyt4bGc5T0dNdUFv?= =?utf-8?B?aWlKaEJUNE5pZktNM2JMcFk0dVNrTUxjZjlaaURTMlRDRVZITHN6Q2RGZHEv?= =?utf-8?B?cWdmaklQaStSL1p4Q2t1Tlh4Sk8rbkp0ZUgzYis2bDNTU2l1aFl5emJHS3dT?= =?utf-8?B?MTBDTGJwa1Y2bG5xS1haNjhCUmNoSFJRVEtpL21kbW5rMkl3RzNabkNPY3Vq?= =?utf-8?B?T09SM1JveE9QVEdMaFU2NnU2OTNPb3dPQjlldFgvZ3BRcTZPY1hERTlzcU5G?= =?utf-8?B?dXpzeVVHcWZkb0MxaG5OYXMvcldOQnBESlpCQ2xzUjVvbFZaS01uOXV2dFVF?= =?utf-8?B?bnJHZHYrc1FQYUNUSitYR0Z0cDBUNXZkUXpySDYxR2F1cm0zQ1RUajRsbGZX?= =?utf-8?B?ZVdvZDFvZkFSYjJUSXBpQkd2Zmd5QTh3T1JsaWxEL09ROXJFMFpTV0ZCZnZM?= =?utf-8?Q?O5KQ223DoSs=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 9a380322-e37f-46ae-28fe-08da34bf7137 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 09:03:26.8872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1P223MB0411 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Friday, May 13, 2022 11:00 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > ff_nlmeans_init into a header > > On Fri, May 13, 2022 at 10:27 AM Andreas Rheinhardt > wrote: > > > > Soft Works: > > > > > > > > >> -----Original Message----- > > >> From: ffmpeg-devel On Behalf Of > > >> Andreas Rheinhardt > > >> Sent: Tuesday, May 3, 2022 8:38 AM > > >> To: ffmpeg-devel@ffmpeg.org > > >> Cc: Andreas Rheinhardt > > >> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > > >> ff_nlmeans_init into a header > > >> > > >> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > > >> and also allows to inline ff_nlmeans_init() irrespectively of > > >> interposing. > > >> > > >> Signed-off-by: Andreas Rheinhardt > > > >> --- > > > > > > [..] > > > > > >> + > > >> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > > >> +{ > > >> + dsp->compute_safe_ssd_integral_image = > > >> compute_safe_ssd_integral_image_c; > > >> + dsp->compute_weights_line = compute_weights_line_c; > > >> + > > >> + if (ARCH_AARCH64) > > >> + ff_nlmeans_init_aarch64(dsp); > > > > > > Hi Andreas, > > > > > > the above breaks compilation for me: > > > > > > 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > unresolved external symbol ff_nlmeans_init_aarch64 referenced in > function ff_nlmeans_init > > > > > > The reason is that I'm (obviously) not compiling stuff from the > > > libavfilter\aarch64 subfolder. > > > > > > It might need an #ifdef ? > > > > > > I haven't taken a deeper look at it, though. > > > > > > Thanks, > > > softworkz > > > > > > > > > > That surprises me: The earlier code did exactly the same; in fact, > using > > if (ARCH_*) is our typical check for arches in dsp-init code. > > Is this the only place where this happens? > > #ifdef is certainly wrong: All ARCH_* are always defined; they are > just > > 0 or 1. > > Anyway, will send a patch with #if. > > > > The inlining due to the code coming from a header probably breaks > dead-code-elimination in some compilers. Ah, that explains why that file with the empty stubs is named dce_defs.c :-) Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".