From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD192402DB for ; Fri, 21 Jan 2022 04:52:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 439D668B104; Fri, 21 Jan 2022 06:52:22 +0200 (EET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2057.outbound.protection.outlook.com [40.92.40.57]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 200FB68B0AE for ; Fri, 21 Jan 2022 06:52:15 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gcoIKIWNosv4rr/7ezeyKpghoYT9937t38ic5rxk1uazrlJ1MvyDG3ZDL83zzPd5AbxDosRN0btp/xg0zyXveSEGshjZ7YJzDINXaEwUpwCwnwoEeNUwga04PxQFxz56PjJ4cQ6jZVSRmJpSlQwBRiRF/cZ/eIcilFFHlvQZPFykmSeC+Nmdba1dgi/CW34CoelJiE0yX2PC97ZAx8AW1eowhM9+rsta+iltL2svx5SkrCIzagosW6B1QvxBOGFFoywN7DIFEL8GZvIDwyWtkEs3FxEvI1MuCHRL8q65ZFFqyJi6Vw2yEI2+5djVE2v5iC+HhWReOFZSYEZp1M8rmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z8jwreIIy0NPJClQzVgXhPYdnpcKlmbRDfu2rpjszTM=; b=fuwgMKMwa+13+Kv37u6MhgJ0wnFj2HuaAA2vOGugrGhlUCk7uLyJexpMN8+D+AOZ2LGiAimLAySRljklDvY6aUeZyTCmJWE8+5kq1Fymzyjs7lpSKt5iXNdC67m4Ms1sd43HSVwvfqVpS/wSuFswJT5Ia4IMD3h5UIYl0Kn9ftrve9onPqIUUi3vteG4c8FtrH/Wzw/Jonc3dS2cnLvrLy9sgA7ePhSO8nr/X8NcpLsYfur9/fyaijujcfffuKL3Z8YI1AC5i1UXg+PasLjf72r94MwYybOR0FZtY023kuNIStBPzmePEm4YoKeGDA3KfgMv1RA6RivISbXXhqiSrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z8jwreIIy0NPJClQzVgXhPYdnpcKlmbRDfu2rpjszTM=; b=rLeX5njEILfSDLxv1Ev6ktCqAoTCaJWHsY0+Lh+r0R78EOF81et/D1QQmyTz14YrhESpjrcUmcdYYFuEgKHFlmFYBEtKBAvgvxUie7CUWdagR8l/1MWHdDe+yvT1pblIILjglDLuzgtNOK84k0D+xTxsxp/eavntO0Z30pJJjjjePflVklSR6uuSihLtJdT/g3H5nwe/Rp2L5V9KEZARf1AzVolUrw52iNG2Pbso8zxyDYz7fhbNbbUAexfT+gb5pME3VPx0E5dmA2X0Is+q1QT8dW9jcTStccq1VyXv2RKANin2Ild6QkbeZbMBq82/4Nr0Re9hYQnV/uQXToLG2A== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0226.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Fri, 21 Jan 2022 04:52:12 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::54ae:66eb:e304:96d6%7]) with mapi id 15.20.4909.012; Fri, 21 Jan 2022 04:52:12 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Patchwork FATE Errors Thread-Index: AdgOQNFmFBJsNZyGRJ6OuUpdsVW+VwAAvO0AAAFcPsAAAUbugAAAsjEwAAVfjgAAABZmYAAF878AAABXs0A= Date: Fri, 21 Jan 2022 04:52:12 +0000 Message-ID: References: <20220121042418.qahluvi7zjbbilkk@jackie> In-Reply-To: <20220121042418.qahluvi7zjbbilkk@jackie> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [CtPAonlBf2BbLBaPKxVBIz36KPbRky20] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1c565b7-f2bc-4c0b-ea57-08d9dc99c9ef x-ms-traffictypediagnostic: BL3P223MB0226:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TnoKO2puehxtShT0rBzz4Vb2t7RUNmm4W6hs2HiuxMxbELPhsiiNCX5LjtlrDN4YAlfG/H6Ns9MjZ6gtggJ6kafBeolGRvjErrlRG5QPMrujytkndwLu43r98l6JUaTFmkdMGHt9qV58CUGJGO0/CqKNJXucbwZXMlfjsua1sqxWd4mTxZR/wK4fzBcw9RTGT+iase202xQoYwqDS/npZpG0C/CiU1cSAo/PO/TGM0GFfHvtE5VEWMSMvyiYJDfYmUznurkHvt3HpKbsp/jqbaDPQQcc3jB+F/1ZpNC9GLhPC3pGtsLDvpe6HWdSKJdPbZABlmo4126RyfP7y+TYERLiMa4cjLcfnM1/4nEJfmmZa1OgwSL6SQMSyrcMW2SrIUwhim44sSmNoqiM6xchdgsKYdgrZM0nGFvROD8keReYb2Zkx/TRt3g2uM8Oimir40IFRD+o8YcM5s2VlMew0UhoYpNlEvKQAfdOUOlnw7Exoo++LHL8jWlcj9qYnOP2PIN1HiEd1GEz3L4g+xRvbfbhoS+CLbkWkNDUZau3o1qf11w8cEJuNv9oaP9JAWfrZPAqld7gxZON7A9z+j4swyQOjfxLfXgwfEsEm0tLV2TZq0arnpV16bU3EzbT++02CjAFZ0kNlv3YYKWwGHcBFK1suKh9O5P37QhHBxZAgiI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L2xFSHhidVBLQWlwTWRZWDVNTC9iOFRYeXZaWVpzVGxhcXhJZlVVYjBPdlMy?= =?utf-8?B?L3FrYXg0NGxsUEdVQWFBalhWN3ZUbndrRXd6WXYrWERwQ096MXl4TlR3Qncx?= =?utf-8?B?S1BrdUNFeUt1cnU4YjhNV1RZekdzeC8xN0ZUd1RPYmMrNHhVaWMzT3FBTDI2?= =?utf-8?B?TW9MWFRjdlpvTkNYTHRkVUNGQVg2YXplMkFraXd0emhyQThxQTFWV3RHYndD?= =?utf-8?B?c2tVZFhJVjdZcnJLd1hjWi9lZXFMNEdWN0JhNEE5L2RQaUdnOUp3aWV3VDN1?= =?utf-8?B?UTlPc0pxdkZObFhWbHo3c25kaWQrZDlONnc0N0JQNXRpVjhFWkNYekdFSG9J?= =?utf-8?B?TEJtYXAydEVDSytWZW43Q041MTMrUUZyVFp6NWNqME4vT1lYYkwzaklGcnR0?= =?utf-8?B?c25heFpyVWVWb251d216Tkx5emhCRDVScXRUZkpUYW1zRkVJcTFNaEtzU09y?= =?utf-8?B?QlJEcFFxTGRHc1l2YmhCSjdxUjJNbUVNTU1wUUErdGxLdWlaQXkraG0wUWVH?= =?utf-8?B?UituS3ZzZ1RqSUt6YmVLbjk4TW9nQkpXclJKNkU3QzA5NHpTUVJXelJBTDh6?= =?utf-8?B?YUpsd2hCd1JaVHdIMkRYTkRYWkkxUmNka3prNjFrQUNRNUhrS0lkTDFOeGQ4?= =?utf-8?B?VWJJWXR4ZVJGUGozMVE2d2FiNzBQODR0Z0tQWktIVm96a1d2bUQ0LzFqNlRY?= =?utf-8?B?eSthNlM4Uzl1ZXFJbFlxQzRnN1A1WXVKMlJ5MWFzakVmRDhMekhXYmFBampp?= =?utf-8?B?RWpTNUZFM2w5UVFNL2tnUC81NU5VZ1o4TnJvN0VxOGN6UjZHR3hCVmFWQkI0?= =?utf-8?B?UTJrR0hzaExJdTZwYm95RUE2WkRzZi8wMmZhcjZXVU0wdDBiNUNLTVJVN0JU?= =?utf-8?B?VUxYd29hMkhuY2g2dFRqUG1NYUtPdUJXK2NFS1ZHNW1LVU1ibnJHQ1UyYzZM?= =?utf-8?B?aWlHQnp6YllvYU1pUnZLYlYwSENtckRvQUJFQzQ1K1Z1R2JReXhib1BPZmFv?= =?utf-8?B?T1pDdlRkZWlCUmJJMUplK1A5RjZjTXE5RGxnbERCUUl4SzU4MElFSVdBTDg4?= =?utf-8?B?RFNVaGI1d1FvZXhhWDFDWmR5OENiS2xXNjk2djk1cTZzd1d1ck5BVHZCOVZL?= =?utf-8?B?VmlwSDN3b1BQTWRrOEp5TjF2Ri9pVVdUQnlaQTlhK2pseU1ZaFUxNldMVkFD?= =?utf-8?B?d2Z2MENnWXdnYWdRTFFkcHVESVBCRnkyWXhJSGV1VlJsUGRmd2haUmQvamJZ?= =?utf-8?B?VWVmRFhCdjVQUE1pMnBSak5BT3RYVXlzNjR0YkxhU0hFQlZQdz09?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a1c565b7-f2bc-4c0b-ea57-08d9dc99c9ef X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 04:52:12.3174 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0226 Subject: Re: [FFmpeg-devel] Patchwork FATE Errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Andriy > Gelman > Sent: Friday, January 21, 2022 5:24 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > On Fri, 21. Jan 01:44, Soft Works wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of Andreas > > > Rheinhardt > > > Sent: Friday, January 21, 2022 2:31 AM > > > To: ffmpeg-devel@ffmpeg.org > > > Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > > > > Soft Works: > > > > > > > > > > > >> -----Original Message----- > > > >> From: ffmpeg-devel On Behalf Of > Andreas > > > >> Rheinhardt > > > >> Sent: Thursday, January 20, 2022 11:38 PM > > > >> To: ffmpeg-devel@ffmpeg.org > > > >> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > >> > > > >> Soft Works: > > > >>> > > > >>> > > > >>>> -----Original Message----- > > > >>>> From: ffmpeg-devel On Behalf Of > > > Andreas > > > >>>> Rheinhardt > > > >>>> Sent: Thursday, January 20, 2022 10:22 PM > > > >>>> To: ffmpeg-devel@ffmpeg.org > > > >>>> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors > > > >>>> > > > >>>> Soft Works: > > > >>>>> > > > >>>>> andriy/make_fate_ppc > > > >>>>> > > > >>>>> => Does it possibly need 'make fate-rsync'? > > > >>>>> > > > >>>> > > > >>>> No. The test does not rely on need samples; > > > >>> > > > >>> It was just a very quick guess, because yesterday I rebased and > > > >>> saw the test matroska-dovi-write-config7 failing which was fixed > > > >>> after fate-rsync - that's why I though it might be the same reason > > > >>> (with make -jX, it's probably not deterministic, which test will > > > >>> fail first). > > > >>> > > > >>> > > > >>>> and the other test that uses > > > >>>> this sample works fine. Some time ago, someone else wrote FATE tests > for > > > >>>> AVDOVIDecoderConfigurationRecord in Matroska > > > >>>> > > > (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220101165153.440729- > > > >> 6- > > > >>>> tcChlisop0@gmail.com/). > > > >>>> These were faulty and one of them relied on a sample that has > apparently > > > >>>> never been uploaded (but this test is actually redundant with the > other > > > >>>> test), so I investigated and saw that the test (presumably > > > >>>> unintentially) reencoded audio, so I switched it to a pure copy test > and > > > >>>> applied it, believing that codec-copy tests could not possibly for > some > > > >>>> arches. That was a mistake and I am deeply sorry for this mess. > > > >>> > > > >>> Nevermind - things happen.. > > > >>> > > > >>> > > > >>> BTW, I was thinking about submitting a patch for > libavutil/tests/md5.c > > > >>> > > > >>> something like: > > > >>> > > > >>> #ifdef __GNUC__ > > > >>> #pragma GCC diagnostic ignored "-Wdiscarded-qualifiers" > > > >>> #endif > > > >>> > > > >>> #ifdef __clang__ > > > >>> #pragma clang diagnostic ignored "-Wdiscarded-qualifiers" > > > >>> #endif > > > >>> > > > >>> Would that make sense? > > > >>> Those warnings are appearing in every single fate error output on > > > >> patchwork, > > > >>> possibly covering up more relevant things. > > > >>> > > > >> > > > >> Instead of pragmas one should limit the volatile to those compilers > > > >> which miscompile the code without them. > > > >> (IMO one does not need to find the exact set of compilers that > > > >> miscompile this; all that matters is that recent versions don't give > > > >> warnings and old versions don't miscompile. If some compilers of > medium > > > >> age still show this warning afterwards without needing the volatile, > so > > > >> be it.) > > > > > > > > You mean like this? > > > > > > > > #if defined(__clang__) && defined(__clang_major__) && __clang_major__ < > 4 > > > > volatile uint8_t in[1000]; // volatile to workaround > > > http://llvm.org/bugs/show_bug.cgi?id=20849 > > > > #else > > > > uint8_t in[1000]; > > > > #endif > > > > > > > > > > I would not use an else branch, but only put the volatile and the > > > comment in the #if branch. > > > > > > > > > > > It was fixed in 3.5.1, so "medium age" would be 3.5.1 to 4.0.0 > > > > > > > > > > Fine by me if tested. > > > > > I do not have a Clang setup locally, I'd assume at least one of the > > Patchwork VMs uses Clang? > > They're all using gcc at the moment. > I can try to add extra info about the runners and their status. Maybe to a > grafana page. Maybe the effort would be better spent on improving the fate-error output. Of course in most cases, one can reproduce locally, but not always. The md5 warnings are gone with my patch. Before: https://patchwork.ffmpeg.org/check/52439/ After: https://patchwork.ffmpeg.org/check/52456/ What would be nice is when it would output all *.err (and maybe *.diff) files from the fate run. Just an idea, though.. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".