From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9685440FE2 for ; Fri, 13 May 2022 23:51:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7ED7E68B439; Sat, 14 May 2022 02:51:32 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2046.outbound.protection.outlook.com [40.92.22.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B18D86801E6 for ; Sat, 14 May 2022 02:51:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5lBdzUF60Hl/jRL7s5NqQPKefZ8U6Lmr9JT2EoIQkQlUni8wHUa31wcdw0lpcEvswarDFiStkd+U78xU/viQJdjBEPDHHxZVWiW99gw1rZuSVGr5PNa40t/80Pb9HOeXq1zEYL54Kg6gy0d167YbtPOTy66ceBnNZMUTeIjBQCf2xhG7g8RQxGELFCt25ISW+byajaQ2emwynUFY67lQUJmPekieIA04SCot6ZVajofOa0Vgl3NtBkFDvn33pPTOu4pLiFkSJRvT/V7EEFZ4/ZdS05sLHk5QwI8yJLP3qJwhM2gc/sfaLL1bQikY8aqgr7nYtHVbI7FG4ZuBLIo0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tZDbISnTaJKSmySdE4CjRP1xdRI7yD6sbiKDuHZuK1g=; b=cFaTxQAnWjcdB0lXgstX6IChgR7lWYm8OWU5KCewNhAGl0yIV9SPKDcXdEq1NE/wmRyqWesrqipj251wWwc4FivwJkhfegtXlSJ0oJbWDklEjzOITMywckbngymgAbOWiSUgk1wRU5YUd2Ruj+bw+BzurFMXm6nBmEWfJNe4I8XlXFaon7DzpXhJuV07kyPy8+pw4r+pdrZ3WA/VyF7INd621fwsexAicpo+PQ5n4C+ZQ8SX6yrnvUw+68wISVymlU23HNGINlZltUrkRBUY59Ap6xVDPtGx645cTVf+kYRey7MmTiEmfKfpJfZwzsullcqTxVFxeWl+56JD4UdyKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tZDbISnTaJKSmySdE4CjRP1xdRI7yD6sbiKDuHZuK1g=; b=L8K5sP8XdILxOS8snNKRgII7GgiXEUSYgASjFOD0JyOw2P/qQS2D3IhFQEfqMCo7nMPr9MPi3CNPBx2DWQe+3UEojI3+Uj2RQt8sJpHz/iZMNL2I2RHLX2WHmag7dcB3X1SBSJxnjDrIfaFscAdrpLS1ecW3tfnUvff0Aee/hOa7jDPeDWdcRHhOfq7BBo/G8pijf6/AMNWS2qcqgYvrEKTPePWZ7i5dw2HT67u3jNZXilrrHA3PeqrxHV4Jb+oY8o/K4bIZ+tMrzgvdyNl/o40RBb0LjUYlqZ36I+r0CMKiQ591PiQvjBeab3au2VpFw8FzB/ZGk5hlR3mjdL2KJQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0152.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:147::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 23:51:23 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Fri, 13 May 2022 23:51:23 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] fftools/opt_common: add missing include of avf/version.h Thread-Index: AQHYZq5YzhTwo9WNTUWE5A+mqAaKI60czm8AgACkSiA= Date: Fri, 13 May 2022 23:51:23 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [3/XA1p/M6ONeoyyH30TEdFap5WkND/1u] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 639b2726-0937-4005-43ec-08da353b7ca4 x-ms-traffictypediagnostic: BN0P223MB0152:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HY+M36LJKep6hb0ntjujFXmW7gCxCnRaL/41O6KFqrRN0ipsVH14mYzZgxyOlRCFx8vGSZEoog+cbkC3SpOJI2jQyQ6w9Q6rb/cTleG3TImyss3vntzjUf4aI4wFckH67mYb31z9BsEzVNeppcFX+dRVBydWGY03G5KBqWrX6holhAJpLrXdWhMrZxkNymEzVcQgT9DLjy+R16QfSP8WeIwQYiFJGs02FS886Q4HFaqoULGRIG97CbU73J+qFu82h+S2/IsqzNvYR+LjEMFhmoPvVGrktqpMrczkSOqD2gGIhiflpBHqn0Rtf0RU94EZE3K8LIt0JKYSVyQze8hlU1CirOKyg8dHSFmhpqgxGauyD577Q/HCIJIptLbqpKp7vl20c1U1BOJZcCdZ/Ch4r9Fl8+HW4HmAVy1NP4LH3BLCP9wT6oJ3kIKKp7YA835YuxDyICR36RpaIn7VjHAkFYEZxNw/5hx3/iqeUlB6g1q7Lc84qBIofeos743t4vXpvF8KruLMX7rI9PBDuWpBaGhYDPquGcjtCf/LaiKMybRf+/eQSnJKk/LWrDtMnawFCCeYxulOMVv3ZbNw4orNG4LImFpm+u7NRVIq63h2RfPwy06fZPW7jlLb0K9EECdbeVuLEgW97gu6VktV1NdGYw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WlNQbVdZZE1jekZZeDJlRjltZUYxU0d5blROZWl1SFE2UFZNOEJQNFdtVlUv?= =?utf-8?B?VVZQd1Q3NEsvelpoenVDNzhmaVR1bXNZdGw4NS9IcU5FaS91QTMxdkc2dnNX?= =?utf-8?B?MGFNQS9ETnhwSXRTRnkwK0p5dzdIb3I4bkZHMStSOU1QTVo4UnhidWFXQVJX?= =?utf-8?B?UFBmT2szS3AydzYwTUFSaHVmSy9kaERPeWNwQlA4NzFvQXYxQ2o1U1RoaUIz?= =?utf-8?B?NXFHcXh4b0RYWE1zVk8zWWlYRm5OUzVXaDgvWXVJRmI1N1dUdjIzZlRFWGNI?= =?utf-8?B?ZWMrY2xsM0dxTytxcWRlNDk2L2lSeHU2M21EakpRdXdwZTZMTU5oOURiWjZq?= =?utf-8?B?THIrOHljaU9iSmRJUlBmRjFtZTY1am9Ec0dsVzlVUHZyRlA3NDJGZ2N5N2J2?= =?utf-8?B?cUs1QlU1MUFHbUFBMVVMUS9ocTZzRnM3UVh1cmNKY3orYktRYW9lYytOWGI3?= =?utf-8?B?eVF6SVVxU2hzL2ZEM2FBVVE4cEgvUXhSaXZ0Q3U5eWRhL0pwejM3YWFkam5K?= =?utf-8?B?NTQwaEdsQVFHOVFYQ1RXdHNmQ2cwcXZnMDVPSndVSWQ1OFREODBUTG5lazVl?= =?utf-8?B?UVdWRVlaellFMWRMYVlDTFAvL0FONzhBQ0VvazNjNlJtUDdaMUVkU3VKRDNK?= =?utf-8?B?djljRFRTRzJoZmRNRS9Id2hySXR6Qlo5cWpJaG1DN1VOQitKNTFmam1vMHMx?= =?utf-8?B?K2laaS9sMDhvdlNXd3dYYWprSEF1M21wNmdJMVVCY2hheERxUGlMb0UwbU9u?= =?utf-8?B?Y2VOZG9EdGxpaE1xVFY2dXRkRDJPQno4Sk1MU1hlN1dhdFpmNUVFTmtQd3p6?= =?utf-8?B?R3lPUENURXBhbjQxczVtNFJBMi9URS9YYnlKd1RMQ081d1I5SWdId2R2NXRn?= =?utf-8?B?cEtteW9uUk1QSStNY0owa3FqY3F3R1BUeFhpSG13NFk0TWlUTitLUDRoeTFm?= =?utf-8?B?elNYUGt5SGF4NDA3SGs2QjViTkZLaUwwTkpTb3JPSWpVaVpDSk9WczZ3VmRq?= =?utf-8?B?QnhvT3hXYlN3K1ZuWkNVWWZMUnoyY29RTzJkYVJOcVVtYW96V0FJYUZsTGhn?= =?utf-8?B?VXdKbnF6S2lrc3dDZTJwb1FuQjN4dllqSS9ydlczVDBnY3Z3ekM1d1BsQXlI?= =?utf-8?B?aTJ0QlBxSlFZek1aaTR6dUdCaDFnT0xIVXpkQm5CK1Q1eHBZSC9UMXI1Rk5x?= =?utf-8?B?QlNkVXdzKzhVUit3cWhOQjR3blpTRkdodlhEYUI5MjlzNW1pZFJSa1o4N21J?= =?utf-8?B?cWRnQWJaZ1phWStmTUQ1T1ZBSXp0T0o1b1hVZWQ0SVhGWkxRS3AzMDBtS3FL?= =?utf-8?B?UTcwZWFnQnBQSllRT21qZEdCdVZoOTV6U0tRWnV3em0zTEpUNElNUGt2Rm5R?= =?utf-8?B?VEJueDNhS1hMeElCZENtWDhRL2NHbzQ2allFblh2MGExMGhCcFB5eDZKTUtq?= =?utf-8?B?a0l3N3hpRkZrMWdBQU5kY29mTVlRNyt3L1Y5ckNkbTdJZzQxZFpqMmtBcmJx?= =?utf-8?B?WW5jakM4OEhOckJ4ajRoQXNiUnFXam8rRERERzVDbXMvM0RIcmZrOVV5RkNJ?= =?utf-8?B?emlrMXF5dG1HVUswdnVRV3diaUI3eXkyaCtsbXFQQWxBSDM4WjQwYXJWcXNj?= =?utf-8?B?bUd4eUtoM2lMblNFajE4bmpaZkJpd0xua0NPMDJHOVVIVG43U3FQeUdzSmJo?= =?utf-8?B?czZydzJGK2NtSGxweFU3UE1vRHpNWm9GcklkSUR0VnA2MFZManhNaUZYRHFo?= =?utf-8?B?cFozUHhPdUdDYnlBMjQrdWhDNFo4Rnk5bXdUdExZcXJxTHRNNzAreHNsNUhP?= =?utf-8?B?Q3h2dlJwenEycWRsQm9GZ2hBNlVoY2FCOS9tLzFBRTlpdzQvZkZNVE1BVm9x?= =?utf-8?B?Rm10b2NpcXZCeThybFBrQ0gzVm12SHV1UXB4Rk5WenhZYmFNbFZ0RjNzSnZr?= =?utf-8?Q?Th6eWMx+CP0=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 639b2726-0937-4005-43ec-08da353b7ca4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 23:51:23.6672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0152 Subject: Re: [FFmpeg-devel] [PATCH] fftools/opt_common: add missing include of avf/version.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Friday, May 13, 2022 3:33 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/opt_common: add missing > include of avf/version.h > > softworkz: > > From: softworkz > > > > required for PRINT_LIB_INFO(avfilter... > > > > Signed-off-by: softworkz > > --- > > fftools/opt_common: add missing include of avf/version.h > > > > MSVC compiler complains without this include > > > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr- > ffstaging-27%2Fsoftworkz%2Fsubmit_version_include-v1 > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr- > ffstaging-27/softworkz/submit_version_include-v1 > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/27 > > > > fftools/opt_common.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > > index c303db4d09..5a5e35bd7f 100644 > > --- a/fftools/opt_common.c > > +++ b/fftools/opt_common.c > > @@ -51,6 +51,8 @@ > > #include "libavdevice/avdevice.h" > > #include "libavdevice/version.h" > > > > +#include "libavfilter/version.h" > > + > > #include "libswscale/swscale.h" > > #include "libswscale/version.h" > > > > > > base-commit: d2d8b9b972ba2df6b2a2ebe29f5307cbb7a69c33 > > What does "complain" here mean? Compilation failure? > It should already be included via > opt_common.h->cmdutils.h->avfilter.h->lavfi/version.h. The latter > inclusion relies on HAVE_AV_CONFIG_H to not be defined. It should only > be defined for the libraries, not fftools, so if it is defined for you > for this file your setup is wrong. You are right. HAVE_AV_CONFIG_H is defined also for the tools binaries. But this seems to be the only case where it causes an issue. > That being said it is nevertheless good to include this and avfilter.h > directly. Looking at the generation tool, it seems to be quite a complex task to shape things in a way that it can be compiled with VS... I can't speak for the author of the tool, but I think when at least some cases that can easily be avoided (to require workarounds) at the ffmpeg side, then it would be a good thing. In that specific case, the version.h files from ALL libs are included just not from avfilter, so I think it would also add to clarity to include it directly. Similar goes for the DCE issue. For me there's just more clarity when those bits are guarded by #if blocks, but I don't want to open a discussion about that. Just thank you for the quick patch to resolve it! Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".