Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log output with simple ids

[Soft Works <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Nicolas George
> Sent: Donnerstag, 6. März 2025 11:09
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avutil/log: Replace addresses in log
> output with simple ids
> 
> Soft Works (HE12025-03-05):
> > Sorry. So - seriously: what would be your recipe then?
> 
> I see not just a little of non-trivial code for a very minor feature,
> that might be a hint that it would be best to let it go.
> 
> Also, if somebody is debugging a program using the libraries, the
> pointers are relevant for that program. For that reason, I think the
> change is a bad idea in the library.
> 
> On the other hand, you could do that change in the fftools. The point
> about pointers being relevant does not apply for them, and they can have
> as much global state as they want.

HI Nicolas,

initially I failed to see the impact of the array being global, I tend to forget about direct usages of the libs, sorry about that.


V3 of the patchset goes the route you are suggesting by introducing a callback for formatting of the context prefixes, so the global state lives in fftools only.

Thanks
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".