[FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid warnings

[FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid warnings

[softworkz]

From: softworkz <softworkz@hotmail.com>

Those are always showing up on Patchwork
when FATE tests are failing, covering
some possibly more useful information.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    libavutil/tests/md5: Avoid warnings
    
    Those are always showing up on Patchwork when FATE tests are failing,
    covering some possibly more useful information.

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20

 libavutil/tests/md5.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
index 42e4538e0a..1f27c40987 100644
--- a/libavutil/tests/md5.c
+++ b/libavutil/tests/md5.c
@@ -33,8 +33,12 @@ int main(void)
 {
     uint8_t md5val[16];
     int i;
+
+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
     volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
-    // FIXME remove volatile once it has been fixed and all fate clients are updated
+#else
+    uint8_t in[1000];
+#endif
 
     for (i = 0; i < 1000; i++)
         in[i] = i * i;

base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings

[softworkz]

From: softworkz <softworkz@hotmail.com>

Those are always showing up on Patchwork
when FATE tests are failing, covering
some possibly more useful information.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    libavutil/tests/md5: Avoid warnings
    
    Those are always showing up on Patchwork when FATE tests are failing,
    covering some possibly more useful information.

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v2
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20

Range-diff vs v1:

 1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
     @@ libavutil/tests/md5.c: int main(void)
       {
           uint8_t md5val[16];
           int i;
     -+
     -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
     -     volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
     +-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
      -    // FIXME remove volatile once it has been fixed and all fate clients are updated
     -+#else
     -+    uint8_t in[1000];
     ++
     ++#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
     ++    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
      +#endif
     ++    uint8_t in[1000];
       
           for (i = 0; i < 1000; i++)
               in[i] = i * i;


 libavutil/tests/md5.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
index 42e4538e0a..cca63d6507 100644
--- a/libavutil/tests/md5.c
+++ b/libavutil/tests/md5.c
@@ -33,8 +33,11 @@ int main(void)
 {
     uint8_t md5val[16];
     int i;
-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
-    // FIXME remove volatile once it has been fixed and all fate clients are updated
+
+#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
+    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
+#endif
+    uint8_t in[1000];
 
     for (i = 0; i < 1000; i++)
         in[i] = i * i;

base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings

[James Almer]

On 1/20/2022 10:41 PM, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> Those are always showing up on Patchwork
> when FATE tests are failing, covering
> some possibly more useful information.
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>      libavutil/tests/md5: Avoid warnings
>      
>      Those are always showing up on Patchwork when FATE tests are failing,
>      covering some possibly more useful information.
> 
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v2
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> 
> Range-diff vs v1:
> 
>   1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
>       @@ libavutil/tests/md5.c: int main(void)
>         {
>             uint8_t md5val[16];
>             int i;
>       -+
>       -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>       -     volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>       +-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>        -    // FIXME remove volatile once it has been fixed and all fate clients are updated
>       -+#else
>       -+    uint8_t in[1000];
>       ++
>       ++#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>       ++    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>        +#endif
>       ++    uint8_t in[1000];
>         
>             for (i = 0; i < 1000; i++)
>                 in[i] = i * i;
> 
> 
>   libavutil/tests/md5.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..cca63d6507 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,11 @@ int main(void)
>   {
>       uint8_t md5val[16];
>       int i;
> -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated
> +
> +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4

1?

> +    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> +#endif
> +    uint8_t in[1000];
>   
>       for (i = 0; i < 1000; i++)
>           in[i] = i * i;
> 
> base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer
> Sent: Friday, January 21, 2022 2:45 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings
> 
> 
> 
> On 1/20/2022 10:41 PM, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >      libavutil/tests/md5: Avoid warnings
> >
> >      Those are always showing up on Patchwork when FATE tests are failing,
> >      covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-
> 20/softworkz/submit_md5-v2
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> > Range-diff vs v1:
> >
> >   1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
> >       @@ libavutil/tests/md5.c: int main(void)
> >         {
> >             uint8_t md5val[16];
> >             int i;
> >       -+
> >       -+#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       -     volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >       +-    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        -    // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> >       -+#else
> >       -+    uint8_t in[1000];
> >       ++
> >       ++#if 1 || defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       ++    volatile // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        +#endif
> >       ++    uint8_t in[1000];
> >
> >             for (i = 0; i < 1000; i++)
> >                 in[i] = i * i;
> >
> >
> >   libavutil/tests/md5.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..cca63d6507 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,11 @@ int main(void)
> >   {
> >       uint8_t md5val[16];
> >       int i;
> > -    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > -    // FIXME remove volatile once it has been fixed and all fate clients
> are updated
> > +
> > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__
> < 4
> 
> 1?

I'm an idiot...

Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v3] libavutil/tests/md5: Avoid warnings

[softworkz]

From: softworkz <softworkz@hotmail.com>

Those are always showing up on Patchwork
when FATE tests are failing, covering
some possibly more useful information.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    libavutil/tests/md5: Avoid warnings
    
    Those are always showing up on Patchwork when FATE tests are failing,
    covering some possibly more useful information.

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v3
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v3
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20

Range-diff vs v2:

 1:  4723054463 ! 1:  e54769c621 libavutil/tests/md5: Avoid warnings
     @@ libavutil/tests/md5.c: int main(void)
      -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
      -    // FIXME remove volatile once it has been fixed and all fate clients are updated
      +
     -+#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
     ++#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
      +    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
      +#endif
      +    uint8_t in[1000];


 libavutil/tests/md5.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
index 42e4538e0a..ef846598e7 100644
--- a/libavutil/tests/md5.c
+++ b/libavutil/tests/md5.c
@@ -33,8 +33,11 @@ int main(void)
 {
     uint8_t md5val[16];
     int i;
-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
-    // FIXME remove volatile once it has been fixed and all fate clients are updated
+
+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
+    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
+#endif
+    uint8_t in[1000];
 
     for (i = 0; i < 1000; i++)
         in[i] = i * i;

base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4] libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings

[softworkz]

From: softworkz <softworkz@hotmail.com>

Those are always showing up on Patchwork when FATE tests are failing,
covering some possibly more useful information.

The volatile keyword was used as a workaround for an eight year old
clang version.

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    libavutil/tests/md5: Avoid warnings
    
    Those are always showing up on Patchwork when FATE tests are failing,
    covering some possibly more useful information.
    
    v4:
    
     * The problem still exists:
       https://patchwork.ffmpeg.org/check/62130/
     * as was suggested, this patch removes the volatile keyword altogether

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v4
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20

Range-diff vs v3:

 1:  e54769c621 ! 1:  21fdf3eba2 libavutil/tests/md5: Avoid warnings
     @@ Metadata
      Author: softworkz <softworkz@hotmail.com>
      
       ## Commit message ##
     -    libavutil/tests/md5: Avoid warnings
     +    libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings
      
     -    Those are always showing up on Patchwork
     -    when FATE tests are failing, covering
     -    some possibly more useful information.
     +    Those are always showing up on Patchwork when FATE tests are failing,
     +    covering some possibly more useful information.
     +
     +    The volatile keyword was used as a workaround for an eight year old
     +    clang version.
      
          Signed-off-by: softworkz <softworkz@hotmail.com>
      
     @@ libavutil/tests/md5.c: int main(void)
      -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
      -    // FIXME remove volatile once it has been fixed and all fate clients are updated
      +
     -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
     -+    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
     -+#endif
      +    uint8_t in[1000];
       
           for (i = 0; i < 1000; i++)


 libavutil/tests/md5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
index 42e4538e0a..0ac8f2834e 100644
--- a/libavutil/tests/md5.c
+++ b/libavutil/tests/md5.c
@@ -33,8 +33,8 @@ int main(void)
 {
     uint8_t md5val[16];
     int i;
-    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
-    // FIXME remove volatile once it has been fixed and all fate clients are updated
+
+    uint8_t in[1000];
 
     for (i = 0; i < 1000; i++)
         in[i] = i * i;

base-commit: 9fba0b8a8c754a012fc74c90ffb7c26a56be8ca0
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4] libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings

[Marton Balint]

On Sat, 28 May 2022, softworkz wrote:

> From: softworkz <softworkz@hotmail.com>
>
> Those are always showing up on Patchwork when FATE tests are failing,
> covering some possibly more useful information.
>
> The volatile keyword was used as a workaround for an eight year old
> clang version.
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>    libavutil/tests/md5: Avoid warnings

Will apply.

Thanks,
Marton

>
>    Those are always showing up on Patchwork when FATE tests are failing,
>    covering some possibly more useful information.
>
>    v4:
>
>     * The problem still exists:
>       https://patchwork.ffmpeg.org/check/62130/
>     * as was suggested, this patch removes the volatile keyword altogether
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v4
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
>
> Range-diff vs v3:
>
> 1:  e54769c621 ! 1:  21fdf3eba2 libavutil/tests/md5: Avoid warnings
>     @@ Metadata
>      Author: softworkz <softworkz@hotmail.com>
>
>       ## Commit message ##
>     -    libavutil/tests/md5: Avoid warnings
>     +    libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings
>
>     -    Those are always showing up on Patchwork
>     -    when FATE tests are failing, covering
>     -    some possibly more useful information.
>     +    Those are always showing up on Patchwork when FATE tests are failing,
>     +    covering some possibly more useful information.
>     +
>     +    The volatile keyword was used as a workaround for an eight year old
>     +    clang version.
>
>          Signed-off-by: softworkz <softworkz@hotmail.com>
>
>     @@ libavutil/tests/md5.c: int main(void)
>      -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>      -    // FIXME remove volatile once it has been fixed and all fate clients are updated
>      +
>     -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>     -+    volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
>     -+#endif
>      +    uint8_t in[1000];
>
>           for (i = 0; i < 1000; i++)
>
>
> libavutil/tests/md5.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..0ac8f2834e 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,8 @@ int main(void)
> {
>     uint8_t md5val[16];
>     int i;
> -    volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated
> +
> +    uint8_t in[1000];
>
>     for (i = 0; i < 1000; i++)
>         in[i] = i * i;
>
> base-commit: 9fba0b8a8c754a012fc74c90ffb7c26a56be8ca0
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid warnings

[Carl Eugen Hoyos]

Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz <ffmpegagent@gmail.com>:
>
> From: softworkz <softworkz@hotmail.com>
>
> Those are always showing up on Patchwork
> when FATE tests are failing, covering
> some possibly more useful information.
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>     libavutil/tests/md5: Avoid warnings
>
>     Those are always showing up on Patchwork when FATE tests are failing,
>     covering some possibly more useful information.
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
>
>  libavutil/tests/md5.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> index 42e4538e0a..1f27c40987 100644
> --- a/libavutil/tests/md5.c
> +++ b/libavutil/tests/md5.c
> @@ -33,8 +33,12 @@ int main(void)
>  {
>      uint8_t md5val[16];
>      int i;
> +
> +#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4
>      volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849
> -    // FIXME remove volatile once it has been fixed and all fate clients are updated

I wonder if the volatile shouldn't just be removed after eight years.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid warnings

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Carl
> Eugen Hoyos
> Sent: Sunday, January 23, 2022 12:23 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] libavutil/tests/md5: Avoid
> warnings
> 
> Am Fr., 21. Jan. 2022 um 02:18 Uhr schrieb softworkz
> <ffmpegagent@gmail.com>:
> >
> > From: softworkz <softworkz@hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >     libavutil/tests/md5: Avoid warnings
> >
> >     Those are always showing up on Patchwork when FATE tests are
> failing,
> >     covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v1
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> ffstaging-20/softworkz/submit_md5-v1
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> >  libavutil/tests/md5.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..1f27c40987 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,12 @@ int main(void)
> >  {
> >      uint8_t md5val[16];
> >      int i;
> > +
> > +#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >      volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > -    // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> 
> I wonder if the volatile shouldn't just be removed after eight years.
> 
> Carl Eugen

So, shall I submit another version that simply removes 'volatile'?

softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".